ipv6: release dst in ping_v6_sendmsg
authorDave Jones <davej@codemonkey.org.uk>
Fri, 2 Sep 2016 18:39:50 +0000 (14:39 -0400)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Sep 2016 19:54:17 +0000 (12:54 -0700)
commit03c2778a938aaba0893f6d6cdc29511d91a79848
treec910de1f10013bbc12295c279c727e5e39099ba5
parent6e1ce3c3451291142a57c4f3f6f999a29fb5b3bc
ipv6: release dst in ping_v6_sendmsg

Neither the failure or success paths of ping_v6_sendmsg release
the dst it acquires.  This leads to a flood of warnings from
"net/core/dst.c:288 dst_release" on older kernels that
don't have 8bf4ada2e21378816b28205427ee6b0e1ca4c5f1 backported.

That patch optimistically hoped this had been fixed post 3.10, but
it seems at least one case wasn't, where I've seen this triggered
a lot from machines doing unprivileged icmp sockets.

Cc: Martin Lau <kafai@fb.com>
Signed-off-by: Dave Jones <davej@codemonkey.org.uk>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ping.c