[CMake] Enable warnings for runtimes
authorKostya Kortchinsky <kostyak@google.com>
Fri, 27 Apr 2018 15:10:50 +0000 (15:10 +0000)
committerKostya Kortchinsky <kostyak@google.com>
Fri, 27 Apr 2018 15:10:50 +0000 (15:10 +0000)
commit03b7c4dabbac7414fbdd5036f26f8623ff2a40c3
tree21f8ff110146aee3d6be548b53cb22dc61a56bd3
parentd1754765662030774356b272c3c818cac6aa11dd
[CMake] Enable warnings for runtimes

Summary:
`HandleLLVMOptions` adds `-w` to the cflags if `LLVM_ENABLE_WARNINGS` is not on.
With `-w`, `check_cxx_compiler_flag` doesn't error out for unsupported flags
(for example `-mcrc` on x86_64), and those flags end up being detected as
working - and really they aren't.

I am not entirely sure what the best way to solve this is, but setting
`LLVM_ENABLE_WARNINGS` prior to including `HandleLLVMOptions` does the job.

Reviewers: phosek, beanz

Reviewed By: phosek

Subscribers: mgorny, llvm-commits

Differential Revision: https://reviews.llvm.org/D46079

llvm-svn: 331042
llvm/runtimes/CMakeLists.txt