Revert "dt-bindings: pinctrl: bcm4708-pinmux: rework binding to use syscon"
authorRafał Miłecki <rafal@milecki.pl>
Fri, 8 Oct 2021 20:59:36 +0000 (22:59 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Wed, 13 Oct 2021 23:09:06 +0000 (01:09 +0200)
commit0398adaec3419bdfa93baae70a3b696b4abdd7ad
tree3cba0e822cf3a31c7a34145ced7cf9b8467b2c66
parent64570fbc14f8d7cb3fe3995f20e26bc25ce4b2cc
Revert "dt-bindings: pinctrl: bcm4708-pinmux: rework binding to use syscon"

This reverts commit 2ae80900f239484069569380e1fc4340fd6e0089.

My rework was unneeded & wrong. It replaced a clear & correct "reg"
property usage with a custom "offset" one.

Back then I didn't understand how to properly handle CRU block binding.
I heard / read about syscon and tried to use it in a totally invalid
way. That change also missed Rob's review (obviously).

Northstar's pin controller is a simple consistent hardware block that
can be cleanly mapped using a 0x24 long reg space.

Since the rework commit there wasn't any follow up modifying in-kernel
DTS files to use the new binding. Broadcom also isn't known to use that
bugged binding. There is close to zero chance this revert may actually
cause problems / regressions.

This commit is a simple revert. Example binding may (should) be updated
/ cleaned up but that can be handled separately.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Reviewed-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20211008205938.29925-1-zajec5@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Documentation/devicetree/bindings/mfd/brcm,cru.yaml
Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml