review.tizen.org Git - platform/upstream/dotnet/runtime.git/commit

projects / platform / upstream / dotnet / runtime.git / commit

author	Levi Broderick <GrabYourPitchforks@users.noreply.github.com>
	Thu, 13 Feb 2020 17:40:34 +0000 (09:40 -0800)
committer	GitHub <noreply@github.com>
	Thu, 13 Feb 2020 17:40:34 +0000 (09:40 -0800)
commit	036fb0779a5bc89026d2ec64172897ab86af5828
tree	8d24b684be00c3a4a16b145d788e533c7501d923	tree \| snapshot
parent	35a59c1d8debff1e62e7142b7bbaa22996ff689d	commit \| diff

Clean up improper usage of linguistic string functions (#31968)

- Optimize ToUpperInvariant/ToLowerInvariant
- Also optimize static field TextInfo.Invariant
- Rewrite ToUpper/Lower(Invariant) call sites to use optimized method
- Fix some uses of culture-aware ToUpper / ToLower to use invariant culture
- Replace Trim().Length with IsNullOrWhiteSpace where appropriate
- Use ordinal StartsWith / EndsWith where appropriate
- Avoid calling CultureInfo.InvariantCulture where possible

94 files changed:

src/libraries/Common/src/Interop/Linux/cgroups/Interop.cgroups.cs		diff \| blob \| history
src/libraries/Common/src/System/Data/Common/DbConnectionOptions.Common.cs		diff \| blob \| history
src/libraries/Common/src/System/Drawing/ColorTranslator.cs		diff \| blob \| history
src/libraries/Common/src/System/Net/NetworkInformation/UnixCommandLinePing.cs		diff \| blob \| history
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/CompilerServices/LikeOperator.vb		diff \| blob \| history
src/libraries/Microsoft.VisualBasic.Core/src/Microsoft/VisualBasic/FileSystem.vb		diff \| blob \| history
src/libraries/Microsoft.XmlSerializer.Generator/src/Sgen.cs		diff \| blob \| history
src/libraries/System.CodeDom/src/Microsoft/CSharp/CSharpCodeGenerator.cs		diff \| blob \| history
src/libraries/System.CodeDom/src/System/Collections/Specialized/FixedStringLookup.cs		diff \| blob \| history
src/libraries/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/RequiredAttribute.cs		diff \| blob \| history
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/Design/DesigntimeLicenseContext.cs		diff \| blob \| history
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/SyntaxCheck.cs		diff \| blob \| history
src/libraries/System.Composition.Hosting/src/System/Composition/Hosting/Util/Formatters.cs		diff \| blob \| history
src/libraries/System.Composition.Runtime/src/System/Composition/Runtime/Util/Formatters.cs		diff \| blob \| history
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ClientConfigPaths.cs		diff \| blob \| history
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/ConfigurationElement.cs		diff \| blob \| history
src/libraries/System.Configuration.ConfigurationManager/src/System/Configuration/IdnElement.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/Common/AdapterUtil.Common.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/Common/DbConnectionOptions.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/DataTable.cs		diff \| blob \| history
src/libraries/System.Data.Common/src/System/Data/XMLSchema.cs		diff \| blob \| history
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcConnection.cs		diff \| blob \| history
src/libraries/System.Data.OleDb/src/DbConnectionOptions.cs		diff \| blob \| history
src/libraries/System.Data.OleDb/src/OleDbCommandBuilder.cs		diff \| blob \| history
src/libraries/System.Data.OleDb/src/OleDbConnection.cs		diff \| blob \| history
src/libraries/System.Data.OleDb/src/OleDbConnectionString.cs		diff \| blob \| history
src/libraries/System.Data.OleDb/src/OleDbConnectionStringBuilder.cs		diff \| blob \| history
src/libraries/System.Data.OleDb/src/OleDbDataReader.cs		diff \| blob \| history
src/libraries/System.Data.OleDb/src/PropertyInfoSet.cs		diff \| blob \| history
src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/InstanceDataCollection.cs		diff \| blob \| history
src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/InstanceDataCollectionCollection.cs		diff \| blob \| history
src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/PerformanceCounter.cs		diff \| blob \| history
src/libraries/System.Diagnostics.PerformanceCounter/src/System/Diagnostics/PerformanceCounterCategory.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Linux.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.Windows.cs		diff \| blob \| history
src/libraries/System.Diagnostics.Process/src/System/Diagnostics/ProcessManager.Windows.cs		diff \| blob \| history
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/AD/ADStoreCtx.cs		diff \| blob \| history
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/Context.cs		diff \| blob \| history
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/SAM/SAMStoreCtx.cs		diff \| blob \| history
src/libraries/System.DirectoryServices.AccountManagement/src/System/DirectoryServices/AccountManagement/SAM/SAMStoreCtx_LoadStore.cs		diff \| blob \| history
src/libraries/System.DirectoryServices.Protocols/src/System/DirectoryServices/Protocols/common/DirectoryAttribute.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ActiveDirectoryReplicationMetaData.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ActiveDirectorySchemaClass.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ActiveDirectorySiteLink.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/ActiveDirectorySiteLinkBridge.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/DirectoryServer.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/Locator.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ActiveDirectory/Utils.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/DirectoryEntry.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/PropertyCollection.cs		diff \| blob \| history
src/libraries/System.DirectoryServices/src/System/DirectoryServices/ResultPropertyCollection.cs		diff \| blob \| history
src/libraries/System.Drawing.Common/src/System/Drawing/Printing/PrintingServices.Unix.cs		diff \| blob \| history
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialPort.FreeBSD.cs		diff \| blob \| history
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialPort.Linux.cs		diff \| blob \| history
src/libraries/System.IO.Ports/src/System/IO/Ports/SerialPort.OSX.cs		diff \| blob \| history
src/libraries/System.Management/src/System/Management/ManagementQuery.cs		diff \| blob \| history
src/libraries/System.Management/src/System/Management/WMIGenerator.cs		diff \| blob \| history
src/libraries/System.Net.Http/src/System/Net/Http/Headers/ContentDispositionHeaderValue.cs		diff \| blob \| history
src/libraries/System.Net.Http/src/System/Net/Http/MultipartContent.cs		diff \| blob \| history
src/libraries/System.Net.HttpListener/src/System/Net/HttpListenerRequest.cs		diff \| blob \| history
src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpEndPointListener.cs		diff \| blob \| history
src/libraries/System.Net.HttpListener/src/System/Net/Managed/HttpListenerRequest.Managed.cs		diff \| blob \| history
src/libraries/System.Net.HttpListener/src/System/Net/Managed/ListenerPrefix.cs		diff \| blob \| history
src/libraries/System.Net.Mail/src/System/Net/Mime/HeaderCollection.cs		diff \| blob \| history
src/libraries/System.Net.Mail/src/System/Net/Mime/MimeMultiPart.cs		diff \| blob \| history
src/libraries/System.Net.Mail/src/System/Net/Mime/SmtpDateTime.cs		diff \| blob \| history
src/libraries/System.Net.NetworkInformation/src/System/Net/NetworkInformation/StringParsingHelpers.Addresses.cs		diff \| blob \| history
src/libraries/System.Net.Primitives/src/System/Net/Cookie.cs		diff \| blob \| history
src/libraries/System.Net.Primitives/src/System/Net/CookieContainer.cs		diff \| blob \| history
src/libraries/System.Net.Requests/src/System/Net/FtpWebRequest.cs		diff \| blob \| history
src/libraries/System.Net.Requests/src/System/Net/HttpWebResponse.cs		diff \| blob \| history
src/libraries/System.Net.Requests/src/System/Net/WebRequest.cs		diff \| blob \| history
src/libraries/System.Net.WebClient/src/System/Net/WebClient.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/AppContextConfigHelper.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/Char.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/Diagnostics/DebugProvider.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/TraceLogging/EventSourceActivity.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/Globalization/TextInfo.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.Globalization.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/String.Comparison.cs		diff \| blob \| history
src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs		diff \| blob \| history
src/libraries/System.Private.DataContractSerialization/src/System/Runtime/Serialization/CollectionDataContract.cs		diff \| blob \| history
src/libraries/System.Private.Uri/src/System/UriScheme.cs		diff \| blob \| history
src/libraries/System.Private.Xml/src/System/Xml/Schema/XmlSchemaDataType.cs		diff \| blob \| history
src/libraries/System.Private.Xml/src/System/Xml/Serialization/CodeIdentifier.cs		diff \| blob \| history
src/libraries/System.Private.Xml/src/System/Xml/Serialization/Types.cs		diff \| blob \| history
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationReader.cs		diff \| blob \| history
src/libraries/System.Private.Xml/src/System/Xml/Serialization/XmlSerializationWriterILGen.cs		diff \| blob \| history
src/libraries/System.Private.Xml/src/System/Xml/Xsl/Runtime/XmlCollation.cs		diff \| blob \| history
src/libraries/System.Reflection.MetadataLoadContext/src/System/Reflection/TypeLoading/General/TypeExtensions.netstandard.cs		diff \| blob \| history
src/libraries/System.Runtime.WindowsRuntime/src/System/Resources/WindowsRuntimeResourceManager.cs		diff \| blob \| history
src/libraries/System.Security.Cryptography.Xml/src/System/Security/Cryptography/Xml/Utils.cs		diff \| blob \| history
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ExtensionMethods.cs		diff \| blob \| history
src/mono/netcore/System.Private.CoreLib/src/System/RuntimeType.Mono.cs		diff \| blob \| history

Domain: Dotnet / Core;

RSS Atom