power: supply: ltc2941-battery-gauge: fix use-after-free
authorSven Van Asbroeck <thesven73@gmail.com>
Thu, 19 Sep 2019 15:11:37 +0000 (11:11 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Feb 2020 12:35:24 +0000 (04:35 -0800)
commit03572189d61c3bc09ba69a379af8104e37c7f765
tree75fbab9db9eda2c0c1f6316e32532f747e07f3c6
parent6f33d59ae165d50f9007a24314c903fd320ce5c4
power: supply: ltc2941-battery-gauge: fix use-after-free

commit a60ec78d306c6548d4adbc7918b587a723c555cc upstream.

This driver's remove path calls cancel_delayed_work().
However, that function does not wait until the work function
finishes. This could mean that the work function is still
running after the driver's remove function has finished,
which would result in a use-after-free.

Fix by calling cancel_delayed_work_sync(), which ensures that
that the work is properly cancelled, no longer running, and
unable to re-schedule itself.

This issue was detected with the help of Coccinelle.

Cc: stable <stable@vger.kernel.org>
Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/supply/ltc2941-battery-gauge.c