internals: Decouple logging an error from exiting unsuccessfully
authorSimon McVittie <smcv@collabora.com>
Mon, 3 Jul 2017 17:58:42 +0000 (18:58 +0100)
committerSimon McVittie <smcv@collabora.com>
Wed, 5 Jul 2017 12:12:37 +0000 (13:12 +0100)
commit0354f5d48fd204bb891946a2baf82290497b44c9
tree7d5f1f8e2ef52a20998a73deb65c38851a078b92
parent2135910d316513efdde69ee3e506a70626b467a3
internals: Decouple logging an error from exiting unsuccessfully

This lets _dbus_warn() and _dbus_warn_check_failed() fall through
to flushing stderr and calling _dbus_abort(), meaning that failed
checks and warnings can result in a core dump as intended.
By renaming the FATAL severity to ERROR, we ensure that any code
contributions that assumed the old semantics will fail to compile.

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=101568
bus/bus.c
dbus/dbus-internals.c
dbus/dbus-sysdeps-unix.c
dbus/dbus-sysdeps-win.c
dbus/dbus-sysdeps.h
test/internals/syslog.c