Tweak sss-bp-on-user-bp.exp
authorYao Qi <yao@codesourcery.com>
Wed, 4 Jun 2014 05:03:19 +0000 (13:03 +0800)
committerYao Qi <yao@codesourcery.com>
Wed, 4 Jun 2014 12:53:47 +0000 (20:53 +0800)
commit03388bb71c1a1d1c613bb963f3d9287cfd100138
treea2afb9ea93b8faed5ec6a6d062029732d2ae8124
parentac21917f6bef764c73323c8117d293b5f6c70228
Tweak sss-bp-on-user-bp.exp

sss-bp-on-user-bp.c has an assumption that write to integer can be
compiled to a single instruction, which isn't true on some arch, such
as arm.  This test requires setting two breakpoints on two consecutive
instructions, so this patch is to get the address of the next
instruction via disassemble and set the 2nd breakpoint there.  This
approach is portable.

This patch fixes the fails in sss-bp-on-user-bp.exp on arm-none-abi
target.  There is no change in x86 test results.  I also revert the
patch to PR breakpoints/17000, and verified that the patched
sss-bp-on-user-bp.exp still trigger the fail on
x86-with-software-single-step.

gdb/testsuite:

2014-06-04  Yao Qi  <yao@codesourcery.com>

* gdb.base/sss-bp-on-user-bp.c (main): Remove comments.
* gdb.base/sss-bp-on-user-bp.exp: Don't set breakpoint on
"set bar break here".  Get the next instruction address and
set breakpoint there.  Remove "bar break" from the regexp
patterns.
gdb/testsuite/gdb.base/sss-bp-on-user-bp.c
gdb/testsuite/gdb.base/sss-bp-on-user-bp.exp