ixgbevf: fix possible crashes in probe and remove
authorEmil Tantilov <emil.s.tantilov@intel.com>
Fri, 5 Dec 2014 04:32:44 +0000 (04:32 +0000)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Fri, 5 Dec 2014 17:13:09 +0000 (09:13 -0800)
commit0333464f5f7c33965173893b2a7322da6fe751ab
tree3a9b20aae9e01f6486a438a192b63fc240a20b5b
parent47068b0ddfa9c7d16ed4fd4c831579699ef89571
ixgbevf: fix possible crashes in probe and remove

This patch resolves couple of issues in ixgbevf_probe/remove():

1. Fix a case where adapter->state is tested after free_netdev() this is
same as the patch for ixgbe from Daniel Borkmann <dborkman@redhat.com>:
commit b5b2ffc0574e1f27 ("ixgbe: fix use after free adapter->state test in ixgbe_remove/ixgbe_probe")

2. Move pci_set_drvdata() after all the error checks in ixgbevf_probe() and
then add a check in ixgbevf_probe() to avoid running the cleanup functions
twice in cases where probe failed.

CC: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c