rbd: don't put snap_context twice in rbd_queue_workfn()
authorIlya Dryomov <idryomov@gmail.com>
Fri, 27 Nov 2015 18:23:24 +0000 (19:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 15 Dec 2015 05:24:34 +0000 (21:24 -0800)
commit0330982c45ec56b0855c9288bf07d5c5edb12faf
tree2f49f2f2bf1da11312d3f8101c7f35f2a13445c0
parentc39df1cf3663f94d5453942aaf4922e18122ca0b
rbd: don't put snap_context twice in rbd_queue_workfn()

commit 70b16db86f564977df074072143284aec2cb1162 upstream.

Commit 4e752f0ab0e8 ("rbd: access snapshot context and mapping size
safely") moved ceph_get_snap_context() out of rbd_img_request_create()
and into rbd_queue_workfn(), adding a ceph_put_snap_context() to the
error path in rbd_queue_workfn().  However, rbd_img_request_create()
consumes a ref on snapc, so calling ceph_put_snap_context() after
a successful rbd_img_request_create() leads to an extra put.  Fix it.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/block/rbd.c