selinux: ensure we cleanup the internal AVC counters on error in avc_update()
authorJaihind Yadav <jaihindyadav@codeaurora.org>
Tue, 17 Dec 2019 11:55:47 +0000 (17:25 +0530)
committerPaul Moore <paul@paul-moore.com>
Sat, 21 Dec 2019 15:59:21 +0000 (10:59 -0500)
commit030b995ad9ece9fa2d218af4429c1c78c2342096
tree1c016af4c1ac6e03442fd29e613240450e3871cf
parent5c108d4e18f80be01965792726c81b105fbd677a
selinux: ensure we cleanup the internal AVC counters on error in avc_update()

In AVC update we don't call avc_node_kill() when avc_xperms_populate()
fails, resulting in the avc->avc_cache.active_nodes counter having a
false value.  In last patch this changes was missed , so correcting it.

Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls")
Signed-off-by: Jaihind Yadav <jaihindyadav@codeaurora.org>
Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@codeaurora.org>
[PM: merge fuzz, minor description cleanup]
Signed-off-by: Paul Moore <paul@paul-moore.com>
security/selinux/avc.c