[ELF][AArch64] Fix unneeded thunk for branches to hidden undefined weak
authorFangrui Song <i@maskray.me>
Thu, 14 Apr 2022 18:32:29 +0000 (11:32 -0700)
committerFangrui Song <i@maskray.me>
Thu, 14 Apr 2022 18:32:30 +0000 (11:32 -0700)
commit02eab52866775f1476028129d1b114235fddc127
tree964b3f1097e4f4655188c319e7e63ef7430310ca
parent2c2568f39ec641aa8f1dcc011f2ce642c2d3423f
[ELF][AArch64] Fix unneeded thunk for branches to hidden undefined weak

Similar to D119787 for PPC64.

A hidden undefined weak may change its binding to local before some
`isUndefinedWeak` code, so some `isUndefinedWeak` code needs to be changed to
`isUndefined`. The undefined non-weak case has been errored, so just using
`isUndefined` is fine.

The Linux kernel recently has a usage that a branch from 0xffff800008491ee0
references a hidden undefined weak symbol `vfio_group_set_kvm`.
It relies on the behavior that a branch to undefined weak resolving to the next
instruction, otherwise it'd see spurious relocation out of range errors.

Fixes https://github.com/ClangBuiltLinux/linux/issues/1624

Differential Revision: https://reviews.llvm.org/D123750
lld/ELF/Arch/AArch64.cpp
lld/ELF/InputSection.cpp
lld/test/ELF/aarch64-undefined-weak.s