fs: lockd: avoid possible wrong NULL parameter
authorSu Hui <suhui@nfschina.com>
Fri, 4 Aug 2023 01:26:57 +0000 (09:26 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Sep 2023 07:42:49 +0000 (09:42 +0200)
commit02a29a2455b08a4cad2b1c8b9a90092e00033b19
treebe9c8853dd217dfd4f5ea7aaaa65f05f9bb7e520
parentf27f759f4cd490593cc7527b03fcec3aa4dbc2e7
fs: lockd: avoid possible wrong NULL parameter

[ Upstream commit de8d38cf44bac43e83bad28357ba84784c412752 ]

clang's static analysis warning: fs/lockd/mon.c: line 293, column 2:
Null pointer passed as 2nd argument to memory copy function.

Assuming 'hostname' is NULL and calling 'nsm_create_handle()', this will
pass NULL as 2nd argument to memory copy function 'memcpy()'. So return
NULL if 'hostname' is invalid.

Fixes: 77a3ef33e2de ("NSM: More clean up of nsm_get_handle()")
Signed-off-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/lockd/mon.c