tty: serial: imx: disable UCR4_OREN in .stop_rx() instead of .shutdown()
authorFugang Duan <fugang.duan@nxp.com>
Thu, 25 Nov 2021 02:03:49 +0000 (10:03 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Nov 2021 17:38:21 +0000 (18:38 +0100)
commit028e083832b06fdeeb290e1e57dc1f6702c4c215
tree9615db421a77e3c04ac276432149f3a3ac38ff5f
parentc67643b46c28fc8bb7d81c65bc7eef18c3fbe972
tty: serial: imx: disable UCR4_OREN in .stop_rx() instead of .shutdown()

The UCR4_OREN should be disabled before disabling the uart receiver in
.stop_rx() instead of in the .shutdown().

Otherwise, if we have the overrun error during the receiver disable
process, the overrun interrupt will keep trigging until we disable the
OREN interrupt in the .shutdown(), because the ORE status can only be
cleared when read the rx FIFO or reset the controller.  Although the
called time between the receiver disable and OREN disable in .shutdown()
is very short, there is still the risk of endless interrupt during this
short period of time. So here change to disable OREN before the receiver
been disabled in .stop_rx().

Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
Link: https://lore.kernel.org/r/20211125020349.4980-1-sherry.sun@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/imx.c