bcache: move calc_cached_dev_sectors to proper place on backing device detach
authorLin Feng <linf@wangsu.com>
Wed, 20 Oct 2021 14:38:08 +0000 (22:38 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 20 Oct 2021 14:40:54 +0000 (08:40 -0600)
commit0259d4498ba48454749ecfb9c81e892cdb8d1a32
treea48372b25ff85c69896adee3688490b4e34e9f63
parentd55f7cb2e5c053010d2b527494da9bbb722a78ba
bcache: move calc_cached_dev_sectors to proper place on backing device detach

Calculation of cache_set's cached sectors is done by travelling
cached_devs list as shown below:

static void calc_cached_dev_sectors(struct cache_set *c)
{
...
        list_for_each_entry(dc, &c->cached_devs, list)
                sectors += bdev_sectors(dc->bdev);

        c->cached_dev_sectors = sectors;
}

But cached_dev won't be unlinked from c->cached_devs list until we call
following list_move(&dc->list, &uncached_devices),
so previous fix in 'commit 46010141da6677b81cc77f9b47f8ac62bd1cbfd3
("bcache: recal cached_dev_sectors on detach")' is wrong, now we move
it to its right place.

Signed-off-by: Lin Feng <linf@wangsu.com>
Signed-off-by: Coly Li <colyli@suse.de>
Link: https://lore.kernel.org/r/20211020143812.6403-5-colyli@suse.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/md/bcache/super.c