iris: Require a 4K alignment for extra clear color BOs.
authorKenneth Graunke <kenneth@whitecape.org>
Wed, 13 Oct 2021 01:09:04 +0000 (18:09 -0700)
committerMarge Bot <eric+marge@anholt.net>
Wed, 13 Oct 2021 18:46:03 +0000 (18:46 +0000)
commit02435f1294d6b9163560f1f5d49b4d2c55b83c79
tree50af3bcf237fe845ae3451d16bf029ed71cbc3eb
parent94e07058ee5b3ecdbf4b1afe347cd815dc7fe640
iris: Require a 4K alignment for extra clear color BOs.

Apparently, we've been requiring a 4K alignment for internally allocated
clear color addresses to work around some unknown issues.  There's a
comment to that effect in iris_resource_create_with_modifiers().

When importing a dmabuf and tacking on an additional clear color BO, we
only required an alignment of 1.  This wasn't a problem for a long time
because all BO allocations were naturally aligned to the 4K page size.

However, once we enabled suballocation, we were able to allocate "BOs"
at 256B granularity, making this no longer 4K aligned.  Increase the
alignment requirement to 4K to match the behavior of our normal
allocations and also our previous behavior.

Fixes Piglit's ext_image_dma_buf_import-intel-modifiers.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5482
Fixes: ce2e2296ab6 ("iris: Suballocate BO using the Gallium pb_slab mechanism")
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13326>
src/gallium/drivers/iris/iris_resource.c