Implement System.ComponentModel.VersionConverter (dotnet/corefx#28516)
authorCédric Luthi <cedric.luthi@gmail.com>
Fri, 17 Aug 2018 22:27:56 +0000 (00:27 +0200)
committerSantiago Fernandez Madero <safern@microsoft.com>
Fri, 17 Aug 2018 22:27:56 +0000 (15:27 -0700)
commit01fab3385467c3a4798e5108fa8d53fd21fb5370
treed763b69f7cd1cfd68d18b6c13b2127b29354f047
parent181c04b4a6c6b82b4633f5db75e04aca0ff8a0ac
Implement System.ComponentModel.VersionConverter (dotnet/corefx#28516)

* Implement System.ComponentModel.VersionConverter

VersionConverter is a new System.ComponentModel.TypeConverter subclass that handle conversions between string and System.Version.

* Fix tests build for VersionTypeConverter

* Use Version.Parse() instead of new Version() to save an allocation

* Add test data to ensure that the version string is trimmed

* Call base class implementation instead of explicitly throwing

* Always throw a FormatException when a version string is invalid

Commit migrated from https://github.com/dotnet/corefx/commit/a5c7e7295ac2e3c889d347d0285794266797db87
src/libraries/System.ComponentModel.TypeConverter/ref/System.ComponentModel.TypeConverter.cs
src/libraries/System.ComponentModel.TypeConverter/src/System.ComponentModel.TypeConverter.csproj
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/ReflectTypeDescriptionProvider.cs
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/VersionConverter.cs [new file with mode: 0644]
src/libraries/System.ComponentModel.TypeConverter/tests/Performance/Perf.TypeDescriptorTests.cs
src/libraries/System.ComponentModel.TypeConverter/tests/System.ComponentModel.TypeConverter.Tests.csproj
src/libraries/System.ComponentModel.TypeConverter/tests/TypeDescriptorTests.cs
src/libraries/System.ComponentModel.TypeConverter/tests/TypeDescriptorTests.netcoreapp.cs [new file with mode: 0644]
src/libraries/System.ComponentModel.TypeConverter/tests/VersionConverterTests.cs [new file with mode: 0644]