dmaengine: mediatek: Fix deadlock caused by synchronize_irq()
authorDuoming Zhou <duoming@zju.edu.cn>
Sun, 6 Aug 2023 03:25:11 +0000 (11:25 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 4 Oct 2023 13:56:36 +0000 (19:26 +0530)
commit01f1ae2733e2bb4de92fefcea5fda847d92aede1
treebbe74fd11ee615dbf570fa24e15205867c3a3d59
parentc0409dd3d151f661e7e57b901a81a02565df163c
dmaengine: mediatek: Fix deadlock caused by synchronize_irq()

The synchronize_irq(c->irq) will not return until the IRQ handler
mtk_uart_apdma_irq_handler() is completed. If the synchronize_irq()
holds a spin_lock and waits the IRQ handler to complete, but the
IRQ handler also needs the same spin_lock. The deadlock will happen.
The process is shown below:

          cpu0                        cpu1
mtk_uart_apdma_device_pause() | mtk_uart_apdma_irq_handler()
  spin_lock_irqsave()         |
                              |   spin_lock_irqsave()
  //hold the lock to wait     |
  synchronize_irq()           |

This patch reorders the synchronize_irq(c->irq) outside the spin_lock
in order to mitigate the bug.

Fixes: 9135408c3ace ("dmaengine: mediatek: Add MediaTek UART APDMA support")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Reviewed-by: Eugen Hristev <eugen.hristev@collabora.com>
Link: https://lore.kernel.org/r/20230806032511.45263-1-duoming@zju.edu.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/mediatek/mtk-uart-apdma.c