media: atomisp: cleanup __printf() atributes on printk messages
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 23 Sep 2020 08:17:47 +0000 (10:17 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 23 Sep 2020 08:19:19 +0000 (10:19 +0200)
commit01cc2ec6ea044731e939e5e47f7e115b86f49465
tree4f44814fae427ccd7c45b5b64612aebd9ebc2b7f
parent8e3d5d4baf0781974a224e284e837665c0d26f92
media: atomisp: cleanup __printf() atributes on printk messages

There are still some warnings produced by -Wsuggest-attribute=format,
like this one:

drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c: In function ‘dtrace_dot’:
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c:2466:2: warning: function ‘dtrace_dot’ might be a candidate for ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
 2466 |  ia_css_debug_vdtrace(IA_CSS_DEBUG_INFO, fmt, ap);
      |  ^~~~~~~~~~~~~~~~~~~~

Also, on some places, is is using __atribute, while on others it
is using the __printf() macro.

Uniform those to always use the __printf() macro, placing it
before the function, and fix the logic in order to cleanup
all such warnings.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
drivers/staging/media/atomisp/pci/hive_isp_css_include/print_support.h
drivers/staging/media/atomisp/pci/ia_css_env.h
drivers/staging/media/atomisp/pci/runtime/debug/interface/ia_css_debug.h
drivers/staging/media/atomisp/pci/runtime/debug/src/ia_css_debug.c
drivers/staging/media/atomisp/pci/sh_css.c
drivers/staging/media/atomisp/pci/sh_css_internal.h