mlxsw: spectrum_router: Don't read 'nud_state' without lock
authorIdo Schimmel <idosch@mellanox.com>
Mon, 6 Feb 2017 15:20:16 +0000 (16:20 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 6 Feb 2017 16:25:57 +0000 (11:25 -0500)
commit01b1aa359dd481579de6047af8d7874e6e529585
treea83784f678946263f0792eae3f06ce9d7272f91a
parent8a0b7275268504259cc1a17bae839d23c4f6e2bc
mlxsw: spectrum_router: Don't read 'nud_state' without lock

We periodically ask the neighbouring system to try and resolve
neighbours that are used for nexthops, but aren't currently resolved.

However, 'nud_state' is protected by the neighbour lock, so we shouldn't
access it without taking it. Instead, we can simply check the
'connected' field of the neighbour entry, which we update upon
NEIGH_UPDATE events.

Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c