net: phy: improve phy_read_poll_timeout
authorHeiner Kallweit <hkallweit1@gmail.com>
Mon, 6 Mar 2023 21:51:35 +0000 (22:51 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 8 Mar 2023 02:19:09 +0000 (18:19 -0800)
commit0194b64578e905dc8f112e641a71c306bd58ddde
tree4aa9e486cd465d80be467017f9499ddd7e9b1f3d
parent36e5e391a25af28dc1f4586f95d577b38ff4ed72
net: phy: improve phy_read_poll_timeout

cond sometimes is (val & MASK) what may result in a false positive
if val is a negative errno. We shouldn't evaluate cond if val < 0.
This has no functional impact here, but it's not nice.
Therefore switch order of the checks.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/6d8274ac-4344-23b4-d9a3-cad4c39517d4@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/linux/phy.h