Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class...
authorMichael Wyman <michael@mwyman.com>
Fri, 7 Feb 2020 23:08:17 +0000 (16:08 -0700)
committerBen Hamilton <benhamilton@google.com>
Mon, 10 Feb 2020 15:56:28 +0000 (08:56 -0700)
commit0151ddc2e834ab4949789cbed4e03a958284cd54
tree7329d8f3b1789ffa5934e4c2e3a3e97e4dc31c2b
parentf5086b3803ac2f908a734bbb2c7a50018fb3cd8c
Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

Summary: Such implementations may override the class's own implementation, and even be a danger in case someone later comes and adds one to the class itself. Most times this has been encountered have been a mistake.

Reviewers: stephanemoore, benhamilton, dmaclach

Reviewed By: stephanemoore, benhamilton, dmaclach

Subscribers: dmaclach, mgorny, cfe-commits

Tags: #clang-tools-extra, #clang

Differential Revision: https://reviews.llvm.org/D72876
clang-tools-extra/clang-tidy/objc/CMakeLists.txt
clang-tools-extra/clang-tidy/objc/DeallocInCategoryCheck.cpp [new file with mode: 0644]
clang-tools-extra/clang-tidy/objc/DeallocInCategoryCheck.h [new file with mode: 0644]
clang-tools-extra/clang-tidy/objc/ObjCTidyModule.cpp
clang-tools-extra/docs/ReleaseNotes.rst
clang-tools-extra/docs/clang-tidy/checks/list.rst
clang-tools-extra/docs/clang-tidy/checks/objc-dealloc-in-category.rst [new file with mode: 0644]
clang-tools-extra/test/clang-tidy/checkers/objc-dealloc-in-category.m [new file with mode: 0644]