btrfs: fixup error handling in fixup_inode_link_counts
authorJosef Bacik <josef@toxicpanda.com>
Wed, 19 May 2021 17:13:15 +0000 (13:13 -0400)
committerDavid Sterba <dsterba@suse.com>
Thu, 27 May 2021 21:31:08 +0000 (23:31 +0200)
commit011b28acf940eb61c000059dd9e2cfcbf52ed96b
treeeb0cf73c036bf4147337824efa4edd4404f492e4
parentd61bec08b904cf171835db98168f82bc338e92e4
btrfs: fixup error handling in fixup_inode_link_counts

This function has the following pattern

while (1) {
ret = whatever();
if (ret)
goto out;
}
ret = 0
out:
return ret;

However several places in this while loop we simply break; when there's
a problem, thus clearing the return value, and in one case we do a
return -EIO, and leak the memory for the path.

Fix this by re-arranging the loop to deal with ret == 1 coming from
btrfs_search_slot, and then simply delete the

ret = 0;
out:

bit so everybody can break if there is an error, which will allow for
proper error handling to occur.

CC: stable@vger.kernel.org # 4.4+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/tree-log.c