ipv4: fix null-deref in ipv4_link_failure
authorKyle Zeng <zengyhkyle@gmail.com>
Fri, 15 Sep 2023 05:12:57 +0000 (22:12 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sun, 17 Sep 2023 14:14:58 +0000 (15:14 +0100)
commit0113d9c9d1ccc07f5a3710dac4aa24b6d711278c
tree617a53dcdcbb3f983b0ef70f17a4e1fced5c86b0
parentcb47b1f679c4d83a5fa5f1852e472f844e41a3da
ipv4: fix null-deref in ipv4_link_failure

Currently, we assume the skb is associated with a device before calling
__ip_options_compile, which is not always the case if it is re-routed by
ipvs.
When skb->dev is NULL, dev_net(skb->dev) will become null-dereference.
This patch adds a check for the edge case and switch to use the net_device
from the rtable when skb->dev is NULL.

Fixes: ed0de45a1008 ("ipv4: recompile ip options in ipv4_link_failure")
Suggested-by: David Ahern <dsahern@kernel.org>
Signed-off-by: Kyle Zeng <zengyhkyle@gmail.com>
Cc: Stephen Suryaputra <ssuryaextr@gmail.com>
Cc: Vadim Fedorenko <vfedorenko@novek.ru>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/route.c