Ensure hyphen/minus is treated as literal in regexes
authorSimon McVittie <smcv@collabora.com>
Fri, 14 Apr 2017 12:04:13 +0000 (13:04 +0100)
committerSimon McVittie <smcv@debian.org>
Tue, 18 Apr 2017 11:46:20 +0000 (12:46 +0100)
commit01019f2bb433c8c12ba4f58e428c3fc506e41632
treeea2dd2010f7e5f550269f41c27260e4bdaf028aa
parentef628c3b0afa0b1effdfdf273f8cbacaff969e31
Ensure hyphen/minus is treated as literal in regexes

Each U+002D HYPHEN-MINUS in [0-9A-Za-z_-/.\] is treated as a member of a
range. The third one, which appears to have been intended to be a
literal, is part of an empty range because the starting point
U+005F LOW LINE is greater than the endpoint U+002F SOLIDUS, resulting
in at least some grep implementations not considering U+002D, U+002F
or U+005F to match the pattern. This resulted in one of the
dbus-launch tests being unintentionally skipped when it used a
regex based on the one in the spec.

regex(7) suggests "To include a literal '-' [in a bracketed character
set], make it the first or last character".

Signed-off-by: Simon McVittie <smcv@collabora.com>
Reviewed-by: Philip Withnall <withnall@endlessm.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=100686
doc/dbus-specification.xml
test/test-dbus-launch-x11.sh