[asan] Keep Itanium mangled names in global metadata
authorFangrui Song <i@maskray.me>
Sat, 19 Nov 2022 01:06:26 +0000 (01:06 +0000)
committerFangrui Song <i@maskray.me>
Sat, 19 Nov 2022 01:06:26 +0000 (01:06 +0000)
commit00be3578e0841dd9abe408e5b4946180de0bf46b
tree3e0b124e7d79c30769dd93d473657181e2472e02
parent3c36de55f5e60dee8f1bc04bd201f6dd762b3423
[asan] Keep Itanium mangled names in global metadata

The runtime calls `MaybeDemangleGlobalName` for error reporting and
`__cxxabiv1::__cxa_demangle` is called if available, so demanging Itanium
mangled names in global metadata is unnecessary and wastes data size.

Add `MaybeDemangleGlobalName` in ODR violation detection to support demangled
names in a suppressions file. `MaybeDemangleGlobalName` may call
`DemangleCXXABI` and leak memory. Use an internal allocation to prevent lsan
leak (in case there is no fatal asan error).

The debug feature `report_globals=2` prints information for all instrumented
global variables. `MaybeDemangleGlobalName` would be slow, so don't do that.
The output looks like `Added Global[0x56448f092d60]: beg=0x56448fa66d60 size=4/32 name=_ZL13test_global_2`
and I think the mangled name is fine.

Other mangled schemes e.g. Windows (see win-string-literal.ll) remain the
current behavior.

Reviewed By: hctim

Differential Revision: https://reviews.llvm.org/D138095
compiler-rt/lib/asan/asan_globals.cpp
compiler-rt/lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cpp
compiler-rt/test/asan/TestCases/Linux/odr_indicators.cpp
llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
llvm/test/Instrumentation/AddressSanitizer/local_alias.ll