drivers/mtd/maps: introduce missing kfree
authorJulia Lawall <julia@diku.dk>
Tue, 1 Jun 2010 14:34:20 +0000 (16:34 +0200)
committerDavid Woodhouse <David.Woodhouse@intel.com>
Thu, 3 Jun 2010 10:29:25 +0000 (11:29 +0100)
commit00b275dbfc2ae3e3312a910736dd9a6bd5110c2b
tree81bf813b90f25a54c5d46927ba51ef24e66cd26e
parentb51adeae29d1ca07090d4f9c9c886499351e0129
drivers/mtd/maps: introduce missing kfree

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
drivers/mtd/maps/physmap_of.c