[Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false
authorSam McCall <sam.mccall@gmail.com>
Sat, 7 May 2022 00:15:41 +0000 (02:15 +0200)
committerSam McCall <sam.mccall@gmail.com>
Tue, 10 May 2022 14:58:13 +0000 (16:58 +0200)
commit00a3c9f2a46a566b3ff10f2d24b01426df2193ab
tree8fb71c5e8a9660d8415753f643b00b09e0ede190
parent9e50168be444dc6cc076fe3ac3d0fb73dfca7428
[Frontend] Flip default of CreateInvocationOptions::ProbePrecompiled to false

This is generally a better default for tools other than the compiler, which
shouldn't assume a PCH file on disk is something they can consume.

Preserve the old behavior in places associated with libclang/c-index-test
(including ASTUnit) as there are tests relying on it and most important
consumers are out-of-tree. It's unclear whether the tests are specifically
trying to test this functionality, and what the downstream implications of
removing it are. Hopefully someone more familiar can clean this up in future.

Differential Revision: https://reviews.llvm.org/D125149
clang/include/clang/Frontend/Utils.h
clang/lib/Frontend/ASTUnit.cpp
clang/tools/c-index-test/core_main.cpp
clang/tools/libclang/Indexing.cpp
clang/unittests/Frontend/UtilsTest.cpp