[ELF] Suppress "duplicate symbol" when resolving STB_WEAK and STB_GNU_UNIQUE in diffe...
authorFangrui Song <i@maskray.me>
Fri, 21 Oct 2022 16:43:25 +0000 (09:43 -0700)
committerFangrui Song <i@maskray.me>
Fri, 21 Oct 2022 16:43:25 +0000 (09:43 -0700)
commit0051b6bb78772b0658f28e5f31ddf91c1589aab5
tree71951c5656093b8320877721ed062cc2468c3bb6
parent461a1836d3d77371bb6271fefd645897997a22b8
[ELF] Suppress "duplicate symbol" when resolving STB_WEAK and STB_GNU_UNIQUE in different COMDATs

```
template <typename T> struct A {
  A() {}
  int value = 0;
};

template <typename Value> struct B {
  static A<int> a;
};

template <typename Value> A<int> B<Value>::a;

inline int foo() {
  return B<int>::a.value;
}
```

```
clang++ -c -fno-pic a.cc -o weak.o
g++ -c -fno-pic a.cc -o unique.o  # --enable-gnu-unique-object

# Duplicate symbol error. In postParse, we do not check `sym.binding`
ld.lld -e 0 weak.o unique.o
```

Mixing GCC and Clang object files in this case is not ideal. .bss._ZGVN1BIiE1aE
has different COMDAT groups. It appears to work in practice because the guard
variable prevents harm due to double initialization.

For the linker, we just stick with the rule that a weak binding does not cause
"duplicate symbol" errors.

Close https://github.com/llvm/llvm-project/issues/58232

Differential Revision: https://reviews.llvm.org/D136381
lld/ELF/InputFiles.cpp
lld/test/ELF/comdat-binding2.s [new file with mode: 0644]