[ELF] - Stop setting OutSecOff too early.
authorGeorge Rimar <grimar@accesssoftek.com>
Mon, 9 Apr 2018 13:01:50 +0000 (13:01 +0000)
committerGeorge Rimar <grimar@accesssoftek.com>
Mon, 9 Apr 2018 13:01:50 +0000 (13:01 +0000)
commit0029f214820d79bf09a9c5c3152012ef9eb4348a
tree71d0eca1a5ec7e520eebecea0d9425ffc39564e7
parent9bc20fff4ad2a5bf38e942c9e24ae8a2240ec7e8
[ELF] - Stop setting OutSecOff too early.

Currently LLD sets OutSecOff in addSection for input sections.
That is a fake offset (just a rude approximation to remember the order),
used for sorting SHF_LINK_ORDER sections
(see resolveShfLinkOrder, compareByFilePosition).

There are 2 problems with such approach:

1. We currently change and reuse Size field as a value assigned. Changing size is
not good because leads to bugs. Currently, SIZEOF(.bss) for empty .bss returns 2
because we add two empty synthetic sections and increase size twice by 1.
(See PR37011: https://bugs.llvm.org/show_bug.cgi?id=37011)

2. Such approach simply does not work when --symbol-ordering-file is involved,
because processing of the ordering file might break the initial section order.

This fixes PR37011.

Differential revision: https://reviews.llvm.org/D45368

llvm-svn: 329560
lld/ELF/LinkerScript.cpp
lld/ELF/OutputSections.cpp
lld/ELF/Writer.cpp
lld/test/ELF/linkerscript/empty-section-size.test [new file with mode: 0644]
lld/test/ELF/linkerscript/section-metadata2.s [new file with mode: 0644]