Nullable: Attributes, SafeHandles, and misc (#23810)
authorStephen Toub <stoub@microsoft.com>
Tue, 9 Apr 2019 17:01:36 +0000 (13:01 -0400)
committerGitHub <noreply@github.com>
Tue, 9 Apr 2019 17:01:36 +0000 (13:01 -0400)
commit0006d20825b83e70e2c8286f9cada843b48be060
tree4969894b23679e77c3f987a235224086dd0c76e2
parent5ce35bf3d4456a81e22b6a74a03978a1a3abd75d
Nullable: Attributes, SafeHandles, and misc (#23810)

* Nullable: Attributes, SafeHandles, and misc

* Address PR feedback
139 files changed:
src/System.Private.CoreLib/Common/NotImplemented.cs
src/System.Private.CoreLib/Common/System/SR.cs
src/System.Private.CoreLib/shared/Internal/Runtime/CompilerServices/Unsafe.cs
src/System.Private.CoreLib/shared/Interop/Windows/Interop.BOOL.cs
src/System.Private.CoreLib/shared/Interop/Windows/Interop.BOOLEAN.cs
src/System.Private.CoreLib/shared/Interop/Windows/Interop.Errors.cs
src/System.Private.CoreLib/shared/Interop/Windows/Interop.Libraries.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/CriticalHandleMinusOneIsInvalid.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/CriticalHandleZeroOrMinusOneIsInvalid.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeFileHandle.Unix.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeFileHandle.Windows.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeFindHandle.Windows.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeHandleMinusOneIsInvalid.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeHandleZeroOrMinusOneIsInvalid.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeLibraryHandle.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeRegistryHandle.Windows.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeRegistryHandle.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeWaitHandle.Windows.cs
src/System.Private.CoreLib/shared/Microsoft/Win32/SafeHandles/SafeWaitHandle.cs
src/System.Private.CoreLib/shared/System/IO/FileStream.Unix.cs
src/System.Private.CoreLib/shared/System/IO/FileStream.Windows.cs
src/System.Private.CoreLib/shared/System/IO/FileStreamCompletionSource.Win32.cs
src/System.Private.CoreLib/shared/System/Numerics/Hashing/HashHelpers.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyAlgorithmIdAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyCompanyAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyConfigurationAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyCopyrightAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyCultureAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyDelaySignAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyDescriptionAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyFileVersionAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyFlagsAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyInformationalVersionAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyKeyFileAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyKeyNameAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyMetadataAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyProductAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblySignatureKeyAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyTitleAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyTrademarkAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/AssemblyVersionAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/DefaultMemberAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/ObfuscateAssemblyAttribute.cs
src/System.Private.CoreLib/shared/System/Reflection/ObfuscationAttribute.cs
src/System.Private.CoreLib/shared/System/Resources/NeutralResourcesLanguageAttribute.cs
src/System.Private.CoreLib/shared/System/Resources/SatelliteContractVersionAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/AccessedThroughPropertyAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/AsyncMethodBuilderAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/CallerArgumentExpressionAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/CallerFilePathAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/CallerLineNumberAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/CallerMemberNameAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/CompilationRelaxationsAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/CompilerGeneratedAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/CompilerGlobalScopeAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/ConditionalWeakTable.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/CustomConstantAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/DecimalConstantAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/DefaultDependencyAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/DependencyAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/DisablePrivateReflectionAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/DiscardableAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/ExtensionAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/FixedAddressValueTypeAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/FixedBufferAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/IndexerNameAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/InternalsVisibleToAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/IntrinsicAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/IsByRefLikeAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/IsReadOnlyAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/MethodImplAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/ReferenceAssemblyAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/RuntimeCompatibilityAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/RuntimeHelpers.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/SpecialNameAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/StateMachineAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/StringFreezingAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/SuppressIldasmAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/TupleElementNamesAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/TypeForwardedFromAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/TypeForwardedToAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/CompilerServices/UnsafeValueTypeAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/ConstrainedExecution/ReliabilityContractAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/ExceptionServices/HandleProcessCorruptedStateExceptionsAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/GCSettings.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/AllowReversePInvokeCallsAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/BestFitMappingAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/ClassInterfaceAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/CoClassAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/ComDefaultInterfaceAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/ComEventInterfaceAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/ComImportAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/ComSourceInterfacesAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/ComVisibleAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/DefaultCharSetAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/DefaultDllImportSearchPathsAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/DefaultParameterValueAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/DispIdAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/DllImportAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/FieldOffsetAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/GuidAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/InAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/InterfaceTypeAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/LCIDConversionAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/MarshalAsAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/NativeCallableAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/OptionalAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/OutAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/PreserveSigAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/ProgIdAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/SafeHandle.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/StructLayoutAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/TypeIdentifierAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/UnmanagedFunctionPointerAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/InteropServices/WindowsRuntime/EventRegistrationToken.cs
src/System.Private.CoreLib/shared/System/Runtime/Loader/AssemblyLoadContext.cs
src/System.Private.CoreLib/shared/System/Runtime/Remoting/ObjectHandle.cs
src/System.Private.CoreLib/shared/System/Runtime/Serialization/OnDeserializedAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/Serialization/OnDeserializingAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/Serialization/OnSerializedAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/Serialization/OnSerializingAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/Serialization/OptionalFieldAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/Versioning/NonVersionableAttribute.cs
src/System.Private.CoreLib/shared/System/Runtime/Versioning/TargetFrameworkAttribute.cs
src/System.Private.CoreLib/shared/System/Text/StringBuilder.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/CrossLoaderAllocatorHashHelpers.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/DependentHandle.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/GCHeapHash.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/ICastableHelpers.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeFeature.CoreCLR.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.cs
src/System.Private.CoreLib/src/System/Runtime/CompilerServices/TypeDependencyAttribute.cs
src/System.Private.CoreLib/src/System/Runtime/GCSettings.CoreCLR.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/Expando/IExpando.cs
src/System.Private.CoreLib/src/System/Runtime/InteropServices/WindowsRuntime/Attributes.cs
src/System.Private.CoreLib/src/System/Runtime/Loader/AssemblyLoadContext.CoreCLR.cs
src/System.Private.CoreLib/src/System/Runtime/RuntimeImports.cs
src/System.Private.CoreLib/src/System/Runtime/Versioning/CompatibilitySwitch.cs
src/System.Private.CoreLib/src/System/Security/DynamicSecurityMethodAttribute.cs