drm/i915: Error out if we are trying to use VGA with SPLL already in use
authorDamien Lespiau <damien.lespiau@intel.com>
Thu, 7 Mar 2013 15:30:25 +0000 (15:30 +0000)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Sat, 23 Mar 2013 12:26:56 +0000 (13:26 +0100)
commit00037c2e95618c8a598ff41e2fc4d34367b0eb91
treecf7ec9d659b0168534035f3dc55569a85d081ffc
parente3dff585508636c8d2915cc1595e04f16ccd66ba
drm/i915: Error out if we are trying to use VGA with SPLL already in use

Our static analysis tool noticed that 'reg' could be used uninitialized if
we are trying to get a PLL to drive VGA and SPLL is already in use
(plls->spll_refcoung != 0).

In the (error) case above, let's return false to the caller and emit an
error.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_ddi.c