X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=src%2Ftdm_layer.c;h=429f8850e0b4774a31031dd8413b7a27b5367196;hb=refs%2Fchanges%2F77%2F184377%2F2;hp=ed86c37abdfbb5ebcd339f9dfb74566dccf16063;hpb=92593db55dd1dd710d043236e5c72177e025b8d4;p=platform%2Fcore%2Fuifw%2Flibtdm.git diff --git a/src/tdm_layer.c b/src/tdm_layer.c index ed86c37..429f885 100644 --- a/src/tdm_layer.c +++ b/src/tdm_layer.c @@ -9,7 +9,7 @@ * Taeheon Kim , * YoungJun Cho , * SooChan Lim , - * Boram Park + * Boram Park * * Permission is hereby granted, free of charge, to any person obtaining a * copy of this software and associated documentation files (the @@ -71,7 +71,6 @@ private_output = private_layer->private_output; \ private_display = private_output->private_display -static void _tdm_layer_free_buffer(tdm_private_layer *private_layer, tdm_private_layer_buffer *layer_buffer); static void _tdm_layer_cb_wait_vblank(tdm_vblank *vblank, tdm_error error, unsigned int sequence, unsigned int tv_sec, unsigned int tv_usec, void *user_data); static void _tbm_layer_queue_acquirable_cb(tbm_surface_queue_h surface_queue, void *data); @@ -80,6 +79,41 @@ static void _tdm_layer_cb_output_commit(tdm_output *output, unsigned int sequenc unsigned int tv_sec, unsigned int tv_usec, void *user_data); static void _tdm_layer_reset_pending_data(tdm_private_layer *private_layer); +EXTERN tdm_output* +tdm_layer_get_output(tdm_layer *layer, tdm_error *error) +{ + tdm_output *output; + + LAYER_FUNC_ENTRY_ERROR(); + + _pthread_mutex_lock(&private_display->lock); + + if (error) + *error = TDM_ERROR_NONE; + + output = private_layer->private_output; + + _pthread_mutex_unlock(&private_display->lock); + + return output; +} + +EXTERN tdm_error +tdm_layer_get_index(tdm_layer *layer, int *index) +{ + LAYER_FUNC_ENTRY(); + + TDM_RETURN_VAL_IF_FAIL(index != NULL, TDM_ERROR_INVALID_PARAMETER); + + _pthread_mutex_lock(&private_display->lock); + + *index = private_layer->index; + + _pthread_mutex_unlock(&private_display->lock); + + return ret; +} + EXTERN tdm_error tdm_layer_get_capabilities(tdm_layer *layer, tdm_layer_capability *capabilities) { @@ -151,15 +185,17 @@ tdm_layer_get_zpos(tdm_layer *layer, int *zpos) EXTERN tdm_error tdm_layer_set_property(tdm_layer *layer, unsigned int id, tdm_value value) { + tdm_private_module *private_module; tdm_func_layer *func_layer; LAYER_FUNC_ENTRY(); _pthread_mutex_lock(&private_display->lock); - func_layer = &private_display->func_layer; + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; if (private_layer->usable) - TDM_INFO("layer(%d) not usable", private_layer->index); + TDM_INFO("layer(%p,%d) not usable", private_layer, private_layer->index); private_layer->usable = 0; @@ -181,6 +217,7 @@ tdm_layer_set_property(tdm_layer *layer, unsigned int id, tdm_value value) EXTERN tdm_error tdm_layer_get_property(tdm_layer *layer, unsigned int id, tdm_value *value) { + tdm_private_module *private_module; tdm_func_layer *func_layer; LAYER_FUNC_ENTRY(); @@ -188,7 +225,8 @@ tdm_layer_get_property(tdm_layer *layer, unsigned int id, tdm_value *value) _pthread_mutex_lock(&private_display->lock); - func_layer = &private_display->func_layer; + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; if (!func_layer->layer_get_property) { /* LCOV_EXCL_START */ @@ -208,15 +246,15 @@ tdm_layer_get_property(tdm_layer *layer, unsigned int id, tdm_value *value) INTERN tdm_error tdm_layer_set_info_internal(tdm_private_layer *private_layer, tdm_info_layer *info) { - tdm_private_output *private_output = private_layer->private_output; - tdm_private_display *private_display = private_output->private_display; + tdm_private_module *private_module; tdm_func_layer *func_layer; char fmtstr[128]; - func_layer = &private_display->func_layer; + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; if (private_layer->usable) - TDM_INFO("layer(%p) not usable", private_layer); + TDM_INFO("layer(%p,%d) not usable", private_layer, private_layer->index); private_layer->usable = 0; @@ -232,8 +270,9 @@ tdm_layer_set_info_internal(tdm_private_layer *private_layer, tdm_info_layer *in else snprintf(fmtstr, 128, "NONE"); - TDM_INFO("layer(%p) info: src(%ux%u %u,%u %ux%u %s) dst(%u,%u %ux%u) trans(%d)", - private_layer, info->src_config.size.h, info->src_config.size.v, + TDM_INFO("layer(%p,%d) info: src(%ux%u %u,%u %ux%u %s) dst(%u,%u %ux%u) trans(%d)", + private_layer, private_layer->index, + info->src_config.size.h, info->src_config.size.v, info->src_config.pos.x, info->src_config.pos.y, info->src_config.pos.w, info->src_config.pos.h, fmtstr, @@ -266,6 +305,7 @@ tdm_layer_set_info(tdm_layer *layer, tdm_info_layer *info) EXTERN tdm_error tdm_layer_get_info(tdm_layer *layer, tdm_info_layer *info) { + tdm_private_module *private_module; tdm_func_layer *func_layer; LAYER_FUNC_ENTRY(); @@ -273,7 +313,8 @@ tdm_layer_get_info(tdm_layer *layer, tdm_info_layer *info) _pthread_mutex_lock(&private_display->lock); - func_layer = &private_display->func_layer; + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; if (!func_layer->layer_get_info) { /* LCOV_EXCL_START */ @@ -322,8 +363,8 @@ _tdm_layer_dump_buffer(tdm_layer *layer, tbm_surface_h buffer) } /* LCOV_EXCL_STOP */ -static void -_tdm_layer_free_buffer(tdm_private_layer *private_layer, tdm_private_layer_buffer *layer_buffer) +void +tdm_layer_free_buffer(tdm_private_layer *private_layer, tdm_private_layer_buffer *layer_buffer) { tdm_private_display *private_display; @@ -355,30 +396,30 @@ _tdm_layer_free_all_buffers(tdm_private_layer *private_layer) _tdm_layer_reset_pending_data(private_layer); if (private_layer->waiting_buffer) { - _tdm_layer_free_buffer(private_layer, private_layer->waiting_buffer); + tdm_layer_free_buffer(private_layer, private_layer->waiting_buffer); private_layer->waiting_buffer = NULL; if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) waiting_buffer(%p)", - private_layer, private_layer->waiting_buffer); + TDM_INFO("layer(%p,%d) waiting_buffer(%p)", + private_layer, private_layer->index, private_layer->waiting_buffer); } if (private_layer->committed_buffer) { - _tdm_layer_free_buffer(private_layer, private_layer->committed_buffer); + tdm_layer_free_buffer(private_layer, private_layer->committed_buffer); private_layer->committed_buffer = NULL; if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) committed_buffer(%p)", - private_layer, private_layer->committed_buffer); + TDM_INFO("layer(%p,%d) committed_buffer(%p)", + private_layer, private_layer->index, private_layer->committed_buffer); } if (private_layer->showing_buffer) { - _tdm_layer_free_buffer(private_layer, private_layer->showing_buffer); + tdm_layer_free_buffer(private_layer, private_layer->showing_buffer); private_layer->showing_buffer = NULL; if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) showing_buffer(%p)", - private_layer, private_layer->showing_buffer); + TDM_INFO("layer(%p,%d) showing_buffer(%p)", + private_layer, private_layer->index, private_layer->showing_buffer); } LIST_FOR_EACH_ENTRY_SAFE(lm, lmm, &private_output->layer_commit_handler_list, link) { @@ -391,7 +432,7 @@ _tdm_layer_free_all_buffers(tdm_private_layer *private_layer) LIST_FOR_EACH_ENTRY_SAFE(lm, lmm, &clone_list, link) { LIST_DEL(&lm->link); tdm_output_remove_commit_handler_internal(private_output, _tdm_layer_cb_output_commit, lm); - _tdm_layer_free_buffer(private_layer, lm->committed_buffer); + tdm_layer_free_buffer(private_layer, lm->committed_buffer); free(lm); } @@ -404,7 +445,7 @@ _tdm_layer_free_all_buffers(tdm_private_layer *private_layer) LIST_FOR_EACH_ENTRY_SAFE(lm, lmm, &clone_list, link) { LIST_DEL(&lm->link); - _tdm_layer_free_buffer(private_layer, lm->committed_buffer); + tdm_layer_free_buffer(private_layer, lm->committed_buffer); free(lm); } @@ -415,17 +456,13 @@ _tdm_layer_free_all_buffers(tdm_private_layer *private_layer) } } -EXTERN tdm_error -tdm_layer_set_buffer(tdm_layer *layer, tbm_surface_h buffer) +INTERN tdm_error +tdm_layer_set_buffer_internal(tdm_private_layer *private_layer, tbm_surface_h buffer) { + tdm_private_module *private_module; + tdm_private_output *private_output = private_layer->private_output; tdm_func_layer *func_layer; - LAYER_FUNC_ENTRY(); - - TDM_RETURN_VAL_IF_FAIL(buffer != NULL, TDM_ERROR_INVALID_PARAMETER); - - _pthread_mutex_lock(&private_display->lock); - /* LCOV_EXCL_START */ /* dump buffer */ if (tdm_dump_enable && !(private_layer->caps.capabilities & TDM_LAYER_CAPABILITY_VIDEO)) @@ -441,16 +478,16 @@ tdm_layer_set_buffer(tdm_layer *layer, tbm_surface_h buffer) } /* LCOV_EXCL_STOP */ - func_layer = &private_display->func_layer; + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; if (private_layer->usable) - TDM_INFO("layer(%p) not usable", private_layer); + TDM_INFO("layer(%p,%d) not usable", private_layer, private_layer->index); private_layer->usable = 0; if (!func_layer->layer_set_buffer) { /* LCOV_EXCL_START */ - _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; /* LCOV_EXCL_START */ @@ -461,8 +498,8 @@ tdm_layer_set_buffer(tdm_layer *layer, tbm_surface_h buffer) if (private_layer->pending_buffer) { if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) pending_buffer(%p) skipped", - private_layer, private_layer->pending_buffer); + TDM_INFO("layer(%p,%d) pending_buffer(%p) skipped", + private_layer, private_layer->index, private_layer->pending_buffer); if (tdm_ttrace_module & TDM_TTRACE_LAYER) { tbm_bo bo = tbm_surface_internal_get_bo(private_layer->pending_buffer, 0); @@ -475,40 +512,56 @@ tdm_layer_set_buffer(tdm_layer *layer, tbm_surface_h buffer) tbm_surface_internal_ref(buffer); private_layer->pending_buffer = buffer; - if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) pending_buffer(%p)", - private_layer, private_layer->pending_buffer); + if (tdm_debug_module & TDM_DEBUG_BUFFER) { + tbm_bo bo = tbm_surface_internal_get_bo(private_layer->pending_buffer, 0); + int flags = tbm_bo_get_flags(bo); + TDM_INFO("layer(%p,%d) pending_buffer(%p) bo_flags(%x)", + private_layer, private_layer->index, private_layer->pending_buffer, flags); + } if (tdm_ttrace_module & TDM_TTRACE_LAYER) { tbm_bo bo = tbm_surface_internal_get_bo(private_layer->pending_buffer, 0); TDM_TRACE_ASYNC_BEGIN((intptr_t)private_layer, "[LAYER] %d", tbm_bo_export(bo)); } - _pthread_mutex_unlock(&private_display->lock); - - return ret; + return TDM_ERROR_NONE; } EXTERN tdm_error -tdm_layer_unset_buffer(tdm_layer *layer) +tdm_layer_set_buffer(tdm_layer *layer, tbm_surface_h buffer) { - tdm_func_layer *func_layer; LAYER_FUNC_ENTRY(); + TDM_RETURN_VAL_IF_FAIL(buffer != NULL, TDM_ERROR_INVALID_PARAMETER); + _pthread_mutex_lock(&private_display->lock); - func_layer = &private_display->func_layer; + ret = tdm_layer_set_buffer_internal(private_layer, buffer); + + _pthread_mutex_unlock(&private_display->lock); + + return ret; +} + +INTERN tdm_error +tdm_layer_unset_buffer_internal(tdm_private_layer *private_layer) +{ + tdm_private_module *private_module; + tdm_func_layer *func_layer; + tdm_error ret = TDM_ERROR_NONE; + + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; _tdm_layer_free_all_buffers(private_layer); private_layer->usable = 1; if (private_layer->usable) - TDM_INFO("layer(%p) now usable", private_layer); + TDM_INFO("layer(%p,%d) now usable", private_layer, private_layer->index); if (!func_layer->layer_unset_buffer) { /* LCOV_EXCL_START */ - _pthread_mutex_unlock(&private_display->lock); TDM_ERR("not implemented!!"); return TDM_ERROR_NOT_IMPLEMENTED; /* LCOV_EXCL_START */ @@ -517,6 +570,19 @@ tdm_layer_unset_buffer(tdm_layer *layer) ret = func_layer->layer_unset_buffer(private_layer->layer_backend); TDM_WARNING_IF_FAIL(ret == TDM_ERROR_NONE); + return ret; +} + +EXTERN tdm_error +tdm_layer_unset_buffer(tdm_layer *layer) +{ + LAYER_FUNC_ENTRY(); + + _pthread_mutex_lock(&private_display->lock); + + ret = tdm_layer_unset_buffer_internal(private_layer); + TDM_WARNING_IF_FAIL(ret == TDM_ERROR_NONE); + _pthread_mutex_unlock(&private_display->lock); return ret; @@ -534,7 +600,8 @@ tdm_layer_committed(tdm_private_layer *private_layer, tdm_private_layer_buffer * if (private_layer->fps_stamp == 0) { private_layer->fps_stamp = curr; } else if ((curr - private_layer->fps_stamp) > 1.0) { - TDM_INFO("output(%d) layer(%d) fps: %d", private_output->index, private_layer->index, private_layer->fps_count); + TDM_INFO("output(%d) layer(%p,%d) fps: %d", + private_output->index, private_layer, private_layer->index, private_layer->fps_count); private_layer->fps_count = 0; private_layer->fps_stamp = curr; } else @@ -551,15 +618,15 @@ tdm_layer_committed(tdm_private_layer *private_layer, tdm_private_layer_buffer * TDM_TRACE_ASYNC_END((intptr_t)private_layer, "[LAYER] %d", tbm_bo_export(bo)); } - _tdm_layer_free_buffer(private_layer, private_layer->showing_buffer); + tdm_layer_free_buffer(private_layer, private_layer->showing_buffer); } private_layer->showing_buffer = *committed_buffer; *committed_buffer = NULL; if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) committed_buffer(%p) showing_buffer(%p)", - private_layer, *committed_buffer, + TDM_INFO("layer(%p,%d) committed_buffer(%p) showing_buffer(%p)", + private_layer, private_layer->index, *committed_buffer, (private_layer->showing_buffer) ? private_layer->showing_buffer->buffer : NULL); } @@ -593,8 +660,8 @@ _tdm_layer_got_output_vblank(tdm_private_output *private_output, unsigned int se LIST_FOR_EACH_ENTRY_SAFE(lm, lmm, &clone_list, link) { if (tdm_debug_module & TDM_DEBUG_COMMIT) - TDM_INFO("layer(%p) committed. handle(%p) commited_buffer(%p)", - lm->private_layer, lm, (lm->committed_buffer) ? lm->committed_buffer->buffer : NULL); + TDM_INFO("layer(%p,%d) committed. handle(%p) commited_buffer(%p)", + lm->private_layer, lm->private_layer->index, lm, (lm->committed_buffer) ? lm->committed_buffer->buffer : NULL); LIST_DEL(&lm->link); tdm_layer_committed(lm->private_layer, &lm->committed_buffer); @@ -603,7 +670,7 @@ _tdm_layer_got_output_vblank(tdm_private_output *private_output, unsigned int se lm->func(lm->private_layer, sequence, tv_sec, tv_usec, lm->user_data); _pthread_mutex_lock(&private_display->lock); if (lm->committed_buffer) - _tdm_layer_free_buffer(lm->private_layer, lm->committed_buffer); + tdm_layer_free_buffer(lm->private_layer, lm->committed_buffer); free(lm); } @@ -657,7 +724,7 @@ wait_failed: if (lm->func) lm->func(lm->private_layer, sequence, tv_sec, tv_usec, lm->user_data); _pthread_mutex_lock(&private_display->lock); - _tdm_layer_free_buffer(lm->private_layer, lm->committed_buffer); + tdm_layer_free_buffer(lm->private_layer, lm->committed_buffer); free(lm); } @@ -693,9 +760,11 @@ _tdm_layer_cb_output_commit(tdm_output *output, unsigned int sequence, private_layer = layer_commit_handler->private_layer; + private_layer->committing = 0; + if (tdm_debug_module & TDM_DEBUG_COMMIT) - TDM_INFO("layer(%p) commit: output(%d) committed. handle(%p)", - private_layer, private_output->pipe, layer_commit_handler); + TDM_INFO("layer(%p,%d) commit: output(%d) committed. handle(%p)", + private_layer, private_layer->index, private_output->pipe, layer_commit_handler); _pthread_mutex_lock(&private_display->lock); @@ -703,7 +772,7 @@ _tdm_layer_cb_output_commit(tdm_output *output, unsigned int sequence, if (layer_commit_handler->func) { _pthread_mutex_unlock(&private_display->lock); - layer_commit_handler->func(private_output, sequence, + layer_commit_handler->func(private_layer, sequence, tv_sec, tv_usec, layer_commit_handler->user_data); _pthread_mutex_lock(&private_display->lock); } @@ -766,18 +835,20 @@ _tdm_layer_commit_possible(tdm_private_layer *private_layer) */ if (!LIST_IS_EMPTY(&private_output->layer_commit_handler_list)) { if (tdm_debug_module & TDM_DEBUG_COMMIT) - TDM_INFO("layer(%p) commit: not possible(previous commit)", private_layer); + TDM_INFO("layer(%p,%d) commit: not possible(previous commit)", + private_layer, private_layer->index); return 0; } if (private_output->commit_per_vblank == 1 && _tdm_lauer_get_output_used_layer_count(private_output) > 1) { if (tdm_debug_module & TDM_DEBUG_COMMIT) - TDM_INFO("layer(%p) commit: not possible(more than 2 layers)", private_layer); + TDM_INFO("layer(%p,%d) commit: not possible(more than 2 layers)", + private_layer, private_layer->index); return 0; } if (tdm_debug_module & TDM_DEBUG_COMMIT) - TDM_INFO("layer(%p) commit: possible", private_layer); + TDM_INFO("layer(%p,%d) commit: possible", private_layer, private_layer->index); return 1; } @@ -798,12 +869,12 @@ _tdm_layer_reset_pending_data(tdm_private_layer *private_layer) INTERN tdm_error tdm_layer_commit_pending_data(tdm_private_layer *private_layer) { - tdm_private_output *private_output = private_layer->private_output; - tdm_private_display *private_display = private_output->private_display; + tdm_private_module *private_module; tdm_func_layer *func_layer; tdm_error ret = TDM_ERROR_NONE; - func_layer = &private_display->func_layer; + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; if (private_layer->pending_info_changed) { ret = func_layer->layer_set_info(private_layer->layer_backend, &private_layer->pending_info); @@ -822,20 +893,20 @@ tdm_layer_commit_pending_data(tdm_private_layer *private_layer) TDM_WARNING_IF_FAIL(ret == TDM_ERROR_NONE); if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) pending_buffer(%p) committed", - private_layer, private_layer->pending_buffer); + TDM_INFO("layer(%p,%d) pending_buffer(%p) committed", + private_layer, private_layer->index, private_layer->pending_buffer); if (ret == TDM_ERROR_NONE) { if (private_layer->waiting_buffer) - _tdm_layer_free_buffer(private_layer, private_layer->waiting_buffer); + tdm_layer_free_buffer(private_layer, private_layer->waiting_buffer); private_layer->waiting_buffer = layer_buffer; private_layer->waiting_buffer->buffer = tdm_buffer_ref_backend(private_layer->pending_buffer); if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) waiting_buffer(%p)", - private_layer, private_layer->waiting_buffer->buffer); + TDM_INFO("layer(%p,%d) waiting_buffer(%p)", + private_layer, private_layer->index, private_layer->waiting_buffer->buffer); } else - _tdm_layer_free_buffer(private_layer, layer_buffer); + tdm_layer_free_buffer(private_layer, layer_buffer); } done: @@ -863,7 +934,7 @@ _tdm_layer_commit(tdm_layer *layer, tdm_layer_commit_handler func, void *user_da } if (tdm_debug_module & TDM_DEBUG_COMMIT) - TDM_INFO("layer(%p) commit: handle(%p)", private_layer, layer_commit_handler); + TDM_INFO("layer(%p,%d) commit: handle(%p)", private_layer, private_layer->index, layer_commit_handler); LIST_INITHEAD(&layer_commit_handler->link); layer_commit_handler->private_layer = private_layer; @@ -873,9 +944,14 @@ _tdm_layer_commit(tdm_layer *layer, tdm_layer_commit_handler func, void *user_da layer_commit_handler->committed_buffer = private_layer->waiting_buffer; private_layer->waiting_buffer = NULL; + if (private_layer->committing) + TDM_WRN("layer(%p,%d) too many commit", private_layer, private_layer->index); + else + private_layer->committing = 1; + if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) waiting_buffer(%p) committed_buffer(%p)", - private_layer, private_layer->waiting_buffer, + TDM_INFO("layer(%p,%d) waiting_buffer(%p) committed_buffer(%p)", + private_layer, private_layer->index, private_layer->waiting_buffer, (layer_commit_handler->committed_buffer) ? layer_commit_handler->committed_buffer->buffer : NULL); if (!private_output->commit_per_vblank) { @@ -886,29 +962,24 @@ _tdm_layer_commit(tdm_layer *layer, tdm_layer_commit_handler func, void *user_da TDM_GOTO_IF_FAIL(ret == TDM_ERROR_NONE, commit_failed); if (tdm_debug_module & TDM_DEBUG_COMMIT) - TDM_INFO("layer(%p) commit: no commit-per-vblank", private_layer); + TDM_INFO("layer(%p,%d) commit: no commit-per-vblank", private_layer, private_layer->index); } else { TDM_GOTO_IF_FAIL(private_output->commit_type == TDM_COMMIT_TYPE_LAYER, commit_failed); - if (private_layer->committing) - TDM_WRN("layer(%d) too many commit", private_layer->index); - else - private_layer->committing = 1; - if (_tdm_layer_commit_possible(private_layer)) { /* add to layer_commit_handler_list */ LIST_ADDTAIL(&layer_commit_handler->link, &private_output->layer_commit_handler_list); - ret = tdm_output_commit_internal(private_layer->private_output, 0, NULL, NULL); + ret = tdm_output_commit_internal(private_layer->private_output, 0, _tdm_layer_cb_output_commit, layer_commit_handler); TDM_GOTO_IF_FAIL(ret == TDM_ERROR_NONE, commit_failed); if (tdm_debug_module & TDM_DEBUG_COMMIT) - TDM_INFO("layer(%p) commit: output", private_layer); + TDM_INFO("layer(%p,%d) commit: output", private_layer, private_layer->index); } else { /* add to pending_commit_handler_list. It will be commited when a vblank occurs */ LIST_ADDTAIL(&layer_commit_handler->link, &private_output->pending_commit_handler_list); if (tdm_debug_module & TDM_DEBUG_COMMIT) - TDM_INFO("layer(%p) commit: pending", private_layer); + TDM_INFO("layer(%p,%d) commit: pending", private_layer, private_layer->index); } if (!private_output->vblank) { @@ -928,7 +999,7 @@ _tdm_layer_commit(tdm_layer *layer, tdm_layer_commit_handler func, void *user_da private_output->layer_waiting_vblank = 1; if (tdm_debug_module & TDM_DEBUG_COMMIT) - TDM_INFO("layer(%p) commit: wait vblank", private_layer); + TDM_INFO("layer(%p,%d) commit: wait vblank", private_layer, private_layer->index); } } @@ -957,7 +1028,7 @@ tdm_layer_commit_internal(tdm_private_layer *private_layer, tdm_layer_commit_han } if (TDM_OUTPUT_DPMS_VSYNC_IS_OFF(private_output->current_dpms_value)) { - TDM_ERR("layer(%p)'s output(%d) dpms: %s", private_layer, private_output->pipe, + TDM_ERR("layer(%p,%d)'s output(%d) dpms: %s", private_layer, private_layer->index, private_output->pipe, tdm_dpms_str(private_output->current_dpms_value)); return TDM_ERROR_DPMS_OFF; } @@ -965,7 +1036,7 @@ tdm_layer_commit_internal(tdm_private_layer *private_layer, tdm_layer_commit_han /* don't call this inside of _tdm_layer_commit */ ret = tdm_layer_commit_pending_data(private_layer); if (ret != TDM_ERROR_NONE) { - TDM_ERR("layer(%p) committing pending data failed", private_layer); + TDM_ERR("layer(%p,%d) committing pending data failed", private_layer, private_layer->index); return ret; } @@ -1011,6 +1082,9 @@ tdm_layer_remove_commit_handler_internal(tdm_layer *layer, tdm_layer_commit_hand tdm_private_output *private_output = private_layer->private_output; tdm_private_layer_commit_handler *lm = NULL, *lmm = NULL; + if (!func && !user_data) + return; + TDM_RETURN_IF_FAIL(private_layer != NULL); TDM_RETURN_IF_FAIL(TDM_MUTEX_IS_LOCKED()); @@ -1018,7 +1092,7 @@ tdm_layer_remove_commit_handler_internal(tdm_layer *layer, tdm_layer_commit_hand if (lm->func == func && lm->user_data == user_data) { LIST_DEL(&lm->link); tdm_output_remove_commit_handler_internal(private_output, _tdm_layer_cb_output_commit, lm); - _tdm_layer_free_buffer(private_layer, lm->committed_buffer); + tdm_layer_free_buffer(private_layer, lm->committed_buffer); free(lm); break; } @@ -1028,7 +1102,7 @@ tdm_layer_remove_commit_handler_internal(tdm_layer *layer, tdm_layer_commit_hand if (lm->func == func && lm->user_data == user_data) { LIST_DEL(&lm->link); tdm_output_remove_commit_handler_internal(private_output, _tdm_layer_cb_output_commit, lm); - _tdm_layer_free_buffer(private_layer, lm->committed_buffer); + tdm_layer_free_buffer(private_layer, lm->committed_buffer); free(lm); break; } @@ -1063,10 +1137,8 @@ tdm_layer_get_displaying_buffer(tdm_layer *layer, tdm_error *error) if (private_layer->showing_buffer) { buffer = private_layer->showing_buffer->buffer; } else { - if (error) - *error = TDM_ERROR_OPERATION_FAILED; _pthread_mutex_unlock(&private_display->lock); - TDM_DBG("layer(%p) showing_buffer is null", private_layer); + TDM_DBG("layer(%p,%d) showing_buffer is null", private_layer, private_layer->index); return NULL; } _pthread_mutex_unlock(&private_display->lock); @@ -1079,14 +1151,16 @@ _tbm_layer_queue_acquirable_cb(tbm_surface_queue_h surface_queue, void *data) { TDM_RETURN_IF_FAIL(data != NULL); tdm_layer *layer = data; + tdm_private_module *private_module; tdm_func_layer *func_layer; - tbm_surface_h surface = NULL; - tdm_private_layer_buffer *layer_buffer; + tbm_surface_h buffer = NULL; LAYER_FUNC_ENTRY_VOID_RETURN(); _pthread_mutex_lock(&private_display->lock); - func_layer = &private_display->func_layer; + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; + if (!func_layer->layer_set_buffer) { /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); @@ -1094,59 +1168,29 @@ _tbm_layer_queue_acquirable_cb(tbm_surface_queue_h surface_queue, void *data) /* LCOV_EXCL_STOP */ } - layer_buffer = calloc(1, sizeof(tdm_private_layer_buffer)); - if (!layer_buffer) { + if (TBM_SURFACE_QUEUE_ERROR_NONE != tbm_surface_queue_acquire(private_layer->buffer_queue, &buffer) || + buffer == NULL) { /* LCOV_EXCL_START */ + TDM_ERR("layer(%p,%d) tbm_surface_queue_acquire() failed surface:%p", + private_layer, private_layer->index, buffer); _pthread_mutex_unlock(&private_display->lock); - TDM_ERR("alloc failed"); return; /* LCOV_EXCL_STOP */ } - LIST_INITHEAD(&layer_buffer->link); - if (TBM_SURFACE_QUEUE_ERROR_NONE != tbm_surface_queue_acquire(private_layer->buffer_queue, &surface) || - surface == NULL) { - /* LCOV_EXCL_START */ - TDM_ERR("layer(%p) tbm_surface_queue_acquire() failed surface:%p", - private_layer, surface); + ret = tdm_layer_set_buffer_internal(private_layer, buffer); + if (ret != TDM_ERROR_NONE) { + TDM_ERR("tdm_layer_set_buffer_internal failed"); _pthread_mutex_unlock(&private_display->lock); - free(layer_buffer); return; - /* LCOV_EXCL_STOP */ } - /* we don't need to handle pending data here because the changes in this function - * should be applied immediately. we can't expect calling tdm_layer_commit. - */ - ret = func_layer->layer_set_buffer(private_layer->layer_backend, surface); - TDM_WARNING_IF_FAIL(ret == TDM_ERROR_NONE); - - if (ret == TDM_ERROR_NONE) { - if (private_layer->waiting_buffer) { - TDM_DBG("layer(%p) drop waiting_buffer(%p)", private_layer, private_layer->waiting_buffer->buffer); - _tdm_layer_free_buffer(private_layer, private_layer->waiting_buffer); - } - - private_layer->waiting_buffer = layer_buffer; - private_layer->waiting_buffer->buffer = tdm_buffer_ref_backend(surface); - - if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) waiting_buffer(%p)", - private_layer, private_layer->waiting_buffer->buffer); - - if (private_output->commit_type == TDM_COMMIT_TYPE_OUTPUT) { - ret = tdm_output_commit_internal(private_layer->private_output, 0, NULL, NULL); - if (ret != TDM_ERROR_NONE) - TDM_ERR("tdm_output_commit_internal() is fail"); - } else if (private_output->commit_type == TDM_COMMIT_TYPE_LAYER) { - ret = _tdm_layer_commit(private_layer, NULL, NULL); - if (ret != TDM_ERROR_NONE) - TDM_ERR("layer(%p) _tdm_layer_commit() is fail", private_layer); - } else { - TDM_NEVER_GET_HERE(); - } - } else - _tdm_layer_free_buffer(private_layer, layer_buffer); + ret = tdm_layer_commit_internal(private_layer, NULL, NULL); + if (ret != TDM_ERROR_NONE) { + TDM_ERR("tdm_layer_commit_internal failed"); + _pthread_mutex_unlock(&private_display->lock); + return; + } _pthread_mutex_unlock(&private_display->lock); } @@ -1171,6 +1215,7 @@ _tbm_layer_queue_destroy_cb(tbm_surface_queue_h surface_queue, void *data) EXTERN tdm_error tdm_layer_set_buffer_queue(tdm_layer *layer, tbm_surface_queue_h buffer_queue) { + tdm_private_module *private_module; tdm_func_layer *func_layer; LAYER_FUNC_ENTRY(); @@ -1178,10 +1223,11 @@ tdm_layer_set_buffer_queue(tdm_layer *layer, tbm_surface_queue_h buffer_queue) _pthread_mutex_lock(&private_display->lock); - func_layer = &private_display->func_layer; + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; if (private_layer->usable) - TDM_INFO("layer(%p) not usable", private_layer); + TDM_INFO("layer(%p,%d) not usable", private_layer, private_layer->index); private_layer->usable = 0; @@ -1199,12 +1245,12 @@ tdm_layer_set_buffer_queue(tdm_layer *layer, tbm_surface_queue_h buffer_queue) } if (private_layer->waiting_buffer) { - _tdm_layer_free_buffer(private_layer, private_layer->waiting_buffer); + tdm_layer_free_buffer(private_layer, private_layer->waiting_buffer); private_layer->waiting_buffer = NULL; if (tdm_debug_module & TDM_DEBUG_BUFFER) - TDM_INFO("layer(%p) waiting_buffer(%p)", - private_layer, private_layer->waiting_buffer); + TDM_INFO("layer(%p,%d) waiting_buffer(%p)", + private_layer, private_layer->index, private_layer->waiting_buffer); } private_layer->buffer_queue = buffer_queue; @@ -1219,6 +1265,20 @@ tdm_layer_set_buffer_queue(tdm_layer *layer, tbm_surface_queue_h buffer_queue) return ret; } +tdm_error +tdm_layer_get_own_buffer_queue(tdm_layer *layer, tbm_surface_queue_h *buffer_queue) +{ + LAYER_FUNC_ENTRY(); + + TDM_RETURN_VAL_IF_FAIL(buffer_queue != NULL, TDM_ERROR_INVALID_PARAMETER); + + _pthread_mutex_lock(&private_display->lock); + + _pthread_mutex_unlock(&private_display->lock); + + return ret; +} + EXTERN tdm_error tdm_layer_unset_buffer_queue(tdm_layer *layer) { @@ -1244,23 +1304,25 @@ tdm_layer_is_usable(tdm_layer *layer, unsigned int *usable) EXTERN tdm_error tdm_layer_set_video_pos(tdm_layer *layer, int zpos) { + tdm_private_module *private_module; tdm_func_layer *func_layer; LAYER_FUNC_ENTRY(); _pthread_mutex_lock(&private_display->lock); - func_layer = &private_display->func_layer; + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; if (!(private_layer->caps.capabilities & TDM_LAYER_CAPABILITY_VIDEO)) { - TDM_ERR("layer(%p) is not video layer", private_layer); + TDM_ERR("layer(%p,%d) is not video layer", private_layer, private_layer->index); _pthread_mutex_unlock(&private_display->lock); - return TDM_ERROR_INVALID_PARAMETER; + return TDM_ERROR_BAD_REQUEST; } if (!func_layer->layer_set_video_pos) { /* LCOV_EXCL_START */ _pthread_mutex_unlock(&private_display->lock); - TDM_ERR("not implemented!!"); + TDM_ERR("layer(%p,%d) not implemented!!", private_layer, private_layer->index); return TDM_ERROR_NOT_IMPLEMENTED; /* LCOV_EXCL_STOP */ } @@ -1291,19 +1353,22 @@ tdm_layer_create_capture(tdm_layer *layer, tdm_error *error) EXTERN tdm_error tdm_layer_get_buffer_flags(tdm_layer *layer, unsigned int *flags) { + tdm_private_module *private_module; tdm_func_layer *func_layer; LAYER_FUNC_ENTRY(); TDM_RETURN_VAL_IF_FAIL(flags != NULL, TDM_ERROR_INVALID_PARAMETER); _pthread_mutex_lock(&private_display->lock); - func_layer = &private_display->func_layer; + private_module = private_layer->private_module; + func_layer = &private_module->func_layer; if (!func_layer->layer_get_buffer_flags) { /* LCOV_EXCL_START */ + *flags = 0; _pthread_mutex_unlock(&private_display->lock); - TDM_ERR("not implemented!!"); - return TDM_ERROR_NOT_IMPLEMENTED; + TDM_INFO("not implemented!!"); + return TDM_ERROR_NONE; /* LCOV_EXCL_STOP */ }