X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=src%2Fpkgmgrinfo_db.c;h=0ead442398a572b154eaf6d785352cc5f65d105d;hb=296b836f2187cedf267ad21b78aea105d6ba6e7e;hp=50eac6109107ac420035b036515612e8aac702ce;hpb=7e5cb9bc5a34f4feb32e858a80e72c10c173c3ce;p=platform%2Fcore%2Fappfw%2Fpkgmgr-info.git diff --git a/src/pkgmgrinfo_db.c b/src/pkgmgrinfo_db.c index 50eac61..0ead442 100644 --- a/src/pkgmgrinfo_db.c +++ b/src/pkgmgrinfo_db.c @@ -5,6 +5,7 @@ #include #include #include +#include #include #include #include @@ -18,62 +19,7 @@ #include "pkgmgrinfo_debug.h" #include "pkgmgrinfo_private.h" #include "pkgmgr_parser.h" -#include "pkgmgr_parser_internal.h" - -#define QUERY_CREATE_TABLE_PACKAGE_CERT_INDEX_INFO \ - "CREATE TABLE IF NOT EXISTS package_cert_index_info( " \ - " cert_info TEXT UNIQUE, " \ - " cert_id INTEGER PRIMARY KEY, " \ - " cert_ref_count INTEGER NOT NULL)" - -#define QUERY_CREATE_TABLE_PACKAGE_CERT_INFO \ - "CREATE TABLE IF NOT EXISTS package_cert_info( " \ - " package TEXT PRIMARY KEY, " \ - " author_root_cert INTEGER, " \ - " author_im_cert INTEGER, " \ - " author_signer_cert INTEGER, " \ - " dist_root_cert INTEGER, " \ - " dist_im_cert INTEGER, " \ - " dist_signer_cert INTEGER, " \ - " dist2_root_cert INTEGER, " \ - " dist2_im_cert INTEGER, " \ - " dist2_signer_cert INTEGER)" - -#define QUERY_CREATE_TRIGGER_DELETE_CERT_INFO \ - "CREATE TRIGGER IF NOT EXISTS delete_cert_info " \ - "AFTER DELETE ON package_cert_info " \ - "BEGIN" \ - " UPDATE package_cert_index_info SET" \ - " cert_ref_count = cert_ref_count - 1" \ - " WHERE cert_id = OLD.author_root_cert" \ - " OR cert_id = OLD.author_im_cert" \ - " OR cert_id = OLD.author_signer_cert" \ - " OR cert_id = OLD.dist_root_cert" \ - " OR cert_id = OLD.dist_im_cert" \ - " OR cert_id = OLD.dist_signer_cert" \ - " OR cert_id = OLD.dist2_root_cert" \ - " OR cert_id = OLD.dist2_im_cert" \ - " OR cert_id = OLD.dist2_signer_cert;" \ - "END;" - -#define QUERY_CREATE_TRIGGER_UPDATE_CERT_INDEX_INFO \ - "CREATE TRIGGER IF NOT EXISTS update_cert_index_info " \ - "AFTER UPDATE ON package_cert_index_info " \ - "WHEN ((SELECT cert_ref_count FROM package_cert_index_info " \ - " WHERE cert_id = OLD.cert_id) = 0) "\ - "BEGIN" \ - " DELETE FROM package_cert_index_info WHERE cert_id = OLD.cert_id;" \ - "END;" - -#define QUERY_CREATE_TRIGGER_UPDATE_CERT_INFO_FORMAT \ - "CREATE TRIGGER IF NOT EXISTS update_%s_info " \ - "AFTER UPDATE ON package_cert_info " \ - "WHEN (OLD.%s IS NOT NULL) " \ - "BEGIN" \ - " UPDATE package_cert_index_info SET" \ - " cert_ref_count = cert_ref_count - 1" \ - " WHERE cert_id = OLD.%s;" \ - "END;" +#include "pkgmgr_parser_db.h" __thread db_handle manifest_db; __thread db_handle cert_db; @@ -86,6 +32,8 @@ static int _mkdir_for_user(const char* dir, uid_t uid, gid_t gid) char *fullpath; char *subpath; char buf[1024]; + int fd; + struct stat sb; fullpath = strdup(dir); if (fullpath == NULL) @@ -109,10 +57,32 @@ static int _mkdir_for_user(const char* dir, uid_t uid, gid_t gid) } if (getuid() == ROOT_UID) { - ret = chown(dir, uid, gid); - if (ret == -1) - _LOGE("FAIL : chown %s %d.%d, because %s", dir, uid, + fd = open(dir, O_RDONLY); + if (fd == -1) { + _LOGE("FAIL : open %s : %s", dir, + strerror_r(errno, buf, sizeof(buf))); + return -1; + } + ret = fstat(fd, &sb); + if (ret == -1) { + _LOGE("FAIL : fstat %s : %s", dir, + strerror_r(errno, buf, sizeof(buf))); + close(fd); + return -1; + } + if (S_ISLNK(sb.st_mode)) { + _LOGE("FAIL : %s is symlink!", dir); + close(fd); + return -1; + } + ret = fchown(fd, uid, gid); + if (ret == -1) { + _LOGE("FAIL : fchown %s %d.%d, because %s", dir, uid, gid, strerror_r(errno, buf, sizeof(buf))); + close(fd); + return -1; + } + close(fd); } free(fullpath); @@ -120,22 +90,29 @@ static int _mkdir_for_user(const char* dir, uid_t uid, gid_t gid) return 0; } -static const char *_get_db_path(uid_t uid) { - const char *db_path = NULL; - if (uid != GLOBAL_USER && uid != ROOT_UID) { - tzplatform_set_user(uid); - db_path = tzplatform_getenv(TZ_USER_DB); - tzplatform_reset_user(); - } else { - db_path = tzplatform_getenv(TZ_SYS_DB); +static char *_get_db_path(uid_t uid) +{ + const char *db_path; + char path[PATH_MAX]; + + db_path = tzplatform_getenv(TZ_SYS_DB); + if (db_path == NULL) { + _LOGE("Failed to get TZ_SYS_DB path"); + return NULL; } - return db_path; + + if (uid == GLOBAL_USER || uid == ROOT_UID) + return strdup(db_path); + + snprintf(path, sizeof(path), "%s/user/%d", db_path, uid); + + return strdup(path); } static int __attach_and_create_view(sqlite3 *handle, const char *db, const char *tables[], uid_t uid) { int i; - char *err; + char *err = NULL; char query[MAX_QUERY_LEN]; if (uid != GLOBAL_USER && uid != ROOT_UID) { @@ -166,51 +143,11 @@ static int __attach_and_create_view(sqlite3 *handle, const char *db, const char return SQLITE_OK; } -static int __exec_db_query(sqlite3 *db, char *query, sqlite_query_callback callback, void *data) +int _check_create_cert_db(void) { - char *error_message = NULL; - int ret = sqlite3_exec(db, query, callback, data, &error_message); - if (SQLITE_OK != ret) { - _LOGE("Don't execute query = %s error message = %s ret = %d\n", query, - error_message, ret); - sqlite3_free(error_message); - return -1; - } - sqlite3_free(error_message); - return 0; + return pkgmgr_parser_initialize_cert_db(); } -int _check_create_cert_db(sqlite3 *certdb) -{ - int i; - char buf[BUFSIZE]; - static const char *columns[] = { - "author_root_cert", "author_im_cert", "author_signer_cert", - "dist_root_cert", "dist_im_cert", "dist_signer_cert", - "dist2_root_cert", "dist2_im_cert", "dist2_signer_cert", - NULL}; - int ret = 0; - ret = __exec_db_query(certdb, QUERY_CREATE_TABLE_PACKAGE_CERT_INDEX_INFO, NULL, NULL); - if (ret < 0) - return ret; - ret = __exec_db_query(certdb, QUERY_CREATE_TABLE_PACKAGE_CERT_INFO, NULL, NULL); - if (ret < 0) - return ret; - ret = __exec_db_query(certdb, QUERY_CREATE_TRIGGER_DELETE_CERT_INFO, NULL, NULL); - if (ret < 0) - return ret; - ret = __exec_db_query(certdb, QUERY_CREATE_TRIGGER_UPDATE_CERT_INDEX_INFO, NULL, NULL); - - for (i = 0; columns[i] != NULL; i++) { - snprintf(buf, sizeof(buf), - QUERY_CREATE_TRIGGER_UPDATE_CERT_INFO_FORMAT, - columns[i], columns[i], columns[i]); - ret = __exec_db_query(certdb, buf, NULL, NULL); - if (ret < 0) - return ret; - } - return ret; -} static gid_t _get_gid(const char *name) { char buf[BUFSIZE]; @@ -234,80 +171,89 @@ API const char *getIconPath(uid_t uid, bool readonly) gid_t gid = ROOT_UID; if (uid != GLOBAL_USER && uid != ROOT_UID) { - tzplatform_set_user(uid); - path = tzplatform_mkpath(TZ_USER_ICONS, "/"); - gid = _get_gid(tzplatform_getenv(TZ_SYS_USER_GROUP)); - tzplatform_reset_user(); - } else { - if (readonly) - path = tzplatform_mkpath(TZ_SYS_RO_ICONS, "/"); - else - path = tzplatform_mkpath(TZ_SYS_RW_ICONS, "/"); + _LOGD("not supported target user"); + return NULL; } - // just allow certain users to create the icon directory if needed. - if (uid_caller == ROOT_UID || uid_caller == uid) + if (readonly) + path = tzplatform_mkpath(TZ_SYS_RO_ICONS, "/"); + + /* just allow certain users to create the icon directory if needed. */ + if (path && (uid_caller == ROOT_UID || + uid_caller == APPFW_UID || uid_caller == uid)) _mkdir_for_user(path, uid, gid); return path; } -API const char *getUserPkgParserDBPath(void) +API char *getUserPkgParserDBPath(void) { return getUserPkgParserDBPathUID(_getuid()); } -API const char *getUserPkgParserDBPathUID(uid_t uid) +API char *getUserPkgParserDBPathUID(uid_t uid) { - const char *pkgmgr_parser_db = NULL; + char pkgmgr_parser_db[PATH_MAX]; uid_t uid_caller = getuid(); gid_t gid = ROOT_UID; - - if (uid != GLOBAL_USER && uid != ROOT_UID) { - tzplatform_set_user(uid); - pkgmgr_parser_db = tzplatform_mkpath(TZ_USER_DB, ".pkgmgr_parser.db"); - gid = _get_gid(tzplatform_getenv(TZ_SYS_USER_GROUP)); - tzplatform_reset_user(); - } else { - pkgmgr_parser_db = tzplatform_mkpath(TZ_SYS_DB, ".pkgmgr_parser.db"); - } - - // just allow certain users to create the dbspace directory if needed. - if (uid_caller == ROOT_UID || uid_caller == uid) { - const char *db_path = _get_db_path(uid); - _mkdir_for_user(db_path, uid, gid); + char *db_path; + + db_path = _get_db_path(uid); + if (db_path == NULL) { + _LOGE("Failed to get db path %d", uid); + return NULL; + } + snprintf(pkgmgr_parser_db, sizeof(pkgmgr_parser_db), + "%s/.pkgmgr_parser.db", db_path); + if (access(db_path, F_OK) != 0) { + if (uid != GLOBAL_USER && uid != ROOT_UID) { + tzplatform_set_user(uid); + gid = _get_gid(tzplatform_getenv(TZ_SYS_USER_GROUP)); + tzplatform_reset_user(); + } + /* just allow certain users to create the dbspace directory if needed. */ + if (uid_caller == ROOT_UID || uid_caller == APPFW_UID || + uid_caller == uid) + _mkdir_for_user(db_path, uid, gid); } + free(db_path); - return pkgmgr_parser_db; + return strdup(pkgmgr_parser_db); } -API const char *getUserPkgCertDBPath(void) +API char *getUserPkgCertDBPath(void) { return getUserPkgCertDBPathUID(_getuid()); } -API const char *getUserPkgCertDBPathUID(uid_t uid) +API char *getUserPkgCertDBPathUID(uid_t uid) { - const char *pkgmgr_cert_db = NULL; + char pkgmgr_cert_db[PATH_MAX]; uid_t uid_caller = getuid(); gid_t gid = ROOT_UID; + char *db_path; + + db_path = _get_db_path(uid); + if (db_path == NULL) { + _LOGE("Failed to get db path %d", uid); + return NULL; + } + snprintf(pkgmgr_cert_db, sizeof(pkgmgr_cert_db), + "%s/.pkgmgr_cert.db", db_path); if (uid != GLOBAL_USER && uid != ROOT_UID) { tzplatform_set_user(uid); - pkgmgr_cert_db = tzplatform_mkpath(TZ_USER_DB, ".pkgmgr_cert.db"); gid = _get_gid(tzplatform_getenv(TZ_SYS_USER_GROUP)); tzplatform_reset_user(); - } else { - pkgmgr_cert_db = tzplatform_mkpath(TZ_SYS_DB, ".pkgmgr_cert.db"); } - // just allow certain users to create the dbspace directory if needed. - if (uid_caller == ROOT_UID || uid_caller == uid) { - const char *db_path = _get_db_path(uid); + /* just allow certain users to create the dbspace directory if needed. */ + if (uid_caller == ROOT_UID || uid_caller == APPFW_UID || uid_caller == uid) _mkdir_for_user(db_path, uid, gid); - } - return pkgmgr_cert_db; + free(db_path); + + return strdup(pkgmgr_cert_db); } API const char *getUserManifestPath(uid_t uid, bool readonly) @@ -328,8 +274,8 @@ API const char *getUserManifestPath(uid_t uid, bool readonly) path = tzplatform_mkpath(TZ_SYS_RW_PACKAGES, "/"); } - // just allow certain users to create the icon directory if needed. - if (uid_caller == ROOT_UID || uid_caller == uid) + /* just allow certain users to create the icon directory if needed. */ + if (uid_caller == ROOT_UID || uid_caller == APPFW_UID || uid_caller == uid) _mkdir_for_user(path, uid, gid); return path; @@ -366,32 +312,48 @@ static const char *parserdb_tables[] = { int __open_manifest_db(uid_t uid, bool readonly) { int ret; - const char *user_pkg_parser; + char *user_pkg_parser; int flags; if (manifest_db.ref) { - manifest_db.ref ++; + manifest_db.ref++; return 0; } user_pkg_parser = getUserPkgParserDBPathUID(uid); + if (user_pkg_parser == NULL) { + _LOGE("Failed to get pkg parser db path - %d", uid); + return -1; + } + if (access(user_pkg_parser, F_OK) != 0) { _LOGE("Manifest DB does not exists !!"); + free(user_pkg_parser); return -1; } flags = readonly ? SQLITE_OPEN_READONLY : SQLITE_OPEN_READWRITE; ret = db_util_open_with_options(user_pkg_parser, &GET_DB(manifest_db), flags, NULL); - retvm_if(ret != SQLITE_OK, -1, "connect db [%s] failed!\n", - user_pkg_parser); + if (ret != SQLITE_OK) { + _LOGE("connect db [%s] failed!\n", user_pkg_parser); + free(user_pkg_parser); + return -1; + } + manifest_db.ref++; if (readonly) { ret = __attach_and_create_view(GET_DB(manifest_db), MANIFEST_DB, parserdb_tables, uid); - retvm_if(ret != SQLITE_OK, -1, "attach db [%s] failed!\n", - user_pkg_parser); + if (ret != SQLITE_OK) { + _LOGE("attach db [%s] failed!\n", user_pkg_parser); + free(user_pkg_parser); + return -1; + } } + + free(user_pkg_parser); + return 0; } @@ -400,7 +362,7 @@ int __close_cert_db(void) if (cert_db.ref) { if (--cert_db.ref == 0) sqlite3_close_v2(GET_DB(cert_db)); - return 0; + return 0; } _LOGE("Certificate DB is already closed !!\n"); return -1; @@ -415,32 +377,47 @@ static const char *certdb_tables[] = { int __open_cert_db(uid_t uid, bool readonly) { int ret; - const char *user_cert_parser; + char *user_cert_parser; int flags; if (cert_db.ref) { - cert_db.ref ++; + cert_db.ref++; return 0; } user_cert_parser = getUserPkgCertDBPathUID(uid); + if (user_cert_parser == NULL) { + _LOGE("Failed to get pkg cert db path - %d", uid); + return -1; + } + if (access(user_cert_parser, F_OK) != 0) { _LOGE("Cert DB does not exists !!"); + free(user_cert_parser); return -1; } flags = readonly ? SQLITE_OPEN_READONLY : SQLITE_OPEN_READWRITE; ret = db_util_open_with_options(user_cert_parser, &GET_DB(cert_db), flags, NULL); - retvm_if(ret != SQLITE_OK, -1, "connect db [%s] failed!", - user_cert_parser); + if (ret != SQLITE_OK) { + _LOGE("connect db [%s] failed!", user_cert_parser); + free(user_cert_parser); + return -1; + } cert_db.ref++; if (readonly) { ret = __attach_and_create_view(GET_DB(cert_db), CERT_DB, certdb_tables, uid); - retvm_if(ret != SQLITE_OK, -1, "attach db [%s] failed!", - user_cert_parser); + if (ret != SQLITE_OK) { + _LOGE("attach db [%s] failed!", user_cert_parser); + free(user_cert_parser); + return -1; + } } + + free(user_cert_parser); + return 0; } @@ -449,7 +426,7 @@ void _save_column_int(sqlite3_stmt *stmt, int idx, int *i) *i = sqlite3_column_int(stmt, idx); } -void _save_column_str(sqlite3_stmt *stmt, int idx, char **str) +inline void _save_column_str(sqlite3_stmt *stmt, int idx, char **str) { const char *val; @@ -458,188 +435,48 @@ void _save_column_str(sqlite3_stmt *stmt, int idx, char **str) *str = strdup(val); } -API int pkgmgrinfo_pkginfo_set_state_enabled(const char *pkgid, bool enabled) +API int pkgmgrinfo_pkginfo_set_usr_installed_storage(const char *pkgid, INSTALL_LOCATION location, const char *external_pkg_path, uid_t uid) { - /* Should be implemented later */ - return 0; -} - -API int pkgmgrinfo_appinfo_set_usr_state_enabled(const char *appid, bool enabled, uid_t uid) -{ - int ret; - char query[MAX_QUERY_LEN] = {'\0'}; - char *error_message; - - retvm_if(appid == NULL, PMINFO_R_EINVAL, "appid is NULL\n"); - - /* Open db.*/ - ret = __open_manifest_db(uid, false); - if (ret != SQLITE_OK) { - _LOGE("connect db [%s] failed!\n", getUserPkgParserDBPathUID(uid)); - return PMINFO_R_ERROR; - } - - /*Begin transaction*/ - ret = sqlite3_exec(GET_DB(manifest_db), "BEGIN EXCLUSIVE", NULL, NULL, NULL); - if (ret != SQLITE_OK) { - _LOGE("Failed to begin transaction\n"); - __close_manifest_db(); - return PMINFO_R_ERROR; - } - _LOGD("Transaction Begin\n"); - - memset(query, '\0', MAX_QUERY_LEN); - snprintf(query, MAX_QUERY_LEN, - "update package_app_info set app_enabled='%s' where app_id='%s'", enabled?"true":"false", appid); - - if (SQLITE_OK != - sqlite3_exec(GET_DB(manifest_db), query, NULL, NULL, &error_message)) { - _LOGE("Don't execute query = %s error message = %s\n", query, - error_message); - sqlite3_free(error_message); - return PMINFO_R_ERROR; - } - sqlite3_free(error_message); - - /*Commit transaction*/ - ret = sqlite3_exec(GET_DB(manifest_db), "COMMIT", NULL, NULL, NULL); - if (ret != SQLITE_OK) { - _LOGE("Failed to commit transaction. Rollback now\n"); - sqlite3_exec(GET_DB(manifest_db), "ROLLBACK", NULL, NULL, NULL); - __close_manifest_db(); - return PMINFO_R_ERROR; - } - _LOGD("Transaction Commit and End\n"); - __close_manifest_db(); - return PMINFO_R_OK; -} - -API int pkgmgrinfo_appinfo_set_state_enabled(const char *appid, bool enabled) -{ - return pkgmgrinfo_appinfo_set_usr_state_enabled(appid, enabled, _getuid()); -} - -API int pkgmgrinfo_appinfo_set_usr_default_label(const char *appid, const char *label, uid_t uid) -{ - int ret; - char query[MAX_QUERY_LEN] = {'\0'}; - char *error_message; - - retvm_if(appid == NULL, PMINFO_R_EINVAL, "appid is NULL\n"); - - ret = __open_manifest_db(uid, false); - if (ret == -1) { - _LOGE("Fail to open manifest DB\n"); - return PMINFO_R_ERROR; - } - - /*Begin transaction*/ - ret = sqlite3_exec(GET_DB(manifest_db), "BEGIN EXCLUSIVE", NULL, NULL, NULL); - if (ret != SQLITE_OK) { - _LOGE("Failed to begin transaction\n"); - __close_manifest_db(); - return PMINFO_R_ERROR; - } - _LOGD("Transaction Begin\n"); - - memset(query, '\0', MAX_QUERY_LEN); - snprintf(query, MAX_QUERY_LEN, - "update package_app_localized_info set app_label='%s' where app_id='%s' and app_locale='No Locale'", label, appid); + retvm_if(pkgid == NULL, PMINFO_R_EINVAL, "pkgid is NULL\n"); + int ret = -1; + sqlite3 *pkgmgr_parser_db = NULL; + char *query = NULL; + char *db_path; - if (SQLITE_OK != - sqlite3_exec(GET_DB(manifest_db), query, NULL, NULL, &error_message)) { - _LOGE("Don't execute query = %s error message = %s\n", query, - error_message); - sqlite3_free(error_message); + db_path = getUserPkgParserDBPathUID(uid); + if (db_path == NULL) { + _LOGE("Failed to get pkg parser db path - %d", uid); return PMINFO_R_ERROR; } - /*Commit transaction*/ - ret = sqlite3_exec(GET_DB(manifest_db), "COMMIT", NULL, NULL, NULL); + ret = db_util_open_with_options(db_path, &pkgmgr_parser_db, + SQLITE_OPEN_READWRITE, NULL); if (ret != SQLITE_OK) { - _LOGE("Failed to commit transaction. Rollback now\n"); - sqlite3_exec(GET_DB(manifest_db), "ROLLBACK", NULL, NULL, NULL); - __close_manifest_db(); + _LOGE("connect db failed!"); + free(db_path); return PMINFO_R_ERROR; } - _LOGD("Transaction Commit and End\n"); - __close_manifest_db(); - return PMINFO_R_OK; -} - -API int pkgmgrinfo_appinfo_set_default_label(const char *appid, const char *label) -{ - return pkgmgrinfo_appinfo_set_usr_default_label(appid, label, _getuid()); -} - -API int pkgmgrinfo_appinfo_set_usr_guestmode_visibility(pkgmgrinfo_appinfo_h handle, uid_t uid, bool status) -{ - const char *val; - int ret; - char query[MAX_QUERY_LEN] = {'\0'}; - char *errmsg; - sqlite3 *pkgmgr_parser_db; - - retvm_if(handle == NULL, PMINFO_R_EINVAL, "appinfo handle is NULL\n"); - - pkgmgr_appinfo_x *info = (pkgmgr_appinfo_x *)handle; - val = info->app_info->guestmode_visibility; - if (val) { - ret = db_util_open_with_options(getUserPkgParserDBPathUID(uid), &pkgmgr_parser_db, - SQLITE_OPEN_READWRITE, NULL); - if (ret != SQLITE_OK) { - _LOGE("DB Open Failed\n"); - return PMINFO_R_ERROR; - } - - /*TODO: Write to DB here*/ - if (status == true) - snprintf(query, MAX_QUERY_LEN, "update package_app_info set app_guestmodevisibility = 'true' where app_id = '%s'", (char *)info->app_info->appid); - else - snprintf(query, MAX_QUERY_LEN, "update package_app_info set app_guestmodevisibility = 'false' where app_id = '%s'", (char *)info->app_info->appid); - - ret = sqlite3_exec(pkgmgr_parser_db, query, NULL, NULL, &errmsg); - sqlite3_close(pkgmgr_parser_db); - if (ret != SQLITE_OK) { - _LOGE("DB update [%s] failed, error message = %s\n", query, errmsg); - free(errmsg); - return PMINFO_R_ERROR; - } - } - return PMINFO_R_OK; -} - -API int pkgmgrinfo_appinfo_set_guestmode_visibility(pkgmgrinfo_appinfo_h handle, bool status) -{ - return pkgmgrinfo_appinfo_set_usr_guestmode_visibility(handle, _getuid(), status); -} - -API int pkgmgrinfo_pkginfo_set_usr_installed_storage(const char *pkgid, INSTALL_LOCATION location, uid_t uid) -{ - retvm_if(pkgid == NULL, PMINFO_R_EINVAL, "pkgid is NULL\n"); - int ret = -1; - sqlite3 *pkgmgr_parser_db = NULL; - char *query = NULL; - - ret = db_util_open_with_options(getUserPkgParserDBPathUID(uid), &pkgmgr_parser_db, - SQLITE_OPEN_READWRITE, NULL); - retvm_if(ret != SQLITE_OK, PMINFO_R_ERROR, "connect db failed!"); + free(db_path); /*Begin transaction*/ - // Setting Manifest DB + /* Setting Manifest DB */ ret = sqlite3_exec(pkgmgr_parser_db, "BEGIN EXCLUSIVE", NULL, NULL, NULL); tryvm_if(ret != SQLITE_OK, ret = PMINFO_R_ERROR, "Failed to begin transaction\n"); _LOGD("Transaction Begin\n"); - // pkgcakge_info table - query = sqlite3_mprintf("update package_info set installed_storage=%Q where package=%Q", location?"installed_external":"installed_internal", pkgid); + /* pkgcakge_info table */ + query = sqlite3_mprintf( + "update package_info set installed_storage=%Q, external_path=%Q where package=%Q", + location ? "installed_external" : "installed_internal", external_pkg_path, pkgid); ret = sqlite3_exec(pkgmgr_parser_db, query, NULL, NULL, NULL); tryvm_if(ret != SQLITE_OK, ret = PMINFO_R_ERROR, "Don't execute query = %s\n", query); sqlite3_free(query); - // package_app_info table - query = sqlite3_mprintf("update package_app_info set app_installed_storage=%Q where package=%Q", location?"installed_external":"installed_internal", pkgid); + /* package_app_info table */ + query = sqlite3_mprintf( + "update package_app_info set app_installed_storage=%Q, app_external_path=%Q where package=%Q", + location ? "installed_external" : "installed_internal", external_pkg_path, pkgid); ret = sqlite3_exec(pkgmgr_parser_db, query, NULL, NULL, NULL); tryvm_if(ret != SQLITE_OK, ret = PMINFO_R_ERROR, "Don't execute query = %s\n", query); @@ -660,7 +497,7 @@ catch: return ret; } -API int pkgmgrinfo_pkginfo_set_installed_storage(const char *pkgid, INSTALL_LOCATION location) +API int pkgmgrinfo_pkginfo_set_installed_storage(const char *pkgid, INSTALL_LOCATION location, const char *external_pkg_path) { - return pkgmgrinfo_pkginfo_set_usr_installed_storage(pkgid, location, _getuid()); + return pkgmgrinfo_pkginfo_set_usr_installed_storage(pkgid, location, external_pkg_path, _getuid()); }