X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=src%2Fpkgmgrinfo_certinfo.c;h=7535c936a78fcfdbdcd84bb357c920fcd3bf0ce4;hb=26a48d898a57696e731bb8c3346ca7c6fc06d976;hp=c82d287c818c4d0e3b83657556bfc1e3261b60db;hpb=7c7d7d4c5640cf1154b79bb1590394dbd0acd224;p=platform%2Fcore%2Fappfw%2Fpkgmgr-info.git diff --git a/src/pkgmgrinfo_certinfo.c b/src/pkgmgrinfo_certinfo.c index c82d287..7535c93 100644 --- a/src/pkgmgrinfo_certinfo.c +++ b/src/pkgmgrinfo_certinfo.c @@ -57,22 +57,23 @@ static int _pkginfo_compare_certinfo(sqlite3 *db, const char *l_pkgid, pkgmgrinfo_cert_compare_result_type_e *result) { static const char query[] = - "SELECT author_signer_cert FROM package_cert_info " + "SELECT COALESCE(author_signer_cert, -1) FROM package_cert_info " "WHERE package=?"; int ret; sqlite3_stmt *stmt; const char *pkgid[2]; - int certid[2] = {-1, }; + int certid[2] = {-1, -1}; int i; + pkgid[0] = l_pkgid; + pkgid[1] = r_pkgid; + ret = sqlite3_prepare_v2(db, query, strlen(query), &stmt, NULL); if (ret != SQLITE_OK) { _LOGE("prepare error: %s", sqlite3_errmsg(db)); return PMINFO_R_ERROR; } - pkgid[0] = l_pkgid; - pkgid[1] = r_pkgid; for (i = 0; i < 2; i++) { ret = sqlite3_bind_text(stmt, 1, pkgid[i], -1, SQLITE_STATIC); if (ret != SQLITE_OK) { @@ -106,7 +107,6 @@ static int _pkginfo_compare_certinfo(sqlite3 *db, const char *l_pkgid, *result = PMINFO_CERT_COMPARE_MISMATCH; sqlite3_finalize(stmt); - return PMINFO_R_OK; } @@ -116,7 +116,7 @@ API int pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(const char *lhs_package_id, { int ret; sqlite3 *db; - const char *dbpath; + char *dbpath; if (lhs_package_id == NULL || rhs_package_id == NULL || compare_result == NULL) { @@ -129,11 +129,13 @@ API int pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(const char *lhs_package_id, if (dbpath == NULL) return PMINFO_R_ERROR; - ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READONLY, NULL); + ret = __open_db(dbpath, &db, SQLITE_OPEN_READONLY); if (ret != SQLITE_OK) { _LOGE("failed to open db: %d", ret); + free(dbpath); return PMINFO_R_ERROR; } + free(dbpath); if (_pkginfo_compare_certinfo(db, lhs_package_id, rhs_package_id, compare_result)) { @@ -149,7 +151,7 @@ API int pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(const char *lhs_package_id, API int pkgmgrinfo_pkginfo_compare_pkg_cert_info(const char *lhs_package_id, const char *rhs_package_id, pkgmgrinfo_cert_compare_result_type_e *compare_result) { - return pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(lhs_package_id, rhs_package_id, GLOBAL_USER, compare_result); + return pkgmgrinfo_pkginfo_compare_usr_pkg_cert_info(lhs_package_id, rhs_package_id, _getuid(), compare_result); } static int _pkginfo_get_pkgid_from_appid(uid_t uid, const char *appid, @@ -159,18 +161,20 @@ static int _pkginfo_get_pkgid_from_appid(uid_t uid, const char *appid, "SELECT package FROM package_app_info WHERE app_id=?"; int ret; sqlite3 *db; - const char *dbpath; + char *dbpath; sqlite3_stmt *stmt; dbpath = getUserPkgParserDBPathUID(uid); if (dbpath == NULL) return PMINFO_R_ERROR; - ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READONLY, NULL); + ret = __open_db(dbpath, &db, SQLITE_OPEN_READONLY); if (ret != SQLITE_OK) { _LOGE("failed to open db: %d", ret); + free(dbpath); return PMINFO_R_ERROR; } + free(dbpath); ret = sqlite3_prepare_v2(db, query, strlen(query), &stmt, NULL); if (ret != SQLITE_OK) { @@ -189,10 +193,10 @@ static int _pkginfo_get_pkgid_from_appid(uid_t uid, const char *appid, ret = sqlite3_step(stmt); if (ret == SQLITE_ROW) { - _save_column_str(stmt, 0, (const char **)pkgid); + _save_column_str(stmt, 0, pkgid); ret = PMINFO_R_OK; } else if (ret == SQLITE_DONE) { - _LOGE("cannot find pkgid of app %s", appid); + _LOGI("cannot find pkgid of app %s for uid %d", appid, (int)uid); ret = PMINFO_R_ENOENT; } else { _LOGE("step error: %s", sqlite3_errmsg(db)); @@ -251,7 +255,7 @@ API int pkgmgrinfo_pkginfo_compare_app_cert_info(const char *lhs_app_id, pkgmgrinfo_cert_compare_result_type_e *compare_result) { return pkgmgrinfo_pkginfo_compare_usr_app_cert_info(lhs_app_id, - rhs_app_id, GLOBAL_USER, compare_result); + rhs_app_id, _getuid(), compare_result); } static int _pkginfo_get_cert(sqlite3 *db, int cert_id[], @@ -288,7 +292,7 @@ static int _pkginfo_get_cert(sqlite3 *db, int cert_id[], return PMINFO_R_ERROR; } - _save_column_str(stmt, 0, (const char **)&cert_info[i]); + _save_column_str(stmt, 0, &cert_info[i]); sqlite3_reset(stmt); sqlite3_clear_bindings(stmt); } @@ -356,18 +360,20 @@ static int _pkginfo_get_certinfo(const char *pkgid, pkgmgr_certinfo_x *info) { int ret; sqlite3 *db; - const char *dbpath; + char *dbpath; /* open unified global cert db */ dbpath = getUserPkgCertDBPathUID(GLOBAL_USER); if (dbpath == NULL) return PMINFO_R_ERROR; - ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READONLY, NULL); + ret = __open_db(dbpath, &db, SQLITE_OPEN_READONLY); if (ret != SQLITE_OK) { _LOGE("failed to open db: %d", ret); + free(dbpath); return PMINFO_R_ERROR; } + free(dbpath); ret = _pkginfo_get_certid(db, pkgid, info->cert_id); if (ret != PMINFO_R_OK) { @@ -381,6 +387,8 @@ static int _pkginfo_get_certinfo(const char *pkgid, pkgmgr_certinfo_x *info) return ret; } + sqlite3_close_v2(db); + return PMINFO_R_OK; } @@ -463,63 +471,41 @@ API int pkgmgrinfo_set_cert_value(pkgmgrinfo_instcertinfo_h handle, pkgmgrinfo_i static int _pkginfo_save_cert_info(sqlite3 *db, const char *pkgid, char *cert_info[]) { - static const char query[] = - "INSERT OR REPLACE INTO package_cert_info (package," + static const char query_insert[] = + "INSERT INTO package_cert_info (package, package_count," " author_root_cert, author_im_cert, author_signer_cert," " dist_root_cert, dist_im_cert, dist_signer_cert," " dist2_root_cert, dist2_im_cert, dist2_signer_cert) " - "VALUES(?, " - " (COALESCE( " - " (SELECT cert_id FROM package_cert_index_info" - " WHERE cert_info=?)," - " (SELECT author_root_cert FROM package_cert_info" - " WHERE package=?)))," - " (COALESCE( " - " (SELECT cert_id FROM package_cert_index_info" - " WHERE cert_info=?)," - " (SELECT author_im_cert FROM package_cert_info" - " WHERE package=?)))," - " (COALESCE( " - " (SELECT cert_id FROM package_cert_index_info" - " WHERE cert_info=?)," - " (SELECT author_signer_cert FROM package_cert_info" - " WHERE package=?)))," - " (COALESCE( " - " (SELECT cert_id FROM package_cert_index_info" - " WHERE cert_info=?)," - " (SELECT dist_root_cert FROM package_cert_info" - " WHERE package=?)))," - " (COALESCE( " - " (SELECT cert_id FROM package_cert_index_info" - " WHERE cert_info=?)," - " (SELECT dist_im_cert FROM package_cert_info" - " WHERE package=?)))," - " (COALESCE( " - " (SELECT cert_id FROM package_cert_index_info" - " WHERE cert_info=?)," - " (SELECT dist_signer_cert FROM package_cert_info" - " WHERE package=?)))," - " (COALESCE( " - " (SELECT cert_id FROM package_cert_index_info" - " WHERE cert_info=?)," - " (SELECT dist2_root_cert FROM package_cert_info" - " WHERE package=?)))," - " (COALESCE( " - " (SELECT cert_id FROM package_cert_index_info" - " WHERE cert_info=?)," - " (SELECT dist2_im_cert FROM package_cert_info" - " WHERE package=?)))," - " (COALESCE( " - " (SELECT cert_id FROM package_cert_index_info" - " WHERE cert_info=?)," - " (SELECT dist2_signer_cert FROM package_cert_info" - " WHERE package=?))))"; + "VALUES(?, 1," + " (SELECT cert_id FROM package_cert_index_info" + " WHERE cert_info=?)," + " (SELECT cert_id FROM package_cert_index_info" + " WHERE cert_info=?)," + " (SELECT cert_id FROM package_cert_index_info" + " WHERE cert_info=?)," + " (SELECT cert_id FROM package_cert_index_info" + " WHERE cert_info=?)," + " (SELECT cert_id FROM package_cert_index_info" + " WHERE cert_info=?)," + " (SELECT cert_id FROM package_cert_index_info" + " WHERE cert_info=?)," + " (SELECT cert_id FROM package_cert_index_info" + " WHERE cert_info=?)," + " (SELECT cert_id FROM package_cert_index_info" + " WHERE cert_info=?)," + " (SELECT cert_id FROM package_cert_index_info" + " WHERE cert_info=?))"; + static const char query_update[] = + "UPDATE package_cert_info " + "SET package_count = package_count + 1 " + "WHERE package=?"; int ret; sqlite3_stmt *stmt; int i; int idx; - ret = sqlite3_prepare_v2(db, query, strlen(query), &stmt, NULL); + ret = sqlite3_prepare_v2(db, query_insert, strlen(query_insert), + &stmt, NULL); if (ret != SQLITE_OK) { _LOGE("prepare error: %s", sqlite3_errmsg(db)); return PMINFO_R_ERROR; @@ -528,23 +514,28 @@ static int _pkginfo_save_cert_info(sqlite3 *db, const char *pkgid, idx = 1; sqlite3_bind_text(stmt, idx++, pkgid, -1, SQLITE_STATIC); for (i = 0; i < MAX_CERT_TYPE; i++) { - ret = sqlite3_bind_text(stmt, idx++, cert_info[i], -1, - SQLITE_STATIC); - if (ret != SQLITE_OK) { + if (sqlite3_bind_text(stmt, idx++, cert_info[i], -1, + SQLITE_STATIC)) { _LOGE("bind error: %s", sqlite3_errmsg(db)); sqlite3_finalize(stmt); return PMINFO_R_ERROR; } - ret = sqlite3_bind_text(stmt, idx++, pkgid, -1, - SQLITE_STATIC); + } + + ret = sqlite3_step(stmt); + sqlite3_finalize(stmt); + if (ret == SQLITE_CONSTRAINT) { + ret = sqlite3_prepare_v2(db, query_update, strlen(query_update), + &stmt, NULL); if (ret != SQLITE_OK) { - _LOGE("bind error: %s", sqlite3_errmsg(db)); - sqlite3_finalize(stmt); + _LOGE("prepare error: %s", sqlite3_errmsg(db)); return PMINFO_R_ERROR; } + sqlite3_bind_text(stmt, 1, pkgid, -1, SQLITE_STATIC); + ret = sqlite3_step(stmt); + sqlite3_finalize(stmt); } - ret = sqlite3_step(stmt); - sqlite3_finalize(stmt); + if (ret != SQLITE_DONE) { _LOGE("step error: %s", sqlite3_errmsg(db)); return PMINFO_R_ERROR; @@ -604,7 +595,7 @@ API int pkgmgrinfo_save_certinfo(const char *pkgid, pkgmgrinfo_instcertinfo_h ha { int ret; sqlite3 *db; - const char *dbpath; + char *dbpath; pkgmgr_instcertinfo_x *info = (pkgmgr_instcertinfo_x *)handle; if (pkgid == NULL || handle == NULL) { @@ -617,11 +608,13 @@ API int pkgmgrinfo_save_certinfo(const char *pkgid, pkgmgrinfo_instcertinfo_h ha if (dbpath == NULL) return PMINFO_R_ERROR; - ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READWRITE, NULL); + ret = __open_db(dbpath, &db, SQLITE_OPEN_READWRITE); if (ret != SQLITE_OK) { _LOGE("failed to open db: %d", ret); + free(dbpath); return PMINFO_R_ERROR; } + free(dbpath); ret = sqlite3_exec(db, "BEGIN EXCLUSIVE", NULL, NULL, NULL); if (ret != SQLITE_OK) { @@ -638,6 +631,7 @@ API int pkgmgrinfo_save_certinfo(const char *pkgid, pkgmgrinfo_instcertinfo_h ha sqlite3_close_v2(db); return PMINFO_R_ERROR; } + if (_pkginfo_save_cert_info(db, pkgid, info->cert_info)) { _LOGE("failed to save cert info, rollback now"); sqlite3_exec(GET_DB(cert_db), "ROLLBACK", NULL, NULL, NULL); @@ -682,7 +676,9 @@ API int pkgmgrinfo_destroy_certinfo_set_handle(pkgmgrinfo_instcertinfo_h handle) static int _pkginfo_delete_certinfo(sqlite3 *db, const char *pkgid) { static const char query[] = - "DELETE FROM package_cert_info WHERE package=?"; + "UPDATE package_cert_info " + "SET package_count = package_count - 1 " + "WHERE package=?"; int ret; sqlite3_stmt *stmt; @@ -713,7 +709,7 @@ API int pkgmgrinfo_delete_usr_certinfo(const char *pkgid, uid_t uid) { int ret; sqlite3 *db; - const char *dbpath; + char *dbpath; if (pkgid == NULL) { _LOGE("invalid parameter"); @@ -725,11 +721,13 @@ API int pkgmgrinfo_delete_usr_certinfo(const char *pkgid, uid_t uid) if (dbpath == NULL) return PMINFO_R_ERROR; - ret = sqlite3_open_v2(dbpath, &db, SQLITE_OPEN_READWRITE, NULL); + ret = __open_db(dbpath, &db, SQLITE_OPEN_READWRITE); if (ret != SQLITE_OK) { _LOGE("failed to open db: %d", ret); + free(dbpath); return PMINFO_R_ERROR; } + free(dbpath); ret = sqlite3_exec(db, "BEGIN EXCLUSIVE", NULL, NULL, NULL); if (ret != SQLITE_OK) { @@ -760,6 +758,6 @@ API int pkgmgrinfo_delete_usr_certinfo(const char *pkgid, uid_t uid) API int pkgmgrinfo_delete_certinfo(const char *pkgid) { - return pkgmgrinfo_delete_usr_certinfo(pkgid, GLOBAL_USER); + return pkgmgrinfo_delete_usr_certinfo(pkgid, _getuid()); }