X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=src%2Fnet%2Fspdy%2Fspdy_protocol_test.cc;h=0e49207e11d45a1879ef164436a5a6b3c2063cdd;hb=4a1a0bdd01eef90b0826a0e761d3379d3715c10f;hp=e098281678c8f1805c5552a0cd30bfc9a9899e0e;hpb=b1be5ca53587d23e7aeb77b26861fdc0a181ffd8;p=platform%2Fframework%2Fweb%2Fcrosswalk.git diff --git a/src/net/spdy/spdy_protocol_test.cc b/src/net/spdy/spdy_protocol_test.cc index e098281..0e49207 100644 --- a/src/net/spdy/spdy_protocol_test.cc +++ b/src/net/spdy/spdy_protocol_test.cc @@ -40,28 +40,6 @@ INSTANTIATE_TEST_CASE_P(SpdyProtocolTests, SpdyProtocolTest, ::testing::Values(SPDY2, SPDY3)); -// Test our protocol constants -// TODO(hkhalil): Remove this test once we no longer rely on exact values. -TEST_P(SpdyProtocolTest, ProtocolConstants) { - EXPECT_EQ(1, SYN_STREAM); - EXPECT_EQ(2, SYN_REPLY); - EXPECT_EQ(3, RST_STREAM); - EXPECT_EQ(4, SETTINGS); - EXPECT_EQ(5, NOOP); - EXPECT_EQ(6, PING); - EXPECT_EQ(7, GOAWAY); - EXPECT_EQ(8, HEADERS); - EXPECT_EQ(9, WINDOW_UPDATE); - EXPECT_EQ(10, CREDENTIAL); - EXPECT_EQ(11, BLOCKED); - EXPECT_EQ(12, PUSH_PROMISE); - EXPECT_EQ(13, CONTINUATION); - EXPECT_EQ(14, ALTSVC); - EXPECT_EQ(15, PRIORITY); - EXPECT_EQ(15, LAST_CONTROL_TYPE); - EXPECT_EQ(std::numeric_limits::max(), kSpdyMaximumWindowSize); -} - class SpdyProtocolDeathTest : public SpdyProtocolTest {}; // All tests are run with two different SPDY versions: SPDY/2 and SPDY/3. @@ -72,7 +50,7 @@ INSTANTIATE_TEST_CASE_P(SpdyProtocolDeathTests, TEST_P(SpdyProtocolDeathTest, TestSpdySettingsAndIdOutOfBounds) { scoped_ptr flags_and_id; - EXPECT_DFATAL(flags_and_id.reset(new SettingsFlagsAndId(1, ~0)), + EXPECT_DFATAL(flags_and_id.reset(new SettingsFlagsAndId(1, 0xFFFFFFFF)), "SPDY setting ID too large."); // Make sure that we get expected values in opt mode. if (flags_and_id.get() != NULL) {