X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=src%2Fcryptsetup.c;h=89040cc6c51569b905820d66fd89448009b982d2;hb=05b695d5165f280bcdffbac9a312a3fee1202436;hp=f8431d8f86c044f2e0e8d5a3c8e062ad22e0ae65;hpb=b861d1e7f49178ea7030c369482f962bed0deb45;p=platform%2Fupstream%2Fcryptsetup.git diff --git a/src/cryptsetup.c b/src/cryptsetup.c index f8431d8..89040cc 100644 --- a/src/cryptsetup.c +++ b/src/cryptsetup.c @@ -1,3 +1,24 @@ +/* + * cryptsetup - setup cryptographic volumes for dm-crypt + * + * Copyright (C) 2004, Christophe Saout + * Copyright (C) 2004-2007, Clemens Fruhwirth + * Copyright (C) 2009-2012, Red Hat, Inc. All rights reserved. + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License + * version 2 as published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. + */ + #include #include #include @@ -6,32 +27,35 @@ #include #include #include +#include +#include #include #include - -#include +#include #include -#include "../config.h" - #include "cryptsetup.h" static int opt_verbose = 0; static int opt_debug = 0; -static char *opt_cipher = NULL; -static char *opt_hash = NULL; +static const char *opt_cipher = NULL; +static const char *opt_hash = NULL; static int opt_verify_passphrase = 0; -static char *opt_key_file = NULL; -static char *opt_master_key_file = NULL; -static char *opt_header_backup_file = NULL; -static char *opt_uuid = NULL; -static unsigned int opt_key_size = 0; -static unsigned int opt_keyfile_size = 0; -static unsigned int opt_new_keyfile_size = 0; +static const char *opt_key_file = NULL; +static const char *opt_master_key_file = NULL; +static const char *opt_header_backup_file = NULL; +static const char *opt_uuid = NULL; +static const char *opt_header_device = NULL; +static int opt_key_size = 0; +static long opt_keyfile_size = 0; +static long opt_new_keyfile_size = 0; +static long opt_keyfile_offset = 0; +static long opt_new_keyfile_offset = 0; static int opt_key_slot = CRYPT_ANY_SLOT; static uint64_t opt_size = 0; static uint64_t opt_offset = 0; static uint64_t opt_skip = 0; +static int opt_skip_valid = 0; static int opt_readonly = 0; static int opt_iteration_time = 1000; static int opt_batch_mode = 0; @@ -42,6 +66,8 @@ static int opt_align_payload = 0; static int opt_random = 0; static int opt_urandom = 0; static int opt_dump_master_key = 0; +static int opt_shared = 0; +static int opt_allow_discards = 0; static const char **action_argv; static int action_argc; @@ -55,6 +81,7 @@ static int action_luksOpen(int arg); static int action_luksAddKey(int arg); static int action_luksKillSlot(int arg); static int action_luksRemoveKey(int arg); +static int action_luksChangeKey(int arg); static int action_isLuks(int arg); static int action_luksUUID(int arg); static int action_luksDump(int arg); @@ -62,6 +89,8 @@ static int action_luksSuspend(int arg); static int action_luksResume(int arg); static int action_luksBackup(int arg); static int action_luksRestore(int arg); +static int action_loopaesOpen(int arg); +static int action_luksRepair(int arg); static struct action_type { const char *type; @@ -76,22 +105,27 @@ static struct action_type { { "remove", action_remove, 0, 1, 1, N_(""), N_("remove device") }, { "resize", action_resize, 0, 1, 1, N_(""), N_("resize active device") }, { "status", action_status, 0, 1, 0, N_(""), N_("show device status") }, + { "repair", action_luksRepair, 0, 1, 1, N_(""), N_("try to repair on-disk metadata") }, { "luksFormat", action_luksFormat, 0, 1, 1, N_(" []"), N_("formats a LUKS device") }, { "luksOpen", action_luksOpen, 0, 2, 1, N_(" "), N_("open LUKS device as mapping ") }, { "luksAddKey", action_luksAddKey, 0, 1, 1, N_(" []"), N_("add key to LUKS device") }, { "luksRemoveKey",action_luksRemoveKey, 0, 1, 1, N_(" []"), N_("removes supplied key or key file from LUKS device") }, + { "luksChangeKey",action_luksChangeKey, 0, 1, 1, N_(" []"), N_("changes supplied key or key file of LUKS device") }, { "luksKillSlot", action_luksKillSlot, 0, 2, 1, N_(" "), N_("wipes key with number from LUKS device") }, { "luksUUID", action_luksUUID, 0, 1, 0, N_(""), N_("print UUID of LUKS device") }, { "isLuks", action_isLuks, 0, 1, 0, N_(""), N_("tests for LUKS partition header") }, { "luksClose", action_remove, 0, 1, 1, N_(""), N_("remove LUKS mapping") }, - { "luksDump", action_luksDump, 0, 1, 0, N_(""), N_("dump LUKS partition information") }, + { "luksDump", action_luksDump, 0, 1, 1, N_(""), N_("dump LUKS partition information") }, { "luksSuspend",action_luksSuspend, 0, 1, 1, N_(""), N_("Suspend LUKS device and wipe key (all IOs are frozen).") }, { "luksResume", action_luksResume, 0, 1, 1, N_(""), N_("Resume suspended LUKS device.") }, { "luksHeaderBackup",action_luksBackup, 0, 1, 1, N_(""), N_("Backup LUKS device header and keyslots") }, { "luksHeaderRestore",action_luksRestore,0,1, 1, N_(""), N_("Restore LUKS device header and keyslots") }, + { "loopaesOpen",action_loopaesOpen, 0, 2, 1, N_(" "), N_("open loop-AES device as mapping ") }, + { "loopaesClose",action_remove, 0, 1, 1, N_(""), N_("remove loop-AES mapping") }, { NULL, NULL, 0, 0, 0, NULL, NULL } }; +__attribute__((format(printf, 5, 6))) static void clogger(struct crypt_device *cd, int level, const char *file, int line, const char *format, ...) { @@ -116,13 +150,13 @@ static void clogger(struct crypt_device *cd, int level, const char *file, free(target); } -static int _yesDialog(const char *msg, void *usrptr) +static int _yesDialog(const char *msg, void *usrptr __attribute__((unused))) { char *answer = NULL; size_t size = 0; int r = 1; - if(isatty(0) && !opt_batch_mode) { + if(isatty(STDIN_FILENO) && !opt_batch_mode) { log_std("\nWARNING!\n========\n"); log_std("%s\n\nAre you sure? (Type uppercase yes): ", msg); if(getline(&answer, &size, stdin) == -1) { @@ -138,7 +172,7 @@ static int _yesDialog(const char *msg, void *usrptr) return r; } -static void _log(int level, const char *msg, void *usrptr) +static void _log(int level, const char *msg, void *usrptr __attribute__((unused))) { switch(level) { @@ -152,12 +186,41 @@ static void _log(int level, const char *msg, void *usrptr) case CRYPT_LOG_ERROR: fputs(msg, stderr); break; + case CRYPT_LOG_DEBUG: + if (opt_debug) + printf("# %s\n", msg); + break; default: fprintf(stderr, "Internal error on logging class for msg: %s", msg); break; } } +static void _quiet_log(int level, const char *msg, void *usrptr) +{ + if (!opt_verbose && (level == CRYPT_LOG_ERROR || level == CRYPT_LOG_NORMAL)) + level = CRYPT_LOG_VERBOSE; + _log(level, msg, usrptr); +} + +static int _verify_passphrase(int def) +{ + /* Batch mode switch off verify - if not overrided by -y */ + if (opt_verify_passphrase) + def = 1; + else if (opt_batch_mode) + def = 0; + + /* Non-tty input doesn't allow verify */ + if (def && !isatty(STDIN_FILENO)) { + if (opt_verify_passphrase) + log_err(_("Can't do passphrase verification on non-tty inputs.\n")); + def = 0; + } + + return def; +} + static void show_status(int errcode) { char error[256], *error_; @@ -187,7 +250,32 @@ static void show_status(int errcode) log_err(".\n"); } -static int action_create(int arg) +static const char *uuid_or_device(const char *spec) +{ + static char device[PATH_MAX]; + char s, *ptr; + int i = 0, uuid_len = 5; + + /* Check if it is correct UUID= format */ + if (spec && !strncmp(spec, "UUID=", uuid_len)) { + strcpy(device, "/dev/disk/by-uuid/"); + ptr = &device[strlen(device)]; + i = uuid_len; + while ((s = spec[i++]) && i < PATH_MAX) { + if (!isxdigit(s) && s != '-') + return spec; /* Bail it out */ + if (isalpha(s)) + s = tolower(s); + *ptr++ = s; + } + *ptr = '\0'; + return device; + } + + return spec; +} + +static int action_create(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; char cipher[MAX_CIPHER_LEN], cipher_mode[MAX_CIPHER_LEN]; @@ -195,16 +283,27 @@ static int action_create(int arg) .hash = opt_hash ?: DEFAULT_PLAIN_HASH, .skip = opt_skip, .offset = opt_offset, + .size = opt_size, }; char *password = NULL; - unsigned int passwordLen; + size_t passwordLen; + size_t key_size = (opt_key_size ?: DEFAULT_PLAIN_KEYBITS) / 8; + uint32_t activate_flags = 0; int r; if (params.hash && !strcmp(params.hash, "plain")) params.hash = NULL; + /* FIXME: temporary hack */ + if (opt_key_file && strcmp(opt_key_file, "-")) + params.hash = NULL; + + if ((opt_keyfile_offset || opt_keyfile_size) && opt_key_file) + log_std(("Ignoring keyfile offset and size options, keyfile read " + "size is always the same as encryption key size.\n")); + r = crypt_parse_name_and_mode(opt_cipher ?: DEFAULT_CIPHER(PLAIN), - cipher, cipher_mode); + cipher, NULL, cipher_mode); if (r < 0) { log_err("No known cipher specification pattern detected.\n"); goto out; @@ -219,28 +318,87 @@ static int action_create(int arg) r = crypt_format(cd, CRYPT_PLAIN, cipher, cipher_mode, NULL, NULL, - (opt_key_size ?: DEFAULT_PLAIN_KEYBITS) / 8, + key_size, ¶ms); if (r < 0) goto out; - r = crypt_get_key(_("Enter passphrase: "), &password, &passwordLen, - opt_keyfile_size, opt_key_file, opt_timeout, - opt_batch_mode ? 0 : opt_verify_passphrase, cd); + if (opt_readonly) + activate_flags |= CRYPT_ACTIVATE_READONLY; + + if (opt_shared) + activate_flags |= CRYPT_ACTIVATE_SHARED; + + if (opt_allow_discards) + activate_flags |= CRYPT_ACTIVATE_ALLOW_DISCARDS; + + if (opt_key_file) + /* With hashing, read the whole keyfile */ + r = crypt_activate_by_keyfile_offset(cd, action_argv[0], + CRYPT_ANY_SLOT, opt_key_file, + params.hash ? 0 : key_size, 0, + activate_flags); + else { + r = crypt_get_key(_("Enter passphrase: "), + &password, &passwordLen, + opt_keyfile_offset, opt_keyfile_size, + NULL, opt_timeout, + _verify_passphrase(0), + cd); + if (r < 0) + goto out; + + r = crypt_activate_by_passphrase(cd, action_argv[0], + CRYPT_ANY_SLOT, password, passwordLen, activate_flags); + } +out: + crypt_free(cd); + crypt_safe_free(password); + + return r; +} + +static int action_loopaesOpen(int arg __attribute__((unused))) +{ + struct crypt_device *cd = NULL; + struct crypt_params_loopaes params = { + .hash = opt_hash ?: NULL, + .offset = opt_offset, + .skip = opt_skip_valid ? opt_skip : opt_offset, + }; + unsigned int key_size = (opt_key_size ?: DEFAULT_LOOPAES_KEYBITS) / 8; + uint32_t activate_flags = 0; + int r; + + if (!opt_key_file) { + log_err(_("Option --key-file is required.\n")); + return -EINVAL; + } + + if (opt_readonly) + activate_flags |= CRYPT_ACTIVATE_READONLY; + + if (opt_allow_discards) + activate_flags |= CRYPT_ACTIVATE_ALLOW_DISCARDS; + + if ((r = crypt_init(&cd, action_argv[0]))) + goto out; + + r = crypt_format(cd, CRYPT_LOOPAES, opt_cipher ?: DEFAULT_LOOPAES_CIPHER, + NULL, NULL, NULL, key_size, ¶ms); if (r < 0) goto out; - r = crypt_activate_by_passphrase(cd, action_argv[0], CRYPT_ANY_SLOT, - password, passwordLen, - opt_readonly ? CRYPT_ACTIVATE_READONLY : 0); + r = crypt_activate_by_keyfile_offset(cd, action_argv[1], CRYPT_ANY_SLOT, + opt_key_file, opt_keyfile_size, + opt_keyfile_size, activate_flags); out: crypt_free(cd); - crypt_safe_free(password); - return (r < 0) ? r : 0; + return r; } -static int action_remove(int arg) +static int action_remove(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; int r; @@ -253,12 +411,12 @@ static int action_remove(int arg) return r; } -static int action_resize(int arg) +static int action_resize(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; int r; - r = crypt_init_by_name(&cd, action_argv[0]); + r = crypt_init_by_name_and_header(&cd, action_argv[0], opt_header_device); if (r == 0) r = crypt_resize(cd, action_argv[0], opt_size); @@ -266,30 +424,46 @@ static int action_resize(int arg) return r; } -static int action_status(int arg) +static int action_status(int arg __attribute__((unused))) { crypt_status_info ci; struct crypt_active_device cad; struct crypt_device *cd = NULL; - int r = 0; + struct stat st; + char *backing_file; + const char *device; + int path = 0, r = 0; + + /* perhaps a path, not a dm device name */ + if (strchr(action_argv[0], '/') && !stat(action_argv[0], &st)) + path = 1; ci = crypt_status(NULL, action_argv[0]); switch (ci) { case CRYPT_INVALID: - r = -ENODEV; + r = -EINVAL; break; case CRYPT_INACTIVE: - log_std("%s/%s is inactive.\n", crypt_get_dir(), action_argv[0]); + if (path) + log_std("%s is inactive.\n", action_argv[0]); + else + log_std("%s/%s is inactive.\n", crypt_get_dir(), action_argv[0]); + r = -ENODEV; break; case CRYPT_ACTIVE: case CRYPT_BUSY: - log_std("%s/%s is active%s.\n", crypt_get_dir(), action_argv[0], - ci == CRYPT_BUSY ? " and is in use" : ""); - r = crypt_init_by_name(&cd, action_argv[0]); + if (path) + log_std("%s is active%s.\n", action_argv[0], + ci == CRYPT_BUSY ? " and is in use" : ""); + else + log_std("%s/%s is active%s.\n", crypt_get_dir(), action_argv[0], + ci == CRYPT_BUSY ? " and is in use" : ""); + + r = crypt_init_by_name_and_header(&cd, action_argv[0], opt_header_device); if (r < 0 || !crypt_get_type(cd)) goto out; - log_std(" type: %s\n", crypt_get_type(cd)); + log_std(" type: %s\n", crypt_get_type(cd)); r = crypt_get_active_device(cd, action_argv[0], &cad); if (r < 0) @@ -297,16 +471,26 @@ static int action_status(int arg) log_std(" cipher: %s-%s\n", crypt_get_cipher(cd), crypt_get_cipher_mode(cd)); log_std(" keysize: %d bits\n", crypt_get_volume_key_size(cd) * 8); - log_std(" device: %s\n", crypt_get_device_name(cd)); + device = crypt_get_device_name(cd); + log_std(" device: %s\n", device); + if (crypt_loop_device(device)) { + backing_file = crypt_loop_backing_file(device); + log_std(" loop: %s\n", backing_file); + free(backing_file); + } log_std(" offset: %" PRIu64 " sectors\n", cad.offset); log_std(" size: %" PRIu64 " sectors\n", cad.size); if (cad.iv_offset) log_std(" skipped: %" PRIu64 " sectors\n", cad.iv_offset); log_std(" mode: %s\n", cad.flags & CRYPT_ACTIVATE_READONLY ? "readonly" : "read/write"); + if (cad.flags & CRYPT_ACTIVATE_ALLOW_DISCARDS) + log_std(" flags: discards\n"); } out: crypt_free(cd); + if (r == -ENOTSUP) + r = 0; return r; } @@ -336,19 +520,50 @@ fail: return -EINVAL; } -static int action_luksFormat(int arg) +static int action_luksRepair(int arg __attribute__((unused))) +{ + struct crypt_device *cd = NULL; + int r; + + if ((r = crypt_init(&cd, action_argv[0]))) + goto out; + + /* Currently only LUKS1 allows repair */ + crypt_set_log_callback(cd, _quiet_log, NULL); + r = crypt_load(cd, CRYPT_LUKS1, NULL); + crypt_set_log_callback(cd, _log, NULL); + if (r == 0) { + log_verbose( _("No known problems detected for LUKS header.\n")); + goto out; + } + + r = _yesDialog(_("Really try to repair LUKS device header?"), + NULL) ? 0 : -EINVAL; + if (r == 0) + r = crypt_repair(cd, CRYPT_LUKS1, NULL); +out: + crypt_free(cd); + return r; +} + +static int action_luksFormat(int arg __attribute__((unused))) { int r = -EINVAL, keysize; + const char *header_device; char *msg = NULL, *key = NULL, cipher [MAX_CIPHER_LEN], cipher_mode[MAX_CIPHER_LEN]; char *password = NULL; - unsigned int passwordLen; + size_t passwordLen; struct crypt_device *cd = NULL; struct crypt_params_luks1 params = { .hash = opt_hash ?: DEFAULT_LUKS1_HASH, .data_alignment = opt_align_payload, + .data_device = opt_header_device ? action_argv[0] : NULL, }; - if(asprintf(&msg, _("This will overwrite data on %s irrevocably."), action_argv[0]) == -1) { + header_device = opt_header_device ?: action_argv[0]; + + if(asprintf(&msg, _("This will overwrite data on %s irrevocably."), + header_device) == -1) { log_err(_("memory allocation error in action_luksFormat")); r = -ENOMEM; goto out; @@ -359,21 +574,23 @@ static int action_luksFormat(int arg) goto out; r = crypt_parse_name_and_mode(opt_cipher ?: DEFAULT_CIPHER(LUKS1), - cipher, cipher_mode); + cipher, NULL, cipher_mode); if (r < 0) { - log_err("No known cipher specification pattern detected.\n"); + log_err(_("No known cipher specification pattern detected.\n")); goto out; } - if ((r = crypt_init(&cd, action_argv[0]))) + if ((r = crypt_init(&cd, header_device))) { + if (opt_header_device) + log_err(_("Cannot use %s as on-disk header.\n"), header_device); goto out; + } keysize = (opt_key_size ?: DEFAULT_LUKS1_KEYBITS) / 8; - crypt_set_password_verify(cd, 1); crypt_set_timeout(cd, opt_timeout); if (opt_iteration_time) - crypt_set_iterarion_time(cd, opt_iteration_time); + crypt_set_iteration_time(cd, opt_iteration_time); if (opt_random) crypt_set_rng_type(cd, CRYPT_RNG_RANDOM); @@ -381,8 +598,8 @@ static int action_luksFormat(int arg) crypt_set_rng_type(cd, CRYPT_RNG_URANDOM); r = crypt_get_key(_("Enter LUKS passphrase: "), &password, &passwordLen, - opt_keyfile_size, opt_key_file, opt_timeout, - opt_batch_mode ? 0 : 1 /* always verify */, cd); + opt_keyfile_offset, opt_keyfile_size, opt_key_file, + opt_timeout, _verify_passphrase(1), cd); if (r < 0) goto out; @@ -405,58 +622,92 @@ out: crypt_safe_free(key); crypt_safe_free(password); - return (r < 0) ? r : 0; + return r; } -static int action_luksOpen(int arg) +static int action_luksOpen(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; + const char *data_device, *header_device; + char *key = NULL; uint32_t flags = 0; - int r; + int r, keysize; - if ((r = crypt_init(&cd, action_argv[0]))) + if (opt_header_device) { + header_device = uuid_or_device(opt_header_device); + data_device = action_argv[0]; + } else { + header_device = uuid_or_device(action_argv[0]); + data_device = NULL; + } + + if ((r = crypt_init(&cd, header_device))) goto out; if ((r = crypt_load(cd, CRYPT_LUKS1, NULL))) goto out; + if (data_device && + (r = crypt_set_data_device(cd, data_device))) + goto out; + + if (!data_device && (crypt_get_data_offset(cd) < 8)) { + log_err(_("Reduced data offset is allowed only for detached LUKS header.\n")); + r = -EINVAL; + goto out; + } + crypt_set_timeout(cd, opt_timeout); crypt_set_password_retry(cd, opt_tries); + crypt_set_password_verify(cd, _verify_passphrase(0)); if (opt_iteration_time) - crypt_set_iterarion_time(cd, opt_iteration_time); + crypt_set_iteration_time(cd, opt_iteration_time); + if (opt_readonly) flags |= CRYPT_ACTIVATE_READONLY; - if (opt_key_file) { + if (opt_allow_discards) + flags |= CRYPT_ACTIVATE_ALLOW_DISCARDS; + + if (opt_master_key_file) { + keysize = crypt_get_volume_key_size(cd); + r = _read_mk(opt_master_key_file, &key, keysize); + if (r < 0) + goto out; + r = crypt_activate_by_volume_key(cd, action_argv[1], + key, keysize, flags); + } else if (opt_key_file) { crypt_set_password_retry(cd, 1); - r = crypt_activate_by_keyfile(cd, action_argv[1], - CRYPT_ANY_SLOT, opt_key_file, opt_keyfile_size, - flags); + r = crypt_activate_by_keyfile_offset(cd, action_argv[1], + opt_key_slot, opt_key_file, opt_keyfile_size, + opt_keyfile_offset, flags); } else r = crypt_activate_by_passphrase(cd, action_argv[1], - CRYPT_ANY_SLOT, NULL, 0, flags); + opt_key_slot, NULL, 0, flags); out: + crypt_safe_free(key); crypt_free(cd); - return (r < 0) ? r : 0; + return r; } static int verify_keyslot(struct crypt_device *cd, int key_slot, char *msg_last, char *msg_pass, - const char *key_file, int keyfile_size) + const char *key_file, int keyfile_offset, + int keyfile_size) { crypt_keyslot_info ki; char *password = NULL; - unsigned int passwordLen, i; - int r; + size_t passwordLen; + int i, r; ki = crypt_keyslot_status(cd, key_slot); if (ki == CRYPT_SLOT_ACTIVE_LAST && msg_last && !_yesDialog(msg_last, NULL)) return -EPERM; r = crypt_get_key(msg_pass, &password, &passwordLen, - keyfile_size, key_file, opt_timeout, - opt_batch_mode ? 0 : opt_verify_passphrase, cd); + keyfile_offset, keyfile_size, key_file, opt_timeout, + _verify_passphrase(0), cd); if(r < 0) goto out; @@ -485,12 +736,12 @@ out: return r; } -static int action_luksKillSlot(int arg) +static int action_luksKillSlot(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; int r; - if ((r = crypt_init(&cd, action_argv[0]))) + if ((r = crypt_init(&cd, uuid_or_device(action_argv[0])))) goto out; crypt_set_confirm_callback(cd, _yesDialog, NULL); @@ -507,6 +758,7 @@ static int action_luksKillSlot(int arg) case CRYPT_SLOT_INACTIVE: log_err(_("Key %d not active. Can't wipe.\n"), opt_key_slot); case CRYPT_SLOT_INVALID: + r = -EINVAL; goto out; } @@ -514,7 +766,7 @@ static int action_luksKillSlot(int arg) r = verify_keyslot(cd, opt_key_slot, _("This is the last keyslot. Device will become unusable after purging this key."), _("Enter any remaining LUKS passphrase: "), - opt_key_file, opt_keyfile_size); + opt_key_file, opt_keyfile_offset, opt_keyfile_size); if (r < 0) goto out; } @@ -522,18 +774,17 @@ static int action_luksKillSlot(int arg) r = crypt_keyslot_destroy(cd, opt_key_slot); out: crypt_free(cd); - - return (r < 0) ? r : 0; + return r; } -static int action_luksRemoveKey(int arg) +static int action_luksRemoveKey(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; char *password = NULL; - unsigned int passwordLen; + size_t passwordLen; int r; - if ((r = crypt_init(&cd, action_argv[0]))) + if ((r = crypt_init(&cd, uuid_or_device(action_argv[0])))) goto out; crypt_set_confirm_callback(cd, _yesDialog, NULL); @@ -544,9 +795,9 @@ static int action_luksRemoveKey(int arg) r = crypt_get_key(_("Enter LUKS passphrase to be deleted: "), &password, &passwordLen, - opt_keyfile_size, opt_key_file, + opt_keyfile_offset, opt_keyfile_size, opt_key_file, opt_timeout, - opt_batch_mode ? 0 : opt_verify_passphrase, + _verify_passphrase(0), cd); if(r < 0) goto out; @@ -571,18 +822,17 @@ static int action_luksRemoveKey(int arg) out: crypt_safe_free(password); crypt_free(cd); - - return (r < 0) ? r : 0; + return r; } -static int action_luksAddKey(int arg) +static int action_luksAddKey(int arg __attribute__((unused))) { int r = -EINVAL, keysize = 0; char *key = NULL; const char *opt_new_key_file = (action_argc > 1 ? action_argv[1] : NULL); struct crypt_device *cd = NULL; - if ((r = crypt_init(&cd, action_argv[0]))) + if ((r = crypt_init(&cd, uuid_or_device(action_argv[0])))) goto out; crypt_set_confirm_callback(cd, _yesDialog, NULL); @@ -591,21 +841,23 @@ static int action_luksAddKey(int arg) goto out; keysize = crypt_get_volume_key_size(cd); - crypt_set_password_verify(cd, opt_verify_passphrase ? 1 : 0); + /* FIXME: lib cannot properly set verification for new/old passphrase */ + crypt_set_password_verify(cd, _verify_passphrase(0)); crypt_set_timeout(cd, opt_timeout); if (opt_iteration_time) - crypt_set_iterarion_time(cd, opt_iteration_time); + crypt_set_iteration_time(cd, opt_iteration_time); if (opt_master_key_file) { - if (_read_mk(opt_master_key_file, &key, keysize) < 0) + r = _read_mk(opt_master_key_file, &key, keysize); + if (r < 0) goto out; - + //FIXME: process keyfile arg r = crypt_keyslot_add_by_volume_key(cd, opt_key_slot, key, keysize, NULL, 0); } else if (opt_key_file || opt_new_key_file) { - r = crypt_keyslot_add_by_keyfile(cd, opt_key_slot, - opt_key_file, opt_keyfile_size, - opt_new_key_file, opt_new_keyfile_size); + r = crypt_keyslot_add_by_keyfile_offset(cd, opt_key_slot, + opt_key_file, opt_keyfile_size, opt_keyfile_offset, + opt_new_key_file, opt_new_keyfile_size, opt_new_keyfile_offset); } else { r = crypt_keyslot_add_by_passphrase(cd, opt_key_slot, NULL, 0, NULL, 0); @@ -613,11 +865,108 @@ static int action_luksAddKey(int arg) out: crypt_free(cd); crypt_safe_free(key); + return r; +} - return (r < 0) ? r : 0; +static int _slots_full(struct crypt_device *cd) +{ + int i; + + for (i = 0; i < crypt_keyslot_max(crypt_get_type(cd)); i++) + if (crypt_keyslot_status(cd, i) == CRYPT_SLOT_INACTIVE) + return 0; + return 1; } -static int action_isLuks(int arg) +static int action_luksChangeKey(int arg __attribute__((unused))) +{ + const char *opt_new_key_file = (action_argc > 1 ? action_argv[1] : NULL); + struct crypt_device *cd = NULL; + char *vk = NULL, *password = NULL; + size_t passwordLen = 0; + size_t vk_size; + int new_key_slot, old_key_slot, r; + + if ((r = crypt_init(&cd, uuid_or_device(action_argv[0])))) + goto out; + + if ((r = crypt_load(cd, CRYPT_LUKS1, NULL))) + goto out; + + if (opt_iteration_time) + crypt_set_iteration_time(cd, opt_iteration_time); + + r = crypt_get_key(_("Enter LUKS passphrase to be changed: "), + &password, &passwordLen, + opt_keyfile_offset, opt_keyfile_size, opt_key_file, + opt_timeout, _verify_passphrase(0), cd); + if (r < 0) + goto out; + + vk_size = crypt_get_volume_key_size(cd); + vk = crypt_safe_alloc(vk_size); + if (!vk) { + r = -ENOMEM; + goto out; + } + + r = crypt_volume_key_get(cd, opt_key_slot, vk, &vk_size, + password, passwordLen); + if (r < 0) { + if (opt_key_slot != CRYPT_ANY_SLOT) + log_err(_("No key available with this passphrase.\n")); + goto out; + } + + if (opt_key_slot != CRYPT_ANY_SLOT || _slots_full(cd)) { + log_dbg("Key slot %d is going to be overwritten (%s).", + r, opt_key_slot != CRYPT_ANY_SLOT ? + "explicit key slot specified" : "no free key slot"); + old_key_slot = r; + new_key_slot = r; + } else { + log_dbg("Allocating new key slot."); + old_key_slot = r; + new_key_slot = CRYPT_ANY_SLOT; + } + + crypt_safe_free(password); + password = NULL; + passwordLen = 0; + r = crypt_get_key(_("Enter new LUKS passphrase: "), + &password, &passwordLen, + opt_new_keyfile_offset, opt_new_keyfile_size, + opt_new_key_file, + opt_timeout, _verify_passphrase(0), cd); + if (r < 0) + goto out; + + if (new_key_slot == old_key_slot) { + (void)crypt_keyslot_destroy(cd, old_key_slot); + r = crypt_keyslot_add_by_volume_key(cd, new_key_slot, + vk, vk_size, + password, passwordLen); + if (r >= 0) + log_verbose(_("Key slot %d changed.\n"), r); + } else { + r = crypt_keyslot_add_by_volume_key(cd, CRYPT_ANY_SLOT, + vk, vk_size, + password, passwordLen); + if (r >= 0) { + log_verbose(_("Replaced with key slot %d.\n"), r); + r = crypt_keyslot_destroy(cd, old_key_slot); + } + } + if (r < 0) + log_err(_("Failed to swap new key slot.\n")); +out: + crypt_safe_free(vk); + crypt_safe_free(password); + crypt_free(cd); + return r; +} + +static int action_isLuks(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; int r; @@ -625,13 +974,14 @@ static int action_isLuks(int arg) if ((r = crypt_init(&cd, action_argv[0]))) goto out; + crypt_set_log_callback(cd, _quiet_log, NULL); r = crypt_load(cd, CRYPT_LUKS1, NULL); out: crypt_free(cd); return r; } -static int action_luksUUID(int arg) +static int action_luksUUID(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; const char *existing_uuid = NULL; @@ -655,15 +1005,15 @@ static int action_luksUUID(int arg) out: crypt_free(cd); return r; - } static int luksDump_with_volume_key(struct crypt_device *cd) { char *vk = NULL, *password = NULL; - unsigned int passwordLen = 0; + size_t passwordLen = 0; size_t vk_size; - int i, r; + unsigned i; + int r; crypt_set_confirm_callback(cd, _yesDialog, NULL); if (!_yesDialog( @@ -679,7 +1029,8 @@ static int luksDump_with_volume_key(struct crypt_device *cd) return -ENOMEM; r = crypt_get_key(_("Enter LUKS passphrase: "), &password, &passwordLen, - opt_keyfile_size, opt_key_file, opt_timeout, 0, cd); + opt_keyfile_offset, opt_keyfile_size, opt_key_file, + opt_timeout, 0, cd); if (r < 0) goto out; @@ -691,9 +1042,9 @@ static int luksDump_with_volume_key(struct crypt_device *cd) log_std("LUKS header information for %s\n", crypt_get_device_name(cd)); log_std("Cipher name: \t%s\n", crypt_get_cipher(cd)); log_std("Cipher mode: \t%s\n", crypt_get_cipher_mode(cd)); - log_std("Payload offset:\t%d\n", crypt_get_data_offset(cd)); + log_std("Payload offset:\t%d\n", (int)crypt_get_data_offset(cd)); log_std("UUID: \t%s\n", crypt_get_uuid(cd)); - log_std("MK bits: \t%d\n", vk_size * 8); + log_std("MK bits: \t%d\n", (int)vk_size * 8); log_std("MK dump:\t"); for(i = 0; i < vk_size; i++) { @@ -709,12 +1060,12 @@ out: return r; } -static int action_luksDump(int arg) +static int action_luksDump(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; int r; - if ((r = crypt_init(&cd, action_argv[0]))) + if ((r = crypt_init(&cd, uuid_or_device(action_argv[0])))) goto out; if ((r = crypt_load(cd, CRYPT_LUKS1, NULL))) @@ -729,12 +1080,12 @@ out: return r; } -static int action_luksSuspend(int arg) +static int action_luksSuspend(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; int r; - r = crypt_init_by_name(&cd, action_argv[0]); + r = crypt_init_by_name_and_header(&cd, action_argv[0], opt_header_device); if (!r) r = crypt_suspend(cd, action_argv[0]); @@ -742,20 +1093,21 @@ static int action_luksSuspend(int arg) return r; } -static int action_luksResume(int arg) +static int action_luksResume(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; int r; - if ((r = crypt_init_by_name(&cd, action_argv[0]))) + if ((r = crypt_init_by_name_and_header(&cd, action_argv[0], opt_header_device))) goto out; - if ((r = crypt_load(cd, CRYPT_LUKS1, NULL))) - goto out; + crypt_set_timeout(cd, opt_timeout); + crypt_set_password_retry(cd, opt_tries); + crypt_set_password_verify(cd, _verify_passphrase(0)); if (opt_key_file) - r = crypt_resume_by_keyfile(cd, action_argv[0], CRYPT_ANY_SLOT, - opt_key_file, opt_keyfile_size); + r = crypt_resume_by_keyfile_offset(cd, action_argv[0], CRYPT_ANY_SLOT, + opt_key_file, opt_keyfile_size, opt_keyfile_offset); else r = crypt_resume_by_passphrase(cd, action_argv[0], CRYPT_ANY_SLOT, NULL, 0); @@ -764,7 +1116,7 @@ out: return r; } -static int action_luksBackup(int arg) +static int action_luksBackup(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; int r; @@ -774,7 +1126,7 @@ static int action_luksBackup(int arg) return -EINVAL; } - if ((r = crypt_init(&cd, action_argv[0]))) + if ((r = crypt_init(&cd, uuid_or_device(action_argv[0])))) goto out; crypt_set_confirm_callback(cd, _yesDialog, NULL); @@ -785,7 +1137,7 @@ out: return r; } -static int action_luksRestore(int arg) +static int action_luksRestore(int arg __attribute__((unused))) { struct crypt_device *cd = NULL; int r = 0; @@ -805,17 +1157,22 @@ out: return r; } -static void usage(poptContext popt_context, int exitcode, - const char *error, const char *more) +static __attribute__ ((noreturn)) void usage(poptContext popt_context, + int exitcode, const char *error, + const char *more) { poptPrintUsage(popt_context, stderr, 0); if (error) log_err("%s: %s\n", more, error); + poptFreeContext(popt_context); exit(exitcode); } -static void help(poptContext popt_context, enum poptCallbackReason reason, - struct poptOption *key, const char * arg, void *data) +static void help(poptContext popt_context, + enum poptCallbackReason reason __attribute__((unused)), + struct poptOption *key, + const char *arg __attribute__((unused)), + void *data __attribute__((unused))) { if (key->shortName == '?') { struct action_type *action; @@ -829,7 +1186,7 @@ static void help(poptContext popt_context, enum poptCallbackReason reason, for(action = action_types; action->type; action++) log_std("\t%s %s - %s\n", action->type, _(action->arg_desc), _(action->desc)); - + log_std(_("\n" " is the device to create under %s\n" " is the encrypted device\n" @@ -837,20 +1194,25 @@ static void help(poptContext popt_context, enum poptCallbackReason reason, " optional key file for the new key for luksAddKey action\n"), crypt_get_dir()); + log_std(_("\nDefault compiled-in keyfile parameters:\n" + "\tMaximum keyfile size: %dkB, " + "Maximum interactive passphrase length %d (characters)\n"), + DEFAULT_KEYFILE_SIZE_MAXKB, DEFAULT_PASSPHRASE_SIZE_MAX); + log_std(_("\nDefault compiled-in device cipher parameters:\n" + "\tloop-AES: %s, Key %d bits\n" "\tplain: %s, Key: %d bits, Password hashing: %s\n" "\tLUKS1: %s, Key: %d bits, LUKS header hashing: %s, RNG: %s\n"), + DEFAULT_LOOPAES_CIPHER, DEFAULT_LOOPAES_KEYBITS, DEFAULT_CIPHER(PLAIN), DEFAULT_PLAIN_KEYBITS, DEFAULT_PLAIN_HASH, DEFAULT_CIPHER(LUKS1), DEFAULT_LUKS1_KEYBITS, DEFAULT_LUKS1_HASH, DEFAULT_RNG); - exit(0); + exit(EXIT_SUCCESS); } else - usage(popt_context, 0, NULL, NULL); + usage(popt_context, EXIT_SUCCESS, NULL, NULL); } -void set_debug_level(int level); - -static void _dbg_version_and_cmd(int argc, char **argv) +static void _dbg_version_and_cmd(int argc, const char **argv) { int i; @@ -858,7 +1220,7 @@ static void _dbg_version_and_cmd(int argc, char **argv) for (i = 0; i < argc; i++) { if (i) log_std(" "); - log_std(argv[i]); + log_std("%s", argv[i]); } log_std("\"\n"); } @@ -867,6 +1229,8 @@ static int run_action(struct action_type *action) { int r; + log_dbg("Running command %s.", action->type); + if (action->required_memlock) crypt_memory_lock(NULL, 1); @@ -875,12 +1239,30 @@ static int run_action(struct action_type *action) if (action->required_memlock) crypt_memory_lock(NULL, 0); + /* Some functions returns keyslot # */ + if (r > 0) + r = 0; + show_status(r); + /* Translate exit code to simple codes */ + switch (r) { + case 0: r = EXIT_SUCCESS; break; + case -EEXIST: + case -EBUSY: r = 5; break; + case -ENOTBLK: + case -ENODEV: r = 4; break; + case -ENOMEM: r = 3; break; + case -EPERM: r = 2; break; + case -EINVAL: + case -ENOENT: + case -ENOSYS: + default: r = EXIT_FAILURE; + } return r; } -int main(int argc, char **argv) +int main(int argc, const char **argv) { static char *popt_tmp; static struct poptOption popt_help_options[] = { @@ -901,8 +1283,10 @@ int main(int argc, char **argv) { "master-key-file", '\0', POPT_ARG_STRING, &opt_master_key_file, 0, N_("Read the volume (master) key from file."), NULL }, { "dump-master-key", '\0', POPT_ARG_NONE, &opt_dump_master_key, 0, N_("Dump volume (master) key instead of keyslots info."), NULL }, { "key-size", 's', POPT_ARG_INT, &opt_key_size, 0, N_("The size of the encryption key"), N_("BITS") }, - { "keyfile-size", 'l', POPT_ARG_INT, &opt_keyfile_size, 0, N_("Limits the read from keyfile"), N_("bytes") }, - { "new-keyfile-size", '\0', POPT_ARG_INT, &opt_new_keyfile_size, 0, N_("Limits the read from newly added keyfile"), N_("bytes") }, + { "keyfile-size", 'l', POPT_ARG_LONG, &opt_keyfile_size, 0, N_("Limits the read from keyfile"), N_("bytes") }, + { "keyfile-offset", '\0', POPT_ARG_LONG, &opt_keyfile_offset, 0, N_("Number of bytes to skip in keyfile"), N_("bytes") }, + { "new-keyfile-size", '\0', POPT_ARG_LONG, &opt_new_keyfile_size, 0, N_("Limits the read from newly added keyfile"), N_("bytes") }, + { "new-keyfile-offset",'\0', POPT_ARG_LONG, &opt_new_keyfile_offset, 0, N_("Number of bytes to skip in newly added keyfile"), N_("bytes") }, { "key-slot", 'S', POPT_ARG_INT, &opt_key_slot, 0, N_("Slot number for new key (default is first free)"), NULL }, { "size", 'b', POPT_ARG_STRING, &popt_tmp, 1, N_("The size of the device"), N_("SECTORS") }, { "offset", 'o', POPT_ARG_STRING, &popt_tmp, 2, N_("The start offset in the backend device"), N_("SECTORS") }, @@ -916,12 +1300,15 @@ int main(int argc, char **argv) { "header-backup-file",'\0', POPT_ARG_STRING, &opt_header_backup_file, 0, N_("File with LUKS header and keyslots backup."), NULL }, { "use-random", '\0', POPT_ARG_NONE, &opt_random, 0, N_("Use /dev/random for generating volume key."), NULL }, { "use-urandom", '\0', POPT_ARG_NONE, &opt_urandom, 0, N_("Use /dev/urandom for generating volume key."), NULL }, - { "uuid", '\0', POPT_ARG_STRING, &opt_uuid, 0, N_("UUID for device to use."), NULL }, + { "shared", '\0', POPT_ARG_NONE, &opt_shared, 0, N_("Share device with another non-overlapping crypt segment."), NULL }, + { "uuid", '\0', POPT_ARG_STRING, &opt_uuid, 0, N_("UUID for device to use."), NULL }, + { "allow-discards", '\0', POPT_ARG_NONE, &opt_allow_discards, 0, N_("Allow discards (aka TRIM) requests for device."), NULL }, + { "header", '\0', POPT_ARG_STRING, &opt_header_device, 0, N_("Device or file with separated LUKS header."), NULL }, POPT_TABLEEND }; poptContext popt_context; struct action_type *action; - char *aname; + const char *aname; int r; const char *null_action_argv[] = {NULL}; @@ -931,17 +1318,21 @@ int main(int argc, char **argv) bindtextdomain(PACKAGE, LOCALEDIR); textdomain(PACKAGE); - popt_context = poptGetContext(PACKAGE, argc, (const char **)argv, - popt_options, 0); + crypt_fips_self_check(NULL); + + popt_context = poptGetContext(PACKAGE, argc, argv, popt_options, 0); poptSetOtherOptionHelp(popt_context, - N_("[OPTION...] ]")); + N_("[OPTION...] ")); while((r = poptGetNextOpt(popt_context)) > 0) { unsigned long long ull_value; char *endp; + errno = 0; ull_value = strtoull(popt_tmp, &endp, 0); - if (*endp || !*popt_tmp) + if (*endp || !*popt_tmp || + (errno == ERANGE && ull_value == ULLONG_MAX) || + (errno != 0 && ull_value == 0)) r = POPT_ERROR_BADNUMBER; switch(r) { @@ -953,6 +1344,7 @@ int main(int argc, char **argv) break; case 3: opt_skip = ull_value; + opt_skip_valid = 1; break; } @@ -961,21 +1353,22 @@ int main(int argc, char **argv) } if (r < -1) - usage(popt_context, 1, poptStrerror(r), + usage(popt_context, EXIT_FAILURE, poptStrerror(r), poptBadOption(popt_context, POPT_BADOPTION_NOALIAS)); if (opt_version_mode) { log_std("%s %s\n", PACKAGE_NAME, PACKAGE_VERSION); - exit(0); + poptFreeContext(popt_context); + exit(EXIT_SUCCESS); } - if (!(aname = (char *)poptGetArg(popt_context))) - usage(popt_context, 1, _("Argument missing."), + if (!(aname = poptGetArg(popt_context))) + usage(popt_context, EXIT_FAILURE, _("Argument missing."), poptGetInvocationName(popt_context)); for(action = action_types; action->type; action++) if (strcmp(action->type, aname) == 0) break; if (!action->type) - usage(popt_context, 1, _("Unknown action."), + usage(popt_context, EXIT_FAILURE, _("Unknown action."), poptGetInvocationName(popt_context)); action_argc = 0; @@ -991,31 +1384,47 @@ int main(int argc, char **argv) if(action_argc < action->required_action_argc) { char buf[128]; snprintf(buf, 128,_("%s: requires %s as arguments"), action->type, action->arg_desc); - usage(popt_context, 1, buf, + usage(popt_context, EXIT_FAILURE, buf, poptGetInvocationName(popt_context)); } /* FIXME: rewrite this from scratch */ + if (opt_shared && strcmp(aname, "create")) { + usage(popt_context, EXIT_FAILURE, + _("Option --shared is allowed only for create operation.\n"), + poptGetInvocationName(popt_context)); + } + + if (opt_allow_discards && + strcmp(aname, "luksOpen") && + strcmp(aname, "create") && + strcmp(aname, "loopaesOpen")) { + usage(popt_context, EXIT_FAILURE, + _("Option --allow-discards is allowed only for luksOpen, loopaesOpen and create operation.\n"), + poptGetInvocationName(popt_context)); + } + if (opt_key_size && strcmp(aname, "luksFormat") && - strcmp(aname, "create")) { - usage(popt_context, 1, - _("Option --key-size is allowed only for luksFormat and create.\n" + strcmp(aname, "create") && + strcmp(aname, "loopaesOpen")) { + usage(popt_context, EXIT_FAILURE, + _("Option --key-size is allowed only for luksFormat, create and loopaesOpen.\n" "To limit read from keyfile use --keyfile-size=(bytes)."), poptGetInvocationName(popt_context)); } if (opt_key_size % 8) - usage(popt_context, 1, + usage(popt_context, EXIT_FAILURE, _("Key size must be a multiple of 8 bits"), poptGetInvocationName(popt_context)); - if (!strcmp(aname, "luksKillSlot")) + if (!strcmp(aname, "luksKillSlot") && action_argc > 1) opt_key_slot = atoi(action_argv[1]); if (opt_key_slot != CRYPT_ANY_SLOT && - (opt_key_slot < 0 || opt_key_slot > crypt_keyslot_max(CRYPT_LUKS1))) - usage(popt_context, 1, _("Key slot is invalid."), + (opt_key_slot < 0 || opt_key_slot >= crypt_keyslot_max(CRYPT_LUKS1))) + usage(popt_context, EXIT_FAILURE, _("Key slot is invalid."), poptGetInvocationName(popt_context)); if ((!strcmp(aname, "luksRemoveKey") || @@ -1024,29 +1433,49 @@ int main(int argc, char **argv) if (opt_key_file) log_err(_("Option --key-file takes precedence over specified key file argument.\n")); else - opt_key_file = (char*)action_argv[1]; + opt_key_file = action_argv[1]; + } + + if (opt_keyfile_size < 0 || opt_new_keyfile_size < 0 || opt_key_size < 0 || + opt_keyfile_offset < 0 || opt_new_keyfile_offset < 0) { + usage(popt_context, EXIT_FAILURE, + _("Negative number for option not permitted."), + poptGetInvocationName(popt_context)); } if (opt_random && opt_urandom) - usage(popt_context, 1, _("Only one of --use-[u]random options is allowed."), + usage(popt_context, EXIT_FAILURE, _("Only one of --use-[u]random options is allowed."), poptGetInvocationName(popt_context)); + if ((opt_random || opt_urandom) && strcmp(aname, "luksFormat")) - usage(popt_context, 1, _("Option --use-[u]random is allowed only for luksFormat."), + usage(popt_context, EXIT_FAILURE, _("Option --use-[u]random is allowed only for luksFormat."), poptGetInvocationName(popt_context)); if (opt_uuid && strcmp(aname, "luksFormat") && strcmp(aname, "luksUUID")) - usage(popt_context, 1, _("Option --uuid is allowed only for luksFormat and luksUUID."), + usage(popt_context, EXIT_FAILURE, _("Option --uuid is allowed only for luksFormat and luksUUID."), poptGetInvocationName(popt_context)); - if ((opt_offset || opt_skip) && strcmp(aname, "create")) - usage(popt_context, 1, _("Options --offset and --skip are supported only for create command.\n"), + if (opt_align_payload && strcmp(aname, "luksFormat")) + usage(popt_context, EXIT_FAILURE, _("Option --align-payload is allowed only for luksFormat."), poptGetInvocationName(popt_context)); + if (opt_skip && strcmp(aname, "create") && strcmp(aname, "loopaesOpen")) + usage(popt_context, EXIT_FAILURE, + _("Option --skip is supported only for create and loopaesOpen commands.\n"), + poptGetInvocationName(popt_context)); + + if (opt_offset && strcmp(aname, "create") && strcmp(aname, "loopaesOpen")) + usage(popt_context, EXIT_FAILURE, + _("Option --offset is supported only for create and loopaesOpen commands.\n"), + poptGetInvocationName(popt_context)); + if (opt_debug) { opt_verbose = 1; crypt_set_debug_level(-1); _dbg_version_and_cmd(argc, argv); } - return run_action(action); + r = run_action(action); + poptFreeContext(popt_context); + return r; }