X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=src%2Fcpp%2FCPulseAudioClient.cpp;h=ef7ddb3bb843f79be88d2feb7bc7f0b83fae3c11;hb=a871d32040c7cae645c8e79f511f2131e8bebfc5;hp=ca3eb6132af979ed181ddbcf2fc6c2a9508170cb;hpb=e2e925a07ae1b75aa8300aeed0419d16c4eccb2c;p=platform%2Fcore%2Fapi%2Faudio-io.git diff --git a/src/cpp/CPulseAudioClient.cpp b/src/cpp/CPulseAudioClient.cpp index ca3eb61..ef7ddb3 100644 --- a/src/cpp/CPulseAudioClient.cpp +++ b/src/cpp/CPulseAudioClient.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2015 Samsung Electronics Co., Ltd All Rights Reserved + git st* Copyright (c) 2015 Samsung Electronics Co., Ltd All Rights Reserved * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -15,10 +15,14 @@ */ -#include #include "CAudioIODef.h" +#include +#include +#include +#include +#include + #ifdef ENABLE_DPM -#include #include #endif @@ -30,6 +34,8 @@ using namespace tizen_media_audio; * class CPulseAudioClient */ const char* CPulseAudioClient::CLIENT_NAME = "AUDIO_IO_PA_CLIENT"; +static constexpr unsigned int drain_wait_interval = 10000; +static constexpr unsigned int drain_wait_max_count = 30; CPulseAudioClient::CPulseAudioClient( EStreamDirection direction, @@ -38,16 +44,19 @@ CPulseAudioClient::CPulseAudioClient( __mDirection(direction), __mSpec(spec), __mpListener(listener), - __mpMainloop(NULL), - __mpContext(NULL), - __mpStream(NULL), - __mpPropList(NULL), + __mpMainloop(nullptr), + __mpContext(nullptr), + __mpStream(nullptr), + __mpPropList(nullptr), __mIsInit(false), __mIsOperationSuccess(false), - __mpSyncReadDataPtr(NULL), + __mpSyncReadDataPtr(nullptr), __mSyncReadIndex(0), __mSyncReadLength(0), - __mIsUsedSyncRead(false) { + __mIsUsedSyncRead(false), + __mIsFirstStream(false), + __mIsDraining(false), + __mIsStarted(false) { } CPulseAudioClient::~CPulseAudioClient() { @@ -55,7 +64,7 @@ CPulseAudioClient::~CPulseAudioClient() { } void CPulseAudioClient::__contextStateChangeCb(pa_context* c, void* user_data) { - CPulseAudioClient* pClient = static_cast(user_data); + auto pClient = static_cast(user_data); assert(pClient); assert(c); @@ -79,58 +88,51 @@ void CPulseAudioClient::__contextStateChangeCb(pa_context* c, void* user_data) { } } -void CPulseAudioClient::__successContextCb(pa_context* c, int success, void* user_data) { - AUDIO_IO_LOGD("pa_context[%p], success[%d], user_data[%p]", c, success, user_data); - assert(c); - assert(user_data); - - CPulseAudioClient* pClient = static_cast(user_data); - pClient->__mIsOperationSuccess = static_cast(success); - - pa_threaded_mainloop_signal(pClient->__mpMainloop, 0); -} - +//LCOV_EXCL_START static bool __is_microphone_restricted(void) { int state = 1; #ifdef ENABLE_DPM - dpm_context_h dpm_ctx_h; - dpm_restriction_policy_h dpm_policy_h; + device_policy_manager_h dpm_h = nullptr; int ret = 0; - if ((dpm_ctx_h = dpm_context_create())) { - if ((dpm_policy_h = dpm_context_acquire_restriction_policy(dpm_ctx_h))) { - /* state: 0(disallowed), 1(allowed) */ - if ((ret = dpm_restriction_get_microphone_state(dpm_policy_h, &state))) - AUDIO_IO_LOGE("Failed to dpm_restriction_get_microphone_state(), ret(0x%x)", ret); - dpm_context_release_restriction_policy(dpm_ctx_h, dpm_policy_h); - } else - AUDIO_IO_LOGE("Failed to dpm_context_acquire_restriction_policy()"); - dpm_context_destroy(dpm_ctx_h); - } else - AUDIO_IO_LOGE("Failed to dpm_context_create()"); + if ((dpm_h = dpm_manager_create())) { + /* state: 0(disallowed), 1(allowed) */ + if ((ret = dpm_restriction_get_microphone_state(dpm_h, &state))) + AUDIO_IO_LOGE("Failed to dpm_restriction_get_microphone_state(), ret(0x%x)", ret); + dpm_manager_destroy(dpm_h); + AUDIO_IO_LOGD("microphone restriction state: %d(1:allowed, 0:disallowed)", state); + } else { + AUDIO_IO_LOGE("Failed to dpm_manager_create()"); + } #endif return (state ? false : true); } +//LCOV_EXCL_STOP void CPulseAudioClient::__streamStateChangeCb(pa_stream* s, void* user_data) { assert(s); assert(user_data); - CPulseAudioClient* pClient = static_cast(user_data); + auto pClient = static_cast(user_data); switch (pa_stream_get_state(s)) { case PA_STREAM_READY: AUDIO_IO_LOGD("The stream is ready"); pClient->__mpListener->onStateChanged(CAudioInfo::EAudioIOState::AUDIO_IO_STATE_RUNNING); + if (pClient->__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) + pClient->__mIsFirstStream = true; + pClient->__mIsInit = true; pa_threaded_mainloop_signal(pClient->__mpMainloop, 0); break; case PA_STREAM_FAILED: +//LCOV_EXCL_START AUDIO_IO_LOGD("The stream is failed"); pClient->__mpListener->onStateChanged(CAudioInfo::EAudioIOState::AUDIO_IO_STATE_IDLE, __is_microphone_restricted()); pa_threaded_mainloop_signal(pClient->__mpMainloop, 0); break; +//LCOV_EXCL_STOP case PA_STREAM_TERMINATED: AUDIO_IO_LOGD("The stream is terminated"); @@ -148,63 +150,141 @@ void CPulseAudioClient::__streamCaptureCb(pa_stream* s, size_t length, void* use assert(s); assert(user_data); - CPulseAudioClient* pClient = static_cast(user_data); + auto pClient = static_cast(user_data); assert(pClient->__mpListener); assert(pClient->__mpMainloop); - if (pClient->__mIsUsedSyncRead == true) { + if (pClient->__mIsUsedSyncRead) pa_threaded_mainloop_signal(pClient->__mpMainloop, 0); - } pClient->__mpListener->onStream(pClient, length); } +#ifndef DISABLE_MOBILE_BACK_COMP +static void __dummy_write(pa_stream* s, size_t length) { + char* dummy = new char[length]; + memset(dummy, 0, length); + pa_stream_write(s, dummy, length, NULL, 0LL, PA_SEEK_RELATIVE); + delete [] dummy; +} +#endif + void CPulseAudioClient::__streamPlaybackCb(pa_stream* s, size_t length, void* user_data) { assert(s); assert(user_data); - CPulseAudioClient* pClient = static_cast(user_data); + auto pClient = static_cast(user_data); assert(pClient->__mpListener); - if (pClient->__mIsInit == false) { - AUDIO_IO_LOGD("Occurred this listener when an out stream is on the way to create : Write dummy, length[%d]", length); - - char* dummy = new char[length]; - memset(dummy, 0, length); - pa_stream_write(s, dummy, length, NULL, 0LL, PA_SEEK_RELATIVE); - delete [] dummy; - +#ifndef DISABLE_MOBILE_BACK_COMP + if (!pClient->__mIsInit) { + AUDIO_IO_LOGD("Occurred this listener when an out stream is on the way to create : Write dummy, length[%zu]", length); + __dummy_write(s, length); return; } + if (pClient->isCorked()) { + AUDIO_IO_LOGD("Occurred this listener when an out stream is CORKED : Write dummy, length[%zu]", length); + __dummy_write(s, length); + return; + } +#endif pClient->__mpListener->onStream(pClient, length); + +#ifndef DISABLE_MOBILE_BACK_COMP + /* If stream is not written in first callback during prepare, + then write dummy data to ensure the start */ + if (pClient->__mSpec.getStreamLatency() == CPulseStreamSpec::EStreamLatency::STREAM_LATENCY_OUTPUT_DEFAULT_ASYNC && + pClient->__mIsFirstStream) { + AUDIO_IO_LOGW("[async] Write dummy of length[%zu] since not written in first callback during prepare", length); + __dummy_write(s, length); + pClient->__mIsFirstStream = false; + } +#endif } void CPulseAudioClient::__streamLatencyUpdateCb(pa_stream* s, void* user_data) { assert(s); assert(user_data); - CPulseAudioClient* pClient = static_cast(user_data); + auto pClient = static_cast(user_data); pa_threaded_mainloop_signal(pClient->__mpMainloop, 0); } +void CPulseAudioClient::__streamStartedCb(pa_stream* s, void* user_data) { + assert(s); + assert(user_data); + + auto pClient = static_cast(user_data); + + AUDIO_IO_LOGD("stream %p started.", pClient); + + pClient->__mIsStarted = true; +} + +void CPulseAudioClient::__streamUnderflowCb(pa_stream* s, void* user_data) { + assert(s); + assert(user_data); + + auto pClient = static_cast(user_data); + + AUDIO_IO_LOGD("stream %p UnderFlow...", pClient); + + pClient->__mIsStarted = false; +} + +//LCOV_EXCL_START +void CPulseAudioClient::__streamEventCb(pa_stream* s, const char *name, pa_proplist *pl, void *user_data) { + assert(s); + assert(user_data); + + AUDIO_IO_LOGE("NAME : %s, Prop : %p", name, pl); + + auto pClient = static_cast(user_data); + if (strcmp(name, PA_STREAM_EVENT_POP_TIMEOUT) == 0) + pa_operation_unref(pa_stream_cork(pClient->__mpStream, 1, NULL, NULL)); +} +//LCOV_EXCL_STOP + void CPulseAudioClient::__successStreamCb(pa_stream* s, int success, void* user_data) { AUDIO_IO_LOGD("pa_stream[%p], success[%d], user_data[%p]", s, success, user_data); assert(s); assert(user_data); - CPulseAudioClient* pClient = static_cast(user_data); + auto pClient = static_cast(user_data); pClient->__mIsOperationSuccess = static_cast(success); pa_threaded_mainloop_signal(pClient->__mpMainloop, 0); } -void CPulseAudioClient::initialize() throw(CAudioError) { - AUDIO_IO_LOGD(""); - if (__mIsInit == true) { +//LCOV_EXCL_START +void CPulseAudioClient::__successDrainCbInThread(pa_stream* s, int success, void* user_data) { + AUDIO_IO_LOGD("pa_stream[%p], success[%d], user_data[%p]", s, success, user_data); + assert(s); + assert(user_data); + + auto pClient = static_cast(user_data); + pClient->__mIsOperationSuccess = static_cast(success); + pClient->__mIsDraining = false; +} +//LCOV_EXCL_STOP + +void CPulseAudioClient::__successDrainCb(pa_stream* s, int success, void* user_data) { + AUDIO_IO_LOGD("pa_stream[%p], success[%d], user_data[%p]", s, success, user_data); + assert(s); + assert(user_data); + + auto pClient = static_cast(user_data); + pClient->__mIsOperationSuccess = static_cast(success); + pClient->__mIsDraining = false; + + pa_threaded_mainloop_signal(pClient->__mpMainloop, 0); +} + +void CPulseAudioClient::initialize() { + if (__mIsInit) return; - } int ret = 0; int err = 0; @@ -212,44 +292,36 @@ void CPulseAudioClient::initialize() throw(CAudioError) { try { // Allocates PA proplist __mpPropList = pa_proplist_new(); - if (__mpPropList == NULL) { - THROW_ERROR_MSG(CAudioError::EError::ERROR_OUT_OF_MEMORY, "Failed pa_proplist_new()"); - } + if (!__mpPropList) + THROW_ERROR_MSG(CAudioError::EError::ERROR_OUT_OF_MEMORY, "Failed pa_proplist_new()"); //LCOV_EXCL_LINE // Adds values on proplist for delivery to PULSEAUDIO - char *streamType = NULL; - CAudioInfo::EAudioType audioType = __mSpec.getAudioInfo().getAudioType(); - __mSpec.getAudioInfo().convertAudioType2StreamType(audioType, &streamType); - pa_proplist_sets(__mpPropList, PA_PROP_MEDIA_ROLE, streamType); + pa_proplist_sets(__mpPropList, PA_PROP_MEDIA_ROLE, __mSpec.getAudioInfo().getConvertedStreamType()); int index = __mSpec.getAudioInfo().getAudioIndex(); - if (index >= 0) { + if (index >= 0) pa_proplist_setf(__mpPropList, PA_PROP_MEDIA_PARENT_ID, "%u", (unsigned int) index); - } // Adds latency on proplist for delivery to PULSEAUDIO - AUDIO_IO_LOGD("LATENCY : %s[%d]", __mSpec.getStreamLatencyToString(), __mSpec.getStreamLatency()); + AUDIO_IO_LOGD("LATENCY : %s[%d]", __mSpec.getStreamLatencyToString(), static_cast(__mSpec.getStreamLatency())); pa_proplist_setf(__mpPropList, PA_PROP_MEDIA_TIZEN_AUDIO_LATENCY, "%s", __mSpec.getStreamLatencyToString()); // Allocates PA mainloop __mpMainloop = pa_threaded_mainloop_new(); - if (__mpMainloop == NULL) { - THROW_ERROR_MSG(CAudioError::EError::ERROR_OUT_OF_MEMORY, "Failed pa_threaded_mainloop_new()"); - } + if (!__mpMainloop) + THROW_ERROR_MSG(CAudioError::EError::ERROR_OUT_OF_MEMORY, "Failed pa_threaded_mainloop_new()"); //LCOV_EXCL_LINE // Allocates PA context __mpContext = pa_context_new(pa_threaded_mainloop_get_api(__mpMainloop), CLIENT_NAME); - if (__mpContext == NULL) { - THROW_ERROR_MSG(CAudioError::EError::ERROR_OUT_OF_MEMORY, "Failed pa_context_new()"); - } + if (!__mpContext) + THROW_ERROR_MSG(CAudioError::EError::ERROR_OUT_OF_MEMORY, "Failed pa_context_new()"); //LCOV_EXCL_LINE // Sets context state changed callback pa_context_set_state_callback(__mpContext, __contextStateChangeCb, this); // Connects this client with PA server - if (pa_context_connect(__mpContext, NULL, PA_CONTEXT_NOFLAGS, NULL) < 0) { - THROW_ERROR_MSG(CAudioError::EError::ERROR_OUT_OF_MEMORY, "Failed pa_context_connect()"); - } + if (pa_context_connect(__mpContext, NULL, PA_CONTEXT_NOFLAGS, NULL) < 0) + THROW_ERROR_MSG(CAudioError::EError::ERROR_OUT_OF_MEMORY, "Failed pa_context_connect()"); //LCOV_EXCL_LINE // LOCK for synchronous connection pa_threaded_mainloop_lock(__mpMainloop); @@ -257,7 +329,7 @@ void CPulseAudioClient::initialize() throw(CAudioError) { // Start mainloop if (pa_threaded_mainloop_start(__mpMainloop) < 0) { pa_threaded_mainloop_unlock(__mpMainloop); - THROW_ERROR_MSG(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_threaded_mainloop_start()"); + THROW_ERROR_MSG(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_threaded_mainloop_start()"); //LCOV_EXCL_LINE } // Connection process is asynchronously @@ -267,14 +339,15 @@ void CPulseAudioClient::initialize() throw(CAudioError) { pa_context_state_t state; state = pa_context_get_state(__mpContext); - if (state == PA_CONTEXT_READY) { + if (state == PA_CONTEXT_READY) break; - } if (!PA_CONTEXT_IS_GOOD(state)) { +//LCOV_EXCL_START err = pa_context_errno(__mpContext); pa_threaded_mainloop_unlock(__mpMainloop); THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INTERNAL_OPERATION, "pa_context's state is not good : err[%d]", err); +//LCOV_EXCL_STOP } /* Wait until the context is ready */ @@ -286,9 +359,11 @@ void CPulseAudioClient::initialize() throw(CAudioError) { pa_channel_map map = __mSpec.getChannelMap(); __mpStream = pa_stream_new_with_proplist(__mpContext, __mSpec.getStreamName(), &ss, &map, __mpPropList); - if (__mpStream == NULL) { + if (!__mpStream) { +//LCOV_EXCL_START pa_threaded_mainloop_unlock(__mpMainloop); THROW_ERROR_MSG(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_new_with_proplist()"); +//LCOV_EXCL_STOP } // Sets stream callbacks @@ -296,34 +371,46 @@ void CPulseAudioClient::initialize() throw(CAudioError) { pa_stream_set_read_callback(__mpStream, __streamCaptureCb, this); pa_stream_set_write_callback(__mpStream, __streamPlaybackCb, this); pa_stream_set_latency_update_callback(__mpStream, __streamLatencyUpdateCb, this); + pa_stream_set_event_callback(__mpStream, __streamEventCb, this); + if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) { + pa_stream_set_started_callback(__mpStream, __streamStartedCb, this); + pa_stream_set_underflow_callback(__mpStream, __streamUnderflowCb, this); + } // Connect stream with PA Server if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) { - pa_stream_flags_t flags = static_cast( + auto flags = static_cast( PA_STREAM_INTERPOLATE_TIMING | PA_STREAM_ADJUST_LATENCY | +#ifndef DISABLE_MOBILE_BACK_COMP + PA_STREAM_START_CORKED | +#endif PA_STREAM_AUTO_TIMING_UPDATE); ret = pa_stream_connect_playback(__mpStream, NULL, NULL, flags, NULL, NULL); } else { - pa_stream_flags_t flags = static_cast( + auto flags = static_cast( PA_STREAM_INTERPOLATE_TIMING | PA_STREAM_ADJUST_LATENCY | +#ifndef DISABLE_MOBILE_BACK_COMP + PA_STREAM_START_CORKED | +#endif PA_STREAM_AUTO_TIMING_UPDATE); ret = pa_stream_connect_record(__mpStream, NULL, NULL, flags); } if (ret != 0) { +//LCOV_EXCL_START err = pa_context_errno(__mpContext); pa_threaded_mainloop_unlock(__mpMainloop); THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_connect() : err[%d]", err); +//LCOV_EXCL_STOP } while (true) { - pa_stream_state_t state; - state = pa_stream_get_state(__mpStream); + pa_stream_state_t state = pa_stream_get_state(__mpStream); if (state == PA_STREAM_READY) { AUDIO_IO_LOGD("STREAM READY"); @@ -333,7 +420,10 @@ void CPulseAudioClient::initialize() throw(CAudioError) { if (!PA_STREAM_IS_GOOD(state)) { err = pa_context_errno(__mpContext); pa_threaded_mainloop_unlock(__mpMainloop); - THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INTERNAL_OPERATION, "pa_stream's state is not good : err[%d]", err); + if (err == PA_ERR_ACCESS) + THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_DEVICE_POLICY_RESTRICTION, "pa_stream's state is not good : err[%d]", err); + else + THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INTERNAL_OPERATION, "pa_stream's state is not good : err[%d]", err); //LCOV_EXCL_LINE } /* Wait until the stream is ready */ @@ -343,62 +433,80 @@ void CPulseAudioClient::initialize() throw(CAudioError) { // End of synchronous pa_threaded_mainloop_unlock(__mpMainloop); - __mIsInit = true; - } catch (CAudioError e) { + // __mIsInit = true; // Moved to __streamStateChangeCb() + } catch (const CAudioError& e) { finalize(); - throw e; + throw; } } void CPulseAudioClient::finalize() { AUDIO_IO_LOGD(""); - if (__mIsInit == false) { - return; + + if (__mpMainloop && !isInThread()) + pa_threaded_mainloop_lock(__mpMainloop); + + /* clear callbacks */ + if (__mpStream) { + if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) + pa_stream_set_write_callback(__mpStream, NULL, NULL); + else + pa_stream_set_read_callback(__mpStream, NULL, NULL); + pa_stream_set_latency_update_callback(__mpStream, NULL, NULL); + pa_stream_set_event_callback(__mpStream, NULL, NULL); } - if (__mpMainloop != NULL) { - pa_threaded_mainloop_stop(__mpMainloop); + if (__mpMainloop && !isInThread()) + pa_threaded_mainloop_unlock(__mpMainloop); + + /* Wait for drain complete if draining before finalize */ + if (__mIsDraining) { + unsigned int drain_wait_count = 0; + while (__mIsDraining && drain_wait_count++ < drain_wait_max_count) + usleep(drain_wait_interval); + AUDIO_IO_LOGD("wait for drain complete!!!! [%d * %d usec]", + drain_wait_count, drain_wait_interval); } - if (__mpStream != NULL) { + if (__mpMainloop) + pa_threaded_mainloop_stop(__mpMainloop); + + if (__mpStream) { pa_stream_disconnect(__mpStream); pa_stream_unref(__mpStream); - __mpStream = NULL; + __mpStream = nullptr; } - if (__mpContext != NULL) { + if (__mpContext) { pa_context_disconnect(__mpContext); pa_context_unref(__mpContext); - __mpContext = NULL; + __mpContext = nullptr; } - if (__mpMainloop != NULL) { + if (__mpMainloop) { pa_threaded_mainloop_free(__mpMainloop); - __mpMainloop = NULL; + __mpMainloop = nullptr; } - if (__mpPropList != NULL) { + if (__mpPropList) { pa_proplist_free(__mpPropList); - __mpPropList = NULL; + __mpPropList = nullptr; } __mIsInit = false; } -int CPulseAudioClient::read(void* buffer, size_t length) throw(CAudioError) { - if (__mIsInit == false) { +int CPulseAudioClient::read(void* buffer, size_t length) { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } checkRunningState(); - if (buffer == NULL) { + if (!buffer) THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT, "The parameter is invalid : buffer[%p]", buffer); - } - if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) { + if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_SUPPORTED, "The Playback client couldn't use this function"); - } size_t lengthIter = length; int ret = 0; @@ -411,37 +519,31 @@ int CPulseAudioClient::read(void* buffer, size_t length) throw(CAudioError) { while (lengthIter > 0) { size_t l; - while (__mpSyncReadDataPtr == NULL) { + while (!__mpSyncReadDataPtr) { ret = pa_stream_peek(__mpStream, &__mpSyncReadDataPtr, &__mSyncReadLength); - if (ret != 0) { + if (ret != 0) THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INTERNAL_OPERATION, "Failed pa_stream_peek() : ret[%d]", ret); - } if (__mSyncReadLength <= 0) { #ifdef _AUDIO_IO_DEBUG_TIMING_ - AUDIO_IO_LOGD("readLength(%d byte) is not valid. wait...", __mSyncReadLength); + AUDIO_IO_LOGD("readLength(%zu byte) is not valid. wait...", __mSyncReadLength); #endif pa_threaded_mainloop_wait(__mpMainloop); - } else if (__mpSyncReadDataPtr == NULL) { + } else if (!__mpSyncReadDataPtr) { // Data peeked, but it doesn't have any data ret = pa_stream_drop(__mpStream); - if (ret != 0) { - THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INTERNAL_OPERATION, "Failed pa_stream_drop() : ret[%d]", ret); - } + if (ret != 0) + THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INTERNAL_OPERATION, "Failed pa_stream_drop() : ret[%d]", ret); //LCOV_EXCL_LINE } else { __mSyncReadIndex = 0; } } - if (__mSyncReadLength < lengthIter) { - l = __mSyncReadLength; - } else { - l = lengthIter; - } + l = min(__mSyncReadLength, lengthIter); // Copy partial pcm data on out parameter #ifdef _AUDIO_IO_DEBUG_TIMING_ - AUDIO_IO_LOGD("memcpy() that a peeked buffer[%], index[%d], length[%d] on out buffer", (const uint8_t*)(__mpSyncReadDataPtr) + __mSyncReadIndex, __mSyncReadIndex, l); + AUDIO_IO_LOGD("memcpy() that a peeked buffer[%p], index[%zu], length[%zu] on out buffer", (const uint8_t*)(__mpSyncReadDataPtr) + __mSyncReadIndex, __mSyncReadIndex, l); #endif memcpy(buffer, (const uint8_t*)__mpSyncReadDataPtr + __mSyncReadIndex, l); @@ -458,12 +560,11 @@ int CPulseAudioClient::read(void* buffer, size_t length) throw(CAudioError) { AUDIO_IO_LOGD("__mSyncReadLength is zero, do drop()"); #endif ret = pa_stream_drop(__mpStream); - if (ret != 0) { - THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INTERNAL_OPERATION, "Failed pa_stream_drop() : ret[%d]", ret); - } + if (ret != 0) + THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INTERNAL_OPERATION, "Failed pa_stream_drop() : ret[%d]", ret); //LCOV_EXCL_LINE // Reset the internal pointer - __mpSyncReadDataPtr = NULL; + __mpSyncReadDataPtr = nullptr; __mSyncReadLength = 0; __mSyncReadIndex = 0; } @@ -471,33 +572,30 @@ int CPulseAudioClient::read(void* buffer, size_t length) throw(CAudioError) { pa_threaded_mainloop_unlock(__mpMainloop); __mIsUsedSyncRead = false; - } catch (CAudioError e) { + } catch (const CAudioError& e) { pa_threaded_mainloop_unlock(__mpMainloop); __mIsUsedSyncRead = false; - throw e; + throw; } return length; } -int CPulseAudioClient::peek(const void** buffer, size_t* length) throw(CAudioError) { - if (__mIsInit == false) { +int CPulseAudioClient::peek(const void** buffer, size_t* length) { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } checkRunningState(); - if (buffer == NULL || length == NULL) { + if (!buffer || !length) THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_ARGUMENT, "The parameter is invalid : buffer[%p], length[%p]", buffer, length); - } - if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) { + if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_SUPPORTED, "The Playback client couldn't use this function"); - } int ret = 0; - if (isInThread() == false) { + if (!isInThread()) { pa_threaded_mainloop_lock(__mpMainloop); ret = pa_stream_peek(__mpStream, buffer, length); pa_threaded_mainloop_unlock(__mpMainloop); @@ -506,20 +604,18 @@ int CPulseAudioClient::peek(const void** buffer, size_t* length) throw(CAudioErr } #ifdef _AUDIO_IO_DEBUG_TIMING_ - AUDIO_IO_LOGD("buffer[%p], length[%d]", *buffer, *length); + AUDIO_IO_LOGD("buffer[%p], length[%zu]", *buffer, *length); #endif - if (ret < 0) { - THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_peek() : err[%d]", ret); - } + if (ret < 0) + THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_peek() : err[%d]", ret); //LCOV_EXCL_LINE return ret; } -int CPulseAudioClient::drop() throw(CAudioError) { - if (__mIsInit == false) { +int CPulseAudioClient::drop() { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } #ifdef _AUDIO_IO_DEBUG_TIMING_ AUDIO_IO_LOGD(""); @@ -527,13 +623,12 @@ int CPulseAudioClient::drop() throw(CAudioError) { checkRunningState(); - if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) { + if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_SUPPORTED, "The Playback client couldn't use this function"); - } int ret = 0; - if (isInThread() == false) { + if (!isInThread()) { pa_threaded_mainloop_lock(__mpMainloop); ret = pa_stream_drop(__mpStream); pa_threaded_mainloop_unlock(__mpMainloop); @@ -541,83 +636,97 @@ int CPulseAudioClient::drop() throw(CAudioError) { ret = pa_stream_drop(__mpStream); } - if (ret < 0) { - THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_drop() : err[%d]", ret); - } + if (ret < 0) + THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_drop() : err[%d]", ret); //LCOV_EXCL_LINE return ret; } -int CPulseAudioClient::write(const void* data, size_t length) throw(CAudioError) { - if (__mIsInit == false) { - THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } - - checkRunningState(); - - if (data == NULL) { +int CPulseAudioClient::write(const void* data, size_t length) { + if (!data) THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_ARGUMENT, "The parameter is invalid"); - } - if (__mDirection == EStreamDirection::STREAM_DIRECTION_RECORD) { + if (__mDirection == EStreamDirection::STREAM_DIRECTION_RECORD) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_SUPPORTED, "The Playback client couldn't use this function"); - } int ret = 0; #ifdef _AUDIO_IO_DEBUG_TIMING_ - AUDIO_IO_LOGD("data[%p], length[%d]", data, length); + AUDIO_IO_LOGD("data[%p], length[%zu], First[%d]", data, length, __mIsFirstStream); #endif - if (isInThread() == false) { + if (!isInThread()) { pa_threaded_mainloop_lock(__mpMainloop); + if (pa_stream_is_corked(__mpStream)) { + AUDIO_IO_LOGW("stream is corked...do uncork here first!!!!"); + pa_operation_unref(pa_stream_cork(__mpStream, 0, NULL, this)); + } + ret = pa_stream_write(__mpStream, data, length, NULL, 0LL, PA_SEEK_RELATIVE); pa_threaded_mainloop_unlock(__mpMainloop); } else { + if (pa_stream_is_corked(__mpStream)) { + AUDIO_IO_LOGW("stream is corked...do uncork here first!!!!"); + pa_operation_unref(pa_stream_cork(__mpStream, 0, NULL, this)); + } + + if (__mIsFirstStream) { + const pa_buffer_attr* attr = pa_stream_get_buffer_attr(__mpStream); + uint32_t prebuf = attr->prebuf; + // Compensate amount of prebuf in first stream callback when audio-io use prebuf(-1) + // Because a stream will never start when an application wrote less than prebuf at first + if (length < prebuf) { + char* dummy = new char[prebuf - length]; + memset(dummy, 0, prebuf - length); + pa_stream_write(__mpStream, dummy, prebuf - length, NULL, 0LL, PA_SEEK_RELATIVE); + delete [] dummy; + } + __mIsFirstStream = false; + AUDIO_IO_LOGW("FIRST STREAM CALLBACK : length[%zu], prebuf[%d], dummy[%zu]", + length, prebuf, (length < prebuf) ? prebuf - length : 0); + } ret = pa_stream_write(__mpStream, data, length, NULL, 0LL, PA_SEEK_RELATIVE); } - if (ret < 0) { - THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_write() : err[%d]", ret); - } + if (ret < 0) + THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_write() : err[%d]", ret); //LCOV_EXCL_LINE return ret; } -void CPulseAudioClient::cork(bool cork) throw(CAudioError) { +void CPulseAudioClient::cork(bool cork) { AUDIO_IO_LOGD("cork[%d]", cork); - if (__mIsInit == false) { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } - if (isInThread() == true) { + if (isInThread()) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_SUPPORTED, "This operation is not supported in callback"); - } checkRunningState(); - if (isInThread() == false) { + // Set __mIsFirstStream flag when uncork(resume) stream, because prebuf will be enable again + if (!cork) + __mIsFirstStream = true; + + if (!isInThread()) { pa_threaded_mainloop_lock(__mpMainloop); pa_operation_unref(pa_stream_cork(__mpStream, static_cast(cork), __successStreamCb, this)); pa_threaded_mainloop_unlock(__mpMainloop); } else { pa_operation_unref(pa_stream_cork(__mpStream, static_cast(cork), __successStreamCb, this)); } - - return; } -bool CPulseAudioClient::isCorked() throw(CAudioError) { - if (__mIsInit == false) { +bool CPulseAudioClient::isCorked() { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } checkRunningState(); int isCork = 0; - if (isInThread() == false) { + if (!isInThread()) { pa_threaded_mainloop_lock(__mpMainloop); isCork = pa_stream_is_corked(__mpStream); pa_threaded_mainloop_unlock(__mpMainloop); @@ -625,64 +734,84 @@ bool CPulseAudioClient::isCorked() throw(CAudioError) { isCork = pa_stream_is_corked(__mpStream); } +#ifdef _AUDIO_IO_DEBUG_TIMING_ AUDIO_IO_LOGD("isCork[%d]", isCork); +#endif return static_cast(isCork); } -bool CPulseAudioClient::drain() throw(CAudioError) { - AUDIO_IO_LOGD("drain"); - - if (__mIsInit == false) { +bool CPulseAudioClient::drain() { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } checkRunningState(); - if (isInThread() == false) { + if (isCorked()) { + AUDIO_IO_LOGW("Corked..."); + return true; + } + + if (__mIsDraining) { + AUDIO_IO_LOGW("already draining..."); + return true; + } + + if (!__mIsStarted) { + AUDIO_IO_LOGW("stream not started yet...skip drain"); + return true; + } + + if (!isInThread()) { + AUDIO_IO_LOGD("drain"); pa_threaded_mainloop_lock(__mpMainloop); - pa_operation_unref(pa_stream_drain(__mpStream, __successStreamCb, this)); + pa_operation* o = pa_stream_drain(__mpStream, __successDrainCb, this); + __mIsDraining = true; + while (pa_operation_get_state(o) == PA_OPERATION_RUNNING) + pa_threaded_mainloop_wait(__mpMainloop); + + pa_operation_unref(o); pa_threaded_mainloop_unlock(__mpMainloop); + AUDIO_IO_LOGD("drain done"); } else { - pa_operation_unref(pa_stream_drain(__mpStream, __successStreamCb, this)); + AUDIO_IO_LOGD("drain in thread"); + pa_operation_unref(pa_stream_drain(__mpStream, __successDrainCbInThread, this)); + __mIsDraining = true; } return true; } -bool CPulseAudioClient::flush() throw(CAudioError) { - AUDIO_IO_LOGD("flush"); - - if (__mIsInit == false) { +bool CPulseAudioClient::flush() { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } checkRunningState(); - if (isInThread() == false) { + if (!isInThread()) { + AUDIO_IO_LOGD("flush"); pa_threaded_mainloop_lock(__mpMainloop); pa_operation_unref(pa_stream_flush(__mpStream, __successStreamCb, this)); pa_threaded_mainloop_unlock(__mpMainloop); } else { + AUDIO_IO_LOGD("flush in thread"); pa_operation_unref(pa_stream_flush(__mpStream, __successStreamCb, this)); } return true; } -size_t CPulseAudioClient::getWritableSize() throw(CAudioError) { - if (__mIsInit == false) { +size_t CPulseAudioClient::getWritableSize() { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } checkRunningState(); - if (__mDirection != EStreamDirection::STREAM_DIRECTION_PLAYBACK) { + if (__mDirection != EStreamDirection::STREAM_DIRECTION_PLAYBACK) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_SUPPORTED, "This client is used for Playback"); - } size_t ret = 0; - if (isInThread() == false) { + if (!isInThread()) { pa_threaded_mainloop_lock(__mpMainloop); ret = pa_stream_writable_size(__mpStream); pa_threaded_mainloop_unlock(__mpMainloop); @@ -693,31 +822,22 @@ size_t CPulseAudioClient::getWritableSize() throw(CAudioError) { return ret; } -void CPulseAudioClient::checkRunningState() throw(CAudioError) { - if (__mIsInit == false) { - THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } - - if (__mpContext == NULL || PA_CONTEXT_IS_GOOD(pa_context_get_state(__mpContext)) == 0) { +void CPulseAudioClient::checkRunningState() { + if (!__mpContext || !PA_CONTEXT_IS_GOOD(pa_context_get_state(__mpContext))) THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_NOT_INITIALIZED, "The context[%p] is not created or not good state", __mpContext); - } - if (__mpStream == NULL || PA_STREAM_IS_GOOD(pa_stream_get_state(__mpStream)) == 0) { + + if (!__mpStream || !PA_STREAM_IS_GOOD(pa_stream_get_state(__mpStream))) THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_NOT_INITIALIZED, "The stream[%p] is not created or not good state", __mpStream); - } - if (pa_context_get_state(__mpContext) != PA_CONTEXT_READY || pa_stream_get_state(__mpStream) != PA_STREAM_READY) { + + if (pa_context_get_state(__mpContext) != PA_CONTEXT_READY || pa_stream_get_state(__mpStream) != PA_STREAM_READY) THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_NOT_INITIALIZED, "The context[%p] or stream[%p] state is not ready", __mpContext, __mpStream); - } #ifdef _AUDIO_IO_DEBUG_TIMING_ AUDIO_IO_LOGD("This client is running"); #endif } -bool CPulseAudioClient::isInThread() throw(CAudioError) { - if (__mIsInit == false) { - THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } - +bool CPulseAudioClient::isInThread() noexcept { int ret = pa_threaded_mainloop_in_thread(__mpMainloop); #ifdef _AUDIO_IO_DEBUG_TIMING_ @@ -726,22 +846,21 @@ bool CPulseAudioClient::isInThread() throw(CAudioError) { return static_cast(ret); } -size_t CPulseAudioClient::getReadableSize() throw(CAudioError) { - if (__mIsInit == false) { +//LCOV_EXCL_START +size_t CPulseAudioClient::getReadableSize() { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } checkRunningState(); - if (__mDirection != EStreamDirection::STREAM_DIRECTION_RECORD) { + if (__mDirection != EStreamDirection::STREAM_DIRECTION_RECORD) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_SUPPORTED, "This client is used for Capture"); - } size_t ret = 0; - if (isInThread() == false) { + if (!isInThread()) { pa_threaded_mainloop_lock(__mpMainloop); - ret = pa_stream_writable_size(__mpStream); + ret = pa_stream_readable_size(__mpStream); pa_threaded_mainloop_unlock(__mpMainloop); } else { ret = pa_stream_writable_size(__mpStream); @@ -750,63 +869,57 @@ size_t CPulseAudioClient::getReadableSize() throw(CAudioError) { return ret; } -size_t CPulseAudioClient::getBufferSize() throw(CAudioError) { - if (__mIsInit == false) { +size_t CPulseAudioClient::getBufferSize() { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } checkRunningState(); size_t ret = 0; try { - if (isInThread() == false) { + if (!isInThread()) pa_threaded_mainloop_lock(__mpMainloop); - } const pa_buffer_attr* attr = pa_stream_get_buffer_attr(__mpStream); - if (attr == NULL) { + if (!attr) { int _err = pa_context_errno(__mpContext); THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_get_buffer_attr() : err[%d]", _err); } if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) { ret = attr->tlength; - AUDIO_IO_LOGD("PLAYBACK buffer size[%d]", ret); + AUDIO_IO_LOGD("PLAYBACK buffer size[%zu]", ret); } else { ret = attr->fragsize; - AUDIO_IO_LOGD("RECORD buffer size[%d]", ret); + AUDIO_IO_LOGD("RECORD buffer size[%zu]", ret); } - } catch (CAudioError err) { - if (isInThread() == false) { + } catch (const CAudioError& e) { + if (!isInThread()) pa_threaded_mainloop_unlock(__mpMainloop); - } - throw err; + throw; } - if (isInThread() == false) { + if (!isInThread()) pa_threaded_mainloop_unlock(__mpMainloop); - } return ret; } -pa_usec_t CPulseAudioClient::getLatency() throw(CAudioError) { - if (__mIsInit == false) { +pa_usec_t CPulseAudioClient::getLatency() { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } checkRunningState(); pa_usec_t ret = 0; int negative = 0; - if (isInThread() == false) { + if (!isInThread()) { if (pa_stream_get_latency(__mpStream, &ret, &negative) < 0) { int _err = pa_context_errno(__mpContext); - if (_err != PA_ERR_NODATA) { + if (_err != PA_ERR_NODATA) THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_get_latency() : err[%d]", _err); - } } return negative ? 0 : ret; } @@ -815,21 +928,19 @@ pa_usec_t CPulseAudioClient::getLatency() throw(CAudioError) { try { while (true) { - if (pa_stream_get_latency(__mpStream, &ret, &negative) >= 0) { + if (pa_stream_get_latency(__mpStream, &ret, &negative) >= 0) break; - } int _err = pa_context_errno(__mpContext); - if (_err != PA_ERR_NODATA) { + if (_err != PA_ERR_NODATA) THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_FAILED_OPERATION, "Failed pa_stream_get_latency() : err[%d]", _err); - } /* Wait until latency data is available again */ pa_threaded_mainloop_wait(__mpMainloop); } - } catch (CAudioError e) { + } catch (const CAudioError& e) { pa_threaded_mainloop_unlock(__mpMainloop); - throw e; + throw; } pa_threaded_mainloop_unlock(__mpMainloop); @@ -837,60 +948,47 @@ pa_usec_t CPulseAudioClient::getLatency() throw(CAudioError) { return negative ? 0 : ret; } -pa_usec_t CPulseAudioClient::getFinalLatency() throw(CAudioError) { - if (__mIsInit == false) { +pa_usec_t CPulseAudioClient::getFinalLatency() { + if (!__mIsInit) THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize CPulseAudioClient"); - } checkRunningState(); pa_usec_t ret = 0; - uint32_t ver = 0; try { - if (isInThread() == false) { + if (!isInThread()) pa_threaded_mainloop_lock(__mpMainloop); - } - ver = pa_context_get_server_protocol_version(__mpContext); + uint32_t ver = pa_context_get_server_protocol_version(__mpContext); if (ver >= 13) { const pa_buffer_attr* buffer_attr = pa_stream_get_buffer_attr(__mpStream); const pa_sample_spec* sample_spec = pa_stream_get_sample_spec(__mpStream); const pa_timing_info* timing_info = pa_stream_get_timing_info(__mpStream); - if (buffer_attr == NULL || sample_spec == NULL || timing_info == NULL) { + if (!buffer_attr || !sample_spec || !timing_info) THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_OUT_OF_MEMORY, "Failed to get buffer_attr[%p] or sample_spec[%p] or timing_info[%p] from a pa_stream", buffer_attr, sample_spec, timing_info); - } if (__mDirection == EStreamDirection::STREAM_DIRECTION_PLAYBACK) { ret = (pa_bytes_to_usec(buffer_attr->tlength, sample_spec) + timing_info->configured_sink_usec); - AUDIO_IO_LOGD("FINAL PLAYBACK LATENCY[%d]", ret); + AUDIO_IO_LOGD("FINAL PLAYBACK LATENCY[%" PRIu64 "]", ret); } else { ret = (pa_bytes_to_usec(buffer_attr->fragsize, sample_spec) + timing_info->configured_source_usec); - AUDIO_IO_LOGD("FINAL RECORD LATENCY[%d]", ret); + AUDIO_IO_LOGD("FINAL RECORD LATENCY[%" PRIu64 "]", ret); } } else { THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_NOT_SUPPORTED, "This version(ver.%d) is not supported", ver); } - if (isInThread() == false) { + if (!isInThread()) pa_threaded_mainloop_unlock(__mpMainloop); - } - } catch (CAudioError e) { - if (isInThread() == false) { + } catch (const CAudioError& e) { + if (!isInThread()) pa_threaded_mainloop_unlock(__mpMainloop); - } - throw e; + throw; } return ret; } - -CPulseAudioClient::EStreamDirection CPulseAudioClient::getStreamDirection() { - return __mDirection; -} - -CPulseStreamSpec CPulseAudioClient::getStreamSpec() { - return __mSpec; -} +//LCOV_EXCL_STOP