X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=src%2Fcommon%2Fmedia-svc-util.c;h=1db380d93debd09b5997bca617a0e6d3672b971b;hb=refs%2Fchanges%2F81%2F307481%2F4;hp=e6e13c30344b4a988fa60342cba456fbd5fdf3dd;hpb=77b292eb9fd3e3076829765e8cc2d6b8c1dc88f2;p=platform%2Fcore%2Fmultimedia%2Flibmedia-service.git diff --git a/src/common/media-svc-util.c b/src/common/media-svc-util.c index e6e13c3..1db380d 100644 --- a/src/common/media-svc-util.c +++ b/src/common/media-svc-util.c @@ -27,10 +27,9 @@ #include #include #include -#include #include -#include #include +#include #include "media-svc-util.h" #include "media-svc-db-utils.h" #include "media-svc-debug.h" @@ -43,18 +42,15 @@ #include #include -#define MEDIA_SVC_FILE_EXT_LEN_MAX 6 /**< Maximum file ext lenth*/ +#define MEDIA_SVC_FILE_EXT_LEN_MAX 6 #define MUSIC_MIME_NUM 29 #define SOUND_MIME_NUM 2 #define MIME_LENGTH 50 -#define MEDIA_SVC_DEFAULT_FORMAT_LEN 19 #define IMAGE_PREFIX "image/" -#define IMAGE_PREFIX_LEN 6 #define AUDIO_PREFIX "audio/" -#define AUDIO_PREFIX_LEN 6 #define VIDEO_PREFIX "video/" -#define VIDEO_PREFIX_LEN 6 +#define PREFIX_LEN 6 #define MEDIA_SVC_PDF_TAG_TAIL_LEN 12 #define MEDIA_SVC_PDF_BUF_SIZE 256 @@ -101,7 +97,6 @@ static const char music_mime_table[MUSIC_MIME_NUM][MIME_LENGTH] = { "x-ape", "x-ms-asx", "vnd.rn-realaudio", - "x-vorbis", /*alias of audio/x-vorbis+ogg*/ "vorbis", /*alias of audio/x-vorbis+ogg*/ "x-oggflac", @@ -174,36 +169,36 @@ static int __media_svc_get_media_type(const char *path, const char *mime_type, m media_svc_retvm_if(!media_type, MS_MEDIA_ERR_INVALID_PARAMETER, "media_type is null"); /* Image */ - if (strncmp(mime_type, IMAGE_PREFIX, IMAGE_PREFIX_LEN) == 0) { + if (strncmp(mime_type, IMAGE_PREFIX, PREFIX_LEN) == 0) { *media_type = MEDIA_SVC_MEDIA_TYPE_IMAGE; return MS_MEDIA_ERR_NONE; } /* Audio */ - if (strncmp(mime_type, AUDIO_PREFIX, AUDIO_PREFIX_LEN) == 0) { + if (strncmp(mime_type, AUDIO_PREFIX, PREFIX_LEN) == 0) { *media_type = MEDIA_SVC_MEDIA_TYPE_SOUND; for (idx = 0; idx < MUSIC_MIME_NUM; idx++) { - if (strcmp(mime_type + AUDIO_PREFIX_LEN, music_mime_table[idx]) == 0) { + if (strcmp(mime_type + PREFIX_LEN, music_mime_table[idx]) == 0) { *media_type = MEDIA_SVC_MEDIA_TYPE_MUSIC; break; } } /* audio/x-mpegurl : .m3u file (playlist file) */ - if (strcmp(mime_type + AUDIO_PREFIX_LEN, "x-mpegurl") == 0) + if (strcmp(mime_type + PREFIX_LEN, "x-mpegurl") == 0) *media_type = MEDIA_SVC_MEDIA_TYPE_OTHER; return MS_MEDIA_ERR_NONE; } /* Video */ - if (strncmp(mime_type, VIDEO_PREFIX, VIDEO_PREFIX_LEN) == 0) { + if (strncmp(mime_type, VIDEO_PREFIX, PREFIX_LEN) == 0) { *media_type = MEDIA_SVC_MEDIA_TYPE_VIDEO; /*some video files don't have video stream. in this case it is categorize as music. */ - if (strcmp(mime_type + VIDEO_PREFIX_LEN, "3gpp") == 0 || - strcmp(mime_type + VIDEO_PREFIX_LEN, "mp4") == 0) { + if (strcmp(mime_type + PREFIX_LEN, "3gpp") == 0 || + strcmp(mime_type + PREFIX_LEN, "mp4") == 0) { if (mm_file_get_stream_info(path, &audio, &video) == FILEINFO_ERROR_NONE) { if (audio > 0 && video == 0) *media_type = MEDIA_SVC_MEDIA_TYPE_MUSIC; @@ -259,7 +254,7 @@ static bool __media_svc_get_file_ext(const char *file_path, char *file_ext) for (i = strlen(file_path); i >= 0; i--) { if (file_path[i] == '.') { - SAFE_STRLCPY(file_ext, &file_path[i + 1], MEDIA_SVC_FILE_EXT_LEN_MAX); + g_strlcpy(file_ext, &file_path[i + 1], MEDIA_SVC_FILE_EXT_LEN_MAX); return true; } @@ -269,25 +264,6 @@ static bool __media_svc_get_file_ext(const char *file_path, char *file_ext) return false; } -static int __media_svc_safe_atoi(char *buffer, int *si) -{ - char *end = NULL; - errno = 0; - media_svc_retvm_if(buffer == NULL || si == NULL, MS_MEDIA_ERR_INTERNAL, "invalid parameter"); - - const long sl = strtol(buffer, &end, 10); - - media_svc_retvm_if(end == buffer, MS_MEDIA_ERR_INTERNAL, "not a decimal number"); - media_svc_retvm_if('\0' != *end, MS_MEDIA_ERR_INTERNAL, "extra characters at end of input: %s", end); - media_svc_retvm_if((LONG_MIN == sl || LONG_MAX == sl) && (ERANGE == errno), MS_MEDIA_ERR_INTERNAL, "out of range of type long"); - media_svc_retvm_if(sl > INT_MAX, MS_MEDIA_ERR_INTERNAL, "greater than INT_MAX"); - media_svc_retvm_if(sl < INT_MIN, MS_MEDIA_ERR_INTERNAL, "less than INT_MIN"); - - *si = (int)sl; - - return MS_MEDIA_ERR_NONE; -} - static int __media_svc_save_image(unsigned char *image, unsigned int size, char *image_path, uid_t uid) { int ret = MS_MEDIA_ERR_NONE; @@ -318,22 +294,18 @@ static int __media_svc_save_image(unsigned char *image, unsigned int size, char return MS_MEDIA_ERR_NONE; } -static char *__media_svc_get_title_from_filepath(const char *path) +static char *__media_svc_get_title_from_filename(const char *filename) { - char *filename = NULL; char *title = NULL; char *last_dot = NULL; - media_svc_retvm_if(!STRING_VALID(path), NULL, "Invalid path"); - - filename = g_path_get_basename(path); + media_svc_retvm_if(!STRING_VALID(filename), g_strdup(MEDIA_SVC_TAG_UNKNOWN), "Invalid path"); last_dot = strrchr(filename, '.'); if (last_dot) { title = g_strndup(filename, last_dot - filename); - g_free(filename); } else { - title = filename; + title = g_strdup(filename); } media_svc_debug("extract title is [%s]", title); @@ -370,12 +342,12 @@ static int __media_svc_get_thumbnail_path(char *thumb_path, const char *pathname if (img_format) { /* 'img_format' is mime-type */ - if (!g_str_has_prefix(img_format, IMAGE_PREFIX) || strlen(img_format) == IMAGE_PREFIX_LEN) { + if (!g_str_has_prefix(img_format, IMAGE_PREFIX) || strlen(img_format) == PREFIX_LEN) { media_svc_error("Not proper img format"); return MS_MEDIA_ERR_INTERNAL; } - snprintf(thumb_path, MEDIA_SVC_PATHNAME_SIZE, "%s/.%s-%s.%s", thumb_dir, file_ext, hash, img_format + IMAGE_PREFIX_LEN); + snprintf(thumb_path, MEDIA_SVC_PATHNAME_SIZE, "%s/.%s-%s.%s", thumb_dir, file_ext, hash, img_format + PREFIX_LEN); } else { if (strcasecmp(file_ext, "PNG") == 0) snprintf(thumb_path, MEDIA_SVC_PATHNAME_SIZE, "%s/.%s-%s.png", thumb_dir, file_ext, hash); @@ -454,12 +426,11 @@ int _media_svc_set_media_info(media_svc_content_info_s *content_info, const char return MS_MEDIA_ERR_NONE; } -static char * __media_svc_get_title(MMHandleType tag, const char *path) +static char * __media_svc_get_title(MMHandleType tag, const char *filename) { int ret = FILEINFO_ERROR_NONE; char *p = NULL; int size = 0; - char *title = NULL; if (tag) { ret = mm_file_get_attrs(tag, MM_FILE_TAG_TITLE, &p, &size, NULL); @@ -471,19 +442,12 @@ static char * __media_svc_get_title(MMHandleType tag, const char *path) } } - title = __media_svc_get_title_from_filepath(path); - if (title) - return title; - - media_svc_error("Can't extract title"); - - return g_strdup(MEDIA_SVC_TAG_UNKNOWN); + return __media_svc_get_title_from_filename(filename); } -char * _media_svc_get_title_by_path(const char *path) +char * _media_svc_get_title_from_filename(const char *filename) { - /* No MMHandleType in media-svc.c */ - return __media_svc_get_title(NULL, path); + return __media_svc_get_title_from_filename(filename); } int _media_svc_extract_image_metadata(media_svc_content_info_s *content_info) @@ -502,7 +466,7 @@ int _media_svc_extract_image_metadata(media_svc_content_info_s *content_info) media_svc_retvm_if(!STRING_VALID(content_info->path), MS_MEDIA_ERR_INVALID_PARAMETER, "Invalid path"); path = content_info->path; - content_info->media_meta.title = __media_svc_get_title(NULL, path); + content_info->media_meta.title = __media_svc_get_title_from_filename(content_info->file_name); /* Not used. But to preserved the behavior, set MEDIA_SVC_TAG_UNKNOWN. */ content_info->media_meta.album = g_strdup(MEDIA_SVC_TAG_UNKNOWN); @@ -566,14 +530,14 @@ int _media_svc_extract_image_metadata(media_svc_content_info_s *content_info) exif_data_unref(ed); GET_WIDTH_HEIGHT: - if (content_info->media_meta.width == 0 || content_info->media_meta.height == 0) { /*Get image width, height*/ unsigned int img_width = 0; unsigned int img_height = 0; - mm_util_img_codec_type img_type = IMG_CODEC_UNKNOWN_TYPE; - mm_util_extract_image_info(path, &img_type, &img_width, &img_height); + if (get_image_info(path, &img_width, &img_height) != THUMB_OK) + return MS_MEDIA_ERR_NONE; + if (content_info->media_meta.width == 0) content_info->media_meta.width = img_width; @@ -597,16 +561,40 @@ static char * __media_svc_get_tag_str_value(MMHandleType tag, const char *tag_na return g_strdup(MEDIA_SVC_TAG_UNKNOWN); } -int _media_svc_extract_audio_metadata(sqlite3 *handle, bool is_direct, media_svc_content_info_s *content_info, uid_t uid) +static char * __media_svc_extract_albumart(MMHandleType tag, const char *path, uid_t uid) +{ + int ret = FILEINFO_ERROR_NONE; + unsigned char *image = NULL; + unsigned int size = 0; + char *mimetype = NULL; + char thumb_path[MEDIA_SVC_PATHNAME_SIZE] = { 0, }; + unsigned int mime_size = 0; + + ret = mm_file_get_attrs(tag, MM_FILE_TAG_ARTWORK, &image, &size, NULL); + media_svc_retvm_if(ret != FILEINFO_ERROR_NONE, NULL, "Failed to get tag artwork[%d]", ret); + media_svc_retvm_if(!image || size == 0, NULL, "Invalid artwork"); + + ret = mm_file_get_attrs(tag, MM_FILE_TAG_ARTWORK_MIME, &mimetype, &mime_size, NULL); + media_svc_retvm_if(ret != FILEINFO_ERROR_NONE, NULL, "Failed to get tag mime[%d]", ret); + media_svc_retvm_if(mime_size == 0, NULL, "Invalid mimetype"); + + ret = __media_svc_get_thumbnail_path(thumb_path, path, mimetype, uid); + media_svc_retvm_if(ret != MS_MEDIA_ERR_NONE, NULL, "Failed to get thumbnail path"); + + ret = __media_svc_save_image(image, size, thumb_path, uid); + media_svc_retvm_if(ret != MS_MEDIA_ERR_NONE, NULL, "Fail to save thumbnail"); + + return g_strdup(thumb_path); +} + +void _media_svc_extract_audio_metadata(sqlite3 *handle, bool is_direct, media_svc_content_info_s *content_info, uid_t uid) { MMHandleType tag = 0; char *p = NULL; - unsigned char *image = NULL; unsigned int size = 0; int mmf_error = FILEINFO_ERROR_NONE; int album_id = 0; int ret = MS_MEDIA_ERR_NONE; - int convert_value = 0; bool support_albumart = ms_user_thumb_support(uid, content_info->path); /*Get Content Tag attribute ===========*/ @@ -615,97 +603,57 @@ int _media_svc_extract_audio_metadata(sqlite3 *handle, bool is_direct, media_svc else mmf_error = mm_file_create_tag_attrs_no_albumart(&tag, content_info->path); - if (mmf_error == FILEINFO_ERROR_NONE) { - content_info->media_meta.title = __media_svc_get_title(tag, content_info->path); - content_info->media_meta.album = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_ALBUM); - content_info->media_meta.artist = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_ARTIST); - content_info->media_meta.album_artist = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_ALBUM_ARTIST); - content_info->media_meta.genre = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_GENRE); - content_info->media_meta.track_num = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_TRACK_NUM); - content_info->media_meta.copyright = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_COPYRIGHT); + if (mmf_error != FILEINFO_ERROR_NONE) { + content_info->media_meta.title = __media_svc_get_title_from_filename(content_info->file_name); + content_info->album_id = 0; + return; + } - mmf_error = mm_file_get_attrs(tag, MM_FILE_TAG_RECDATE, &p, &size, NULL); - if ((mmf_error == FILEINFO_ERROR_NONE) && (size > 0)) { - if (g_str_has_suffix(content_info->mime_type, "mp4") || g_str_has_suffix(content_info->mime_type, "3gpp")) { - /*Creation time format is 20130101 00:00:00 +0000. change it to 2013:01:01 00:00:00 +0000 like exif time format*/ - char *p_value = g_strdelimit(g_strdup(p), "", ':'); - content_info->media_meta.recorded_date = g_strdup_printf("%s +0000", p_value); - g_free(p_value); - } else { - content_info->media_meta.recorded_date = g_strdup(p); - } + content_info->media_meta.title = __media_svc_get_title(tag, content_info->file_name); + content_info->media_meta.album = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_ALBUM); + content_info->media_meta.artist = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_ARTIST); + content_info->media_meta.album_artist = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_ALBUM_ARTIST); + content_info->media_meta.genre = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_GENRE); + content_info->media_meta.track_num = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_TRACK_NUM); + content_info->media_meta.copyright = __media_svc_get_tag_str_value(tag, MM_FILE_TAG_COPYRIGHT); + + mmf_error = mm_file_get_attrs(tag, MM_FILE_TAG_RECDATE, &p, &size, NULL); + if ((mmf_error == FILEINFO_ERROR_NONE) && (size > 0)) { + if (g_str_has_suffix(content_info->mime_type, "mp4") || g_str_has_suffix(content_info->mime_type, "3gpp")) { + /*Creation time format is 20130101 00:00:00 +0000. change it to 2013:01:01 00:00:00 +0000 like exif time format*/ + char *p_value = g_strdelimit(g_strdup(p), "-", ':'); + content_info->media_meta.recorded_date = g_strdup_printf("%s +0000", p_value); + g_free(p_value); + } else { + content_info->media_meta.recorded_date = g_strdup(p); } + } - if (content_info->media_meta.recorded_date == NULL) - content_info->media_meta.recorded_date = g_strdup(MEDIA_SVC_TAG_UNKNOWN); - - mmf_error = mm_file_get_attrs(tag, MM_FILE_TAG_DATE, &p, &size, NULL); - if (mmf_error == FILEINFO_ERROR_NONE && size == 4) { - if (__media_svc_safe_atoi(p, &convert_value) == MS_MEDIA_ERR_NONE) - content_info->media_meta.year = g_strdup(p); - } + if (content_info->media_meta.recorded_date == NULL) + content_info->media_meta.recorded_date = g_strdup(MEDIA_SVC_TAG_UNKNOWN); - if (!content_info->media_meta.year) - content_info->media_meta.year = g_strdup(MEDIA_SVC_TAG_UNKNOWN); - - /*Do not extract artwork for the USB Storage content*/ - if (support_albumart) { - mmf_error = mm_file_get_attrs(tag, MM_FILE_TAG_ARTWORK, &image, &size, NULL); - if (mmf_error != FILEINFO_ERROR_NONE) - media_svc_error("fail to get tag artwork - err(%x)", mmf_error); - - mmf_error = mm_file_get_attrs(tag, MM_FILE_TAG_ARTWORK_SIZE, &size, NULL); - if (mmf_error != FILEINFO_ERROR_NONE) - media_svc_error("fail to get artwork size - err(%x)", mmf_error); - - if (image != NULL && size > 0) { - char thumb_path[MEDIA_SVC_PATHNAME_SIZE] = "\0"; - int artwork_mime_size = -1; - - mmf_error = mm_file_get_attrs(tag, MM_FILE_TAG_ARTWORK_MIME, &p, &artwork_mime_size, NULL); - if ((mmf_error == FILEINFO_ERROR_NONE) && (artwork_mime_size > 0)) { - ret = __media_svc_get_thumbnail_path(thumb_path, content_info->path, p, uid); - if (ret != MS_MEDIA_ERR_NONE) { - media_svc_error("Fail to Get Thumbnail Path"); - } else { - ret = __media_svc_save_image(image, size, thumb_path, uid); - if (ret != MS_MEDIA_ERR_NONE) { - media_svc_error("Fail to Save Image"); - } else { - content_info->thumbnail_path = g_strdup(thumb_path); - } - } - } - } - } + mmf_error = mm_file_get_attrs(tag, MM_FILE_TAG_DATE, &p, &size, NULL); + if (mmf_error == FILEINFO_ERROR_NONE && size == 4) + content_info->media_meta.year = g_strdup(p); + else + content_info->media_meta.year = g_strdup(MEDIA_SVC_TAG_UNKNOWN); - /*Initialize album_id to 0. below code will set the album_id*/ - content_info->album_id = album_id; - ret = _media_svc_get_album_id(handle, content_info->media_meta.album, content_info->media_meta.artist, &album_id); - if (ret != MS_MEDIA_ERR_NONE) { - if (ret == MS_MEDIA_ERR_DB_NO_RECORD) { - media_svc_debug("album does not exist. So start to make album art"); - if ((g_strcmp0(content_info->media_meta.album, MEDIA_SVC_TAG_UNKNOWN)) && - (g_strcmp0(content_info->media_meta.artist, MEDIA_SVC_TAG_UNKNOWN))) - ret = _media_svc_append_album(handle, is_direct, content_info->media_meta.album, content_info->media_meta.artist, content_info->thumbnail_path, &album_id, uid); - else - ret = _media_svc_append_album(handle, is_direct, content_info->media_meta.album, content_info->media_meta.artist, NULL, &album_id, uid); - - content_info->album_id = album_id; - } - } else { - content_info->album_id = album_id; - } + /*Do not extract artwork for the USB Storage content*/ + if (support_albumart) + content_info->thumbnail_path = __media_svc_extract_albumart(tag, content_info->path, uid); - mmf_error = mm_file_destroy_tag_attrs(tag); - if (mmf_error != FILEINFO_ERROR_NONE) - media_svc_error("fail to free tag attr - err(%x)", mmf_error); - } else { - content_info->media_meta.title = __media_svc_get_title(NULL, content_info->path); - content_info->album_id = album_id; + ret = _media_svc_get_album_id(handle, content_info->media_meta.album, content_info->media_meta.artist, &album_id); + if (ret == MS_MEDIA_ERR_DB_NO_RECORD) { + media_svc_debug("album does not exist. So start to make album art"); + if (strlen(content_info->media_meta.album) > 0 && strlen(content_info->media_meta.artist) > 0) + ret = _media_svc_append_album(handle, is_direct, content_info->media_meta.album, content_info->media_meta.artist, content_info->thumbnail_path, &album_id, uid); + else + ret = _media_svc_append_album(handle, is_direct, content_info->media_meta.album, content_info->media_meta.artist, NULL, &album_id, uid); } + content_info->album_id = album_id; - return MS_MEDIA_ERR_NONE; + if (mm_file_destroy_tag_attrs(tag) != FILEINFO_ERROR_NONE) + media_svc_error("destroy failed"); } int _media_svc_extract_video_metadata(media_svc_content_info_s *content_info) @@ -723,9 +671,7 @@ int _media_svc_extract_video_metadata(media_svc_content_info_s *content_info) if ((mmf_error == FILEINFO_ERROR_NONE) && (size > 0)) { if (g_str_has_suffix(content_info->mime_type, "mp4") || g_str_has_suffix(content_info->mime_type, "3gpp")) { /*Creation time format is 20130101 00:00:00 +0000. change it to 2013:01:01 00:00:00 +0000 like exif time format*/ - char *p_value = g_strdelimit(g_strdup(p), "", ':'); - content_info->media_meta.recorded_date = g_strdup_printf("%s +0000", p_value); - g_free(p_value); + content_info->media_meta.recorded_date = g_strdelimit(g_strdup(p), "-", ':'); } else { content_info->media_meta.recorded_date = g_strdup(p); } @@ -747,7 +693,9 @@ int _media_svc_extract_video_metadata(media_svc_content_info_s *content_info) MM_FILE_CONTENT_VIDEO_HEIGHT, &content_info->media_meta.height, NULL); - content_info->media_meta.title = __media_svc_get_title(NULL, content_info->path); + mm_file_destroy_content_attrs(content); + + content_info->media_meta.title = __media_svc_get_title_from_filename(content_info->file_name); content_info->media_meta.album = g_strdup(MEDIA_SVC_TAG_UNKNOWN); content_info->media_meta.artist = g_strdup(MEDIA_SVC_TAG_UNKNOWN); content_info->media_meta.album_artist = g_strdup(MEDIA_SVC_TAG_UNKNOWN); @@ -914,6 +862,7 @@ static gboolean __media_svc_get_xml_metadata(const xmlChar *buffer, gboolean is_ } content_info->media_meta.title = __media_svc_find_and_get_value(root, "title"); + /* In the case of PDF, if there is no title, it may not be a metadata block. Search for the next xml block*/ if (is_pdf && !content_info->media_meta.title) { xmlFreeDoc(doc); return FALSE; @@ -1040,12 +989,22 @@ static int __media_svc_get_pdf_metadata(media_svc_content_info_s *content_info) int _media_svc_extract_book_metadata(media_svc_content_info_s *content_info) { + int ret = MS_MEDIA_ERR_NONE; + media_svc_retvm_if(!content_info, MS_MEDIA_ERR_INVALID_PARAMETER, "content info is NULL"); if (g_str_has_suffix(content_info->mime_type, "epub+zip")) - return __media_svc_get_epub_metadata(content_info); + ret = __media_svc_get_epub_metadata(content_info); else - return __media_svc_get_pdf_metadata(content_info); + ret = __media_svc_get_pdf_metadata(content_info); + + media_svc_retvm_if(ret != MS_MEDIA_ERR_NONE, ret, "failed to extract metadata"); + if (!content_info->media_meta.title || strlen(content_info->media_meta.title) == 0) { + g_free(content_info->media_meta.title); + content_info->media_meta.title = __media_svc_get_title_from_filename(content_info->file_name); + } + + return MS_MEDIA_ERR_NONE; } void _media_svc_destroy_content_info(media_svc_content_info_s *content_info) @@ -1090,11 +1049,7 @@ int _media_svc_create_thumbnail(const char *path, char *thumb_path, media_svc_me //1. make thumb path ret = __media_svc_get_thumbnail_path(thumb_path, path, NULL, uid); - if (ret != MS_MEDIA_ERR_NONE) { - media_svc_error("Failed to create thumbnail path[%d]", ret); - SAFE_STRLCPY(thumb_path, "", MAX_FILEPATH_LEN); - return ret; - } + media_svc_retvm_if(ret != MS_MEDIA_ERR_NONE, ret, "Failed to create thumbnail path[%d]", ret); //2. save thumbnail if (media_type == MEDIA_SVC_MEDIA_TYPE_IMAGE)