X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=src%2Fagent.c;h=82dc46d73a9e94b2f953e0fc375dc301f310338c;hb=6636320dc4c4b3254631098b4e748f0e38090344;hp=ce72d503a4dd108147261258a10a09a218ad4b7b;hpb=8c0cc20f3686a299a0abc8ddd8df8a702a26e379;p=framework%2Fconnectivity%2Fconnman.git diff --git a/src/agent.c b/src/agent.c index ce72d50..82dc46d 100644 --- a/src/agent.c +++ b/src/agent.c @@ -2,7 +2,7 @@ * * Connection Manager * - * Copyright (C) 2007-2010 Intel Corporation. All rights reserved. + * Copyright (C) 2007-2012 Intel Corporation. All rights reserved. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as @@ -31,6 +31,8 @@ #include "connman.h" +#define REQUEST_TIMEOUT (120 * 1000) /* 120 seconds */ + static DBusConnection *connection = NULL; static guint agent_watch = 0; static gchar *agent_path = NULL; @@ -85,6 +87,26 @@ int __connman_agent_unregister(const char *sender, const char *path) return 0; } +static connman_bool_t check_reply_has_dict(DBusMessage *reply) +{ + const char *signature = DBUS_TYPE_ARRAY_AS_STRING + DBUS_DICT_ENTRY_BEGIN_CHAR_AS_STRING + DBUS_TYPE_STRING_AS_STRING + DBUS_TYPE_VARIANT_AS_STRING + DBUS_DICT_ENTRY_END_CHAR_AS_STRING; + + if (dbus_message_has_signature(reply, signature) == TRUE) + return TRUE; + + connman_warn("Reply %s to %s from %s has wrong signature %s", + signature, + dbus_message_get_interface(reply), + dbus_message_get_sender(reply), + dbus_message_get_signature(reply)); + + return FALSE; +} + struct request_input_reply { struct connman_service *service; authentication_cb_t callback; @@ -96,14 +118,22 @@ static void request_input_passphrase_reply(DBusPendingCall *call, void *user_dat struct request_input_reply *passphrase_reply = user_data; connman_bool_t values_received = FALSE; connman_bool_t wps = FALSE; + const char *error = NULL; char *identity = NULL; char *passphrase = NULL; char *wpspin = NULL; char *key; + char *name = NULL; + int name_len = 0; DBusMessageIter iter, dict; DBusMessage *reply = dbus_pending_call_steal_reply(call); - if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) + if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) { + error = dbus_message_get_error_name(reply); + goto done; + } + + if (check_reply_has_dict(reply) == FALSE) goto done; values_received = TRUE; @@ -144,34 +174,41 @@ static void request_input_passphrase_reply(DBusPendingCall *call, void *user_dat dbus_message_iter_recurse(&entry, &value); dbus_message_iter_get_basic(&value, &wpspin); break; + } else if (g_str_equal(key, "Name")) { + dbus_message_iter_next(&entry); + if (dbus_message_iter_get_arg_type(&entry) + != DBUS_TYPE_VARIANT) + break; + dbus_message_iter_recurse(&entry, &value); + dbus_message_iter_get_basic(&value, &name); + name_len = strlen(name); + } else if (g_str_equal(key, "SSID")) { + dbus_message_iter_next(&entry); + if (dbus_message_iter_get_arg_type(&entry) + != DBUS_TYPE_VARIANT) + break; + dbus_message_iter_recurse(&entry, &value); + if (dbus_message_iter_get_arg_type(&value) + != DBUS_TYPE_VARIANT) + break; + if (dbus_message_iter_get_element_type(&value) + != DBUS_TYPE_VARIANT) + break; + dbus_message_iter_get_fixed_array(&value, &name, + &name_len); } dbus_message_iter_next(&dict); } - if (wps == TRUE) { - struct connman_network *network; - - network = __connman_service_get_network( - passphrase_reply->service); - if (network == NULL) - goto done; - - connman_network_set_bool(network, "WiFi.UseWPS", wps); - - if (wpspin != NULL && strlen(wpspin) > 0) - connman_network_set_string(network, - "WiFi.PinWPS", wpspin); - else - connman_network_set_string(network, - "WiFi.PinWPS", NULL); - } - done: passphrase_reply->callback(passphrase_reply->service, values_received, + name, name_len, identity, passphrase, + wps, wpspin, error, passphrase_reply->user_data); connman_service_unref(passphrase_reply->service); dbus_message_unref(reply); + dbus_pending_call_unref(call); g_free(passphrase_reply); } @@ -202,7 +239,7 @@ static void request_input_append_identity(DBusMessageIter *iter, connman_dbus_dict_append_basic(iter, "Type", DBUS_TYPE_STRING, &str); - str = "Mandatory"; + str = "mandatory"; connman_dbus_dict_append_basic(iter, "Requirement", DBUS_TYPE_STRING, &str); } @@ -238,7 +275,7 @@ static void request_input_append_passphrase(DBusMessageIter *iter, } connman_dbus_dict_append_basic(iter, "Type", DBUS_TYPE_STRING, &value); - value = "Mandatory"; + value = "mandatory"; connman_dbus_dict_append_basic(iter, "Requirement", DBUS_TYPE_STRING, &value); @@ -294,7 +331,7 @@ static void request_input_append_password(DBusMessageIter *iter, connman_dbus_dict_append_basic(iter, "Type", DBUS_TYPE_STRING, &str); - str = "Mandatory"; + str = "mandatory"; connman_dbus_dict_append_basic(iter, "Requirement", DBUS_TYPE_STRING, &str); } @@ -302,15 +339,24 @@ static void request_input_append_password(DBusMessageIter *iter, static void request_input_login_reply(DBusPendingCall *call, void *user_data) { struct request_input_reply *username_password_reply = user_data; + const char *error = NULL; + connman_bool_t values_received = FALSE; char *username = NULL; char *password = NULL; char *key; DBusMessageIter iter, dict; DBusMessage *reply = dbus_pending_call_steal_reply(call); - if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) + if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) { + error = dbus_message_get_error_name(reply); + goto done; + } + + if (check_reply_has_dict(reply) == FALSE) goto done; + values_received = TRUE; + dbus_message_iter_init(reply, &iter); dbus_message_iter_recurse(&iter, &dict); while (dbus_message_iter_get_arg_type(&dict) == DBUS_TYPE_DICT_ENTRY) { @@ -344,8 +390,9 @@ static void request_input_login_reply(DBusPendingCall *call, void *user_data) done: username_password_reply->callback(username_password_reply->service, - TRUE, + values_received, NULL, 0, username, password, + FALSE, NULL, error, username_password_reply->user_data); connman_service_unref(username_password_reply->service); dbus_message_unref(reply); @@ -392,8 +439,11 @@ int __connman_agent_request_passphrase_input(struct connman_service *service, request_input_append_identity, service); } - connman_dbus_dict_append_dict(&dict, "Passphrase", - request_input_append_passphrase, service); + if (__connman_service_get_security(service) != + CONNMAN_SERVICE_SECURITY_NONE) { + connman_dbus_dict_append_dict(&dict, "Passphrase", + request_input_append_passphrase, service); + } if (__connman_service_wps_enabled(service) == TRUE) { connman_dbus_dict_append_dict(&dict, "WPS", @@ -408,8 +458,8 @@ int __connman_agent_request_passphrase_input(struct connman_service *service, return -ENOMEM; } - if (dbus_connection_send_with_reply(connection, message, - &call, -1) == FALSE) { + if (dbus_connection_send_with_reply(connection, message, &call, + REQUEST_TIMEOUT) == FALSE) { dbus_message_unref(message); g_free(passphrase_reply); return -ESRCH; @@ -430,7 +480,7 @@ int __connman_agent_request_passphrase_input(struct connman_service *service, dbus_message_unref(message); - return -EIO; + return -EINPROGRESS; } int __connman_agent_request_login_input(struct connman_service *service, @@ -474,8 +524,8 @@ int __connman_agent_request_login_input(struct connman_service *service, return -ENOMEM; } - if (dbus_connection_send_with_reply(connection, message, - &call, -1) == FALSE) { + if (dbus_connection_send_with_reply(connection, message, &call, + REQUEST_TIMEOUT) == FALSE) { dbus_message_unref(message); g_free(username_password_reply); return -ESRCH; @@ -496,7 +546,95 @@ int __connman_agent_request_login_input(struct connman_service *service, dbus_message_unref(message); - return -EIO; + return -EINPROGRESS; +} + +struct request_browser_reply_data { + struct connman_service *service; + browser_authentication_cb_t callback; + void *user_data; +}; + +static void request_browser_reply(DBusPendingCall *call, void *user_data) +{ + struct request_browser_reply_data *browser_reply_data = user_data; + DBusMessage *reply = dbus_pending_call_steal_reply(call); + connman_bool_t result = FALSE; + const char *error = NULL; + + if (dbus_message_get_type(reply) == DBUS_MESSAGE_TYPE_ERROR) { + error = dbus_message_get_error_name(reply); + goto done; + } + + result = TRUE; + +done: + browser_reply_data->callback(browser_reply_data->service, result, + error, browser_reply_data->user_data); + connman_service_unref(browser_reply_data->service); + dbus_message_unref(reply); + g_free(browser_reply_data); +} + +int __connman_agent_request_browser(struct connman_service *service, + browser_authentication_cb_t callback, + const char *url, void *user_data) +{ + struct request_browser_reply_data *browser_reply_data; + DBusPendingCall *call; + DBusMessage *message; + DBusMessageIter iter; + const char *path; + + if (service == NULL || agent_path == NULL || callback == NULL) + return -ESRCH; + + if (url == NULL) + url = ""; + + message = dbus_message_new_method_call(agent_sender, agent_path, + CONNMAN_AGENT_INTERFACE, + "RequestBrowser"); + if (message == NULL) + return -ENOMEM; + + dbus_message_iter_init_append(message, &iter); + + path = __connman_service_get_path(service); + dbus_message_iter_append_basic(&iter, DBUS_TYPE_OBJECT_PATH, &path); + + dbus_message_iter_append_basic(&iter, DBUS_TYPE_STRING, &url); + + browser_reply_data = g_try_new0(struct request_browser_reply_data, 1); + if (browser_reply_data == NULL) { + dbus_message_unref(message); + return -ENOMEM; + } + + if (dbus_connection_send_with_reply(connection, message, &call, + REQUEST_TIMEOUT) == FALSE) { + dbus_message_unref(message); + g_free(browser_reply_data); + return -ESRCH; + } + + if (call == NULL) { + dbus_message_unref(message); + g_free(browser_reply_data); + return -ESRCH; + } + + browser_reply_data->service = connman_service_ref(service); + browser_reply_data->callback = callback; + browser_reply_data->user_data = user_data; + + dbus_pending_call_set_notify(call, request_browser_reply, + browser_reply_data, NULL); + + dbus_message_unref(message); + + return -EINPROGRESS; } struct report_error_data { @@ -525,6 +663,7 @@ static void report_error_reply(DBusPendingCall *call, void *user_data) connman_service_unref(report_error->service); g_free(report_error); dbus_message_unref(reply); + dbus_pending_call_unref(call); } int __connman_agent_report_error(struct connman_service *service, @@ -561,8 +700,8 @@ int __connman_agent_report_error(struct connman_service *service, return -ENOMEM; } - if (dbus_connection_send_with_reply(connection, message, - &call, -1) == FALSE) { + if (dbus_connection_send_with_reply(connection, message, &call, + REQUEST_TIMEOUT) == FALSE) { dbus_message_unref(message); g_free(report_error); return -ESRCH; @@ -581,7 +720,7 @@ int __connman_agent_report_error(struct connman_service *service, report_error, NULL); dbus_message_unref(message); - return -EIO; + return -EINPROGRESS; } int __connman_agent_init(void)