X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=isl_tab_pip.c;h=8d16d5ca5c8a56f22ea03af296013d7c1edbeb84;hb=3961a579833bebbcd7192f4f4fa5464937b6562a;hp=9759dcf2ae10dac0c3be2be9615238322a7874db;hpb=af52e84245fb4bab6734d62da39f63f568371dcd;p=platform%2Fupstream%2Fisl.git

diff --git a/isl_tab_pip.c b/isl_tab_pip.c
index 9759dcf..8d16d5c 100644
--- a/isl_tab_pip.c
+++ b/isl_tab_pip.c
@@ -2,7 +2,7 @@
  * Copyright 2008-2009 Katholieke Universiteit Leuven
  * Copyright 2010      INRIA Saclay
  *
- * Use of this software is governed by the GNU LGPLv2.1 license
+ * Use of this software is governed by the MIT license
  *
  * Written by Sven Verdoolaege, K.U.Leuven, Departement
  * Computerwetenschappen, Celestijnenlaan 200A, B-3001 Leuven, Belgium
@@ -102,6 +102,8 @@ struct isl_context_op {
 	void *(*save)(struct isl_context *context);
 	/* restore saved context */
 	void (*restore)(struct isl_context *context, void *);
+	/* discard saved context */
+	void (*discard)(void *);
 	/* invalidate context */
 	void (*invalidate)(struct isl_context *context);
 	/* free context */
@@ -201,6 +203,7 @@ static void sol_push_sol(struct isl_sol *sol,
 	return;
 error:
 	isl_basic_set_free(dom);
+	isl_mat_free(M);
 	sol->error = 1;
 }
 
@@ -306,6 +309,8 @@ static void sol_pop(struct isl_sol *sol)
 			struct isl_basic_set *bset;
 
 			bset = sol_domain(sol);
+			if (!bset)
+				goto error;
 
 			isl_basic_set_free(partial->next->dom);
 			partial->next->dom = bset;
@@ -318,6 +323,9 @@ static void sol_pop(struct isl_sol *sol)
 		}
 	} else
 		sol_pop_one(sol);
+
+	if (0)
+error:		sol->error = 1;
 }
 
 static void sol_dec_level(struct isl_sol *sol)
@@ -431,6 +439,8 @@ static void sol_add(struct isl_sol *sol, struct isl_tab *tab)
 
 	if (tab->empty && !sol->add_empty)
 		return;
+	if (sol->context->op->is_empty(sol->context))
+		return;
 
 	bset = sol_domain(sol);
 
@@ -743,6 +753,30 @@ static struct isl_vec *get_row_parameter_ineq(struct isl_tab *tab, int row)
 	return ineq;
 }
 
+/* Normalize a div expression of the form
+ *
+ *	[(g*f(x) + c)/(g * m)]
+ *
+ * with c the constant term and f(x) the remaining coefficients, to
+ *
+ *	[(f(x) + [c/g])/m]
+ */
+static void normalize_div(__isl_keep isl_vec *div)
+{
+	isl_ctx *ctx = isl_vec_get_ctx(div);
+	int len = div->size - 2;
+
+	isl_seq_gcd(div->el + 2, len, &ctx->normalize_gcd);
+	isl_int_gcd(ctx->normalize_gcd, ctx->normalize_gcd, div->el[0]);
+
+	if (isl_int_is_one(ctx->normalize_gcd))
+		return;
+
+	isl_int_divexact(div->el[0], div->el[0], ctx->normalize_gcd);
+	isl_int_fdiv_q(div->el[1], div->el[1], ctx->normalize_gcd);
+	isl_seq_scale_down(div->el + 2, div->el + 2, ctx->normalize_gcd, len);
+}
+
 /* Return a integer division for use in a parametric cut based on the given row.
  * In particular, let the parametric constant of the row be
  *
@@ -763,8 +797,8 @@ static struct isl_vec *get_row_parameter_div(struct isl_tab *tab, int row)
 
 	isl_int_set(div->el[0], tab->mat->row[row][0]);
 	get_row_parameter_line(tab, row, div->el + 1);
-	div = isl_vec_normalize(div);
 	isl_seq_neg(div->el + 1, div->el + 1, div->size - 1);
+	normalize_div(div);
 	isl_seq_fdiv_r(div->el + 1, div->el + 1, div->el[0], div->size - 1);
 
 	return div;
@@ -791,7 +825,7 @@ static struct isl_vec *get_row_split_div(struct isl_tab *tab, int row)
 
 	isl_int_set(div->el[0], tab->mat->row[row][0]);
 	get_row_parameter_line(tab, row, div->el + 1);
-	div = isl_vec_normalize(div);
+	normalize_div(div);
 	isl_seq_fdiv_r(div->el + 1, div->el + 1, div->el[0], div->size - 1);
 
 	return div;
@@ -1151,8 +1185,8 @@ static int report_conflicting_constraint(struct isl_tab *tab, int con)
 
 /* Given a conflicting row in the tableau, report all constraints
  * involved in the row to the caller.  That is, the row itself
- * (if represents a constraint) and all constraint columns with
- * non-zero (and therefore negative) coefficient.
+ * (if it represents a constraint) and all constraint columns with
+ * non-zero (and therefore negative) coefficients.
  */
 static int report_conflict(struct isl_tab *tab, int row)
 {
@@ -1604,6 +1638,9 @@ static int add_cut(struct isl_tab *tab, int row)
 	return tab->con[r].index;
 }
 
+#define CUT_ALL 1
+#define CUT_ONE 0
+
 /* Given a non-parametric tableau, add cuts until an integer
  * sample point is obtained or until the tableau is determined
  * to be integer infeasible.
@@ -1615,8 +1652,12 @@ static int add_cut(struct isl_tab *tab, int row)
  * combination of variables/constraints plus a non-integral constant,
  * then there is no way to obtain an integer point and we return
  * a tableau that is marked empty.
+ * The parameter cutting_strategy controls the strategy used when adding cuts
+ * to remove non-integer points. CUT_ALL adds all possible cuts
+ * before continuing the search. CUT_ONE adds only one cut at a time.
  */
-static struct isl_tab *cut_to_integer_lexmin(struct isl_tab *tab)
+static struct isl_tab *cut_to_integer_lexmin(struct isl_tab *tab,
+	int cutting_strategy)
 {
 	int var;
 	int row;
@@ -1638,6 +1679,8 @@ static struct isl_tab *cut_to_integer_lexmin(struct isl_tab *tab)
 			row = add_cut(tab, row);
 			if (row < 0)
 				goto error;
+			if (cutting_strategy == CUT_ONE)
+				break;
 		} while ((var = next_non_integer_var(tab, var, &flags)) != -1);
 		if (restore_lexmin(tab) < 0)
 			goto error;
@@ -1728,7 +1771,7 @@ static struct isl_tab *check_integer_feasible(struct isl_tab *tab)
 	if (isl_tab_push_basis(tab) < 0)
 		goto error;
 
-	tab = cut_to_integer_lexmin(tab);
+	tab = cut_to_integer_lexmin(tab, CUT_ALL);
 	if (!tab)
 		goto error;
 
@@ -1922,6 +1965,7 @@ static int add_parametric_cut(struct isl_tab *tab, int row,
 
 	n = tab->n_div;
 	d = context->op->get_div(context, tab, div);
+	isl_vec_free(div);
 	if (d < 0)
 		return -1;
 
@@ -1987,8 +2031,6 @@ static int add_parametric_cut(struct isl_tab *tab, int row,
 	if (tab->row_sign)
 		tab->row_sign[tab->con[r].index] = isl_tab_row_neg;
 
-	isl_vec_free(div);
-
 	row = tab->con[r].index;
 
 	if (d >= n && context->op->detect_equalities(context, tab) < 0)
@@ -2383,6 +2425,10 @@ static void context_lex_restore(struct isl_context *context, void *save)
 	}
 }
 
+static void context_lex_discard(void *save)
+{
+}
+
 static int context_lex_is_ok(struct isl_context *context)
 {
 	struct isl_context_lex *clex = (struct isl_context_lex *)context;
@@ -2502,6 +2548,7 @@ struct isl_context_op isl_context_lex_op = {
 	context_lex_is_ok,
 	context_lex_save,
 	context_lex_restore,
+	context_lex_discard,
 	context_lex_invalidate,
 	context_lex_free,
 };
@@ -2510,7 +2557,6 @@ static struct isl_tab *context_tab_for_lexmin(struct isl_basic_set *bset)
 {
 	struct isl_tab *tab;
 
-	bset = isl_basic_set_cow(bset);
 	if (!bset)
 		return NULL;
 	tab = tab_for_lexmin((struct isl_basic_map *)bset, NULL, 1, 0);
@@ -2609,7 +2655,7 @@ static void gbr_init_shifted(struct isl_context_gbr *cgbr)
 		}
 	}
 
-	cgbr->shifted = isl_tab_from_basic_set(bset);
+	cgbr->shifted = isl_tab_from_basic_set(bset, 0);
 
 	for (i = 0; i < bset->n_ineq; ++i)
 		isl_int_set(bset->ineq[i][0], cst->el[i]);
@@ -2682,7 +2728,8 @@ static struct isl_vec *gbr_get_sample(struct isl_context_gbr *cgbr)
 		cgbr->cone = isl_tab_from_recession_cone(bset, 0);
 		if (!cgbr->cone)
 			return NULL;
-		if (isl_tab_track_bset(cgbr->cone, isl_basic_set_dup(bset)) < 0)
+		if (isl_tab_track_bset(cgbr->cone,
+					isl_basic_set_copy(bset)) < 0)
 			return NULL;
 	}
 	if (isl_tab_detect_implicit_equalities(cgbr->cone) < 0)
@@ -3044,7 +3091,8 @@ static int context_gbr_detect_equalities(struct isl_context *context,
 		cgbr->cone = isl_tab_from_recession_cone(bset, 0);
 		if (!cgbr->cone)
 			goto error;
-		if (isl_tab_track_bset(cgbr->cone, isl_basic_set_dup(bset)) < 0)
+		if (isl_tab_track_bset(cgbr->cone,
+					isl_basic_set_copy(bset)) < 0)
 			goto error;
 	}
 	if (isl_tab_detect_implicit_equalities(cgbr->cone) < 0)
@@ -3189,6 +3237,12 @@ error:
 	cgbr->tab = NULL;
 }
 
+static void context_gbr_discard(void *save)
+{
+	struct isl_gbr_tab_undo *snap = (struct isl_gbr_tab_undo *)save;
+	free(snap);
+}
+
 static int context_gbr_is_ok(struct isl_context *context)
 {
 	struct isl_context_gbr *cgbr = (struct isl_context_gbr *)context;
@@ -3227,6 +3281,7 @@ struct isl_context_op isl_context_gbr_op = {
 	context_gbr_is_ok,
 	context_gbr_save,
 	context_gbr_restore,
+	context_gbr_discard,
 	context_gbr_invalidate,
 	context_gbr_free,
 };
@@ -3246,13 +3301,10 @@ static struct isl_context *isl_context_gbr_alloc(struct isl_basic_set *dom)
 
 	cgbr->shifted = NULL;
 	cgbr->cone = NULL;
-	cgbr->tab = isl_tab_from_basic_set(dom);
+	cgbr->tab = isl_tab_from_basic_set(dom, 1);
 	cgbr->tab = isl_tab_init_samples(cgbr->tab);
 	if (!cgbr->tab)
 		goto error;
-	if (isl_tab_track_bset(cgbr->tab,
-				isl_basic_set_cow(isl_basic_set_copy(dom))) < 0)
-		goto error;
 	check_gbr_integer_feasible(cgbr);
 
 	return &cgbr->context;
@@ -3528,6 +3580,8 @@ static void find_in_pos(struct isl_sol *sol, struct isl_tab *tab, isl_int *ineq)
 
 	if (!sol->error)
 		sol->context->op->restore(sol->context, saved);
+	else
+		sol->context->op->discard(saved);
 	return;
 error:
 	sol->error = 1;
@@ -4488,7 +4542,7 @@ static union isl_lex_res basic_map_partial_lexopt_symm(
 	bmap = isl_basic_map_finalize(bmap);
 
 	n_div = isl_basic_set_dim(dom, isl_dim_div);
-	dom = isl_basic_set_add(dom, isl_dim_set, 1);
+	dom = isl_basic_set_add_dims(dom, isl_dim_set, 1);
 	dom = isl_basic_set_extend_constraints(dom, 0, n);
 	for (i = 0; i < n; ++i) {
 		k = isl_basic_set_alloc_inequality(dom);
@@ -4652,6 +4706,7 @@ static void sol_for_add(struct isl_sol_for *sol,
 			isl_int_set(aff->v->el[0], M->row[0][0]);
 			isl_seq_cpy(aff->v->el + 1, M->row[i], M->n_col);
 		}
+		aff = isl_aff_normalize(aff);
 		list = isl_aff_list_add(list, aff);
 	}
 	isl_local_space_free(ls);
@@ -4729,11 +4784,13 @@ int isl_basic_map_foreach_lexopt(__isl_keep isl_basic_map *bmap, int max,
 	struct isl_sol_for *sol_for = NULL;
 
 	bmap = isl_basic_map_copy(bmap);
+	bmap = isl_basic_map_detect_equalities(bmap);
 	if (!bmap)
 		return -1;
 
-	bmap = isl_basic_map_detect_equalities(bmap);
 	sol_for = sol_for_init(bmap, max, fn, user);
+	if (!sol_for)
+		goto error;
 
 	if (isl_basic_map_plain_is_empty(bmap))
 		/* nothing */;
@@ -4932,13 +4989,19 @@ __isl_give isl_vec *isl_tab_basic_set_non_trivial_lexmin(
 {
 	int i, j;
 	int r;
-	isl_ctx *ctx = isl_basic_set_get_ctx(bset);
+	isl_ctx *ctx;
 	isl_vec *v = NULL;
-	isl_vec *sol = isl_vec_alloc(ctx, 0);
+	isl_vec *sol = NULL;
 	struct isl_tab *tab;
 	struct isl_trivial *triv = NULL;
 	int level, init;
 
+	if (!bset)
+		return NULL;
+
+	ctx = isl_basic_set_get_ctx(bset);
+	sol = isl_vec_alloc(ctx, 0);
+
 	tab = tab_for_lexmin(bset, NULL, 0, 0);
 	if (!tab)
 		goto error;
@@ -4957,7 +5020,7 @@ __isl_give isl_vec *isl_tab_basic_set_non_trivial_lexmin(
 		int side, base;
 
 		if (init) {
-			tab = cut_to_integer_lexmin(tab);
+			tab = cut_to_integer_lexmin(tab, CUT_ONE);
 			if (!tab)
 				goto error;
 			if (tab->empty)
@@ -5054,6 +5117,9 @@ __isl_give isl_vec *isl_tab_basic_set_non_neg_lexmin(
 	isl_ctx *ctx = isl_basic_set_get_ctx(bset);
 	isl_vec *sol;
 
+	if (!bset)
+		return NULL;
+
 	tab = tab_for_lexmin(bset, NULL, 0, 0);
 	if (!tab)
 		goto error;