X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=isl_convex_hull.c;h=dc8ac917a517b4396107f48526965ea278f649f8;hb=de51a9bc4da5dd3f1f9f57c2362da6f9752c44e0;hp=17212c36d5c94d000ac28547d59a0dc1e249293b;hpb=d1374f24acec4c3b3e65f1c6f44b54406500470d;p=platform%2Fupstream%2Fisl.git

diff --git a/isl_convex_hull.c b/isl_convex_hull.c
index 17212c3..dc8ac91 100644
--- a/isl_convex_hull.c
+++ b/isl_convex_hull.c
@@ -1,34 +1,25 @@
 /*
  * Copyright 2008-2009 Katholieke Universiteit Leuven
  *
- * Use of this software is governed by the GNU LGPLv2.1 license
+ * Use of this software is governed by the MIT license
  *
  * Written by Sven Verdoolaege, K.U.Leuven, Departement
  * Computerwetenschappen, Celestijnenlaan 200A, B-3001 Leuven, Belgium
  */
 
-#include "isl_lp.h"
-#include "isl_map.h"
-#include "isl_map_private.h"
-#include "isl_mat.h"
-#include "isl_set.h"
-#include "isl_seq.h"
+#include <isl_ctx_private.h>
+#include <isl_map_private.h>
+#include <isl/lp.h>
+#include <isl/map.h>
+#include <isl_mat_private.h>
+#include <isl/set.h>
+#include <isl/seq.h>
+#include <isl_options_private.h>
 #include "isl_equalities.h"
 #include "isl_tab.h"
 
 static struct isl_basic_set *uset_convex_hull_wrap_bounded(struct isl_set *set);
 
-static void swap_ineq(struct isl_basic_map *bmap, unsigned i, unsigned j)
-{
-	isl_int *t;
-
-	if (i != j) {
-		t = bmap->ineq[i];
-		bmap->ineq[i] = bmap->ineq[j];
-		bmap->ineq[j] = t;
-	}
-}
-
 /* Return 1 if constraint c is redundant with respect to the constraints
  * in bmap.  If c is a lower [upper] bound in some variable and bmap
  * does not have a lower [upper] bound in that variable, then c cannot
@@ -79,7 +70,7 @@ int isl_basic_set_constraint_is_redundant(struct isl_basic_set **bset,
 			(struct isl_basic_map **)bset, c, opt_n, opt_d);
 }
 
-/* Compute the convex hull of a basic map, by removing the redundant
+/* Remove redundant
  * constraints.  If the minimal value along the normal of a constraint
  * is the same if the constraint is removed, then the constraint is redundant.
  *
@@ -87,7 +78,8 @@ int isl_basic_set_constraint_is_redundant(struct isl_basic_set **bset,
  * corresponding equality and the checked if the dimension was that
  * of a facet.
  */
-struct isl_basic_map *isl_basic_map_convex_hull(struct isl_basic_map *bmap)
+__isl_give isl_basic_map *isl_basic_map_remove_redundancies(
+	__isl_take isl_basic_map *bmap)
 {
 	struct isl_tab *tab;
 
@@ -102,8 +94,9 @@ struct isl_basic_map *isl_basic_map_convex_hull(struct isl_basic_map *bmap)
 	if (bmap->n_ineq <= 1)
 		return bmap;
 
-	tab = isl_tab_from_basic_map(bmap);
-	tab = isl_tab_detect_implicit_equalities(tab);
+	tab = isl_tab_from_basic_map(bmap, 0);
+	if (isl_tab_detect_implicit_equalities(tab) < 0)
+		goto error;
 	if (isl_tab_detect_redundant(tab) < 0)
 		goto error;
 	bmap = isl_basic_map_update_from_tab(bmap, tab);
@@ -117,10 +110,24 @@ error:
 	return NULL;
 }
 
-struct isl_basic_set *isl_basic_set_convex_hull(struct isl_basic_set *bset)
+__isl_give isl_basic_set *isl_basic_set_remove_redundancies(
+	__isl_take isl_basic_set *bset)
 {
 	return (struct isl_basic_set *)
-		isl_basic_map_convex_hull((struct isl_basic_map *)bset);
+		isl_basic_map_remove_redundancies((struct isl_basic_map *)bset);
+}
+
+/* Remove redundant constraints in each of the basic maps.
+ */
+__isl_give isl_map *isl_map_remove_redundancies(__isl_take isl_map *map)
+{
+	return isl_map_inline_foreach_basic_map(map,
+					    &isl_basic_map_remove_redundancies);
+}
+
+__isl_give isl_set *isl_set_remove_redundancies(__isl_take isl_set *set)
+{
+	return isl_map_remove_redundancies(set);
 }
 
 /* Check if the set set is bound in the direction of the affine
@@ -171,47 +178,62 @@ error:
 	return -1;
 }
 
-struct isl_basic_set *isl_basic_set_set_rational(struct isl_basic_set *bset)
+__isl_give isl_basic_map *isl_basic_map_set_rational(
+	__isl_take isl_basic_set *bmap)
 {
-	if (!bset)
+	if (!bmap)
 		return NULL;
 
-	if (ISL_F_ISSET(bset, ISL_BASIC_MAP_RATIONAL))
-		return bset;
+	if (ISL_F_ISSET(bmap, ISL_BASIC_MAP_RATIONAL))
+		return bmap;
 
-	bset = isl_basic_set_cow(bset);
-	if (!bset)
+	bmap = isl_basic_map_cow(bmap);
+	if (!bmap)
 		return NULL;
 
-	ISL_F_SET(bset, ISL_BASIC_MAP_RATIONAL);
+	ISL_F_SET(bmap, ISL_BASIC_MAP_RATIONAL);
 
-	return isl_basic_set_finalize(bset);
+	return isl_basic_map_finalize(bmap);
 }
 
-static struct isl_set *isl_set_set_rational(struct isl_set *set)
+__isl_give isl_basic_set *isl_basic_set_set_rational(
+	__isl_take isl_basic_set *bset)
+{
+	return isl_basic_map_set_rational(bset);
+}
+
+__isl_give isl_map *isl_map_set_rational(__isl_take isl_map *map)
 {
 	int i;
 
-	set = isl_set_cow(set);
-	if (!set)
+	map = isl_map_cow(map);
+	if (!map)
 		return NULL;
-	for (i = 0; i < set->n; ++i) {
-		set->p[i] = isl_basic_set_set_rational(set->p[i]);
-		if (!set->p[i])
+	for (i = 0; i < map->n; ++i) {
+		map->p[i] = isl_basic_map_set_rational(map->p[i]);
+		if (!map->p[i])
 			goto error;
 	}
-	return set;
+	return map;
 error:
-	isl_set_free(set);
+	isl_map_free(map);
 	return NULL;
 }
 
+__isl_give isl_set *isl_set_set_rational(__isl_take isl_set *set)
+{
+	return isl_map_set_rational(set);
+}
+
 static struct isl_basic_set *isl_basic_set_add_equality(
 	struct isl_basic_set *bset, isl_int *c)
 {
 	int i;
 	unsigned dim;
 
+	if (!bset)
+		return NULL;
+
 	if (ISL_F_ISSET(bset, ISL_BASIC_SET_EMPTY))
 		return bset;
 
@@ -284,6 +306,7 @@ static struct isl_basic_set *wrap_constraints(struct isl_set *set)
 		n_ineq += set->p[i]->n_ineq;
 	}
 	lp = isl_basic_set_alloc(set->ctx, 0, dim * set->n, 0, n_eq, n_ineq);
+	lp = isl_basic_set_set_rational(lp);
 	if (!lp)
 		return NULL;
 	lp_dim = isl_basic_set_n_dim(lp);
@@ -377,6 +400,7 @@ isl_int *isl_set_wrap_facet(__isl_keep isl_set *set,
 	isl_int *facet, isl_int *ridge)
 {
 	int i;
+	isl_ctx *ctx;
 	struct isl_mat *T = NULL;
 	struct isl_basic_set *lp = NULL;
 	struct isl_vec *obj;
@@ -384,11 +408,14 @@ isl_int *isl_set_wrap_facet(__isl_keep isl_set *set,
 	isl_int num, den;
 	unsigned dim;
 
+	if (!set)
+		return NULL;
+	ctx = set->ctx;
 	set = isl_set_copy(set);
 	set = isl_set_set_rational(set);
 
 	dim = 1 + isl_set_n_dim(set);
-	T = isl_mat_alloc(set->ctx, 3, dim);
+	T = isl_mat_alloc(ctx, 3, dim);
 	if (!T)
 		goto error;
 	isl_int_set_si(T->row[0][0], 1);
@@ -401,7 +428,7 @@ isl_int *isl_set_wrap_facet(__isl_keep isl_set *set,
 	if (!set)
 		goto error;
 	lp = wrap_constraints(set);
-	obj = isl_vec_alloc(set->ctx, 1 + dim*set->n);
+	obj = isl_vec_alloc(ctx, 1 + dim*set->n);
 	if (!obj)
 		goto error;
 	isl_int_set_si(obj->block.data[0], 0);
@@ -413,17 +440,20 @@ isl_int *isl_set_wrap_facet(__isl_keep isl_set *set,
 	isl_int_init(num);
 	isl_int_init(den);
 	res = isl_basic_set_solve_lp(lp, 0,
-			    obj->block.data, set->ctx->one, &num, &den, NULL);
+			    obj->block.data, ctx->one, &num, &den, NULL);
 	if (res == isl_lp_ok) {
 		isl_int_neg(num, num);
 		isl_seq_combine(facet, num, facet, den, ridge, dim);
+		isl_seq_normalize(ctx, facet, dim);
 	}
 	isl_int_clear(num);
 	isl_int_clear(den);
 	isl_vec_free(obj);
 	isl_basic_set_free(lp);
 	isl_set_free(set);
-	isl_assert(set->ctx, res == isl_lp_ok || res == isl_lp_unbounded, 
+	if (res == isl_lp_error)
+		return NULL;
+	isl_assert(ctx, res == isl_lp_ok || res == isl_lp_unbounded, 
 		   return NULL);
 	return facet;
 error:
@@ -450,11 +480,10 @@ static __isl_give isl_mat *initial_facet_constraint(__isl_keep isl_set *set)
 {
 	struct isl_set *slice = NULL;
 	struct isl_basic_set *face = NULL;
-	struct isl_mat *m, *U, *Q;
 	int i;
 	unsigned dim = isl_set_n_dim(set);
 	int is_bound;
-	isl_mat *bounds;
+	isl_mat *bounds = NULL;
 
 	isl_assert(set->ctx, set->n > 0, goto error);
 	bounds = isl_mat_alloc(set->ctx, 1, 1 + dim);
@@ -464,7 +493,9 @@ static __isl_give isl_mat *initial_facet_constraint(__isl_keep isl_set *set)
 	isl_seq_clr(bounds->row[0], dim);
 	isl_int_set_si(bounds->row[0][1 + dim - 1], 1);
 	is_bound = uset_is_bound(set, bounds->row[0], 1 + dim);
-	isl_assert(set->ctx, is_bound == 1, goto error);
+	if (is_bound < 0)
+		goto error;
+	isl_assert(set->ctx, is_bound, goto error);
 	isl_seq_normalize(set->ctx, bounds->row[0], 1 + dim);
 	bounds->n_row = 1;
 
@@ -559,7 +590,8 @@ static struct isl_basic_set *compute_facet(struct isl_set *set, isl_int *c)
 	set = isl_set_preimage(set, U);
 	facet = uset_convex_hull_wrap_bounded(set);
 	facet = isl_basic_set_preimage(facet, Q);
-	isl_assert(ctx, facet->n_eq == 0, goto error);
+	if (facet)
+		isl_assert(ctx, facet->n_eq == 0, goto error);
 	return facet;
 error:
 	isl_basic_set_free(facet);
@@ -613,11 +645,13 @@ static struct isl_basic_set *extend(struct isl_basic_set *hull,
 		hull_facet = isl_basic_set_add_equality(hull_facet, hull->ineq[i]);
 		hull_facet = isl_basic_set_gauss(hull_facet, NULL);
 		hull_facet = isl_basic_set_normalize_constraints(hull_facet);
-		if (!facet)
+		if (!facet || !hull_facet)
 			goto error;
 		hull = isl_basic_set_cow(hull);
-		hull = isl_basic_set_extend_dim(hull,
-			isl_dim_copy(hull->dim), 0, 0, facet->n_ineq);
+		hull = isl_basic_set_extend_space(hull,
+			isl_space_copy(hull->dim), 0, 0, facet->n_ineq);
+		if (!hull)
+			goto error;
 		for (j = 0; j < facet->n_ineq; ++j) {
 			for (f = 0; f < hull_facet->n_ineq; ++f)
 				if (isl_seq_eq(facet->ineq[j],
@@ -769,13 +803,6 @@ error:
 	return NULL;
 }
 
-/* Project out final n dimensions using Fourier-Motzkin */
-static struct isl_set *set_project_out(struct isl_ctx *ctx,
-	struct isl_set *set, unsigned n)
-{
-	return isl_set_remove_dims(set, isl_set_n_dim(set) - n, n);
-}
-
 static struct isl_basic_set *convex_hull_0d(struct isl_set *set)
 {
 	struct isl_basic_set *convex_hull;
@@ -784,9 +811,9 @@ static struct isl_basic_set *convex_hull_0d(struct isl_set *set)
 		return NULL;
 
 	if (isl_set_is_empty(set))
-		convex_hull = isl_basic_set_empty(isl_dim_copy(set->dim));
+		convex_hull = isl_basic_set_empty(isl_space_copy(set->dim));
 	else
-		convex_hull = isl_basic_set_universe(isl_dim_copy(set->dim));
+		convex_hull = isl_basic_set_universe(isl_space_copy(set->dim));
 	isl_set_free(set);
 	return convex_hull;
 }
@@ -852,8 +879,8 @@ static struct isl_basic_set *convex_hull_pair_elim(struct isl_basic_set *bset1,
 		isl_int_set_si(hull->eq[k][2*(1+dim)+j], 1);
 	}
 	hull = isl_basic_set_set_rational(hull);
-	hull = isl_basic_set_remove_dims(hull, dim, 2*(1+dim));
-	hull = isl_basic_set_convex_hull(hull);
+	hull = isl_basic_set_remove_dims(hull, isl_dim_set, dim, 2*(1+dim));
+	hull = isl_basic_set_remove_redundancies(hull);
 	isl_basic_set_free(bset1);
 	isl_basic_set_free(bset2);
 	return hull;
@@ -864,26 +891,52 @@ error:
 	return NULL;
 }
 
-static int isl_basic_set_is_bounded(struct isl_basic_set *bset)
+/* Is the set bounded for each value of the parameters?
+ */
+int isl_basic_set_is_bounded(__isl_keep isl_basic_set *bset)
 {
 	struct isl_tab *tab;
 	int bounded;
 
 	if (!bset)
 		return -1;
-	if (isl_basic_set_fast_is_empty(bset))
+	if (isl_basic_set_plain_is_empty(bset))
 		return 1;
 
-	tab = isl_tab_from_recession_cone(bset);
+	tab = isl_tab_from_recession_cone(bset, 1);
 	bounded = isl_tab_cone_is_bounded(tab);
 	isl_tab_free(tab);
 	return bounded;
 }
 
+/* Is the image bounded for each value of the parameters and
+ * the domain variables?
+ */
+int isl_basic_map_image_is_bounded(__isl_keep isl_basic_map *bmap)
+{
+	unsigned nparam = isl_basic_map_dim(bmap, isl_dim_param);
+	unsigned n_in = isl_basic_map_dim(bmap, isl_dim_in);
+	int bounded;
+
+	bmap = isl_basic_map_copy(bmap);
+	bmap = isl_basic_map_cow(bmap);
+	bmap = isl_basic_map_move_dims(bmap, isl_dim_param, nparam,
+					isl_dim_in, 0, n_in);
+	bounded = isl_basic_set_is_bounded((isl_basic_set *)bmap);
+	isl_basic_map_free(bmap);
+
+	return bounded;
+}
+
+/* Is the set bounded for each value of the parameters?
+ */
 int isl_set_is_bounded(__isl_keep isl_set *set)
 {
 	int i;
 
+	if (!set)
+		return -1;
+
 	for (i = 0; i < set->n; ++i) {
 		int bounded = isl_basic_set_is_bounded(set->p[i]);
 		if (!bounded || bounded < 0)
@@ -909,7 +962,7 @@ static struct isl_basic_set *induced_lineality_space(
 		goto error;
 
 	dim = isl_basic_set_total_dim(bset1);
-	lin = isl_basic_set_alloc_dim(isl_basic_set_get_dim(bset1), 0,
+	lin = isl_basic_set_alloc_space(isl_basic_set_get_space(bset1), 0,
 					bset1->n_eq + bset2->n_eq,
 					bset1->n_ineq + bset2->n_ineq);
 	lin = isl_basic_set_set_rational(lin);
@@ -987,7 +1040,7 @@ static struct isl_basic_set *modulo_lineality(struct isl_set *set,
 	if (!set || !lin)
 		goto error;
 	lin_dim = total - lin->n_eq;
-	M = isl_mat_sub_alloc(set->ctx, lin->eq, 0, lin->n_eq, 1, total);
+	M = isl_mat_sub_alloc6(set->ctx, lin->eq, 0, lin->n_eq, 1, total);
 	M = isl_mat_left_hermite(M, 0, &U, &Q);
 	if (!M)
 		goto error;
@@ -1000,7 +1053,7 @@ static struct isl_basic_set *modulo_lineality(struct isl_set *set,
 	Q = isl_mat_lin_to_aff(Q);
 
 	set = isl_set_preimage(set, U);
-	set = isl_set_remove_dims(set, total - lin_dim, lin_dim);
+	set = isl_set_remove_dims(set, isl_dim_set, total - lin_dim, lin_dim);
 	hull = uset_convex_hull(set);
 	hull = isl_basic_set_preimage(hull, Q);
 
@@ -1023,7 +1076,7 @@ error:
 static struct isl_basic_set *valid_direction_lp(
 	struct isl_basic_set *bset1, struct isl_basic_set *bset2)
 {
-	struct isl_dim *dim;
+	isl_space *dim;
 	struct isl_basic_set *lp;
 	unsigned d;
 	int n;
@@ -1034,8 +1087,8 @@ static struct isl_basic_set *valid_direction_lp(
 	d = 1 + isl_basic_set_total_dim(bset1);
 	n = 2 +
 	    2 * bset1->n_eq + bset1->n_ineq + 2 * bset2->n_eq + bset2->n_ineq;
-	dim = isl_dim_set_alloc(bset1->ctx, 0, n);
-	lp = isl_basic_set_alloc_dim(dim, 0, d, n);
+	dim = isl_space_set_alloc(bset1->ctx, 0, n);
+	lp = isl_basic_set_alloc_space(dim, 0, d, n);
 	if (!lp)
 		goto error;
 	for (i = 0; i < n; ++i) {
@@ -1051,23 +1104,25 @@ static struct isl_basic_set *valid_direction_lp(
 		if (k < 0)
 			goto error;
 		n = 0;
-		isl_int_set_si(lp->eq[k][n++], 0);
+		isl_int_set_si(lp->eq[k][n], 0); n++;
 		/* positivity constraint 1 >= 0 */
-		isl_int_set_si(lp->eq[k][n++], i == 0);
+		isl_int_set_si(lp->eq[k][n], i == 0); n++;
 		for (j = 0; j < bset1->n_eq; ++j) {
-			isl_int_set(lp->eq[k][n++], bset1->eq[j][i]);
-			isl_int_neg(lp->eq[k][n++], bset1->eq[j][i]);
+			isl_int_set(lp->eq[k][n], bset1->eq[j][i]); n++;
+			isl_int_neg(lp->eq[k][n], bset1->eq[j][i]); n++;
+		}
+		for (j = 0; j < bset1->n_ineq; ++j) {
+			isl_int_set(lp->eq[k][n], bset1->ineq[j][i]); n++;
 		}
-		for (j = 0; j < bset1->n_ineq; ++j)
-			isl_int_set(lp->eq[k][n++], bset1->ineq[j][i]);
 		/* positivity constraint 1 >= 0 */
-		isl_int_set_si(lp->eq[k][n++], -(i == 0));
+		isl_int_set_si(lp->eq[k][n], -(i == 0)); n++;
 		for (j = 0; j < bset2->n_eq; ++j) {
-			isl_int_neg(lp->eq[k][n++], bset2->eq[j][i]);
-			isl_int_set(lp->eq[k][n++], bset2->eq[j][i]);
+			isl_int_neg(lp->eq[k][n], bset2->eq[j][i]); n++;
+			isl_int_set(lp->eq[k][n], bset2->eq[j][i]); n++;
+		}
+		for (j = 0; j < bset2->n_ineq; ++j) {
+			isl_int_neg(lp->eq[k][n], bset2->ineq[j][i]); n++;
 		}
-		for (j = 0; j < bset2->n_ineq; ++j)
-			isl_int_neg(lp->eq[k][n++], bset2->ineq[j][i]);
 	}
 	lp = isl_basic_set_gauss(lp, NULL);
 	isl_basic_set_free(bset1);
@@ -1114,7 +1169,7 @@ static struct isl_vec *valid_direction(
 		goto error;
 	lp = valid_direction_lp(isl_basic_set_copy(bset1),
 				isl_basic_set_copy(bset2));
-	tab = isl_tab_from_basic_set(lp);
+	tab = isl_tab_from_basic_set(lp, 0);
 	sample = isl_tab_get_sample_value(tab);
 	isl_tab_free(tab);
 	isl_basic_set_free(lp);
@@ -1127,7 +1182,7 @@ static struct isl_vec *valid_direction(
 	isl_seq_clr(dir->block.data + 1, dir->size - 1);
 	n = 1;
 	/* positivity constraint 1 >= 0 */
-	isl_int_set(dir->block.data[0], sample->block.data[n++]);
+	isl_int_set(dir->block.data[0], sample->block.data[n]); n++;
 	for (i = 0; i < bset1->n_eq; ++i) {
 		isl_int_sub(sample->block.data[n],
 			    sample->block.data[n], sample->block.data[n+1]);
@@ -1268,7 +1323,7 @@ static struct isl_basic_set *convex_hull_pair_pointed(
 
 	bset1 = homogeneous_map(bset1, isl_mat_copy(T2));
 	bset2 = homogeneous_map(bset2, T2);
-	set = isl_set_alloc_dim(isl_basic_set_get_dim(bset1), 2, 0);
+	set = isl_set_alloc_space(isl_basic_set_get_space(bset1), 2, 0);
 	set = isl_set_add_basic_set(set, bset1);
 	set = isl_set_add_basic_set(set, bset2);
 	hull = uset_convex_hull(set);
@@ -1307,6 +1362,9 @@ static struct isl_basic_set *convex_hull_pair(struct isl_basic_set *bset1,
 	isl_basic_set *lin, *aff;
 	int bounded1, bounded2;
 
+	if (bset1->ctx->opt->convex == ISL_CONVEX_HULL_FM)
+		return convex_hull_pair_elim(bset1, bset2);
+
 	aff = isl_set_affine_hull(isl_basic_set_union(isl_basic_set_copy(bset1),
 						    isl_basic_set_copy(bset2)));
 	if (!aff)
@@ -1338,7 +1396,7 @@ static struct isl_basic_set *convex_hull_pair(struct isl_basic_set *bset1,
 	}
 	if (lin->n_eq < isl_basic_set_total_dim(lin)) {
 		struct isl_set *set;
-		set = isl_set_alloc_dim(isl_basic_set_get_dim(bset1), 2, 0);
+		set = isl_set_alloc_space(isl_basic_set_get_space(bset1), 2, 0);
 		set = isl_set_add_basic_set(set, bset1);
 		set = isl_set_add_basic_set(set, bset2);
 		return modulo_lineality(set, lin);
@@ -1368,7 +1426,7 @@ struct isl_basic_set *isl_basic_set_lineality_space(struct isl_basic_set *bset)
 	isl_assert(bset->ctx, bset->n_div == 0, goto error);
 	dim = isl_basic_set_total_dim(bset);
 
-	lin = isl_basic_set_alloc_dim(isl_basic_set_get_dim(bset), 0, dim, 0);
+	lin = isl_basic_set_alloc_space(isl_basic_set_get_space(bset), 0, dim, 0);
 	if (!lin)
 		goto error;
 	for (i = 0; i < bset->n_eq; ++i) {
@@ -1410,12 +1468,12 @@ static struct isl_basic_set *uset_combined_lineality_space(struct isl_set *set)
 	if (!set)
 		return NULL;
 	if (set->n == 0) {
-		struct isl_dim *dim = isl_set_get_dim(set);
+		isl_space *dim = isl_set_get_space(set);
 		isl_set_free(set);
 		return isl_basic_set_empty(dim);
 	}
 
-	lin = isl_set_alloc_dim(isl_set_get_dim(set), set->n, 0);
+	lin = isl_set_alloc_space(isl_set_get_space(set), set->n, 0);
 	for (i = 0; i < set->n; ++i)
 		lin = isl_set_add_basic_set(lin,
 		    isl_basic_set_lineality_space(isl_basic_set_copy(set->p[i])));
@@ -1613,9 +1671,9 @@ static struct isl_basic_set *common_constraints(struct isl_basic_set *hull,
 	if (isl_hash_table_init(hull->ctx, table, min_constraints))
 		goto error;
 
-	total = isl_dim_total(set->dim);
+	total = isl_space_dim(set->dim, isl_dim_all);
 	for (i = 0; i < set->p[best]->n_ineq; ++i) {
-		constraints[i].c = isl_mat_sub_alloc(hull->ctx,
+		constraints[i].c = isl_mat_sub_alloc6(hull->ctx,
 			set->p[best]->ineq + i, 0, 1, 0, 1 + total);
 		if (!constraints[i].c)
 			goto error;
@@ -1710,7 +1768,7 @@ static struct isl_basic_set *proto_hull(struct isl_set *set, int *is_hull)
 		n_ineq += set->p[i]->n_eq;
 		n_ineq += set->p[i]->n_ineq;
 	}
-	hull = isl_basic_set_alloc_dim(isl_dim_copy(set->dim), 0, 0, n_ineq);
+	hull = isl_basic_set_alloc_space(isl_space_copy(set->dim), 0, 0, n_ineq);
 	hull = isl_basic_set_set_rational(hull);
 	if (!hull)
 		return NULL;
@@ -1762,7 +1820,8 @@ static struct isl_basic_set *uset_convex_hull(struct isl_set *set)
 	if (isl_set_n_dim(set) == 1)
 		return convex_hull_1d(set);
 
-	if (isl_set_is_bounded(set))
+	if (isl_set_is_bounded(set) &&
+	    set->ctx->opt->convex == ISL_CONVEX_HULL_WRAP)
 		return uset_convex_hull_wrap(set);
 
 	lin = uset_combined_lineality_space(isl_set_copy(set));
@@ -1791,23 +1850,24 @@ static struct isl_basic_set *uset_convex_hull_wrap_bounded(struct isl_set *set)
 {
 	struct isl_basic_set *convex_hull = NULL;
 
+	if (!set)
+		goto error;
+
 	if (isl_set_n_dim(set) == 0) {
-		convex_hull = isl_basic_set_universe(isl_dim_copy(set->dim));
+		convex_hull = isl_basic_set_universe(isl_space_copy(set->dim));
 		isl_set_free(set);
 		convex_hull = isl_basic_set_set_rational(convex_hull);
 		return convex_hull;
 	}
 
 	set = isl_set_set_rational(set);
-
-	if (!set)
-		goto error;
 	set = isl_set_coalesce(set);
 	if (!set)
 		goto error;
 	if (set->n == 1) {
 		convex_hull = isl_basic_set_copy(set->p[0]);
 		isl_set_free(set);
+		convex_hull = isl_basic_map_remove_redundancies(convex_hull);
 		return convex_hull;
 	}
 	if (isl_set_n_dim(set) == 1)
@@ -1874,6 +1934,8 @@ struct isl_basic_map *isl_map_convex_hull(struct isl_map *map)
 
 	map = isl_map_detect_equalities(map);
 	map = isl_map_align_divs(map);
+	if (!map)
+		goto error;
 	model = isl_basic_map_copy(map->p[0]);
 	set = isl_map_underlying_set(map);
 	if (!set)
@@ -1890,6 +1952,8 @@ struct isl_basic_map *isl_map_convex_hull(struct isl_map *map)
 	}
 
 	convex_hull = isl_basic_map_overlying_set(bset, model);
+	if (!convex_hull)
+		return NULL;
 
 	ISL_F_SET(convex_hull, ISL_BASIC_MAP_NO_IMPLICIT);
 	ISL_F_SET(convex_hull, ISL_BASIC_MAP_ALL_EQUALITIES);
@@ -1907,6 +1971,19 @@ struct isl_basic_set *isl_set_convex_hull(struct isl_set *set)
 		isl_map_convex_hull((struct isl_map *)set);
 }
 
+__isl_give isl_basic_map *isl_map_polyhedral_hull(__isl_take isl_map *map)
+{
+	isl_basic_map *hull;
+
+	hull = isl_map_convex_hull(map);
+	return isl_basic_map_remove_divs(hull);
+}
+
+__isl_give isl_basic_set *isl_set_polyhedral_hull(__isl_take isl_set *set)
+{
+	return (isl_basic_set *)isl_map_polyhedral_hull((isl_map *)set);
+}
+
 struct sh_data_entry {
 	struct isl_hash_table	*table;
 	struct isl_tab		*tab;
@@ -2030,18 +2107,20 @@ error:
  * it can be relaxed (by increasing the constant term) to become
  * a bound for that basic set.  In the latter case, the constant
  * term is updated.
+ * Relaxation of the constant term is only allowed if "shift" is set.
+ *
  * Return 1 if "ineq" is a bound
  *	  0 if "ineq" may attain arbitrarily small values on basic set "j"
  *	 -1 if some error occurred
  */
 static int is_bound(struct sh_data *data, struct isl_set *set, int j,
-			isl_int *ineq)
+	isl_int *ineq, int shift)
 {
 	enum isl_lp_result res;
 	isl_int opt;
 
 	if (!data->p[j].tab) {
-		data->p[j].tab = isl_tab_from_basic_set(set->p[j]);
+		data->p[j].tab = isl_tab_from_basic_set(set->p[j], 0);
 		if (!data->p[j].tab)
 			return -1;
 	}
@@ -2050,8 +2129,12 @@ static int is_bound(struct sh_data *data, struct isl_set *set, int j,
 
 	res = isl_tab_min(data->p[j].tab, ineq, data->ctx->one,
 				&opt, NULL, 0);
-	if (res == isl_lp_ok && isl_int_is_neg(opt))
-		isl_int_sub(ineq[0], ineq[0], opt);
+	if (res == isl_lp_ok && isl_int_is_neg(opt)) {
+		if (shift)
+			isl_int_sub(ineq[0], ineq[0], opt);
+		else
+			res = isl_lp_unbounded;
+	}
 
 	isl_int_clear(opt);
 
@@ -2059,9 +2142,9 @@ static int is_bound(struct sh_data *data, struct isl_set *set, int j,
 	       res == isl_lp_unbounded ? 0 : -1;
 }
 
-/* Check if inequality "ineq" from basic set "i" can be relaxed to
+/* Check if inequality "ineq" from basic set "i" is or can be relaxed to
  * become a bound on the whole set.  If so, add the (relaxed) inequality
- * to "hull".
+ * to "hull".  Relaxation is only allowed if "shift" is set.
  *
  * We first check if "hull" already contains a translate of the inequality.
  * If so, we are done.
@@ -2077,7 +2160,8 @@ static int is_bound(struct sh_data *data, struct isl_set *set, int j,
  * the inequality accordingly.
  */
 static struct isl_basic_set *add_bound(struct isl_basic_set *hull,
-	struct sh_data *data, struct isl_set *set, int i, isl_int *ineq)
+	struct sh_data *data, struct isl_set *set, int i, isl_int *ineq,
+	int shift)
 {
 	uint32_t c_hash;
 	struct ineq_cmp_data v;
@@ -2112,7 +2196,7 @@ static struct isl_basic_set *add_bound(struct isl_basic_set *hull,
 
 	for (j = 0; j < i; ++j) {
 		int bound;
-		bound = is_bound(data, set, j, hull->ineq[k]);
+		bound = is_bound(data, set, j, hull->ineq[k], shift);
 		if (bound < 0)
 			goto error;
 		if (!bound)
@@ -2140,7 +2224,7 @@ static struct isl_basic_set *add_bound(struct isl_basic_set *hull,
 				isl_int_neg(ineq_j[0], ineq_j[0]);
 			continue;
 		}
-		bound = is_bound(data, set, j, hull->ineq[k]);
+		bound = is_bound(data, set, j, hull->ineq[k], shift);
 		if (bound < 0)
 			goto error;
 		if (!bound)
@@ -2163,12 +2247,12 @@ error:
 	return NULL;
 }
 
-/* Check if any inequality from basic set "i" can be relaxed to
+/* Check if any inequality from basic set "i" is or can be relaxed to
  * become a bound on the whole set.  If so, add the (relaxed) inequality
- * to "hull".
+ * to "hull".  Relaxation is only allowed if "shift" is set.
  */
 static struct isl_basic_set *add_bounds(struct isl_basic_set *bset,
-	struct sh_data *data, struct isl_set *set, int i)
+	struct sh_data *data, struct isl_set *set, int i, int shift)
 {
 	int j, k;
 	unsigned dim = isl_basic_set_total_dim(bset);
@@ -2176,18 +2260,21 @@ static struct isl_basic_set *add_bounds(struct isl_basic_set *bset,
 	for (j = 0; j < set->p[i]->n_eq; ++j) {
 		for (k = 0; k < 2; ++k) {
 			isl_seq_neg(set->p[i]->eq[j], set->p[i]->eq[j], 1+dim);
-			bset = add_bound(bset, data, set, i, set->p[i]->eq[j]);
+			bset = add_bound(bset, data, set, i, set->p[i]->eq[j],
+					    shift);
 		}
 	}
 	for (j = 0; j < set->p[i]->n_ineq; ++j)
-		bset = add_bound(bset, data, set, i, set->p[i]->ineq[j]);
+		bset = add_bound(bset, data, set, i, set->p[i]->ineq[j], shift);
 	return bset;
 }
 
 /* Compute a superset of the convex hull of set that is described
- * by only translates of the constraints in the constituents of set.
+ * by only (translates of) the constraints in the constituents of set.
+ * Translation is only allowed if "shift" is set.
  */
-static struct isl_basic_set *uset_simple_hull(struct isl_set *set)
+static __isl_give isl_basic_set *uset_simple_hull(__isl_take isl_set *set,
+	int shift)
 {
 	struct sh_data *data = NULL;
 	struct isl_basic_set *hull = NULL;
@@ -2204,7 +2291,7 @@ static struct isl_basic_set *uset_simple_hull(struct isl_set *set)
 		n_ineq += 2 * set->p[i]->n_eq + set->p[i]->n_ineq;
 	}
 
-	hull = isl_basic_set_alloc_dim(isl_dim_copy(set->dim), 0, 0, n_ineq);
+	hull = isl_basic_set_alloc_space(isl_space_copy(set->dim), 0, 0, n_ineq);
 	if (!hull)
 		goto error;
 
@@ -2213,7 +2300,7 @@ static struct isl_basic_set *uset_simple_hull(struct isl_set *set)
 		goto error;
 
 	for (i = 0; i < set->n; ++i)
-		hull = add_bounds(hull, data, set, i);
+		hull = add_bounds(hull, data, set, i, shift);
 
 	sh_data_free(data);
 	isl_set_free(set);
@@ -2227,9 +2314,11 @@ error:
 }
 
 /* Compute a superset of the convex hull of map that is described
- * by only translates of the constraints in the constituents of map.
+ * by only (translates of) the constraints in the constituents of map.
+ * Translation is only allowed if "shift" is set.
  */
-struct isl_basic_map *isl_map_simple_hull(struct isl_map *map)
+static __isl_give isl_basic_map *map_simple_hull(__isl_take isl_map *map,
+	int shift)
 {
 	struct isl_set *set = NULL;
 	struct isl_basic_map *model = NULL;
@@ -2253,28 +2342,54 @@ struct isl_basic_map *isl_map_simple_hull(struct isl_map *map)
 	map = isl_map_detect_equalities(map);
 	affine_hull = isl_map_affine_hull(isl_map_copy(map));
 	map = isl_map_align_divs(map);
-	model = isl_basic_map_copy(map->p[0]);
+	model = map ? isl_basic_map_copy(map->p[0]) : NULL;
 
 	set = isl_map_underlying_set(map);
 
-	bset = uset_simple_hull(set);
+	bset = uset_simple_hull(set, shift);
 
 	hull = isl_basic_map_overlying_set(bset, model);
 
 	hull = isl_basic_map_intersect(hull, affine_hull);
-	hull = isl_basic_map_convex_hull(hull);
+	hull = isl_basic_map_remove_redundancies(hull);
+
+	if (!hull)
+		return NULL;
 	ISL_F_SET(hull, ISL_BASIC_MAP_NO_IMPLICIT);
 	ISL_F_SET(hull, ISL_BASIC_MAP_ALL_EQUALITIES);
 
 	return hull;
 }
 
+/* Compute a superset of the convex hull of map that is described
+ * by only translates of the constraints in the constituents of map.
+ */
+__isl_give isl_basic_map *isl_map_simple_hull(__isl_take isl_map *map)
+{
+	return map_simple_hull(map, 1);
+}
+
 struct isl_basic_set *isl_set_simple_hull(struct isl_set *set)
 {
 	return (struct isl_basic_set *)
 		isl_map_simple_hull((struct isl_map *)set);
 }
 
+/* Compute a superset of the convex hull of map that is described
+ * by only the constraints in the constituents of map.
+ */
+__isl_give isl_basic_map *isl_map_unshifted_simple_hull(
+	__isl_take isl_map *map)
+{
+	return map_simple_hull(map, 0);
+}
+
+__isl_give isl_basic_set *isl_set_unshifted_simple_hull(
+	__isl_take isl_set *set)
+{
+	return isl_map_unshifted_simple_hull(set);
+}
+
 /* Given a set "set", return parametric bounds on the dimension "dim".
  */
 static struct isl_basic_set *set_bounds(struct isl_set *set, int dim)