X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=examples%2Fp5solv;h=6f5424750bb19c2b51a82127b9b1c7b193f95f94;hb=4ddbcf346d1185bacbe63dba6e9317424b5206b9;hp=7a57f1caac53c00b1d88f83dbf5aa9a8149b09ae;hpb=6bdd2a75661ff480af9ca757f54bb5118168b65e;p=platform%2Fupstream%2Flibsolv.git

diff --git a/examples/p5solv b/examples/p5solv
index 7a57f1c..6f54247 100755
--- a/examples/p5solv
+++ b/examples/p5solv
@@ -15,14 +15,15 @@ package Repo::generic;
 sub new {
   my ($class, $alias, $type, $attr) = @_;
   my $r = { %{$attr || {}} };
-  $r->{'alias'} = $alias;
-  $r->{'type'} = $type;
+  $r->{alias} = $alias;
+  $r->{type} = $type;
   return bless $r, $class;
 }
 
 sub calc_cookie_fp {
   my ($self, $fp) = @_;
   my $chksum = solv::Chksum->new($solv::REPOKEY_TYPE_SHA256);
+  $chksum->add("1.1");
   $chksum->add_fp($fp);
   return $chksum->raw();
 }
@@ -35,34 +36,40 @@ sub calc_cookie_file {
   return $chksum->raw();
 }
 
+sub calc_cookie_ext {
+  my ($self, $f, $cookie) = @_;
+  my $chksum = solv::Chksum->new($solv::REPOKEY_TYPE_SHA256);
+  $chksum->add("1.1");
+  $chksum->add($cookie);
+  $chksum->add_fstat(fileno($f));
+  return $chksum->raw();
+}
+
 sub cachepath {
   my ($self, $ext) = @_;
-  my $path = $self->{'alias'};
+  my $path = $self->{alias};
   $path =~ s/^\./_/s;
   $path .= $ext ? "_$ext.solvx" : '.solv';
-  $path =~ s/\//_/gs;
+  $path =~ s!/!_!gs;
   return "/var/cache/solv/$path";
 }
 
 sub load {
   my ($self, $pool) = @_;
-  $self->{'handle'} = $pool->add_repo($self->{'alias'});
-  $self->{'handle'}->{'appdata'} = $self;
-  $self->{'handle'}->{'priority'} = 99 - $self->{'priority'};
-  my $dorefresh = $self->{'autorefresh'};
+  $self->{handle} = $pool->add_repo($self->{alias});
+  $self->{handle}->{appdata} = $self;
+  $self->{handle}->{priority} = 99 - $self->{priority};
+  my $dorefresh = $self->{autorefresh};
   if ($dorefresh) {
     my @s = stat($self->cachepath());
-    $dorefresh = 0 if @s && time() - $s[9] < $self->{'metadata_expire'};
+    $dorefresh = 0 if @s && ($self->{metadata_expire} == -1 || time() - $s[9] < $self->{metadata_expire});
   }
-  $self->{'cookie'} = '';
+  $self->{cookie} = '';
+  $self->{extcookie} = '';
   if (!$dorefresh && $self->usecachedrepo()) {
-    print "repo: '$self->{'alias'}' cached\n";
+    print "repo: '$self->{alias}' cached\n";
     return 1;
   }
-  return $self->load_if_changed();
-}
-
-sub load_if_changed {
   return 0;
 }
 
@@ -72,45 +79,44 @@ sub load_ext {
 
 sub download {
   my ($self, $file, $uncompress, $chksum, $markincomplete) = @_;
-  if (!$self->{'baseurl'}) {
-    print "$self->{'alias'}: no baseurl\n";
+  if (!$self->{baseurl}) {
+    print "$self->{alias}: no baseurl\n";
     return undef;
   }
-  my $url = $self->{'baseurl'};
-  $url =~ s/\/$//;
+  my $url = $self->{baseurl};
+  $url =~ s!/$!!;
   $url .= "/$file";
   open(my $f, '+>', undef) || die;
-  fcntl($f, Fcntl::F_SETFD, 0);
-  my $st = system('curl', '-f', '-s', '-L', '-o', "/dev/fd/".fileno($f), '--', $url);
+  fcntl($f, Fcntl::F_SETFD, 0);		# turn off CLOEXEC
+  my $st = system('curl', '-f', '-s', '-L', '-o', "/dev/fd/" . fileno($f), '--', $url);
   if (POSIX::lseek(fileno($f), 0, POSIX::SEEK_END) == 0 && ($st == 0 || !$chksum)) {
     return undef;
   }
   POSIX::lseek(fileno($f), 0, POSIX::SEEK_SET);
   if ($st) {
     print "$file: download error #$st\n";
-    $self->{'incomplete'} = 1 if $markincomplete;
+    $self->{incomplete} = 1 if $markincomplete;
     return undef;
   }
   if ($chksum) {
-    my $fchksum = solv::Chksum->new($chksum->{'type'});
+    my $fchksum = solv::Chksum->new($chksum->{type});
     $fchksum->add_fd(fileno($f));
     if ($fchksum != $chksum) {
       print "$file: checksum error\n";
-      $self->{'incomplete'} = 1 if $markincomplete;
+      $self->{incomplete} = 1 if $markincomplete;
       return undef;
     }
   }
   if ($uncompress) {
-    return solv::xfopen_dup($file, fileno($f));
+    return solv::xfopen_fd($file, fileno($f));
   } else {
-    return solv::xfopen_dup(undef, fileno($f));
+    return solv::xfopen_fd(undef, fileno($f));
   }
 }
 
 sub usecachedrepo {
   my ($self, $ext, $mark) = @_;
-  my $cookie = $ext ? $self->{'extcookie'} : $self->{'cookie'};
-  my $handle = $self->{'handle'};
+  my $cookie = $ext ? $self->{extcookie} : $self->{cookie};
   my $cachepath = $self->cachepath($ext);
   my $fextcookie;
   if (sysopen(my $f, $cachepath, POSIX::O_RDONLY)) {
@@ -118,42 +124,28 @@ sub usecachedrepo {
     my $fcookie = '';
     return undef if sysread($f, $fcookie, 32) != 32;
     return undef if $cookie && $fcookie ne $cookie;
-    if ($self->{'type'} ne 'system' && !$ext) {
+    if ($self->{type} ne 'system' && !$ext) {
       sysseek($f, -32 * 2, Fcntl::SEEK_END);
       return undef if sysread($f, $fextcookie, 32) != 32;
     }
     sysseek($f, 0, Fcntl::SEEK_SET);
-    my $fd = solv::xfopen_dup(undef, fileno($f));
+    my $fd = solv::xfopen_fd(undef, fileno($f));
     my $flags = $ext ? $solv::Repo::REPO_USE_LOADING|$solv::Repo::REPO_EXTEND_SOLVABLES : 0;
     $flags |= $solv::Repo::REPO_LOCALPOOL if $ext && $ext ne 'DL';
-    if (!$self->{'handle'}->add_solv($fd, $flags)) {
-      solv::xfclose($fd);
+    if (!$self->{handle}->add_solv($fd, $flags)) {
       return undef;
     }
-    solv::xfclose($fd);
-    $self->{'cookie'} = $fcookie unless $ext;
-    $self->{'extcookie'} = $fextcookie if $fextcookie;
+    $self->{cookie} = $fcookie unless $ext;
+    $self->{extcookie} = $fextcookie if $fextcookie;
     utime undef, undef, $f if $mark;
     return 1;
   }
   return undef;
 }
 
-sub genextcookie {
-  my ($self, $f) = @_;
-  my $chksum = solv::Chksum->new($solv::REPOKEY_TYPE_SHA256);
-  $chksum->add($self->{'cookie'});
-  if ($f) {
-    my @s = stat($f);
-    $chksum->add("@s");
-  }
-  my $extcookie = $chksum->raw();
-  substr($extcookie, 0, 1) = chr(1) if ord(substr($extcookie, 0, 1)) == 0;
-  $self->{'extcookie'} = $extcookie;
-}
-
 sub writecachedrepo {
-  my ($self, $ext, $info) = @_;
+  my ($self, $ext, $repodata) = @_;
+  return if $self->{incomplete};
   mkdir("/var/cache/solv", 0755) unless -d "/var/cache/solv";
   my ($f, $tmpname);
   eval {
@@ -161,50 +153,84 @@ sub writecachedrepo {
   };
   return unless $f;
   chmod 0444, $f;
-  my $ff = solv::xfopen_dup(undef, fileno($f));
-  if (!$info) {
-    $self->{'handle'}->write($ff);
+  my $ff = solv::xfopen_fd(undef, fileno($f));
+  if (!$repodata) {
+    $self->{handle}->write($ff);
   } elsif ($ext) {
-    $info->write($ff);
+    $repodata->write($ff);
   } else {
-     $self->{'handle'}->write_first_repodata($ff);
+     $self->{handle}->write_first_repodata($ff);
   }
-  solv::xfclose($ff);
-  if ($self->{'type'} ne 'system' && !$ext) {
-    $self->genextcookie($f) unless $self->{'extcookie'};
-    syswrite($f, $self->{'extcookie'});
+  undef $ff;	# also flushes
+  if ($self->{type} ne 'system' && !$ext) {
+    $self->{extcookie} ||= $self->calc_cookie_ext($f, $self->{cookie});
+    syswrite($f, $self->{extcookie});
   }
-  syswrite($f, $ext ? $self->{'extcookie'} : $self->{'cookie'});
+  syswrite($f, $ext ? $self->{extcookie} : $self->{cookie});
   close($f);
-  if ($self->{'handle'}->iscontiguous()) {
+  if ($self->{handle}->iscontiguous()) {
     $f = solv::xfopen($tmpname);
     if ($f) {
       if (!$ext) {
-        $self->{'handle'}->empty();
-        die("internal error, cannot reload solv file\n") unless $self->{'handle'}->add_solv($f, $solv::Repo::SOLV_ADD_NO_STUBS);
+	$self->{handle}->empty();
+	die("internal error, cannot reload solv file\n") unless $self->{handle}->add_solv($f, $repodata ? 0 : $solv::Repo::SOLV_ADD_NO_STUBS);
       } else {
-	$info->extend_to_repo();
-	$info->add_solv($f, $solv::Repo::REPO_EXTEND_SOLVABLES);
+	$repodata->extend_to_repo();
+	my $flags = $solv::Repo::REPO_EXTEND_SOLVABLES;
+	$flags |= $solv::Repo::REPO_LOCALPOOL if $ext ne 'DL';
+	$repodata->add_solv($f, $flags);
       }
-      solv::xfclose($f);
     }
   }
   rename($tmpname, $self->cachepath($ext));
 }
 
+sub packagespath {
+  my ($self) = @_;
+  return '';
+}
+
+my %langtags = (
+  $solv::SOLVABLE_SUMMARY     => $solv::REPOKEY_TYPE_STR,
+  $solv::SOLVABLE_DESCRIPTION => $solv::REPOKEY_TYPE_STR,
+  $solv::SOLVABLE_EULA        => $solv::REPOKEY_TYPE_STR,
+  $solv::SOLVABLE_MESSAGEINS  => $solv::REPOKEY_TYPE_STR,
+  $solv::SOLVABLE_MESSAGEDEL  => $solv::REPOKEY_TYPE_STR,
+  $solv::SOLVABLE_CATEGORY    => $solv::REPOKEY_TYPE_ID,
+);
+
+sub add_ext_keys {
+  my ($self, $ext, $repodata, $handle) = @_;
+  if ($ext eq 'DL') {
+    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOSITORY_DELTAINFO);
+    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOKEY_TYPE_FLEXARRAY);
+  } elsif ($ext eq 'DU') {
+    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::SOLVABLE_DISKUSAGE);
+    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOKEY_TYPE_DIRNUMNUMARRAY);
+  } elsif ($ext eq 'FL') {
+    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::SOLVABLE_FILELIST);
+    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOKEY_TYPE_DIRSTRARRAY);
+  } else {
+    for my $langid (sort { $a <=> $b } keys %langtags) {
+      $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $self->{handle}->{pool}->id2langid($langid, $ext, 1));
+      $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $langtags{$langid});
+    }
+  }
+}
+
 package Repo::rpmmd;
 
 our @ISA = ('Repo::generic');
 
 sub find {
   my ($self, $what) = @_;
-  my $di = $self->{'handle'}->Dataiterator($solv::SOLVID_META, $solv::REPOSITORY_REPOMD_TYPE, $what, $solv::Dataiterator::SEARCH_STRING);
+  my $di = $self->{handle}->Dataiterator_meta($solv::REPOSITORY_REPOMD_TYPE, $what, $solv::Dataiterator::SEARCH_STRING);
   $di->prepend_keyname($solv::REPOSITORY_REPOMD);
   for my $d (@$di) {
-    $d->setpos_parent();
-    my $filename = $d->{'pool'}->lookup_str($solv::SOLVID_POS, $solv::REPOSITORY_REPOMD_LOCATION);
+    my $dp = $d->parentpos();
+    my $filename = $dp->lookup_str($solv::REPOSITORY_REPOMD_LOCATION);
     next unless $filename;
-    my $chksum = $d->{'pool'}->lookup_checksum($solv::SOLVID_POS, $solv::REPOSITORY_REPOMD_CHECKSUM);
+    my $chksum = $dp->lookup_checksum($solv::REPOSITORY_REPOMD_CHECKSUM);
     if (!$chksum) {
       print "no $filename file checksum!\n";
       return (undef, undef);
@@ -223,19 +249,14 @@ sub add_ext {
   $repodata->set_poolstr($handle, $solv::REPOSITORY_REPOMD_TYPE, $what);
   $repodata->set_str($handle, $solv::REPOSITORY_REPOMD_LOCATION, $filename);
   $repodata->set_checksum($handle, $solv::REPOSITORY_REPOMD_CHECKSUM, $chksum);
-  if ($ext eq 'DL') {
-    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOSITORY_DELTAINFO);
-    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOKEY_TYPE_FLEXARRAY);
-  } elsif ($ext eq 'FL') {
-    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::SOLVABLE_FILELIST);
-    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOKEY_TYPE_DIRSTRARRAY);
-  }
+  $self->add_ext_keys($ext, $repodata, $handle);
   $repodata->add_flexarray($solv::SOLVID_META, $solv::REPOSITORY_EXTERNAL, $handle);
 }
 
 sub add_exts {
   my ($self) = @_;
-  my $repodata = $self->{'handle'}->add_repodata(0);
+  my $repodata = $self->{handle}->add_repodata(0);
+  $repodata->extend_to_repo();
   $self->add_ext($repodata, 'deltainfo', 'DL');
   $self->add_ext($repodata, 'filelists', 'FL');
   $repodata->internalize();
@@ -252,7 +273,7 @@ sub load_ext {
   } else {
     return 0;
   }
-  print("[$self->{'alias'}:$ext: ");
+  print("[$self->{alias}:$ext: ");
   STDOUT->flush();
   if ($self->usecachedrepo($ext)) {
     print "cached]\n";
@@ -264,55 +285,51 @@ sub load_ext {
   my $f = $self->download($filename, 1, $filechksum);
   return 0 unless $f;
   if ($ext eq 'FL') {
-    $self->{'handle'}->add_rpmmd($f, 'FL', $solv::Repo::REPO_USE_LOADING|$solv::Repo::REPO_EXTEND_SOLVABLES);
-  } elsif ($ext eq 'FL') {
-    $self->{'handle'}->add_deltainfoxml($f, $solv::Repo::REPO_USE_LOADING);
+    $self->{handle}->add_rpmmd($f, 'FL', $solv::Repo::REPO_USE_LOADING|$solv::Repo::REPO_EXTEND_SOLVABLES|$solv::Repo::REPO_LOCALPOOL);
+  } elsif ($ext eq 'DL') {
+    $self->{handle}->add_deltainfoxml($f, $solv::Repo::REPO_USE_LOADING);
   }
-  solv::xfclose($f);
   $self->writecachedrepo($ext, $repodata);
   return 1;
 }
 
-sub load_if_changed {
-  my ($self) = @_;
-  print "rpmmd repo '$self->{'alias'}': ";
+sub load {
+  my ($self, $pool) = @_;
+  return 1 if $self->Repo::generic::load($pool);
+  print "rpmmd repo '$self->{alias}': ";
   STDOUT->flush();
   my $f = $self->download("repodata/repomd.xml");
   if (!$f) {
     print "no repomd.xml file, skipped\n";
-    $self->{'handle'}->free(1);
-    delete $self->{'handle'};
+    $self->{handle}->free(1);
+    delete $self->{handle};
     return undef;
   }
-  $self->{'cookie'} = $self->calc_cookie_fp($f);
+  $self->{cookie} = $self->calc_cookie_fp($f);
   if ($self->usecachedrepo(undef, 1)) {
     print "cached\n";
-    solv::xfclose($f);
     return 1;
   }
-  $self->{'handle'}->add_repomdxml($f, 0);
-  solv::xfclose($f);
+  $self->{handle}->add_repomdxml($f, 0);
   print "fetching\n";
   my ($filename, $filechksum) = $self->find('primary');
   if ($filename) {
     $f = $self->download($filename, 1, $filechksum, 1);
     if ($f) {
-      $self->{'handle'}->add_rpmmd($f, undef, 0);
-      solv::xfclose($f);
+      $self->{handle}->add_rpmmd($f, undef, 0);
     }
-    return undef if $self->{'incomplete'};
+    return undef if $self->{incomplete};
   }
   ($filename, $filechksum) = $self->find('updateinfo');
   if ($filename) {
     $f = $self->download($filename, 1, $filechksum, 1);
     if ($f) {
-      $self->{'handle'}->add_updateinfoxml($f, 0);
-      solv::xfclose($f);
+      $self->{handle}->add_updateinfoxml($f, 0);
     }
   }
   $self->add_exts();
-  $self->writecachedrepo() unless $self->{'incomplete'};
-  $self->{'handle'}->create_stubs();
+  $self->writecachedrepo();
+  $self->{handle}->create_stubs();
   return 1;
 }
 
@@ -323,53 +340,32 @@ our @ISA = ('Repo::generic');
 sub find {
   my ($self, $what) = @_;
   
-  my $di = $self->{'handle'}->Dataiterator($solv::SOLVID_META, $solv::SUSETAGS_FILE_NAME, $what, $solv::Dataiterator::SEARCH_STRING);
+  my $di = $self->{handle}->Dataiterator_meta($solv::SUSETAGS_FILE_NAME, $what, $solv::Dataiterator::SEARCH_STRING);
   $di->prepend_keyname($solv::SUSETAGS_FILE);
   for my $d (@$di) {
-    $d->setpos_parent();
-    my $chksum = $d->{'pool'}->lookup_checksum($solv::SOLVID_POS, $solv::SUSETAGS_FILE_CHECKSUM);
+    my $dp = $d->parentpos();
+    my $chksum = $dp->lookup_checksum($solv::SUSETAGS_FILE_CHECKSUM);
     return ($what, $chksum);
   }
   return (undef, undef);
 }
 
-my %langtags = (
-  $solv::SOLVABLE_SUMMARY     => $solv::REPOKEY_TYPE_STR,
-  $solv::SOLVABLE_DESCRIPTION => $solv::REPOKEY_TYPE_STR,
-  $solv::SOLVABLE_EULA        => $solv::REPOKEY_TYPE_STR,
-  $solv::SOLVABLE_MESSAGEINS  => $solv::REPOKEY_TYPE_STR,
-  $solv::SOLVABLE_MESSAGEDEL  => $solv::REPOKEY_TYPE_STR,
-  $solv::SOLVABLE_CATEGORY    => $solv::REPOKEY_TYPE_ID,
-);
 
 sub add_ext {
   my ($self, $repodata, $what, $ext) = @_;
   my ($filename, $chksum) = $self->find($what);
+  return unless $filename;
   my $handle = $repodata->new_handle();
   $repodata->set_str($handle, $solv::SUSETAGS_FILE_NAME, $filename);
   $repodata->set_checksum($handle, $solv::SUSETAGS_FILE_CHECKSUM, $chksum);
-  if ($ext eq 'DL') {
-    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOSITORY_DELTAINFO);
-    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOKEY_TYPE_FLEXARRAY);
-  } elsif ($ext eq 'DU') {
-    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::SOLVABLE_DISKUSAGE);
-    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOKEY_TYPE_DIRNUMNUMARRAY);
-  } elsif ($ext eq 'FL') {
-    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::SOLVABLE_FILELIST);
-    $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $solv::REPOKEY_TYPE_DIRSTRARRAY);
-  } else {
-    for my $langid (sort {$a <=> $b} keys %langtags) {
-      $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $self->{'handle'}->{'pool'}->id2langid($langid, $ext, 1));
-      $repodata->add_idarray($handle, $solv::REPOSITORY_KEYS, $langtags{$langid});
-    }
-  }
+  $self->add_ext_keys($ext, $repodata, $handle);
   $repodata->add_flexarray($solv::SOLVID_META, $solv::REPOSITORY_EXTERNAL, $handle);
 }
 
 sub add_exts {
   my ($self) = @_;
-  my $repodata = $self->{'handle'}->add_repodata(0);
-  my $di = $self->{'handle'}->Dataiterator($solv::SOLVID_META, $solv::SUSETAGS_FILE_NAME, undef, 0);
+  my $repodata = $self->{handle}->add_repodata(0);
+  my $di = $self->{handle}->Dataiterator_meta($solv::SUSETAGS_FILE_NAME, undef, 0);
   $di->prepend_keyname($solv::SUSETAGS_FILE);
   for my $d (@$di) {
     my $filename = $d->str();
@@ -384,78 +380,81 @@ sub load_ext {
   my ($self, $repodata) = @_;
   my $filename = $repodata->lookup_str($solv::SOLVID_META, $solv::SUSETAGS_FILE_NAME);
   my $ext = substr($filename, 9, 2);
-  print("[$self->{'alias'}:$ext: ");
+  print("[$self->{alias}:$ext: ");
   STDOUT->flush();
   if ($self->usecachedrepo($ext)) {
     print "cached]\n";
     return 1;
   }
   print "fetching]\n";
-  my $defvendorid = $self->{'handle'}->lookup_id($solv::SOLVID_META, $solv::SUSETAGS_DEFAULTVENDOR);
-  my $descrdir = $self->{'handle'}->lookup_str($solv::SOLVID_META, $solv::SUSETAGS_DESCRDIR) || 'suse/setup/descr'; 
+  my $defvendorid = $self->{handle}->{meta}->lookup_id($solv::SUSETAGS_DEFAULTVENDOR);
+  my $descrdir = $self->{handle}->{meta}->lookup_str($solv::SUSETAGS_DESCRDIR) || 'suse/setup/descr'; 
   my $filechksum = $repodata->lookup_checksum($solv::SOLVID_META, $solv::SUSETAGS_FILE_CHECKSUM);
   my $f = $self->download("$descrdir/$filename", 1, $filechksum);
   return 0 unless $f;
-  $self->{'handle'}->add_susetags($f, $defvendorid, $ext, $solv::Repo::REPO_USE_LOADING|$solv::Repo::REPO_EXTEND_SOLVABLES);
-  solv::xfclose($f);
+  my $flags = $solv::Repo::REPO_USE_LOADING|$solv::Repo::REPO_EXTEND_SOLVABLES;
+  $flags |= $solv::Repo::REPO_LOCALPOOL if $ext ne 'DL';
+  $self->{handle}->add_susetags($f, $defvendorid, $ext, $flags);
   $self->writecachedrepo($ext, $repodata);
   return 1;
 }
 
-sub load_if_changed {
-  my ($self) = @_;
-  print "susetags repo '$self->{'alias'}': ";
+sub load {
+  my ($self, $pool) = @_;
+  return 1 if $self->Repo::generic::load($pool);
+  print "susetags repo '$self->{alias}': ";
   STDOUT->flush();
   my $f = $self->download("content");
   if (!$f) {
     print "no content file, skipped\n";
-    $self->{'handle'}->free(1);
-    delete $self->{'handle'};
+    $self->{handle}->free(1);
+    delete $self->{handle};
     return undef;
   }
-  $self->{'cookie'} = $self->calc_cookie_fp($f);
+  $self->{cookie} = $self->calc_cookie_fp($f);
   if ($self->usecachedrepo(undef, 1)) {
     print "cached\n";
-    solv::xfclose($f);
     return 1;
   }
-  $self->{'handle'}->add_content($f, 0);
-  solv::xfclose($f);
+  $self->{handle}->add_content($f, 0);
   print "fetching\n";
-  my $defvendorid = $self->{'handle'}->lookup_id($solv::SOLVID_META, $solv::SUSETAGS_DEFAULTVENDOR);
-  my $descrdir = $self->{'handle'}->lookup_str($solv::SOLVID_META, $solv::SUSETAGS_DESCRDIR) || 'suse/setup/descr'; 
+  my $defvendorid = $self->{handle}->{meta}->lookup_id($solv::SUSETAGS_DEFAULTVENDOR);
+  my $descrdir = $self->{handle}->{meta}->lookup_str($solv::SUSETAGS_DESCRDIR) || 'suse/setup/descr'; 
   my ($filename, $filechksum) = $self->find('packages.gz');
   ($filename, $filechksum) = $self->find('packages') unless $filename;
   if ($filename) {
     $f = $self->download("$descrdir/$filename", 1, $filechksum, 1);
     if ($f) {
-      $self->{'handle'}->add_susetags($f, $defvendorid, undef, $solv::Repo::REPO_NO_INTERNALIZE|$solv::Repo::SUSETAGS_RECORD_SHARES);
-      solv::xfclose($f);
+      $self->{handle}->add_susetags($f, $defvendorid, undef, $solv::Repo::REPO_NO_INTERNALIZE|$solv::Repo::SUSETAGS_RECORD_SHARES);
       ($filename, $filechksum) = $self->find('packages.en.gz');
       ($filename, $filechksum) = $self->find('packages.en') unless $filename;
       if ($filename) {
-        $f = $self->download("$descrdir/$filename", 1, $filechksum, 1);
+	$f = $self->download("$descrdir/$filename", 1, $filechksum, 1);
 	if ($f) {
-          $self->{'handle'}->add_susetags($f, $defvendorid, undef, $solv::Repo::REPO_NO_INTERNALIZE|$solv::Repo::REPO_REUSE_REPODATA|$solv::Repo::REPO_EXTEND_SOLVABLES);
-          solv::xfclose($f);
+	  $self->{handle}->add_susetags($f, $defvendorid, undef, $solv::Repo::REPO_NO_INTERNALIZE|$solv::Repo::REPO_REUSE_REPODATA|$solv::Repo::REPO_EXTEND_SOLVABLES);
 	}
       }
-      $self->{'handle'}->internalize();
+      $self->{handle}->internalize();
     }
   }
   $self->add_exts();
-  $self->writecachedrepo() unless $self->{'incomplete'};
-  $self->{'handle'}->create_stubs();
+  $self->writecachedrepo();
+  $self->{handle}->create_stubs();
   return undef;
 }
 
+sub packagespath {
+  my ($self) = @_;
+  return ($self->{handle}->{meta}->lookup_str($solv::SUSETAGS_DATADIR) || 'suse') . '/';
+}
+
 package Repo::unknown;
 
 our @ISA = ('Repo::generic');
 
 sub load {
-  my ($self, $pool) = @_;
-  print "unsupported repo '$self->{'alias'}': skipped\n";
+  my ($self) = @_;
+  print "unsupported repo '$self->{alias}': skipped\n";
   return 0;
 }
 
@@ -466,192 +465,61 @@ our @ISA = ('Repo::generic');
 sub load {
   my ($self, $pool) = @_;
 
-  $self->{'handle'} = $pool->add_repo($self->{'alias'});
-  $self->{'handle'}->{'appdata'} = $self;
-  $pool->{'installed'} = $self->{'handle'};
+  $self->{handle} = $pool->add_repo($self->{alias});
+  $self->{handle}->{appdata} = $self;
+  $pool->{installed} = $self->{handle};
   print "rpm database: ";
-  $self->{'cookie'} = $self->calc_cookie_file('/var/lib/rpm/Packages');
+  $self->{cookie} = $self->calc_cookie_file('/var/lib/rpm/Packages');
   if ($self->usecachedrepo()) {
     print "cached\n";
     return 1;
   }
   print "reading\n";
-  $self->{'handle'}->add_products("/etc/products.d", $solv::Repo::REPO_NO_INTERNALIZE);
-  $self->{'handle'}->add_rpmdb(undef, $solv::Repo::REPO_REUSE_REPODATA);
+  if (defined(&solv::Repo::add_products)) {
+    $self->{handle}->add_products("/etc/products.d", $solv::Repo::REPO_NO_INTERNALIZE);
+  }
+  my $f = solv::xfopen($self->cachepath());
+  $self->{handle}->add_rpmdb_reffp($f, $solv::Repo::REPO_REUSE_REPODATA);
   $self->writecachedrepo();
   return 1;
 }
 
 package main;
 
-sub validarch {
-  my ($pool, $arch) = @_;
-  return undef unless $arch;
-  my $id = $pool->str2id($arch, 0);
-  return $id && $pool->isknownarch($id) ? 1 : undef;
-}
-
-sub depglob {
-  my ($pool, $name, $globname, $globdep) = @_;
-  my $id = $pool->str2id($name, 0);
-  if ($id) {
-    my $match;
-    for my $s ($pool->whatprovides($id)) {
-      return $pool->Job($solv::Job::SOLVER_SOLVABLE_NAME, $id) if $globname && $s->{'nameid'} == $id;
-      $match = 1;
-    }
-    if ($match) {
-      print "[using capability match for '$name']\n" if $globname && $globdep;
-      return $pool->Job($solv::Job::SOLVER_SOLVABLE_PROVIDES, $id);
-    }
-  }
-  return unless $name =~ /[[*?]/;
-  if ($globname) {
-    my %idmatches;
-    for my $d (@{$pool->Dataiterator(0, $solv::SOLVABLE_NAME, $name, $solv::Dataiterator::SEARCH_GLOB)}) {
-      my $s = $d->{'solvable'};
-      $idmatches{$s->{'nameid'}} = 1 if $s->installable();
-    }
-    if (%idmatches) {
-      return map {$pool->Job($solv::Job::SOLVER_SOLVABLE_NAME, $_)} sort(keys %idmatches);
-    }
-  }
-  if ($globdep) {
-    my @idmatches = $pool->matchprovidingids($name, $solv::Dataiterator::SEARCH_GLOB);
-    if (@idmatches) {
-      print "[using capability match for '$name']\n";
-      return map {$pool->Job($solv::Job::SOLVER_SOLVABLE_PROVIDES, $_)} sort(@idmatches);
-    }
-  }
-  return;
-}
-
-sub limitjobs {
-  my ($pool, $jobs, $flags, $evrstr) = @_;
-  my @jobs;
-  my $evr = $pool->str2id($evrstr);
-  for my $j (@$jobs) {
-    my $how = $j->{'how'};
-    my $sel = $how & $solv::Job::SOLVER_SELECTMASK;
-    my $what = $pool->rel2id($j->{'what'}, $evr, $flags);
-    if ($flags == $solv::REL_ARCH) {
-      $how |= $solv::Job::SOLVER_SETARCH;
-    } elsif ($flags == $solv::REL_EQ && $sel == $solv::Job::SOLVER_SOLVABLE_NAME) {
-      $how |= $evrstr =~ /-/ ? $solv::Job::SOLVER_SETEVR : $solv::Job::SOLVER_SETEV;
-    }
-    push @jobs, $pool->Job($how, $what);
-  }
-  return @jobs;
-}
-
-sub limitjobs_evrarch {
-  my ($pool, $jobs, $flags, $evrstr) = @_;
-  if ($evrstr =~ /^(.+)\.(.+?)$/ && validarch($pool, $2)) {
-    $evrstr = $1;
-    $jobs = [ limitjobs($pool, $jobs, $solv::REL_ARCH, $2) ];
-  }
-  return limitjobs($pool, $jobs, $flags, $evrstr);
-}
-
-sub mkjobs_rel {
-  my ($pool, $cmd, $name, $rel, $evr) = @_;
-  my $flags = 0;
-  $flags |= $solv::REL_LT if $rel =~ /</;
-  $flags |= $solv::REL_EQ if $rel =~ /=/;
-  $flags |= $solv::REL_GT if $rel =~ />/;
-  my @jobs = depglob($pool, $name, 1, 1);
-  return limitjobs($pool, \@jobs, $flags, $evr) if @jobs;
-  if (($name =~ /^(.+)\.(.+?)$/s) && validarch($pool, $2)) {
-    my $arch = $2;
-    @jobs = depglob($pool, $1, 1, 1);
-    if (@jobs) {
-      @jobs = limitjobs($pool, \@jobs, $solv::REL_ARCH, $arch);
-      return limitjobs($pool, \@jobs, $flags, $evr);
-    }
-  }
-  return ();
-}
-
-sub mkjobs_nevra {
-  my ($pool, $cmd, $arg) = @_;
-  my @jobs = depglob($pool, $arg, 1, 1);
-  return @jobs if @jobs;
-  if (($arg =~ /^(.+)\.(.+?)$/s) && validarch($pool, $2)) {
-    my $arch = $2;
-    @jobs = depglob($pool, $1, 1, 1);
-    return limitjobs($pool, \@jobs, $solv::REL_ARCH, $arch) if @jobs;
-  }
-  if ($arg =~ /^(.+)-(.+?)$/s) {
-    my $evr = $2;
-    @jobs = depglob($pool, $1, 1, 0);
-    return limitjobs_evrarch($pool, \@jobs, $solv::REL_EQ, $evr) if @jobs;
-  }
-  if ($arg =~ /^(.+)-(.+?-.+?)$/s) {
-    my $evr = $2;
-    @jobs = depglob($pool, $1, 1, 0);
-    return limitjobs_evrarch($pool, \@jobs, $solv::REL_EQ, $evr) if @jobs;
-  }
-  return ();
-}
-
-sub mkjobs_filelist {
-  my ($pool, $cmd, $arg) = @_;
-  my $type = ($arg =~ /[[*?]/) ? $solv::Dataiterator::SEARCH_GLOB : $solv::Dataiterator::SEARCH_STRING;
-  $type |= $solv::Dataiterator::SEARCH_FILES | $solv::Dataiterator::SEARCH_COMPLETE_FILELIST;
-  my $di;
-  if ($cmd eq 'erase') {
-    $di = $pool->{'installed'}->Dataiterator(0, $solv::SOLVABLE_FILELIST, $arg, $type);
-  } else {
-    $di = $pool->Dataiterator(0, $solv::SOLVABLE_FILELIST, $arg, $type);
-  }
-  my @matches;
-  for my $d (@$di) {
-    my $s = $d->{'solvable'};
-    next unless $s && $s->installable();
-    push @matches, $s->{'id'};
-    $di->skip_solvable();
-  }
-  return () unless @matches;
-  print "[using file list match for '$arg']\n";
-  if (@matches > 1) {
-    return $pool->Job($solv::Job::SOLVER_SOLVABLE_ONE_OF, $pool->towhatprovides(\@matches));
-  } else {
-    return $pool->Job($solv::Job::SOLVER_SOLVABLE | $solv::Job::SOLVER_NOAUTOSET, $matches[0]);
-  }
-}
-
-sub mkjobs {
-  my ($pool, $cmd, $arg) = @_;
-  if ($arg && $arg =~ /^\//) {
-    my @jobs = mkjobs_filelist($pool, $cmd, $arg);
-    return @jobs if @jobs;
-  }
-  if ($arg =~ /^(.+?)\s*([<=>]+)\s*(.+?)$/s) {
-    return mkjobs_rel($pool, $cmd, $1, $2, $3);
-  } else {
-    return mkjobs_nevra($pool, $cmd, $arg);
-  }
-}
-
 sub load_stub {
   my ($repodata) = @_;
-  my $repo = $repodata->{'repo'}->{'appdata'};
+  my $repo = $repodata->{repo}->{appdata};
   return $repo ? $repo->load_ext($repodata) : 0;
 }
 
 die("Usage: p5solv COMMAND [ARGS]\n") unless @ARGV;
 my $cmd = shift @ARGV;
-$cmd = 'list' if $cmd eq 'li';
-$cmd = 'install' if $cmd eq 'in';
-$cmd = 'erase' if $cmd eq 'rm';
-$cmd = 'verify' if $cmd eq 've';
-$cmd = 'search' if $cmd eq 'se';
+my %cmdabbrev = ( 'ls' => 'list', 'in' => 'install', 'rm' => 'erase',
+                  've' => 'verify', 'se' => 'search' );
+$cmd = $cmdabbrev{$cmd} if $cmdabbrev{$cmd};
+
+my %cmdactionmap = (
+  'install' => $solv::Job::SOLVER_INSTALL,
+  'erase'   => $solv::Job::SOLVER_ERASE,
+  'up'      => $solv::Job::SOLVER_UPDATE,
+  'dup'     => $solv::Job::SOLVER_DISTUPGRADE,
+  'verify'  => $solv::Job::SOLVER_VERIFY,
+  'list'    => 0,  
+  'info'    => 0,
+);
 
 my @repos;
-for my $reposdir ('/etc/zypp/repos.d') {
+my @reposdirs;
+if (-d '/etc/zypp/repos.d') {
+  @reposdirs = ( '/etc/zypp/repos.d' );
+} else {
+  @reposdirs = ( '/etc/yum/repos.d' );
+}
+for my $reposdir (@reposdirs) {
   next unless -d $reposdir;
-  next unless opendir(DIR, $reposdir);
-  for my $reponame (sort(grep {/\.repo$/} readdir(DIR))) {
+  my $dir;
+  next unless opendir($dir, $reposdir);
+  for my $reponame (sort(grep {/\.repo$/} readdir($dir))) {
     my $cfg = new Config::IniFiles('-file' => "$reposdir/$reponame");
     for my $alias ($cfg->Sections()) {
       my $repoattr = {'alias' => $alias, 'enabled' => 0, 'priority' => 99, 'autorefresh' => 1, 'type' => 'rpm-md', 'metadata_expire' => 900};
@@ -659,9 +527,9 @@ for my $reposdir ('/etc/zypp/repos.d') {
 	$repoattr->{$p} = $cfg->val($alias, $p);
       }
       my $repo;
-      if ($repoattr->{'type'} eq 'rpm-md') {
+      if ($repoattr->{type} eq 'rpm-md') {
 	$repo = Repo::rpmmd->new($alias, 'repomd', $repoattr);
-      } elsif ($repoattr->{'type'} eq 'yast2') {
+      } elsif ($repoattr->{type} eq 'yast2') {
 	$repo = Repo::susetags->new($alias, 'susetags', $repoattr);
       } else {
 	$repo = Repo::unknown->new($alias, 'unknown', $repoattr);
@@ -672,212 +540,212 @@ for my $reposdir ('/etc/zypp/repos.d') {
 }
 
 my $pool = solv::Pool->new();
-$pool->setarch((POSIX::uname())[4]);
+$pool->setarch();
 $pool->set_loadcallback(\&load_stub);
 
 my $sysrepo = Repo::system->new('@System', 'system');
 $sysrepo->load($pool);
 for my $repo (@repos) {
-  $repo->load($pool) if $repo->{'enabled'};
+  $repo->load($pool) if $repo->{enabled};
 }
 
 if ($cmd eq 'search') {
-  my %matches;
-  my $di = $pool->Dataiterator(0, $solv::SOLVABLE_NAME, $ARGV[0], $solv::Dataiterator::SEARCH_SUBSTRING | $solv::Dataiterator::SEARCH_NOCASE);
+  $pool->createwhatprovides();
+  my $sel = $pool->Selection();
+  my $di = $pool->Dataiterator($solv::SOLVABLE_NAME, $ARGV[0], $solv::Dataiterator::SEARCH_SUBSTRING | $solv::Dataiterator::SEARCH_NOCASE);
   for my $d (@$di) {
-    $matches{$d->{'solvid'}} = 1;
+    $sel->add_raw($solv::Job::SOLVER_SOLVABLE, $d->{solvid});
   }
-  for my $solvid (sort keys %matches) {
-    my $s = $pool->{'solvables'}->[$solvid];
-    print "- ".$s->str()." [$s->{'repo'}->{'name'}] ".$s->lookup_str($solv::SOLVABLE_SUMMARY)."\n";
+  for my $s ($sel->solvables()) {
+    print "- ".$s->str()." [$s->{repo}->{name}]: ".$s->lookup_str($solv::SOLVABLE_SUMMARY)."\n";
   }
   exit(0);
 }
 
-my @addedprovides =  $pool->addfileprovides_ids();
+die("unknown command '$cmd'\n") unless defined $cmdactionmap{$cmd};
+
+$pool->addfileprovides();
 $pool->createwhatprovides();
+$pool->set_namespaceproviders($solv::NAMESPACE_LANGUAGE, $pool->Dep('de'), 1);
 
 my @jobs;
 for my $arg (@ARGV) {
-  my @njobs = mkjobs($pool, $cmd, $arg);
-  die("nothing matches '$arg'\n") unless @njobs;
-  push @jobs, @njobs;
+  my $flags = $solv::Selection::SELECTION_NAME | $solv::Selection::SELECTION_PROVIDES | $solv::Selection::SELECTION_GLOB;
+  $flags |= $solv::Selection::SELECTION_CANON | $solv::Selection::SELECTION_DOTARCH | $solv::Selection::SELECTION_REL;
+  if ($arg =~ m!^/!) {
+    $flags |= $solv::Selection::SELECTION_FILELIST;
+    $flags |= $solv::Selection::SELECTION_INSTALLED_ONLY if $cmd eq 'erase';
+  }
+  my $sel = $pool->select($arg, $flags);
+  if ($sel->isempty()) {
+    $sel = $pool->select($arg, $flags | $solv::Selection::SELECTION_NOCASE);
+    print "[ignoring case for '$arg']\n" unless $sel->isempty();
+  }
+  die("nothing matches '$arg'\n") if $sel->isempty();
+  print "[using file list match for '$arg']\n" if $sel->{flags} & $solv::Selection::SELECTION_FILELIST;
+  print "[using capability match for '$arg']\n" if $sel->{flags} & $solv::Selection::SELECTION_PROVIDES;
+  push @jobs, $sel->jobs($cmdactionmap{$cmd});
+}
+
+if (!@jobs && ($cmd eq 'up' || $cmd eq 'dup' || $cmd eq 'verify')) {
+  my $sel = $pool->Selection_all();
+  push @jobs, $sel->jobs($cmdactionmap{$cmd});
 }
 
+die("no package matched.\n") unless @jobs;
+
 if ($cmd eq 'list' || $cmd eq 'info') {
-  die("no package matched.\n") unless @jobs;
   for my $job (@jobs) {
     for my $s ($job->solvables()) {
       if ($cmd eq 'info') {
-        printf "Name:        %s\n", $s->str();
-        printf "Repo:        %s\n", $s->{'repo'}->{'name'};
-        printf "Summary:     %s\n", $s->lookup_str($solv::SOLVABLE_SUMMARY);
+	printf "Name:        %s\n", $s->str();
+	printf "Repo:        %s\n", $s->{repo}->{name};
+	printf "Summary:     %s\n", $s->lookup_str($solv::SOLVABLE_SUMMARY);
 	my $str = $s->lookup_str($solv::SOLVABLE_URL);
-        printf "Url:         %s\n", $str if $str;
+	printf "Url:         %s\n", $str if $str;
 	$str = $s->lookup_str($solv::SOLVABLE_LICENSE);
-        printf "License:     %s\n", $str if $str;
-        printf "Description:\n%s\n", $s->lookup_str($solv::SOLVABLE_DESCRIPTION);
+	printf "License:     %s\n", $str if $str;
+	printf "Description:\n%s\n", $s->lookup_str($solv::SOLVABLE_DESCRIPTION);
       } else {
-        printf "  - %s [%s]\n", $s->str(), $s->{'repo'}->{'name'};
-        printf "    %s\n", $s->lookup_str($solv::SOLVABLE_SUMMARY);
+	printf "  - %s [%s]\n", $s->str(), $s->{repo}->{name};
+	printf "    %s\n", $s->lookup_str($solv::SOLVABLE_SUMMARY);
       }
     }
   }
   exit 0;
 }
 
-if ($cmd eq 'install' || $cmd eq 'erase' || $cmd eq 'up' || $cmd eq 'dup' || $cmd eq 'verify') {
-  if (!@jobs) {
-    if ($cmd eq 'up' || $cmd eq 'verify' || $cmd eq 'dup') {
-      push @jobs, $pool->Job($solv::Job::SOLVER_SOLVABLE_ALL, 0);
-    } else {
-      die("no package matched.\n");
+# up magic, turn into install if nothing matches
+for my $job (@jobs) {
+  $job->{how} ^= $solv::Job::SOLVER_UPDATE ^ $solv::Job::SOLVER_INSTALL if $cmd eq 'up' && $job->isemptyupdate();
+}
+
+my $solver = $pool->Solver();
+$solver->set_flag($solv::Solver::SOLVER_FLAG_SPLITPROVIDES, 1);
+$solver->set_flag($solv::Solver::SOLVER_FLAG_ALLOW_UNINSTALL, 1) if $cmd eq 'erase';
+
+while (1) {
+  my @problems = $solver->solve(\@jobs);
+  last unless @problems;
+  for my $problem (@problems) {
+    print "Problem $problem->{id}/".@problems.":\n";
+    print $problem->str()."\n";
+    my @solutions = $problem->solutions();
+    for my $solution (@solutions) {
+      print "  Solution $solution->{id}:\n";
+      for my $element ($solution->elements(1)) {
+	print "  - ".$element->str()."\n";
+      }
+      print "\n";
     }
-  }
-  for my $job (@jobs) {
-    if ($cmd eq 'up') {
-      if ($job->{'how'} == $solv::Job::SOLVER_SOLVABLE_ALL || grep {$_->isinstalled()} $job->solvables()) {
-        $job->{'how'} |= $solv::Job::SOLVER_UPDATE;
+    my $sol;
+    while (1) {
+      print "Please choose a solution: ";
+      $sol = <STDIN>;
+      chomp $sol;
+      last if $sol eq 's' || $sol eq 'q' || ($sol =~ /^\d+$/ && $sol >= 1 && $sol <= @solutions);
+    }
+    next if $sol eq 's';
+    exit(1) if $sol eq 'q';
+    my $solution = $solutions[$sol - 1];
+    for my $element ($solution->elements()) {
+      my $newjob = $element->Job();
+      if ($element->{type} == $solv::Solver::SOLVER_SOLUTION_JOB) {
+	$jobs[$element->{jobidx}] = $newjob;
       } else {
-        $job->{'how'} |= $solv::Job::SOLVER_INSTALL;
+	push @jobs, $newjob if $newjob && !grep {$_ == $newjob} @jobs;
       }
-    } elsif ($cmd eq 'install') {
-        $job->{'how'} |= $solv::Job::SOLVER_INSTALL;
-    } elsif ($cmd eq 'erase') {
-        $job->{'how'} |= $solv::Job::SOLVER_ERASE;
-    } elsif ($cmd eq 'dup') {
-        $job->{'how'} |= $solv::Job::SOLVER_DISTUPGRADE;
-    } elsif ($cmd eq 'verify') {
-        $job->{'how'} |= $solv::Job::SOLVER_VERIFY;
     }
   }
-  my $solver;
-  while (1) {
-    $solver = $pool->Solver();
-    $solver->set_flag($solv::Solver::SOLVER_FLAG_IGNORE_ALREADY_RECOMMENDED, 1);
-    $solver->set_flag($solv::Solver::SOLVER_FLAG_SPLITPROVIDES, 1);
-    $solver->set_flag($solv::Solver::SOLVER_FLAG_ALLOW_UNINSTALL, 1) if $cmd eq 'erase';
-    my @problems = $solver->solve(\@jobs);
-    last unless @problems;
-    for my $problem (@problems) {
-      print "Problem $problem->{'id'}/".@problems.":\n";
-      my $r = $problem->findproblemrule();
-      my $ri = $r->info();
-      print $ri->problemstr()."\n";
-      my @solutions = $problem->solutions();
-      for my $solution (@solutions) {
-	print "  Solution $solution->{'id'}:\n";
-	for my $element ($solution->elements(1)) {
-	  print "  - ".$element->str()."\n";
-        }
-        print "\n";
-      }
-      my $sol;
-      while (1) {
-	print "Please choose a solution: ";
-	$sol = <STDIN>;
-	chomp $sol;
-	last if $sol eq 's' || $sol eq 'q' || ($sol =~ /^\d+$/ && $sol >= 1 && $sol <= @solutions);
-      }
-      next if $sol eq 's';
-      exit(1) if $sol eq 'q';
-      my $solution = $solutions[$sol - 1];
-      for my $element ($solution->elements()) {
-        my $newjob = $element->Job();
-        if ($element->{'type'} == $solv::Solver::SOLVER_SOLUTION_JOB) {
-	  $jobs[$element->{'jobidx'}] = $newjob;
-        } else {
-	  push @jobs, $newjob if $newjob && !grep {$_ == $newjob} @jobs;
-	}
-      }
-    }
+}
+
+my $trans = $solver->transaction();
+undef $solver;
+if ($trans->isempty()) {
+  print "Nothing to do.\n";
+  exit 0;
+}
+
+print "\nTransaction summary:\n\n";
+for my $c ($trans->classify($solv::Transaction::SOLVER_TRANSACTION_SHOW_OBSOLETES|$solv::Transaction::SOLVER_TRANSACTION_OBSOLETE_IS_UPGRADE)) {
+  if ($c->{type} == $solv::Transaction::SOLVER_TRANSACTION_ERASE) {
+    print "$c->{count} erased packages:\n";
+  } elsif ($c->{type} == $solv::Transaction::SOLVER_TRANSACTION_INSTALL) {
+    print "$c->{count} installed packages:\n";
+  } elsif ($c->{type} == $solv::Transaction::SOLVER_TRANSACTION_REINSTALLED) {
+    print "$c->{count} reinstalled packages:\n";
+  } elsif ($c->{type} == $solv::Transaction::SOLVER_TRANSACTION_DOWNGRADED) {
+    print "$c->{count} downgraded packages:\n";
+  } elsif ($c->{type} == $solv::Transaction::SOLVER_TRANSACTION_CHANGED) {
+    print "$c->{count} changed packages:\n";
+  } elsif ($c->{type} == $solv::Transaction::SOLVER_TRANSACTION_UPGRADED) {
+    print "$c->{count} upgraded packages:\n";
+  } elsif ($c->{type} == $solv::Transaction::SOLVER_TRANSACTION_VENDORCHANGE) {
+    printf "$c->{count} vendor changes from '%s' to '%s':\n", $c->{fromstr}, $c->{tostr};
+  } elsif ($c->{type} == $solv::Transaction::SOLVER_TRANSACTION_ARCHCHANGE) {
+    printf "$c->{count} arch changes from '%s' to '%s':\n", $c->{fromstr}, $c->{tostr};
+  } else {
+    next;
   }
-  my $trans = $solver->transaction();
-  undef $solver;
-  if ($trans->isempty()) {
-    print "Nothing to do.\n";
-    exit 0;
-  }
-  print "\nTransaction summary:\n\n";
-  for my $c ($trans->classify()) {
-    if ($c->{'type'} == $solv::Transaction::SOLVER_TRANSACTION_ERASE) {
-      print "$c->{'count'} erased packages:\n";
-    } elsif ($c->{'type'} == $solv::Transaction::SOLVER_TRANSACTION_INSTALL) {
-      print "$c->{'count'} installed packages:\n";
-    } elsif ($c->{'type'} == $solv::Transaction::SOLVER_TRANSACTION_REINSTALLED) {
-      print "$c->{'count'} reinstalled packages:\n";
-    } elsif ($c->{'type'} == $solv::Transaction::SOLVER_TRANSACTION_DOWNGRADED) {
-      print "$c->{'count'} downgraded packages:\n";
-    } elsif ($c->{'type'} == $solv::Transaction::SOLVER_TRANSACTION_CHANGED) {
-      print "$c->{'count'} changed packages:\n";
-    } elsif ($c->{'type'} == $solv::Transaction::SOLVER_TRANSACTION_UPGRADED) {
-      print "$c->{'count'} upgraded packages:\n";
-    } elsif ($c->{'type'} == $solv::Transaction::SOLVER_TRANSACTION_VENDORCHANGE) {
-      printf "$c->{'count'} vendor changes from '%s' to '%s':\n", $pool->id2str($c->{'fromid'}), $pool->id2str($c->{'toid'});
-    } elsif ($c->{'type'} == $solv::Transaction::SOLVER_TRANSACTION_ARCHCHANGE) {
-      printf "$c->{'count'} arch changes from '%s' to '%s':\n", $pool->id2str($c->{'fromid'}), $pool->id2str($c->{'toid'});
+  for my $p ($c->solvables()) {
+    if ($c->{type} == $solv::Transaction::SOLVER_TRANSACTION_UPGRADED || $c->{type} == $solv::Transaction::SOLVER_TRANSACTION_DOWNGRADED) {
+      my $other = $trans->othersolvable($p);
+      printf "  - %s -> %s\n", $p->str(), $other->str();
     } else {
-      next;
-    }
-    for my $p ($c->solvables()) {
-      if ($c->{'type'} == $solv::Transaction::SOLVER_TRANSACTION_UPGRADED || $c->{'type'} == $solv::Transaction::SOLVER_TRANSACTION_DOWNGRADED) {
-	my $other = $trans->othersolvable($p);
-	printf "  - %s -> %s\n", $p->str(), $other->str();
-      } else {
-	printf "  - %s\n", $p->str();
-      }
-    }
-    print "\n";
-  }
-  printf "install size change: %d K\n\n", $trans->calc_installsizechange();
-  while (1) {
-    print("OK to continue (y/n)? ");
-    my $yn = <STDIN>;
-    chomp $yn;
-    last if $yn eq 'y';
-    exit(1) if $yn eq 'n';
-  }
-  my @newpkgs = $trans->newpackages();
-  my %newpkgsfps;
-  if (@newpkgs) {
-    my $downloadsize = 0;
-    $downloadsize += $_->lookup_num($solv::SOLVABLE_DOWNLOADSIZE) for @newpkgs;
-    printf "Downloading %d packages, %d K\n", scalar(@newpkgs), $downloadsize;
-    for my $p (@newpkgs) {
-      my $repo = $p->{'repo'}->{'appdata'};
-      my ($location, $medianr) = $p->lookup_location();
-      next unless $location;
-      if ($repo->{'type'} eq 'susetags') {
-	$location = ($repo->{'handle'}->lookup_str($solv::SOLVID_META, $solv::SUSETAGS_DATADIR) || 'suse') ."/$location";
-      }
-      my $chksum = $p->lookup_checksum($solv::SOLVABLE_CHECKSUM);
-      my $f = $repo->download($location, 0, $chksum);
-      die("\n$repo->{'alias'}: $location not found in repository\n") unless $f;
-      $newpkgsfps{$p->{'id'}} = $f;
-      print ".";
-      STDOUT->flush();
-    }
-    print "\n";
-  }
-  print "Committing transaction:\n\n";
-  $trans->order(0);
-  for my $p ($trans->steps()) {
-    my $steptype = $trans->steptype($p, $solv::Transaction::SOLVER_TRANSACTION_RPM_ONLY);
-    if ($steptype == $solv::Transaction::SOLVER_TRANSACTION_ERASE) {
-      print "erase ".$p->str()."\n";
-      next unless $p->lookup_num($solv::RPM_RPMDBID);
-      my $evr = $p->{'evr'};
-      $evr =~ s/^[0-9]+://;	# strip epoch
-      system('rpm', '-e', '--nodeps', '--nodigest', '--nosignature', "$p->{'name'}-$evr.$p->{'arch'}") && die("rpm failed: $?\n");
-    } elsif ($steptype == $solv::Transaction::SOLVER_TRANSACTION_INSTALL || $steptype == $solv::Transaction::SOLVER_TRANSACTION_MULTIINSTALL) {
-      print "install ".$p->str()."\n";
-      my $f = $newpkgsfps{$p->{'id'}};
-      my $mode = $steptype == $solv::Transaction::SOLVER_TRANSACTION_INSTALL ? '-U' : '-i';
-      system('rpm', $mode, '--force', '--nodeps', '--nodigest', '--nosignature', "/dev/fd/".solv::xfileno($f)) && die("rpm failed: $?\n");
-      solv::xfclose($f);
-      delete $newpkgsfps{$p->{'id'}};
+      printf "  - %s\n", $p->str();
     }
   }
+  print "\n";
+}
+printf "install size change: %d K\n\n", $trans->calc_installsizechange();
+
+while (1) {
+  print("OK to continue (y/n)? ");
+  my $yn = <STDIN>;
+  chomp $yn;
+  last if $yn eq 'y';
+  exit(1) if $yn eq 'n' || $yn eq 'q';
+}
+
+my @newpkgs = $trans->newsolvables();
+my %newpkgsfps;
+if (@newpkgs) {
+  my $downloadsize = 0;
+  $downloadsize += $_->lookup_num($solv::SOLVABLE_DOWNLOADSIZE) for @newpkgs;
+  printf "Downloading %d packages, %d K\n", scalar(@newpkgs), $downloadsize / 1024;
+  for my $p (@newpkgs) {
+    my $repo = $p->{repo}->{appdata};
+    my ($location) = $p->lookup_location();
+    next unless $location;
+    $location = $repo->packagespath() . $location;
+    my $chksum = $p->lookup_checksum($solv::SOLVABLE_CHECKSUM);
+    my $f = $repo->download($location, 0, $chksum);
+    die("\n$repo->{alias}: $location not found in repository\n") unless $f;
+    $newpkgsfps{$p->{id}} = $f;
+    print ".";
+    STDOUT->flush();
+  }
+  print "\n";
+}
+
+print "Committing transaction:\n\n";
+$trans->order();
+for my $p ($trans->steps()) {
+  my $steptype = $trans->steptype($p, $solv::Transaction::SOLVER_TRANSACTION_RPM_ONLY);
+  if ($steptype == $solv::Transaction::SOLVER_TRANSACTION_ERASE) {
+    print "erase ".$p->str()."\n";
+    next unless $p->lookup_num($solv::RPM_RPMDBID);
+    my $evr = $p->{evr};
+    $evr =~ s/^[0-9]+://;	# strip epoch
+    system('rpm', '-e', '--nodeps', '--nodigest', '--nosignature', "$p->{name}-$evr.$p->{arch}") && die("rpm failed: $?\n");
+  } elsif ($steptype == $solv::Transaction::SOLVER_TRANSACTION_INSTALL || $steptype == $solv::Transaction::SOLVER_TRANSACTION_MULTIINSTALL) {
+    print "install ".$p->str()."\n";
+    my $f = $newpkgsfps{$p->{id}};
+    my $mode = $steptype == $solv::Transaction::SOLVER_TRANSACTION_INSTALL ? '-U' : '-i';
+    $f->cloexec(0);
+    system('rpm', $mode, '--force', '--nodeps', '--nodigest', '--nosignature', "/dev/fd/".$f->fileno()) && die("rpm failed: $?\n");
+    delete $newpkgsfps{$p->{id}};
+  }
 }
 
 exit 0;