X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=dali-toolkit%2Finternal%2Ffeedback%2Ffeedback-style.cpp;h=4375a29021bc9263f995c94af30df9317d84caef;hb=refs%2Fchanges%2F99%2F210399%2F9;hp=da2f055f84a6ce8b3f8a0d47a396ae8ff8fcb594;hpb=f3da11c2818c6d17706fbb2417f21b602b3190f5;p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git diff --git a/dali-toolkit/internal/feedback/feedback-style.cpp b/dali-toolkit/internal/feedback/feedback-style.cpp index da2f055..4375a29 100644 --- a/dali-toolkit/internal/feedback/feedback-style.cpp +++ b/dali-toolkit/internal/feedback/feedback-style.cpp @@ -1,5 +1,5 @@ /* - * Copyright (c) 2014 Samsung Electronics Co., Ltd. + * Copyright (c) 2019 Samsung Electronics Co., Ltd. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -19,6 +19,7 @@ #include // EXTERNAL INCLUDES +#include #include #include #include @@ -102,7 +103,6 @@ struct FeedbackStyleInfo static const FeedbackStyleInfo DEFAULT_FEEDBACK_STYLE_INFO; FeedbackStyle::FeedbackStyle() -: mConnections( this ) { mFeedback = Dali::FeedbackPlayer::Get(); @@ -195,7 +195,7 @@ const FeedbackStyleInfo& FeedbackStyle::GetStyleInfo( const string& type ) const void FeedbackStyle::StyleChanged( const std::string& userDefinedThemePath, Dali::StyleChange::Type styleChange ) { - if( StyleChange::THEME_CHANGE ) + if( styleChange == StyleChange::THEME_CHANGE ) { string userDefinedTheme; @@ -307,7 +307,7 @@ void FeedbackStyle::LoadFromString( const string& data ) if( signalFeedbackInfo.mHasHapticFeedbackInfo || signalFeedbackInfo.mHasSoundFeedbackInfo ) { - AddSignalInfo( themeInfo, signalFeedbackInfo ); + AddSignalInfo( themeInfo, std::move( signalFeedbackInfo ) ); } } } @@ -320,10 +320,10 @@ void FeedbackStyle::LoadFromString( const string& data ) } // LoadFromString() -void FeedbackStyle::AddSignalInfo( FeedbackStyleInfo& styleInfo, SignalFeedbackInfo signalInfo ) +void FeedbackStyle::AddSignalInfo( FeedbackStyleInfo& styleInfo, SignalFeedbackInfo&& signalInfo ) { bool updated = false; - std::vector::iterator iter; + SignalFeedbackInfoContainer::iterator iter; // If info exists for the signal then update it, else add new for( iter = styleInfo.mSignalFeedbackInfoList.begin(); iter != styleInfo.mSignalFeedbackInfoList.end(); ++iter ) @@ -344,7 +344,7 @@ void FeedbackStyle::AddSignalInfo( FeedbackStyleInfo& styleInfo, SignalFeedbackI if( !updated ) { - styleInfo.mSignalFeedbackInfoList.push_back( signalInfo ); + styleInfo.mSignalFeedbackInfoList.emplace_back( std::move( signalInfo ) ); } }