X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=dali-toolkit%2Finternal%2Fcontrols%2Fbuttons%2Fradio-button-impl.cpp;h=ba3348ab7ce9802132ad2dd3735bf3d5a685615e;hb=fb222199e44a5352d8c7f6e1c715da1a995e41af;hp=96b588cc171297fbbeaae0f3596f6586945c65b7;hpb=afb47f411d700d2b4be6415b61995cde5c37126c;p=platform%2Fcore%2Fuifw%2Fdali-toolkit.git diff --git a/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp b/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp index 96b588c..ba3348a 100644 --- a/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp +++ b/dali-toolkit/internal/controls/buttons/radio-button-impl.cpp @@ -15,43 +15,38 @@ * */ - // CLASS HEADER #include "radio-button-impl.h" // EXTERNAL INCLUDES +#include #include -#include + +#if defined(DEBUG_ENABLED) +extern Debug::Filter* gLogButtonFilter; +#endif namespace Dali { - namespace Toolkit { - namespace Internal { - namespace { - BaseHandle Create() { return Toolkit::RadioButton::New(); } -TypeRegistration typeRegistration( typeid( Toolkit::RadioButton ), typeid( Toolkit::Button ), Create); +TypeRegistration typeRegistration(typeid(Toolkit::RadioButton), typeid(Toolkit::Button), Create); -const char* const UNSELECTED_BUTTON_IMAGE_DIR = DALI_IMAGE_DIR "radio-button-unselected.png"; -const char* const SELECTED_BUTTON_IMAGE_DIR = DALI_IMAGE_DIR "radio-button-selected.png"; - -const float DISTANCE_BETWEEN_IMAGE_AND_LABEL( 5.0f ); -} +} // namespace Dali::Toolkit::RadioButton RadioButton::New() { // Create the implementation, temporarily owned on stack - IntrusivePtr< RadioButton > internalRadioButton = new RadioButton(); + IntrusivePtr internalRadioButton = new RadioButton(); // Pass ownership to CustomActor Dali::Toolkit::RadioButton radioButton(*internalRadioButton); @@ -72,105 +67,58 @@ RadioButton::~RadioButton() { } -void RadioButton::OnButtonInitialize() +void RadioButton::OnInitialize() { - Actor self = Self(); - - // Wrap size of radio button around all its children - self.SetResizePolicy( FIT_TO_CHILDREN, ALL_DIMENSIONS ); - - Image buttonImage = Dali::ResourceImage::New( UNSELECTED_BUTTON_IMAGE_DIR ); - Image selectedImage = Dali::ResourceImage::New( SELECTED_BUTTON_IMAGE_DIR ); - - SetButtonImage( ImageActor::New( buttonImage ) ); - SetSelectedImage( ImageActor::New( selectedImage ) ); + Button::OnInitialize(); - RelayoutRequest(); + DevelControl::SetAccessibilityConstructor(Self(), [](Dali::Actor actor) { + return std::unique_ptr( + new AccessibleImpl(actor, Dali::Accessibility::Role::RADIO_BUTTON)); + }); } -void RadioButton::OnButtonUp() +bool RadioButton::OnToggleReleased() { - if( ButtonDown == GetState() ) - { - // Don't allow selection on an already selected radio button - if( !IsSelected() ) - { - SetSelected( !IsSelected() ); - } - } -} - -void RadioButton::OnLabelSet() -{ - Actor& label = GetLabel(); - - if( label ) - { - label.SetParentOrigin( ParentOrigin::CENTER_LEFT ); - label.SetAnchorPoint( AnchorPoint::CENTER_LEFT ); - - if( IsSelected() ) - { - label.SetX( GetSelectedImage().GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - else - { - label.SetX( GetButtonImage().GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - } + // Radio button overrides toggle release (button up) as doesn't allow un-selection to be performed on it directly. + return false; } -bool RadioButton::OnSelected() +void RadioButton::OnStateChange(State newState) { - Actor& buttonImage = GetButtonImage(); - Actor& selectedImage = GetSelectedImage(); - Actor& label = GetLabel(); - - PaintState paintState = GetPaintState(); + // Radio button can be part of a group, if a button in the group is selected then all others should be unselected + DALI_LOG_INFO(gLogButtonFilter, Debug::Verbose, "RadioButton::OnStateChange state(%d)\n", newState); - switch( paintState ) + if(SELECTED_STATE == newState) { - case UnselectedState: + Actor parent = Self().GetParent(); + if(parent) { - Actor parent = Self().GetParent(); - if( parent ) + for(unsigned int i = 0; i < parent.GetChildCount(); ++i) { - for( unsigned int i = 0; i < parent.GetChildCount(); ++i ) + Dali::Toolkit::RadioButton radioButtonChild = Dali::Toolkit::RadioButton::DownCast(parent.GetChildAt(i)); + if(radioButtonChild && radioButtonChild != Self()) { - Dali::Toolkit::RadioButton radioButtonChild = Dali::Toolkit::RadioButton::DownCast( parent.GetChildAt( i ) ); - if( radioButtonChild && radioButtonChild != Self() ) - { - radioButtonChild.SetSelected( false ); - } + radioButtonChild.SetProperty(Toolkit::Button::Property::SELECTED, false); } } - - RemoveChild( buttonImage ); - - if( label ) - { - label.SetX( selectedImage.GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - break; - } - case SelectedState: - { - RemoveChild( selectedImage ); - - if( label ) - { - label.SetX( buttonImage.GetNaturalSize().width + DISTANCE_BETWEEN_IMAGE_AND_LABEL ); - } - break; - } - default: - { - break; } } + // TODO: replace it with OnPropertySet hook once Button::Property::SELECTED will be consistently used + if(Dali::Accessibility::IsUp() && (newState == SELECTED_STATE || newState == UNSELECTED_STATE)) + { + Dali::Accessibility::Accessible::Get(Self())->EmitStateChanged( + Dali::Accessibility::State::CHECKED, newState == SELECTED_STATE ? 1 : 0, 0); + } +} - // there is no animation - return false; +Dali::Accessibility::States RadioButton::AccessibleImpl::CalculateStates() +{ + auto tmp = Button::AccessibleImpl::CalculateStates(); + auto slf = Toolkit::Button::DownCast(self); + if(slf.GetProperty(Toolkit::Button::Property::SELECTED)) + tmp[Dali::Accessibility::State::CHECKED] = true; + tmp[Dali::Accessibility::State::SELECTABLE] = true; + return tmp; } } // namespace Internal