X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=dali%2Finternal%2Fgraphics%2Fgles-impl%2Fgles-graphics-shader.h;h=180a14b1029b62b85cf9db37b6866d9de93ee70e;hb=refs%2Ftags%2Fsubmit%2Ftizen%2F20220503.090411;hp=d96223f7c7b09db0bc7fff3e0a9336c2a114fc43;hpb=ed6148202ef7f9086818070ffa8d98db83d52f95;p=platform%2Fcore%2Fuifw%2Fdali-adaptor.git

diff --git a/dali/internal/graphics/gles-impl/gles-graphics-shader.h b/dali/internal/graphics/gles-impl/gles-graphics-shader.h
index d96223f..180a14b 100644
--- a/dali/internal/graphics/gles-impl/gles-graphics-shader.h
+++ b/dali/internal/graphics/gles-impl/gles-graphics-shader.h
@@ -42,15 +42,12 @@ public:
   /**
    * @brief Destructor
    */
-  ~Shader() override = default;
+  ~Shader() override;
 
   /**
    * @brief Called when GL resources are destroyed
    */
-  void DestroyResource() override
-  {
-    // TODO: Implement destroying the resource
-  }
+  void DestroyResource() override;
 
   /**
    * @brief Called when initializing the resource
@@ -59,29 +56,28 @@ public:
    */
   bool InitializeResource() override
   {
-    // TODO: Implement initializing resource
-    return {};
+    // The Shader has instant initialization, hence no need to initialize GL resource
+    // here
+    return true;
   }
 
   /**
    * @brief Compiles shader
-   * @return
+   *
+   * @return True on success
    */
-  bool Compile() const;
+  [[nodiscard]] bool Compile() const;
 
   /**
    * @brief Called when UniquePtr<> on client-side dies
    */
-  void DiscardResource() override
-  {
-    // TODO: Implement moving to the discard queue
-  }
+  void DiscardResource() override;
 
   uint32_t GetGLShader() const;
 
 private:
   struct Impl;
-  std::unique_ptr<Impl> mImpl;
+  std::unique_ptr<Impl> mImpl{nullptr};
 };
 
 } // namespace Dali::Graphics::GLES