X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=configurecompiler.cmake;h=0f4594415e909b8cc77befcfe27b3104f7bc6c0c;hb=2adf8f813f4371257cd5c28321142d28d6fe3fe6;hp=41e881ca639fc5b18d90eb461ecce8ebb05449f9;hpb=57ac3820b4284e6c6c278d9be95e81eb446a13b2;p=platform%2Fupstream%2Fcoreclr.git diff --git a/configurecompiler.cmake b/configurecompiler.cmake index 41e881c..0f45944 100644 --- a/configurecompiler.cmake +++ b/configurecompiler.cmake @@ -1,3 +1,21 @@ +# Set initial flags for each configuration + +set(CMAKE_EXPORT_COMPILE_COMMANDS ON) +set(CMAKE_C_STANDARD 11) +set(CMAKE_C_STANDARD_REQUIRED ON) +set(CMAKE_CXX_STANDARD 11) +set(CMAKE_CXX_STANDARD_REQUIRED ON) + +# All code we build should be compiled as position independent +set(CMAKE_POSITION_INDEPENDENT_CODE ON) + +set(CLR_DEFINES_DEBUG_INIT DEBUG _DEBUG _DBG URTBLDENV_FRIENDLY=Checked BUILDENV_CHECKED=1) +set(CLR_DEFINES_CHECKED_INIT DEBUG _DEBUG _DBG URTBLDENV_FRIENDLY=Checked BUILDENV_CHECKED=1) +set(CLR_DEFINES_RELEASE_INIT NDEBUG URTBLDENV_FRIENDLY=Retail) +set(CLR_DEFINES_RELWITHDEBINFO_INIT NDEBUG URTBLDENV_FRIENDLY=Retail) + +include(${CMAKE_CURRENT_LIST_DIR}/configureoptimization.cmake) + #---------------------------------------- # Detect and set platform variable names # - for non-windows build platform & architecture is detected using inbuilt CMAKE variables and cross target component configure @@ -8,8 +26,12 @@ if(CMAKE_SYSTEM_NAME STREQUAL Linux) if(CLR_CROSS_COMPONENTS_BUILD) # CMAKE_HOST_SYSTEM_PROCESSOR returns the value of `uname -p` on host. if(CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL x86_64 OR CMAKE_HOST_SYSTEM_PROCESSOR STREQUAL amd64) - if(CLR_CMAKE_TARGET_ARCH STREQUAL "arm") - set(CLR_CMAKE_PLATFORM_UNIX_X86 1) + if(CLR_CMAKE_TARGET_ARCH STREQUAL "arm" OR CLR_CMAKE_TARGET_ARCH STREQUAL "armel") + if($ENV{CROSSCOMPILE} STREQUAL "1") + set(CLR_CMAKE_PLATFORM_UNIX_X86 1) + else() + set(CLR_CMAKE_PLATFORM_UNIX_AMD64 1) + endif() else() set(CLR_CMAKE_PLATFORM_UNIX_AMD64 1) endif() @@ -58,11 +80,7 @@ if(CMAKE_SYSTEM_NAME STREQUAL Darwin) set(CLR_CMAKE_PLATFORM_UNIX 1) set(CLR_CMAKE_PLATFORM_UNIX_AMD64 1) set(CLR_CMAKE_PLATFORM_DARWIN 1) - if(CMAKE_VERSION VERSION_LESS "3.4.0") - set(CMAKE_ASM_COMPILE_OBJECT "${CMAKE_C_COMPILER} -o -c ") - else() - set(CMAKE_ASM_COMPILE_OBJECT "${CMAKE_C_COMPILER} -o -c ") - endif(CMAKE_VERSION VERSION_LESS "3.4.0") + set(CMAKE_ASM_COMPILE_OBJECT "${CMAKE_C_COMPILER} -o -c ") endif(CMAKE_SYSTEM_NAME STREQUAL Darwin) if(CMAKE_SYSTEM_NAME STREQUAL FreeBSD) @@ -152,13 +170,16 @@ if (CLR_CMAKE_TARGET_ARCH STREQUAL x64) set(CLR_CMAKE_TARGET_ARCH_ARM64 1) elseif(CLR_CMAKE_TARGET_ARCH STREQUAL arm) set(CLR_CMAKE_TARGET_ARCH_ARM 1) + elseif(CLR_CMAKE_TARGET_ARCH STREQUAL armel) + set(CLR_CMAKE_TARGET_ARCH_ARM 1) + set(ARM_SOFTFP 1) else() clr_unknown_arch() endif() # check if host & target arch combination are valid if(NOT(CLR_CMAKE_TARGET_ARCH STREQUAL CLR_CMAKE_HOST_ARCH)) - if(NOT((CLR_CMAKE_PLATFORM_ARCH_AMD64 AND CLR_CMAKE_TARGET_ARCH_ARM64) OR (CLR_CMAKE_PLATFORM_ARCH_I386 AND CLR_CMAKE_TARGET_ARCH_ARM))) + if(NOT((CLR_CMAKE_PLATFORM_ARCH_AMD64 AND CLR_CMAKE_TARGET_ARCH_ARM64) OR (CLR_CMAKE_PLATFORM_ARCH_I386 AND CLR_CMAKE_TARGET_ARCH_ARM) OR (CLR_CMAKE_PLATFORM_ARCH_AMD64 AND CLR_CMAKE_TARGET_ARCH_ARM))) message(FATAL_ERROR "Invalid host and target arch combination") endif() endif() @@ -167,12 +188,24 @@ endif() # Initialize Cmake compiler flags and other variables #----------------------------------------------------- +if(WIN32) + add_compile_options(/Zi /FC /Zc:strictStrings) +elseif (CLR_CMAKE_PLATFORM_UNIX) + add_compile_options(-g) + add_compile_options(-Wall) + if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") + add_compile_options(-Wno-null-conversion) + else() + add_compile_options($<$:-Werror=conversion-null>) + endif() +endif() + if (CMAKE_CONFIGURATION_TYPES) # multi-configuration generator? set(CMAKE_CONFIGURATION_TYPES "Debug;Checked;Release;RelWithDebInfo" CACHE STRING "" FORCE) endif (CMAKE_CONFIGURATION_TYPES) -set(CMAKE_C_FLAGS_CHECKED ${CLR_C_FLAGS_CHECKED_INIT} CACHE STRING "Flags used by the compiler during checked builds.") -set(CMAKE_CXX_FLAGS_CHECKED ${CLR_CXX_FLAGS_CHECKED_INIT} CACHE STRING "Flags used by the compiler during checked builds.") +set(CMAKE_C_FLAGS_CHECKED "") +set(CMAKE_CXX_FLAGS_CHECKED "") set(CMAKE_EXE_LINKER_FLAGS_CHECKED "") set(CMAKE_SHARED_LINKER_FLAGS_CHECKED "") @@ -214,11 +247,11 @@ if (WIN32) set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /DEBUG /PDBCOMPRESS") set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} /STACK:1572864") - # Temporarily disable incremental link due to incremental linking CFG bug crashing crossgen. + # Temporarily disable incremental link due to incremental linking CFG bug crashing crossgen. # See https://github.com/dotnet/coreclr/issues/12592 # This has been fixed in VS 2017 Update 5 but we're keeping this around until everyone is off # the versions that have the bug. The bug manifests itself as a bad crash. - set(NO_INCREMENTAL_LINKER_FLAGS "/INCREMENTAL:NO") + set(NO_INCREMENTAL_LINKER_FLAGS "/INCREMENTAL:NO") # Debug build specific flags set(CMAKE_SHARED_LINKER_FLAGS_DEBUG "/NOVCFEATURE ${NO_INCREMENTAL_LINKER_FLAGS}") @@ -256,7 +289,7 @@ elseif (CLR_CMAKE_PLATFORM_UNIX) # set the different configuration defines. if (UPPERCASE_CMAKE_BUILD_TYPE STREQUAL DEBUG) # First DEBUG - set_property(DIRECTORY PROPERTY COMPILE_DEFINITIONS ${CLR_DEFINES_DEBUG_INIT}) + set_property(DIRECTORY PROPERTY COMPILE_DEFINITIONS ${CLR_DEFINES_DEBUG_INIT}) elseif (UPPERCASE_CMAKE_BUILD_TYPE STREQUAL CHECKED) # Then CHECKED set_property(DIRECTORY PROPERTY COMPILE_DEFINITIONS ${CLR_DEFINES_CHECKED_INIT}) @@ -270,6 +303,17 @@ elseif (CLR_CMAKE_PLATFORM_UNIX) message(FATAL_ERROR "Unknown build type! Set CMAKE_BUILD_TYPE to DEBUG, CHECKED, RELEASE, or RELWITHDEBINFO!") endif () + if(DEFINED ENV{TIZEN_ASAN_ENVIRONMENT}) + if (CLR_CMAKE_PLATFORM_UNIX_ARM OR CLR_CMAKE_PLATFORM_UNIX_AMD64) + message(STATUS "TIZEN_ASAN_ENVIRONMENT is enabled.") + # add definitions to enable ASan support for only external libraries (supported only Tizen) + add_definitions(-DTIZEN_ASAN_ENVIRONMENT -DHAS_ADDRESS_SANITIZER) + set(TIZEN_ASAN_ENVIRONMENT 1) + else() + message(STATUS "TIZEN_ASAN_ENVIRONMENT cannot be enabled. Current arch is not supported.") + endif() + endif() + # set the CLANG sanitizer flags for debug build if(UPPERCASE_CMAKE_BUILD_TYPE STREQUAL DEBUG OR UPPERCASE_CMAKE_BUILD_TYPE STREQUAL CHECKED) # obtain settings from running enablesanitizers.sh @@ -292,10 +336,9 @@ elseif (CLR_CMAKE_PLATFORM_UNIX) endif () # -fdata-sections -ffunction-sections: each function has own section instead of one per .o file (needed for --gc-sections) - # -fPIC: enable Position Independent Code normally just for shared libraries but required when linking with address sanitizer # -O1: optimization level used instead of -O0 to avoid compile error "invalid operand for inline asm constraint" - set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} ${CLR_SANITIZE_CXX_FLAGS} -fdata-sections -ffunction-sections -fPIC -O1") - set(CMAKE_CXX_FLAGS_CHECKED "${CMAKE_CXX_FLAGS_CHECKED} ${CLR_SANITIZE_CXX_FLAGS} -fdata-sections -ffunction-sections -fPIC -O1") + set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} ${CLR_SANITIZE_CXX_FLAGS} -fdata-sections -ffunction-sections -O1") + set(CMAKE_CXX_FLAGS_CHECKED "${CMAKE_CXX_FLAGS_CHECKED} ${CLR_SANITIZE_CXX_FLAGS} -fdata-sections -ffunction-sections -O1") set(CMAKE_EXE_LINKER_FLAGS_DEBUG "${CMAKE_EXE_LINKER_FLAGS_DEBUG} ${CLR_SANITIZE_LINK_FLAGS}") set(CMAKE_EXE_LINKER_FLAGS_CHECKED "${CMAKE_EXE_LINKER_FLAGS_CHECKED} ${CLR_SANITIZE_LINK_FLAGS}") @@ -305,6 +348,11 @@ elseif (CLR_CMAKE_PLATFORM_UNIX) set(CMAKE_SHARED_LINKER_FLAGS_CHECKED "${CMAKE_SHARED_LINKER_FLAGS_CHECKED} ${CLR_SANITIZE_LINK_FLAGS} -Wl,--gc-sections") endif () endif(UPPERCASE_CMAKE_BUILD_TYPE STREQUAL DEBUG OR UPPERCASE_CMAKE_BUILD_TYPE STREQUAL CHECKED) + + # This linker option causes executables we build to be marked as containing position independent code. + # It is necessary to make ASLR work for executables. + set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -pie" ) + endif(WIN32) # CLR_ADDITIONAL_LINKER_FLAGS - used for passing additional arguments to linker @@ -316,7 +364,6 @@ endif(WIN32) if(CLR_CMAKE_PLATFORM_UNIX) set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${CLR_ADDITIONAL_LINKER_FLAGS}") set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${CLR_ADDITIONAL_LINKER_FLAGS}" ) - add_compile_options(${CLR_ADDITIONAL_COMPILER_OPTIONS}) endif(CLR_CMAKE_PLATFORM_UNIX) if(CLR_CMAKE_PLATFORM_LINUX) @@ -324,6 +371,11 @@ if(CLR_CMAKE_PLATFORM_LINUX) set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,--build-id=sha1") set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -Wl,--build-id=sha1") endif(CLR_CMAKE_PLATFORM_LINUX) +if(CLR_CMAKE_PLATFORM_FREEBSD) + set(CMAKE_ASM_FLAGS "${CMAKE_ASM_FLAGS} -Wa,--noexecstack") + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -fuse-ld=lld -Xlinker --build-id=sha1") + set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -fuse-ld=lld -Xlinker --build-id=sha1") +endif(CLR_CMAKE_PLATFORM_FREEBSD) #------------------------------------ # Definitions (for platform) @@ -332,7 +384,7 @@ if (CLR_CMAKE_PLATFORM_ARCH_AMD64) add_definitions(-D_AMD64_) add_definitions(-D_WIN64) add_definitions(-DAMD64) - add_definitions(-DBIT64=1) + add_definitions(-DBIT64) elseif (CLR_CMAKE_PLATFORM_ARCH_I386) add_definitions(-D_X86_) elseif (CLR_CMAKE_PLATFORM_ARCH_ARM) @@ -342,7 +394,7 @@ elseif (CLR_CMAKE_PLATFORM_ARCH_ARM64) add_definitions(-D_ARM64_) add_definitions(-DARM64) add_definitions(-D_WIN64) - add_definitions(-DBIT64=1) + add_definitions(-DBIT64) else () clr_unknown_arch() endif () @@ -368,7 +420,7 @@ if (CLR_CMAKE_PLATFORM_UNIX) endif(CLR_CMAKE_PLATFORM_UNIX) if (CLR_CMAKE_PLATFORM_UNIX) - add_definitions(-DPLATFORM_UNIX=1) + add_definitions(-DPLATFORM_UNIX) if(CLR_CMAKE_PLATFORM_DARWIN) message("Detected OSX x86_64") @@ -384,6 +436,8 @@ if (CLR_CMAKE_PLATFORM_UNIX) endif(CLR_CMAKE_PLATFORM_UNIX) if (WIN32) + add_definitions(-DPLATFORM_WINDOWS) + # Define the CRT lib references that link into Desktop imports set(STATIC_MT_CRT_LIB "libcmt$<$,$>:d>.lib") set(STATIC_MT_VCRT_LIB "libvcruntime$<$,$>:d>.lib") @@ -426,43 +480,78 @@ if (CLR_CMAKE_PLATFORM_UNIX) add_compile_options(-fstack-protector-strong) endif(CLR_CMAKE_PLATFORM_DARWIN) + # Contracts are disabled on UNIX. add_definitions(-DDISABLE_CONTRACTS) - # The -ferror-limit is helpful during the porting, it makes sure the compiler doesn't stop - # after hitting just about 20 errors. - add_compile_options(-ferror-limit=4096) if (CLR_CMAKE_WARNINGS_ARE_ERRORS) # All warnings that are not explicitly disabled are reported as errors add_compile_options(-Werror) endif(CLR_CMAKE_WARNINGS_ARE_ERRORS) - # Disabled warnings - add_compile_options(-Wno-unused-private-field) + # Disabled common warnings add_compile_options(-Wno-unused-variable) - # Explicit constructor calls are not supported by clang (this->ClassName::ClassName()) - add_compile_options(-Wno-microsoft) - # This warning is caused by comparing 'this' to NULL - add_compile_options(-Wno-tautological-compare) - # There are constants of type BOOL used in a condition. But BOOL is defined as int - # and so the compiler thinks that there is a mistake. - add_compile_options(-Wno-constant-logical-operand) - # We use pshpack1/2/4/8.h and poppack.h headers to set and restore packing. However - # clang 6.0 complains when the packing change lifetime is not contained within - # a header file. - add_compile_options(-Wno-pragma-pack) - - add_compile_options(-Wno-unknown-warning-option) + add_compile_options(-Wno-unused-value) + add_compile_options(-Wno-unused-function) #These seem to indicate real issues - add_compile_options(-Wno-invalid-offsetof) - # The following warning indicates that an attribute __attribute__((__ms_struct__)) was applied - # to a struct or a class that has virtual members or a base class. In that case, clang - # may not generate the same object layout as MSVC. - add_compile_options(-Wno-incompatible-ms-struct) + add_compile_options($<$:-Wno-invalid-offsetof>) + + if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") + # The -ferror-limit is helpful during the porting, it makes sure the compiler doesn't stop + # after hitting just about 20 errors. + add_compile_options(-ferror-limit=4096) + + # Disabled warnings + add_compile_options(-Wno-unused-private-field) + # Explicit constructor calls are not supported by clang (this->ClassName::ClassName()) + add_compile_options(-Wno-microsoft) + # This warning is caused by comparing 'this' to NULL + add_compile_options(-Wno-tautological-compare) + # There are constants of type BOOL used in a condition. But BOOL is defined as int + # and so the compiler thinks that there is a mistake. + add_compile_options(-Wno-constant-logical-operand) + # We use pshpack1/2/4/8.h and poppack.h headers to set and restore packing. However + # clang 6.0 complains when the packing change lifetime is not contained within + # a header file. + add_compile_options(-Wno-pragma-pack) + + add_compile_options(-Wno-unknown-warning-option) + + # The following warning indicates that an attribute __attribute__((__ms_struct__)) was applied + # to a struct or a class that has virtual members or a base class. In that case, clang + # may not generate the same object layout as MSVC. + add_compile_options(-Wno-incompatible-ms-struct) + # Do not convert a #warning into an #error + add_compile_options("-Wno-error=#warnings") + else() + add_compile_options(-Wno-unused-variable) + add_compile_options(-Wno-unused-but-set-variable) + add_compile_options(-fms-extensions) + add_compile_options(-Wno-unknown-pragmas) + # Do not convert a #warning into an #error + add_compile_options(-Wno-error=cpp) + if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 7.0) + add_compile_options(-Wno-nonnull-compare) + endif() + if (COMPILER_SUPPORTS_F_ALIGNED_NEW) + add_compile_options($<$:-faligned-new>) + endif() + endif() # Some architectures (e.g., ARM) assume char type is unsigned while CoreCLR assumes char is signed # as x64 does. It has been causing issues in ARM (https://github.com/dotnet/coreclr/issues/4746) add_compile_options(-fsigned-char) + + # We mark the function which needs exporting with DLLEXPORT + add_compile_options(-fvisibility=hidden) + + # Specify the minimum supported version of macOS + if(CLR_CMAKE_PLATFORM_DARWIN) + set(MACOS_VERSION_MIN_FLAGS "-mmacosx-version-min=10.12") + add_compile_options("${MACOS_VERSION_MIN_FLAGS}") + set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${MACOS_VERSION_MIN_FLAGS}") + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${MACOS_VERSION_MIN_FLAGS}") + endif(CLR_CMAKE_PLATFORM_DARWIN) endif(CLR_CMAKE_PLATFORM_UNIX) if(CLR_CMAKE_PLATFORM_UNIX_ARM) @@ -470,13 +559,29 @@ if(CLR_CMAKE_PLATFORM_UNIX_ARM) # we have to set the triple by adding a compiler argument add_compile_options(-mthumb) add_compile_options(-mfpu=vfpv3) - add_compile_options(-march=armv7-a) if(ARM_SOFTFP) add_definitions(-DARM_SOFTFP) add_compile_options(-mfloat-abi=softfp) + if("$ENV{__DistroRid}" MATCHES "tizen.*") + add_compile_options(-target armv7l-tizen-linux-gnueabi) + else() + add_compile_options(-march=armv7-a) + endif() + else() + add_compile_options(-march=armv7-a) endif(ARM_SOFTFP) endif(CLR_CMAKE_PLATFORM_UNIX_ARM) +if(CLR_CMAKE_PLATFORM_UNIX_ARM64) + if("$ENV{__DistroRid}" MATCHES "tizen.*") + add_compile_options(-target aarch64-tizen-linux-gnu) + endif() +endif(CLR_CMAKE_PLATFORM_UNIX_ARM64) + +if(CLR_CMAKE_PLATFORM_UNIX) + add_compile_options(${CLR_ADDITIONAL_COMPILER_OPTIONS}) +endif(CLR_CMAKE_PLATFORM_UNIX) + if (WIN32) # Compile options for targeting windows @@ -521,19 +626,24 @@ if (WIN32) # enable control-flow-guard support for native components for non-Arm64 builds # Added using variables instead of add_compile_options to let individual projects override it set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /guard:cf") - set(CMAKE_C_FLAGS "${CMAKE_CXX_FLAGS} /guard:cf") + set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} /guard:cf") - # Statically linked CRT (libcmt[d].lib, libvcruntime[d].lib and libucrt[d].lib) by default. This is done to avoid - # linking in VCRUNTIME140.DLL for a simplified xcopy experience by reducing the dependency on VC REDIST. - # - # For Release builds, we shall dynamically link into uCRT [ucrtbase.dll] (which is pushed down as a Windows Update on downlevel OS) but - # wont do the same for debug/checked builds since ucrtbased.dll is not redistributable and Debug/Checked builds are not - # production-time scenarios. - add_compile_options($<$,$>:/MT>) - add_compile_options($<$,$>:/MTd>) + # Statically linked CRT (libcmt[d].lib, libvcruntime[d].lib and libucrt[d].lib) by default. This is done to avoid + # linking in VCRUNTIME140.DLL for a simplified xcopy experience by reducing the dependency on VC REDIST. + # + # For Release builds, we shall dynamically link into uCRT [ucrtbase.dll] (which is pushed down as a Windows Update on downlevel OS) but + # wont do the same for debug/checked builds since ucrtbased.dll is not redistributable and Debug/Checked builds are not + # production-time scenarios. + add_compile_options($<$,$>:/MT>) + add_compile_options($<$,$>:/MTd>) set(CMAKE_ASM_MASM_FLAGS "${CMAKE_ASM_MASM_FLAGS} /ZH:SHA_256") - + + if (CLR_CMAKE_TARGET_ARCH_ARM OR CLR_CMAKE_TARGET_ARCH_ARM64) + # Contracts work too slow on ARM/ARM64 DEBUG/CHECKED. + add_definitions(-DDISABLE_CONTRACTS) + endif (CLR_CMAKE_TARGET_ARCH_ARM OR CLR_CMAKE_TARGET_ARCH_ARM64) + endif (WIN32) if(CLR_CMAKE_ENABLE_CODE_COVERAGE)