X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=atk-adaptor%2Fevent.c;h=a616879edb131a6faab99ba2e760bbcc5d66032e;hb=c2f52177b77cc70b02c898fb7b5e5908eb891bfb;hp=53e7cfec99ca55872f7f433081f38cb938299c73;hpb=f8854ff9962b332145a5626b9de0562714b0f4ef;p=platform%2Fcore%2Fuifw%2Fat-spi2-atk.git diff --git a/atk-adaptor/event.c b/atk-adaptor/event.c index 53e7cfe..a616879 100644 --- a/atk-adaptor/event.c +++ b/atk-adaptor/event.c @@ -27,11 +27,14 @@ #include #include +#include #include "bridge.h" #include "accessible-register.h" #include "common/spi-dbus.h" +#include "event.h" +#include "object.h" static GArray *listener_ids = NULL; @@ -56,16 +59,14 @@ typedef struct _SpiReentrantCallClosure static void switch_main_context (GMainContext *cnx) { -/* This code won't work on dbus-glib earlier than 0.9.0 because of FDO#30574 */ - if (spi_global_app_data->app_bus_addr [0] == '\0') - return; - GList *list; - dbus_server_setup_with_g_main (spi_global_app_data->server, cnx); - dbus_connection_setup_with_g_main (spi_global_app_data->bus, cnx); +#ifndef DISABLE_P2P + atspi_dbus_server_setup_with_g_main (spi_global_app_data->server, cnx); +#endif + atspi_dbus_connection_setup_with_g_main (spi_global_app_data->bus, cnx); for (list = spi_global_app_data->direct_connections; list; list = list->next) - dbus_connection_setup_with_g_main (list->data, cnx); + atspi_dbus_connection_setup_with_g_main (list->data, cnx); } static void @@ -227,7 +228,7 @@ convert_signal_name (const gchar * s) } static const void * -replace_null (const gint type, +validate_for_dbus (const gint type, const void *val) { switch (type) @@ -236,6 +237,11 @@ replace_null (const gint type, case DBUS_TYPE_OBJECT_PATH: if (!val) return ""; + else if (!g_utf8_validate (val, -1, NULL)) + { + g_warning ("atk-bridge: Received bad UTF-8 string when emitting event"); + return ""; + } else return val; default: @@ -252,7 +258,7 @@ append_basic (DBusMessageIter *iter, dbus_message_iter_open_container(iter, DBUS_TYPE_VARIANT, type, &sub); - val = replace_null ((int) *type, val); + val = validate_for_dbus ((int) *type, val); dbus_message_iter_append_basic(&sub, (int) *type, &val); dbus_message_iter_close_container(iter, &sub); @@ -357,6 +363,19 @@ signal_is_needed (const gchar *klass, const gchar *major, const gchar *minor) data [2] = ensure_proper_format (minor); data [3] = NULL; + /* Hack: Always pass events that update the cache. + * TODO: FOr 2.2, have at-spi2-core define a special "cache listener" for + * this instead, so that we don't send these if no one is listening */ + if (!g_strcmp0 (data [1], "ChildrenChanged") || + !g_strcmp0 (data [1], "PropertyChange") || + !g_strcmp0 (data [1], "StateChanged")) + { + g_free (data [2]); + g_free (data [1]); + g_free (data [0]); + return TRUE; + } + /* Hack: events such as "object::text-changed::insert:system" as generated by Gecko */ data [2][strcspn (data [2], ":")] = '\0'; @@ -370,6 +389,9 @@ signal_is_needed (const gchar *klass, const gchar *major, const gchar *minor) } } +#if 0 + g_print("event: %s %s %s: %d\n", data[0], data[1], data[2], ret); +#endif g_free (data [2]); g_free (data [1]); g_free (data [0]); @@ -759,6 +781,8 @@ link_selected_event_listener (GSignalInvocationHint * signal_hint, /* * Handles the ATK signal 'Gtk:AtkText:text-changed' and * converts it to the AT-SPI signal - 'object:text-changed' + * This signal is deprecated by Gtk:AtkText:text-insert + * and Gtk:AtkText:text-remove * */ static gboolean @@ -789,9 +813,109 @@ text_changed_event_listener (GSignalInvocationHint * signal_hint, emit_event (accessible, ITF_EVENT_OBJECT, name, minor, detail1, detail2, DBUS_TYPE_STRING_AS_STRING, selected, append_basic); + g_free (selected); + + return TRUE; +} + +/* + * Handles the ATK signal 'Gtk:AtkText:text-insert' and + * converts it to the AT-SPI signal - 'object:text-changed' + * + */ +static gboolean +text_insert_event_listener (GSignalInvocationHint * signal_hint, + guint n_param_values, + const GValue * param_values, gpointer data) +{ + AtkObject *accessible; + guint text_changed_signal_id; + GSignalQuery signal_query; + const gchar *name; + gchar *minor, *text; + gint detail1, detail2; + + accessible = ATK_OBJECT (g_value_get_object (¶m_values[0])); + /* Get signal name for 'Gtk:AtkText:text-changed' so + * we convert it to the AT-SPI signal - 'object:text-changed' + */ + text_changed_signal_id = g_signal_lookup ("text-changed", G_OBJECT_TYPE (accessible)); + g_signal_query (text_changed_signal_id, &signal_query); + name = signal_query.signal_name; + + + /* Add the insert and keep any detail coming from atk */ + minor = g_quark_to_string (signal_hint->detail); + if (minor) + minor = g_strconcat ("insert:", minor, NULL); + else + minor = g_strdup ("insert"); + + if (G_VALUE_TYPE (¶m_values[1]) == G_TYPE_INT) + detail1 = g_value_get_int (¶m_values[1]); + + if (G_VALUE_TYPE (¶m_values[2]) == G_TYPE_INT) + detail2 = g_value_get_int (¶m_values[2]); + + if (G_VALUE_TYPE (¶m_values[3]) == G_TYPE_STRING) + text = g_value_get_string (¶m_values[3]); + + emit_event (accessible, ITF_EVENT_OBJECT, name, minor, detail1, detail2, + DBUS_TYPE_STRING_AS_STRING, text, append_basic); + g_free (minor); + return TRUE; +} + +/* + * Handles the ATK signal 'Gtk:AtkText:text-remove' and + * converts it to the AT-SPI signal - 'object:text-changed' + * + */ +static gboolean +text_remove_event_listener (GSignalInvocationHint * signal_hint, + guint n_param_values, + const GValue * param_values, gpointer data) +{ + AtkObject *accessible; + guint text_changed_signal_id; + GSignalQuery signal_query; + const gchar *name; + gchar *minor, *text; + gint detail1, detail2; + + accessible = ATK_OBJECT (g_value_get_object (¶m_values[0])); + /* Get signal name for 'Gtk:AtkText:text-changed' so + * we convert it to the AT-SPI signal - 'object:text-changed' + */ + text_changed_signal_id = g_signal_lookup ("text-changed", G_OBJECT_TYPE (accessible)); + g_signal_query (text_changed_signal_id, &signal_query); + name = signal_query.signal_name; + + minor = g_quark_to_string (signal_hint->detail); + + /* Add the delete and keep any detail coming from atk */ + minor = g_quark_to_string (signal_hint->detail); + if (minor) + minor = g_strconcat ("delete:", minor, NULL); + else + minor = g_strdup ("delete"); + + if (G_VALUE_TYPE (¶m_values[1]) == G_TYPE_INT) + detail1 = g_value_get_int (¶m_values[1]); + + if (G_VALUE_TYPE (¶m_values[2]) == G_TYPE_INT) + detail2 = g_value_get_int (¶m_values[2]); + + if (G_VALUE_TYPE (¶m_values[3]) == G_TYPE_STRING) + text = g_value_get_string (¶m_values[3]); + + emit_event (accessible, ITF_EVENT_OBJECT, name, minor, detail1, detail2, + DBUS_TYPE_STRING_AS_STRING, text, append_basic); + g_free (minor); return TRUE; } + /*---------------------------------------------------------------------------*/ /* @@ -1002,6 +1126,10 @@ spi_atk_register_event_listeners (void) "Gtk:AtkText:text-selection-changed"); add_signal_listener (text_changed_event_listener, "Gtk:AtkText:text-changed"); + add_signal_listener (text_insert_event_listener, + "Gtk:AtkText:text-insert"); + add_signal_listener (text_remove_event_listener, + "Gtk:AtkText:text-remove"); add_signal_listener (link_selected_event_listener, "Gtk:AtkHypertext:link-selected"); add_signal_listener (generic_event_listener,