X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=HACKING;h=805fd2e00de22cfbef8f1ffdd73529abc60ac009;hb=3ccb027c907f9ee2890028e83b60296204bbf478;hp=64dc040912d654d3f8b317f8b18f3fd80c558a1b;hpb=3eac3d3e6d38a2507a6ca923b98e55377e7e26f9;p=platform%2Fupstream%2Fdbus.git diff --git a/HACKING b/HACKING index 64dc040..805fd2e 100644 --- a/HACKING +++ b/HACKING @@ -208,16 +208,19 @@ To make a release of D-Bus, do the following: - post to dbus@lists.freedesktop.org announcing the release. -After making a ".0" stable release +Making a ".0" stable release === -We create a branch for each stable release; sometimes the branch is -not done immediately, instead it's possible to wait until someone has -a not-suitable-for-stable change they want to make and then branch to -allow committing that change. +We create a branch for each stable release. The branch name should be +dbus-X.Y which is a branch that has releases versioned X.Y.Z; +changes on a stable branch should be limited to significant bug fixes. -The branch name should be dbus-X.Y which is a branch that has -releases versioned X.Y.Z +Because we won't make minor changes like keeping up with the latest +deprecations on a stable branch, stable branches should turn off the +gcc warning for deprecated declarations (e.g. see commit 4ebb275ab7). + +Be extra-careful not to merge master (or any branch based on master) into a +stable branch. To branch: git branch dbus-X.Y @@ -303,6 +306,20 @@ rules are: - if there's a live unresolved controversy about a change, don't commit it while the argument is still raging. + - at their discretion, members of the reviewer group may also commit + branches/patches under these conditions: + + - the branch does not add or change API, ABI or wire-protocol + + - the branch solves a known problem and is covered by the regression tests + + - there are no objections from the rest of the review group within + a week of the patches being attached to Bugzilla + + - the committer gets a positive review on Bugzilla from someone they + consider qualified to review the change (e.g. a colleague with D-Bus + experience; not necessarily a member of the reviewer group) + - regardless of reviews, to commit a patch: - make check must pass - the test suite must be extended to cover the new code @@ -331,5 +348,4 @@ John Palmieri Scott James Remnant Will Thompson Simon McVittie - - +David Zeuthen