X-Git-Url: http://review.tizen.org/git/?a=blobdiff_plain;f=CONTRIBUTING.md;h=b06e3cb47a7f455c6461b4b6f72b0b5226b205d5;hb=c54ea5aae8673b85e377b4d04fccfb929f838add;hp=5713ff57e5a7f67ceb9a537fb2c65447e1a67777;hpb=e43f396ef38b358f8fdb5d6f8e4ead673c9d4c0a;p=platform%2Fcore%2Fgraphics%2Ftizenvg.git
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 5713ff5..b06e3cb 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -4,15 +4,11 @@ We always appreciate your contribution. ThorVG doesn't expect perfect patch cont
Hermet Park (hermet) is the lead maintainer. Also there are designated maintainers you can request your pull-request for separate modules.
common: Junsu Choi (JSUYA)
-sw_engine: Junsu Choi (JSUYA), Mira Grudzinska (mgrudzinska), Michal Szczecinski (mihashco)
-gl_engine: Prudhvi Raj Vasireddi (prudhvirajv)
-svg_loader: Junsu Choi (JSUYA), Mira Grudzinska (mgrudzinska), Michal Maciola (mmaciola)
-jpg_loader: Michal Maciola (mmaciola)
-tvg_loader: Michal Maciola (mmaciola)
+sw_engine: Junsu Choi (JSUYA), Mira Grudzinska (mgrudzinska), Peter Vullings (projectitis)
+svg_loader: Junsu Choi (JSUYA), Mira Grudzinska (mgrudzinska)
tvg_saver: Mira Grudzinska (mgrudzinska)
-wasm: Shinwoo Kim (kimcinoo), Michal Maciola (mmaciola)
-svg2png: Junsu Choi (JSUYA), Michal Maciola (mmaciola)
-capi: Michal Szczecinski (mihashco), Mira Grudzinska (mgrudzinska)
+svg2png: Junsu Choi (JSUYA)
+capi: Mira Grudzinska (mgrudzinska)
## Self Test & Verification
@@ -46,7 +42,7 @@ If your change don't belonged to any sub modules, you can replace with proper na
The name must be written in all lower alphabet characters.
- ex) build / doc / infra / common / sw_engine / gl_engine / svg_loader / examples / wasm / svg2png ...
-- [Feature] is what major function/feature you changed. Normally this indicates a representive file name.
+- [Feature] is what major function/feature you changed. Normally this indicates a representive file name.
You can keep the file name, but don't please contain any prefix(tvg) nor suffix(Impl) here.
- ex) Canvas / TaskScehduler / SvgLoader / SvgBuilder / SwRle / GlRenderer / ...
@@ -55,51 +51,51 @@ You can keep the file name, but don't please contain any prefix(tvg) nor suffix(
- ex) "Fixed compile warnings"
- ex) "Code refactoring"
- ex) "Fixed a rendering bug that overlapped shapes inproper way."
-
+
- [Description] There is no any strict formats, but it must describe what you did in this patch as far as possible you can describe in detail.
If you fixed any bugs, it must contain below:
- - what type of bug
+ - what type of bug
- conditions to reproduce it
- root cause
- - solution
-
+ - solution
+
Or if you add a new feature or function, it must contain below:
- what sort of features
- api full specification (if any api additions)
- any necessity
- - condition / restriction
+ - condition / restriction
- reference or sample
-
+
Lastly, please append any issue ticket numbers in this section if any.
-
-
+
+
- Here is a overall commit message what we expect to review:
-
+
- common composite: newly added path clipping feature
We introduced new method Paint::composite() to support composite behaviors.
This allows paints to composite with other paints instances.
Composite behaviors depend on its composite method type.
- Here we firstly introduced "ClipPath" method to support clipping by path unit of paint.
-
+ Here we firstly introduced "ClipPath" method to support clipping by path unit of paint.
+
tagetPaint->composite(srcPaint, CompositeMethod::ClipPath);
-
+
Beaware if the source paint doesn't contain any path info, clipping won't be applied as you expected.
-
+
@API Additions:
enum CompositeMethod {None = 0, ClipPath};
Result Paint::composite(std::unique_ptr target, CompositeMethod method) const noexcept;
@Examples: added ClipPath
-
+
@References: any links to the references such as screenshot images.
@Issues: 49
## Pull Request
-
+
Once you submitted a pull request(PR), please make it sure below check list.
- Reviewers: Check Reviewers List
- Assignees: You