#include "zypp/target/TargetCallbackReceiver.h"
#include "zypp/target/rpm/librpmDb.h"
#include "zypp/target/CommitPackageCache.h"
+#include "zypp/target/RpmPostTransCollector.h"
#include "zypp/parser/ProductFileReader.h"
#include "zypp/solver/detail/Testcase.h"
-#include "zypp/repo/DeltaCandidates.h"
-#include "zypp/repo/PackageProvider.h"
#include "zypp/repo/SrcPackageProvider.h"
#include "zypp/sat/Pool.h"
#include "zypp/sat/Transaction.h"
-#include "zypp/PluginScript.h"
+#include "zypp/PluginExecutor.h"
using namespace std;
}
} // namespace json
///////////////////////////////////////////////////////////////////
+
///////////////////////////////////////////////////////////////////
namespace target
- { /////////////////////////////////////////////////////////////////
-
- /** Helper for commit plugin execution.
- * \ingroup g_RAII
- */
- class CommitPlugins : private base::NonCopyable
+ {
+ ///////////////////////////////////////////////////////////////////
+ namespace
{
- public:
- /** Default ctor: Empty plugin list */
- CommitPlugins()
- {}
-
- /** Dtor: Send PLUGINEND message and close plugins. */
- ~CommitPlugins()
- {
- if ( ! _scripts.empty() )
- send( PluginFrame( "PLUGINEND" ) );
- // ~PluginScript will disconnect all remaining plugins!
- }
-
- /** Whether no plugins are waiting */
- bool empty() const
- { return _scripts.empty(); }
-
-
- /** Send \ref PluginFrame to all open plugins.
- * Failed plugins are removed from the execution list.
- */
- void send( const PluginFrame & frame_r )
- {
- DBG << "+++++++++++++++ send " << frame_r << endl;
- for ( auto it = _scripts.begin(); it != _scripts.end(); )
- {
- doSend( *it, frame_r );
- if ( it->isOpen() )
- ++it;
- else
- it = _scripts.erase( it );
- }
- DBG << "--------------- send " << frame_r << endl;
- }
-
- /** Find and launch plugins sending PLUGINSTART message.
- *
- * If \a path_r is a directory all executable files whithin are
- * expected to be plugins. Otherwise \a path_r must point to an
- * executable plugin.
- */
- void load( const Pathname & path_r )
+ SolvIdentFile::Data getUserInstalledFromHistory( const Pathname & historyFile_r )
+ {
+ SolvIdentFile::Data onSystemByUserList;
+ // go and parse it: 'who' must constain an '@', then it was installed by user request.
+ // 2009-09-29 07:25:19|install|lirc-remotes|0.8.5-3.2|x86_64|root@opensuse|InstallationImage|a204211eb0...
+ std::ifstream infile( historyFile_r.c_str() );
+ for( iostr::EachLine in( infile ); in; in.next() )
{
- PathInfo pi( path_r );
- DBG << "+++++++++++++++ load " << pi << endl;
- if ( pi.isDir() )
- {
- std::list<Pathname> entries;
- if ( filesystem::readdir( entries, pi.path(), false ) != 0 )
- {
- WAR << "Plugin dir is not readable: " << pi << endl;
- return;
- }
- for_( it, entries.begin(), entries.end() )
- {
- PathInfo pii( *it );
- if ( pii.isFile() && pii.userMayRX() )
- doLoad( pii );
- }
- }
- else if ( pi.isFile() )
- {
- if ( pi.userMayRX() )
- doLoad( pi );
- else
- WAR << "Plugin file is not executable: " << pi << endl;
- }
- else
+ const char * ch( (*in).c_str() );
+ // start with year
+ if ( *ch < '1' || '9' < *ch )
+ continue;
+ const char * sep1 = ::strchr( ch, '|' ); // | after date
+ if ( !sep1 )
+ continue;
+ ++sep1;
+ // if logs an install or delete
+ bool installs = true;
+ if ( ::strncmp( sep1, "install|", 8 ) )
{
- WAR << "Plugin path is neither dir nor file: " << pi << endl;
- }
- DBG << "--------------- load " << pi << endl;
- }
-
- private:
- /** Send \ref PluginFrame and expect valid answer (ACK|_ENOMETHOD).
- * Upon invalid answer or error, close the plugin. and remove it from the
- * execution list.
- * \returns the received \ref PluginFrame (empty Frame upon Exception)
- */
- PluginFrame doSend( PluginScript & script_r, const PluginFrame & frame_r )
- {
- PluginFrame ret;
-
- try {
- script_r.send( frame_r );
- ret = script_r.receive();
+ if ( ::strncmp( sep1, "remove |", 8 ) )
+ continue; // no install and no remove
+ else
+ installs = false; // remove
}
- catch( const zypp::Exception & e )
- { ZYPP_CAUGHT(e); }
-
- if ( ! ( ret.isAckCommand() || ret.isEnomethodCommand() ) )
+ sep1 += 8; // | after what
+ // get the package name
+ const char * sep2 = ::strchr( sep1, '|' ); // | after name
+ if ( !sep2 || sep1 == sep2 )
+ continue;
+ (*in)[sep2-ch] = '\0';
+ IdString pkg( sep1 );
+ // we're done, if a delete
+ if ( !installs )
{
- WAR << "Bad plugin response from " << script_r << endl;
- WAR << dump(ret) << endl;
- script_r.close();
- }
-
- return ret;
- }
-
- /** Launch a plugin sending PLUGINSTART message. */
- void doLoad( const PathInfo & pi_r )
- {
- MIL << "Load plugin: " << pi_r << endl;
- try {
- PluginScript plugin( pi_r.path() );
- plugin.open();
-
- PluginFrame frame( "PLUGINBEGIN" );
- if ( ZConfig::instance().hasUserData() )
- frame.setHeader( "userdata", ZConfig::instance().userData() );
-
- doSend( plugin, frame ); // closes on error
- if ( plugin.isOpen() )
- _scripts.push_back( plugin );
+ onSystemByUserList.erase( pkg );
+ continue;
}
- catch( const zypp::Exception & e )
+ // now guess whether user installed or not (3rd next field contains 'user@host')
+ if ( (sep1 = ::strchr( sep2+1, '|' )) // | after version
+ && (sep1 = ::strchr( sep1+1, '|' )) // | after arch
+ && (sep2 = ::strchr( sep1+1, '|' )) ) // | after who
{
- WAR << "Failed to load plugin " << pi_r << endl;
+ (*in)[sep2-ch] = '\0';
+ if ( ::strchr( sep1+1, '@' ) )
+ {
+ // by user
+ onSystemByUserList.insert( pkg );
+ continue;
+ }
}
}
-
- private:
- std::list<PluginScript> _scripts;
- };
-
- void testCommitPlugins( const Pathname & path_r ) // for testing only
- {
- USR << "+++++" << endl;
- {
- CommitPlugins pl;
- pl.load( path_r );
- USR << "=====" << endl;
+ MIL << "onSystemByUserList found: " << onSystemByUserList.size() << endl;
+ return onSystemByUserList;
}
- USR << "-----" << endl;
- }
+ } // namespace
+ ///////////////////////////////////////////////////////////////////
///////////////////////////////////////////////////////////////////
namespace
ZYppCommitResult & result_r )
{ RunUpdateMessages( root_r, messagesPath_r, checkPackages_r, result_r ); }
- /** Helper for PackageProvider queries during commit. */
- struct QueryInstalledEditionHelper
- {
- bool operator()( const std::string & name_r,
- const Edition & ed_r,
- const Arch & arch_r ) const
- {
- rpm::librpmDb::db_const_iterator it;
- for ( it.findByName( name_r ); *it; ++it )
- {
- if ( arch_r == it->tag_arch()
- && ( ed_r == Edition::noedition || ed_r == it->tag_edition() ) )
- {
- return true;
- }
- }
- return false;
- }
- };
-
- /**
- * \short Let the Source provide the package.
- * \p pool_r \ref ResPool used to get candidates
- * \p pi item to be commited
- */
- struct RepoProvidePackage
- {
- repo::RepoMediaAccess &_access;
- std::list<Repository> _repos;
- repo::PackageProviderPolicy _packageProviderPolicy;
-
- RepoProvidePackage( repo::RepoMediaAccess &access, ResPool pool_r )
- : _access(access), _repos( pool_r.knownRepositoriesBegin(), pool_r.knownRepositoriesEnd() )
- {
- _packageProviderPolicy.queryInstalledCB( QueryInstalledEditionHelper() );
- }
-
- ManagedFile operator()( const PoolItem & pi, bool fromCache_r )
- {
- Package::constPtr p = asKind<Package>(pi.resolvable());
- if ( fromCache_r )
- {
- repo::PackageProvider pkgProvider( _access, p, repo::DeltaCandidates(), _packageProviderPolicy );
- return pkgProvider.providePackageFromCache();
- }
- else
- {
- repo::DeltaCandidates deltas( _repos, p->name() );
- repo::PackageProvider pkgProvider( _access, p, deltas, _packageProviderPolicy );
- return pkgProvider.providePackage();
- }
- }
- };
///////////////////////////////////////////////////////////////////
IMPL_PTR_TYPE(TargetImpl);
TargetImpl::TargetImpl( const Pathname & root_r, bool doRebuild_r )
: _root( root_r )
, _requestedLocalesFile( home() / "RequestedLocales" )
- , _softLocksFile( home() / "SoftLocks" )
+ , _autoInstalledFile( home() / "AutoInstalled" )
, _hardLocksFile( Pathname::assertprefix( _root, ZConfig::instance().locksFile() ) )
{
_rpm.initDatabase( root_r, Pathname(), doRebuild_r );
bool build_rpm_solv = true;
// lets see if the rpm solv cache exists
- RepoStatus rpmstatus( RepoStatus( _root/"/var/lib/rpm/Name" )
- && (_root/"/etc/products.d") );
+ RepoStatus rpmstatus( RepoStatus(_root/"var/lib/rpm/Name") && RepoStatus(_root/"etc/products.d") );
bool solvexisted = PathInfo(rpmsolv).isExist();
if ( solvexisted )
{
RepoStatus status = RepoStatus::fromCookieFile(rpmsolvcookie);
// now compare it with the rpm database
- if ( status.checksum() == rpmstatus.checksum() )
- build_rpm_solv = false;
- MIL << "Read cookie: " << rpmsolvcookie << " says: "
- << (build_rpm_solv ? "outdated" : "uptodate") << endl;
+ if ( status == rpmstatus )
+ build_rpm_solv = false;
+ MIL << "Read cookie: " << rpmsolvcookie << " says: "
+ << (build_rpm_solv ? "outdated" : "uptodate") << endl;
}
}
cmd << "rpmdb2solv";
if ( ! _root.empty() )
cmd << " -r '" << _root << "'";
-
+ cmd << " -X"; // autogenerate pattern/product/... from -package
+ cmd << " -A"; // autogenerate application pseudo packages
cmd << " -p '" << Pathname::assertprefix( _root, "/etc/products.d" ) << "'";
if ( ! oldSolvFile.empty() )
// We keep it.
guard.resetDispose();
- // Finally send notification to plugins
- // NOTE: quick hack looking for spacewalk plugin only
+ // system-hook: Finally send notification to plugins
+ if ( root() == "/" )
{
- Pathname script( Pathname::assertprefix( _root, ZConfig::instance().pluginsPath()/"system/spacewalk" ) );
- if ( PathInfo( script ).isX() )
- try {
- PluginScript spacewalk( script );
- spacewalk.open();
-
- PluginFrame notify( "PACKAGESETCHANGED" );
- spacewalk.send( notify );
-
- PluginFrame ret( spacewalk.receive() );
- MIL << ret << endl;
- if ( ret.command() == "ERROR" )
- ret.writeTo( WAR ) << endl;
- }
- catch ( const Exception & excpt )
- {
- WAR << excpt.asUserHistory() << endl;
- }
+ PluginExecutor plugins;
+ plugins.load( ZConfig::instance().pluginsPath()/"system" );
+ if ( plugins )
+ plugins.send( PluginFrame( "PACKAGESETCHANGED" ) );
}
}
return build_rpm_solv;
system.addSolv( rpmsolv );
}
+ sat::Pool::instance().rootDir( _root );
// (Re)Load the requested locales et al.
// If the requested locales are empty, we leave the pool untouched
}
}
{
- SoftLocksFile::Data softLocks( _softLocksFile.data() );
- if ( ! softLocks.empty() )
- {
- // Don't soft lock any installed item.
- for_( it, system.solvablesBegin(), system.solvablesEnd() )
- {
- softLocks.erase( it->ident() );
- }
- ResPool::instance().setAutoSoftLocks( softLocks );
- }
+ if ( ! PathInfo( _autoInstalledFile.file() ).isExist() )
+ {
+ // Initialize from history, if it does not exist
+ Pathname historyFile( Pathname::assertprefix( _root, ZConfig::instance().historyLogFile() ) );
+ if ( PathInfo( historyFile ).isExist() )
+ {
+ SolvIdentFile::Data onSystemByUser( getUserInstalledFromHistory( historyFile ) );
+ SolvIdentFile::Data onSystemByAuto;
+ for_( it, system.solvablesBegin(), system.solvablesEnd() )
+ {
+ IdString ident( (*it).ident() );
+ if ( onSystemByUser.find( ident ) == onSystemByUser.end() )
+ onSystemByAuto.insert( ident );
+ }
+ _autoInstalledFile.setData( onSystemByAuto );
+ }
+ // on the fly removed any obsolete SoftLocks file
+ filesystem::unlink( home() / "SoftLocks" );
+ }
+ // read from AutoInstalled file
+ sat::StringQueue q;
+ for ( const auto & idstr : _autoInstalledFile.data() )
+ q.push( idstr.id() );
+ satpool.setAutoInstalled( q );
}
if ( ZConfig::instance().apply_locks_file() )
{
///////////////////////////////////////////////////////////////////
// Prepare execution of commit plugins:
///////////////////////////////////////////////////////////////////
- CommitPlugins commitPlugins;
+ PluginExecutor commitPlugins;
if ( root() == "/" && ! policy_r.dryRun() )
{
- Pathname plugindir( Pathname::assertprefix( _root, ZConfig::instance().pluginsPath()/"commit" ) );
- commitPlugins.load( plugindir );
+ commitPlugins.load( ZConfig::instance().pluginsPath()/"commit" );
}
- if ( ! commitPlugins.empty() )
+ if ( commitPlugins )
commitPlugins.send( transactionPluginFrame( "COMMITBEGIN", steps ) );
///////////////////////////////////////////////////////////////////
// Write out a testcase if we're in dist upgrade mode.
///////////////////////////////////////////////////////////////////
- if ( getZYpp()->resolver()->upgradeMode() )
+ if ( pool_r.resolver().upgradeMode() || pool_r.resolver().upgradingRepos() )
{
if ( ! policy_r.dryRun() )
{
filesystem::assert_dir( home() );
// requested locales
_requestedLocalesFile.setLocales( pool_r.getRequestedLocales() );
- // weak locks
+ // autoinstalled
{
- SoftLocksFile::Data newdata;
- pool_r.getActiveSoftLocks( newdata );
- _softLocksFile.setData( newdata );
+ SolvIdentFile::Data newdata;
+ for ( sat::Queue::value_type id : result.rTransaction().autoInstalled() )
+ newdata.insert( IdString(id) );
+ _autoInstalledFile.setData( newdata );
}
// hard locks
if ( ZConfig::instance().apply_locks_file() )
if ( ! policy_r.dryRun() || policy_r.downloadMode() == DownloadOnly )
{
// Prepare the package cache. Pass all items requiring download.
- repo::RepoMediaAccess access;
- RepoProvidePackage repoProvidePackage( access, pool_r );
- CommitPackageCache packageCache( root(), repoProvidePackage );
+ CommitPackageCache packageCache( root() );
packageCache.setCommitList( steps.begin(), steps.end() );
bool miss = false;
}
}
}
+ packageCache.preloaded( true ); // try to avoid duplicate infoInCache CBs in commit
}
if ( miss )
{
ERR << "Some packages could not be provided. Aborting commit."<< endl;
}
- else if ( ! policy_r.dryRun() )
- {
- commit( policy_r, packageCache, result );
- }
else
- {
- DBG << "dryRun: Not installing/deleting anything." << endl;
- }
+ {
+ if ( ! policy_r.dryRun() )
+ {
+ // if cache is preloaded, check for file conflicts
+ commitFindFileConflicts( policy_r, result );
+ commit( policy_r, packageCache, result );
+ }
+ else
+ {
+ DBG << "dryRun/downloadOnly: Not installing/deleting anything." << endl;
+ }
+ }
}
else
{
///////////////////////////////////////////////////////////////////
// Send result to commit plugins:
///////////////////////////////////////////////////////////////////
- if ( ! commitPlugins.empty() )
+ if ( commitPlugins )
commitPlugins.send( transactionPluginFrame( "COMMITEND", steps ) );
///////////////////////////////////////////////////////////////////
// COMMIT internal
//
///////////////////////////////////////////////////////////////////
+ namespace
+ {
+ struct NotifyAttemptToModify
+ {
+ NotifyAttemptToModify( ZYppCommitResult & result_r ) : _result( result_r ) {}
+
+ void operator()()
+ { if ( _guard ) { _result.attemptToModify( true ); _guard = false; } }
+
+ TrueBool _guard;
+ ZYppCommitResult & _result;
+ };
+ } // namespace
+
void TargetImpl::commit( const ZYppCommitPolicy & policy_r,
CommitPackageCache & packageCache_r,
ZYppCommitResult & result_r )
ZYppCommitResult::TransactionStepList & steps( result_r.rTransactionStepList() );
MIL << "TargetImpl::commit(<list>" << policy_r << ")" << steps.size() << endl;
+ // Send notification once upon 1st call to rpm
+ NotifyAttemptToModify attemptToModify( result_r );
+
bool abort = false;
+
+ RpmPostTransCollector postTransCollector( _root );
std::vector<sat::Solvable> successfullyInstalledPackages;
TargetImpl::PoolItemList remaining;
if (policy_r.rpmExcludeDocs()) flags |= rpm::RPMINST_EXCLUDEDOCS;
if (policy_r.rpmNoSignature()) flags |= rpm::RPMINST_NOSIGNATURE;
+ attemptToModify();
try
{
progress.tryLevel( target::rpm::InstallResolvableReport::RPM_NODEPS_FORCE );
+ if ( postTransCollector.collectScriptFromPackage( localfile ) )
+ flags |= rpm::RPMINST_NOPOSTTRANS;
rpm().installPackage( localfile, flags );
HistoryLog().install(citem);
rpm::RpmInstFlags flags( policy_r.rpmInstFlags() & rpm::RPMINST_JUSTDB );
flags |= rpm::RPMINST_NODEPS;
if (policy_r.dryRun()) flags |= rpm::RPMINST_TEST;
+
+ attemptToModify();
try
{
rpm().removePackage( p, flags );
} // for
+ // process all remembered posttrans scripts.
+ if ( !abort )
+ postTransCollector.executeScripts();
+ else
+ postTransCollector.discardScripts();
+
// Check presence of update scripts/messages. If aborting,
// at least log omitted scripts.
if ( ! successfullyInstalledPackages.empty() )
{
parser::ProductFileData baseproductdata( const Pathname & root_r )
{
+ parser::ProductFileData ret;
PathInfo baseproduct( Pathname::assertprefix( root_r, "/etc/products.d/baseproduct" ) );
+
if ( baseproduct.isFile() )
{
try
{
- return parser::ProductFileReader::scanFile( baseproduct.path() );
+ ret = parser::ProductFileReader::scanFile( baseproduct.path() );
}
catch ( const Exception & excpt )
{
ZYPP_CAUGHT( excpt );
}
}
- return parser::ProductFileData();
+ else if ( PathInfo( Pathname::assertprefix( root_r, "/etc/products.d" ) ).isDir() )
+ {
+ ERR << "baseproduct symlink is dangling or missing: " << baseproduct << endl;
+ }
+ return ret;
}
inline Pathname staticGuessRoot( const Pathname & root_r )
std::string TargetImpl::targetDistributionRelease( const Pathname & root_r )
{ return baseproductdata( staticGuessRoot(root_r) ).registerRelease();}
+ std::string TargetImpl::targetDistributionFlavor() const
+ { return baseproductdata( _root ).registerFlavor(); }
+ // static version:
+ std::string TargetImpl::targetDistributionFlavor( const Pathname & root_r )
+ { return baseproductdata( staticGuessRoot(root_r) ).registerFlavor();}
+
Target::DistributionLabel TargetImpl::distributionLabel() const
{
Target::DistributionLabel ret;